December 2008 - Wine-Devel - list.winehq.org

RE: [PATCH] wined3d_gl.h minor typo fix
by Stefan Dösinger Dec. 21, 2008

Dec. 21, 2008

> - USE_GL_FUNC(PGLFNGLFOGCOORDDVEXTPROC, glFogCoordvEXT, EXT_FOG_COORD, NULL )\ > + USE_GL_FUNC(PGLFNGLFOGCOORDDVEXTPROC, glFogCoorddvEXT, EXT_FOG_COORD, NULL )\ I think I fixed that one with a patch in my glFogCoord emulation patchset a few days ago. Did you forget to update your git tree, or did I miss something? Other than that, the patch breaks the alignment of the 3rd and 4th column because a 'v' was added to the function name, but no space removed to keep the alignment.

2 1

Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes
by Reece Dunn Dec. 21, 2008

Dec. 21, 2008

Hi, There is a discussion going on over at https://bugs.launchpad.net/ubuntu/+source/wine/+bug/111061 about improving Wine's look and feel to better match the system that it is running on. The situation is as follows: == Colour Schemes Wine supports these by reading the settings from the registry. Winecfg can load a .theme file containing a colour profile and adapt accordingly (saving those settings to the registry). At the moment, if you need to script this (e.g. when installing Wine) you need to manipulate the registry. It would be helpful if winecfg (or some other helper utility) supported setting the theme file on the command line. In addition to this, if the user changes the theme used on their system it would not be reflected by Wine. == Windows Theme Support Windows theming support is in place to some extent, w.r.t. the XP theming APIs. There are some user32 controls and the window/dialog handlers that don't support theming yet and there are some performance issues that need resolving. This would be set via the command line used to set the colour scheme since they can be set via the same .theme file. This is limited in that you need an XP theme for each native theme available. == Native Theme Support The main thing here is that Wine would monitor the native system for theme changes. The colours of the native theme would be mapped to the Windows system colours, saved to the registry and then a WM_SYSCOLORCHANGED message would be sent to all open top-level windows so they could update to the new look. Any metric data would be mapped in a similar way. As for the theme, an implementation of uxtheme would map the API calls to the native calls. Here, it may be possible to just send a request to redraw everything on each active window. If not, a WM_THEMECHANGED message would need to be sent to all active windows. The challenge with native theme support is two-fold: (1) it should work on any system - some have Gtk, some Qt and some Cocoa/Carbon, while others (like the *BSDs and OpenSolaris) are likely not to have those engines available; (2) it should not break any Windows application. Note that as Vista has a different msstyles theming engine (it is a DLL), we could have the msstyles DLL expose the uxtheme API and have uxtheme call msstyles to do the rendering. That way, we could have a gtk.msstyles, qt3.msstyles, qt4.msstyles and an carbon.msstyles that would bind to the corresponding theming engine. If the msstyles DLL does not expose those methods, the uxtheme engine could then fallback to the current XP theme processing. For Mac theme support that would possibly require Objective-C code to be done properly, that theme could be an external package (possibly in darwine) that would be installed in addition to Wine. The same thing for the Qt engines, allowing them to directly interface with the C++ Qt APIs. Thoughts? Ideas? - Reece

7 19

Re: [PATCH] winedbg: add a crash dialog for --auto mode
by Juan Lang Dec. 20, 2008

Dec. 20, 2008

Hi Mikolaj, there are a few typos in your patch: + /* we waist some memory for the full path and UNICODE_STRING header, but s/waist/waste/ Sorry, I wouldn't ordinarily comment on something so minor, but there are a few typos in the resources too: + LTEXT "The program %s has met a serious problem and needs to close. We are sorry for the inconvinience.", s/inconvinience/inconvenience/ Also, using "encountered" rather than "met" seems a little more idiomatic. + You may want to check http://appdb.winehq.org if there are some \ + tips about running this applicaiton.\n\n\ s/applicaiton/application/ Also, the following wording seems better: You may want to check http://appdb.winehq.org for tips about running this application. Thanks, --Juan

1 0

Re: ntoskrnl.exe: Add a redirect for IoGetCurrentProcess
by Paul Chitescu Dec. 20, 2008

Dec. 20, 2008

On Saturday 20 December 2008 07:31:53 Chris Wulff wrote: > Redirect for IoGetCurrentProcess to kernel32.GetCurrentProcess > > -- Chris Wulff This is incorrect. Please provide a separate stub for IoGetCurrentProcess as it returns something else: "The IoGetCurrentProcess routine returns a pointer to the current process." - needs to be a valid pointer to some undocumented structure _EPROCESS "GetCurrentProcess Function Retrieves a pseudo handle for the current process." - essentially (HANDLE)-1 FYI I use a stub that returns (PEPROCESS)"System" since I traced some Sysinternals utility comparing the first 6 bytes to that string: TRACE(": semi-stub\n"); return (PEPROCESS)"System"; /* Sysinternals portmon expects this one */ http://www.winehq.org/pipermail/wine-patches/2008-February/049784.html This patch was not accepted for unknown reason. Paul Chitescu

2 2

qedit: tests/mediadet.c test skips sometimes
by Rico Schüller Dec. 20, 2008

Dec. 20, 2008

Hi, could anyone try the attached patch for the qedit test on a windows machine? It works around bug 16548. But according to the comment in the source I think this could be a mistake. I'd like to know if it works without renaming the file on windows. On wine it works. Cheers Rico diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c index 2b43124..558ff3a 100644 --- a/dlls/qedit/tests/mediadet.c +++ b/dlls/qedit/tests/mediadet.c @@ -68,8 +68,10 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH]) return FALSE; DeleteFileW(name); +/* + Renaming isn't a good way to solve this, see bug 16548. lstrcpyW(name + lstrlenW(name) - 3, avi); - +*/ fh = CreateFileW(name, GENERIC_WRITE, 0, NULL, CREATE_NEW, FILE_ATTRIBUTE_NORMAL, NULL); if (fh == INVALID_HANDLE_VALUE)

3 7

Re: include/wine: Header only implementation of generic redblack binary search tree.
by Marcus Meissner Dec. 20, 2008

Dec. 20, 2008

On Sat, Dec 20, 2008 at 07:30:53PM +0200, Pauli Nieminen wrote: > This implementation provides easy access to rb-tree which should be used instead of hashmap > if number of entries changes a lot of over time of execution. > It should be simple to write hashtree based on this which uses hash value of the key instead of > key it self. (Which would speed up tree operations a lot if key is long string) > > Note: I have also code to test the tree functionality but I don't know where to put > internal test cases. For what functionality in Wine is this intended? We do not seem to be using hashmap either? Ciao, Marcus

2 1

Re: jscript: Do not call memcpy() with a NULL pointer argument
by Andrew Talbot Dec. 20, 2008

Dec. 20, 2008

On Thu Dec 18 22:41 , 'James Hawkins' <truiken(a)gmail.com> sent: >I didn't write jscript, so I'm not the expert, but create_string is >internal, so we should probably crash if str is NULL instead of hiding >the error. What is this patch for? > >-- >James Hawkins Hi James, create_string() is called on line 1323 of this file, with str == NULL and len = 0. This function always allocates memory for at least one one WCHAR, so I zero-terminated it. -- Andy.

2 4

Re: Andrei Derevyanko : mshtml: Updated test of QueryInterface.
by Vitaly Lipatov Dec. 20, 2008

Dec. 20, 2008

В следующий раз - если ты добавляешь тест на интерфейс IMarshal, так и пиши. Просто Updated test - бессмысленно. В сообщении от 20 декабря 2008 Вы написали: > Module: wine > Branch: master > Commit: 2afc8fcd5a788b94c64de654823bf2f8b262338e > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=2afc8fcd5a788b94c64de6548 >23bf2f8b262338e > > Author: Andrei Derevyanko <and(a)etersoft.ru> > Date: Thu Dec 18 14:59:57 2008 +0300 > > mshtml: Updated test of QueryInterface. > > --- > > dlls/mshtml/tests/htmldoc.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c > index 84803fb..ed69725 100644 > --- a/dlls/mshtml/tests/htmldoc.c > +++ b/dlls/mshtml/tests/htmldoc.c > @@ -3766,6 +3766,11 @@ static void test_QueryInterface(IUnknown *unk) > hres = IUnknown_QueryInterface(unk, &IID_UndocumentedScriptIface, > (void**)&qi); ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, > expected E_NOINTERFACE\n", hres); ok(qi == NULL, "qi=%p, expected NULL\n", > qi); > + > + qi = (void*)0xdeadbeef; > + hres = IUnknown_QueryInterface(unk, &IID_IMarshal, (void**)&qi); > + ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); + ok(qi == NULL, "qi=%p, expected NULL\n", qi); > } > > static void init_test(enum load_state_t ls) { -- С уважением, Виталий Липатов Россия, Санкт-Петербург. www.etersoft.ru GNU! ALT Linux Team! WINE! WIKI! LaTeX! LyX!

1 0

Re: ntoskrnl.exe: Add a redirect for IoGetCurrentProcess
by Andrey Turkin Dec. 20, 2008

Dec. 20, 2008

I believe this is wrong - IoGetCurrentProcess return pointer to kernel EPROCESS structure instance, and GetCurrentProcess return constant (HANDLE)-1 . The structure is declared opaque so drivers must not dereference it, but some drivers surely won't obey. 2008/12/20 Chris Wulff <crwulff(a)rochester.rr.com> > Redirect for IoGetCurrentProcess to kernel32.GetCurrentProcess > > -- Chris Wulff > > > >

1 0

Re: mscoree: Add a stub for LockClrVersion
by Jeff Zaroyko Dec. 20, 2008

Dec. 20, 2008

On Sat, Dec 20, 2008 at 3:12 PM, Chris Wulff <crwulff(a)rochester.rr.com> wrote: > A stub for LockClrVersion. > > -- Chris Wulff > > Hi Chris You need to set your name and email address in git then regenerate your patches. git repo-config user.name "Your Name" git repo-config user.email "me(a)example.com" -Jeff

1 0