December 2008 - Wine-Devel - list.winehq.org

RE: Simplify dlls/comctl32/nativefont.c
by ricardo filipe Dec. 27, 2008

Dec. 27, 2008

are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ... ---------------------------------------- > Date: Sat, 27 Dec 2008 08:57:44 +0100 > From: gerald(a)pfeifer.com > To: wine-patches(a)winehq.org > Subject: Simplify dlls/comctl32/nativefont.c > > ChangeLog: > Simplify NATIVEFONT_Create. > > Index: dlls/comctl32/nativefont.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/nativefont.c,v > retrieving revision 1.29 > diff -u -3 -p -r1.29 nativefont.c > --- dlls/comctl32/nativefont.c 24 Oct 2008 13:13:47 -0000 1.29 > +++ dlls/comctl32/nativefont.c 27 Dec 2008 07:57:10 -0000 > @@ -47,7 +47,7 @@ typedef struct > #define NATIVEFONT_GetInfoPtr(hwnd) ((NATIVEFONT_INFO *)GetWindowLongPtrW (hwnd, 0)) > > static LRESULT > -NATIVEFONT_Create (HWND hwnd, WPARAM wParam, LPARAM lParam) > +NATIVEFONT_Create (HWND hwnd) > { > NATIVEFONT_INFO *infoPtr; > > @@ -85,7 +85,7 @@ NATIVEFONT_WindowProc (HWND hwnd, UINT u > switch (uMsg) > { > case WM_CREATE: > - return NATIVEFONT_Create (hwnd, wParam, lParam); > + return NATIVEFONT_Create (hwnd); > > case WM_DESTROY: > return NATIVEFONT_Destroy (infoPtr); > > _________________________________________________________________ Show them the way! Add maps and directions to your party invites. http://www.microsoft.com/windows/windowslive/events.aspx

3 2

Wine build failed
by Stefan Leichter Dec. 27, 2008

Dec. 27, 2008

Hello, building current git tree fails to me on Debian Etch (x86) with: ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o font.o ../../../wine-git/dlls/gdi32/font.c ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o freetype.o ../../../wine-git/dlls/gdi32/freetype.c ../../../wine-git/dlls/gdi32/freetype.c:187: error: expected declaration specifiers or ‘...’ before ‘FT_LcdFilter’ ../../../wine-git/dlls/gdi32/freetype.c: In function ‘WineEngGetGlyphOutline’: ../../../wine-git/dlls/gdi32/freetype.c:4776: error: ‘FT_LcdFilter’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4776: error: (Each undeclared identifier is reported only once ../../../wine-git/dlls/gdi32/freetype.c:4776: error: for each function it appears in.) ../../../wine-git/dlls/gdi32/freetype.c:4776: error: expected ‘;’ before ‘lcdfilter’ ../../../wine-git/dlls/gdi32/freetype.c:4777: warning: ISO C90 forbids mixed declarations and code ../../../wine-git/dlls/gdi32/freetype.c:4785: error: ‘lcdfilter’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4785: error: too many arguments to function ‘pFT_Library_SetLcdFilter’ ../../../wine-git/dlls/gdi32/freetype.c:4803: error: ‘FT_LCD_FILTER_DEFAULT’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4803: error: ‘FT_LCD_FILTER_LIGHT’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c: In function ‘is_subpixel_rendering_enabled’: ../../../wine-git/dlls/gdi32/freetype.c:5923: error: too many arguments to function ‘pFT_Library_SetLcdFilter’ make[2]: *** [freetype.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/gdi32' make[1]: *** [gdi32] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-build/dlls' make: *** [dlls] Fehler 2 ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o font.o ../../../wine-git/dlls/gdi32/font.c ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o freetype.o ../../../wine-git/dlls/gdi32/freetype.c ../../../wine-git/dlls/gdi32/freetype.c:187: error: expected declaration specifiers or ‘...’ before ‘FT_LcdFilter’ ../../../wine-git/dlls/gdi32/freetype.c: In function ‘WineEngGetGlyphOutline’: ../../../wine-git/dlls/gdi32/freetype.c:4776: error: ‘FT_LcdFilter’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4776: error: (Each undeclared identifier is reported only once ../../../wine-git/dlls/gdi32/freetype.c:4776: error: for each function it appears in.) ../../../wine-git/dlls/gdi32/freetype.c:4776: error: expected ‘;’ before ‘lcdfilter’ ../../../wine-git/dlls/gdi32/freetype.c:4777: warning: ISO C90 forbids mixed declarations and code ../../../wine-git/dlls/gdi32/freetype.c:4785: error: ‘lcdfilter’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4785: error: too many arguments to function ‘pFT_Library_SetLcdFilter’ ../../../wine-git/dlls/gdi32/freetype.c:4803: error: ‘FT_LCD_FILTER_DEFAULT’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4803: error: ‘FT_LCD_FILTER_LIGHT’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c: In function ‘is_subpixel_rendering_enabled’: ../../../wine-git/dlls/gdi32/freetype.c:5923: error: too many arguments to function ‘pFT_Library_SetLcdFilter’ make[2]: *** [freetype.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/gdi32' make[1]: *** [gdi32] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-build/dlls' make: *** [dlls] Fehler 2

5 4

Re: [2/2] mshtml: Add VT_INT support in IHTMLElementCollection_item
by Jacek Caban Dec. 27, 2008

Dec. 27, 2008

HI Konstantin, Konstantin Kondratyuk wrote: > VT_INT type isn't documented in MSDN, but it is supported in Windows > > You're duplicating the code that handles VT_I4 case. Please avoid it. Jacek

2 2

Re: winecfg: Add dll override on return key press in combobox [resend]
by Dmitry Timoshkov Dec. 27, 2008

Dec. 27, 2008

"Andre Wisplinghoff" <andre.wisplinghoff(a)gmail.com> wrote: > +INT_PTR CALLBACK > +comboedit_wndproc (HWND hEdit, UINT uMsg, WPARAM wParam, LPARAM lParam) INT_PTR is wrong return value type for a window proc. > + /* subclass dllcombo's edit to allow return keypress handling */ > + GetComboBoxInfo(GetDlgItem(dialog, IDC_DLLCOMBO), &cbinfo); > + edit = cbinfo.hwndItem; /* retrieve edit box handle */ > + oldWndProc = (LONG_PTR)SetWindowLong(edit, GWL_WNDPROC, > + (DWORD) comboedit_wndproc); > + SetWindowLong(edit, GWL_USERDATA, (DWORD)oldWndProc); The code is above is not 64-bit safe. -- Dmitry.

3 3

Are OpenBSD bugs worth filing?
by David Gerard Dec. 27, 2008

Dec. 27, 2008

Some of us on wine-users are trying to get Wine to install on OpenBSD. First, of course, we need to get it to compile on OpenBSD ... Are bugs on this platform considered valid reportable bugs? I couldn't find any OpenBSD bugs on a quick search in Bugzilla. State of things: it doesn't compile cleanly yet, and ./configure seems to fail to recognise a lot of libs that are in fact present. (I realise that running Windows on OpenBSD may cause a matter-antimatter explosion as the two security models meet ... But it has *hack value*!) - d.

4 5

Fwd: Wine on OpenBSD
by David Gerard Dec. 26, 2008

Dec. 26, 2008

2008/12/27 Austin English <austinenglish(a)gmail.com>: > Would you mind starting a wiki page on this? > http://wiki.winehq.org/OpenBSD is empty at the moment. I've done ones > for OpenSolaris/PC-BSD, see: http://wiki.winehq.org/PC-BSD and > http://wiki.winehq.org/OpenSolaris > The wiki page would make it easier to track progress. http://wiki.winehq.org/OpenBSD - this incorporates most of the discussion from the thread on wine-users. Marcel, please add to it and file Wine on OpenBSD bugs as well. I've also done a page for VirtualBox (basically: VirtualBox is quite buggy, so bugs found in Wine running in a VirtualBox are as likely as not to be bugs in VirtualBox), which should probably become a more general page on why VMs aren't good to report bugs from. - d.

1 0

Wine bugs e-mails/spoofing warnings
by Austin English Dec. 26, 2008

Dec. 26, 2008

Anyone else on gmail seeing this? It doesn't happen on all e-mails, only once every couple days (I've got digest mode enabled): "Due to a filter you created, this message was not sent to Spam. Edit Filters Warning: This message may not be from whom it claims to be. Beware of following any links in it or of providing the sender with any personal information. Learn more" -- -Austin

4 4

Bugzilla - CVS/GIT tag
by Austin English Dec. 26, 2008

Dec. 26, 2008

In an effort to remove the CVS/GIT tag, I was going to go through and start changing the versions based on when the bug was filed. I.e., look at when 1.1.10 was out, and any bugs filed in those dates with CVS/GIT tag get moved to 1.1.10. I'm thinking of starting with 0.9, as anything before that is _really_ old and not worth the effort... Anyone opposed to this plan? Also, the FIXME, NoAppDBEntry, and BugBuster should probably be removed...they're not that useful anyway... -- -Austin

4 6

Re: feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function
by Henri Verbeet Dec. 26, 2008

Dec. 26, 2008

2008/12/27 Stefan Dösinger <stefandoesinger(a)gmx.at>: >>anything wrong with the patch >>wined3d: Implement r5g6b5 to x8r8g8b8 function >>David > Probably alexandre wanted an ok from me. Can you resend the patch? > No, the patch was flawed. The author knows about this, and posted an improved patch to bugzilla (bug 18011). The improved patch is mostly ok, but doesn't round correctly, and could be made a bit faster by using a lookup table instead of recalculating everything all the time.

2 1

website: interviews / XML error: Mismatched tag
by Andre Wisplinghoff Dec. 26, 2008

Dec. 26, 2008

Hi, for example at http://www.winehq.org/interview/14 you get 'XML error: Mismatched tag at line 9'. I'm sending a proposed patch here because last time I sent a website patch to wine-patches it wasn't applied and there was no reaction. wwn/en/interviews/interview_11.xml | 2 +- wwn/en/interviews/interview_12.xml | 2 +- wwn/en/interviews/interview_14.xml | 2 +- wwn/en/interviews/interview_15.xml | 2 +- wwn/en/interviews/interview_6.xml | 2 +- wwn/en/interviews/interview_9.xml | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) -- Andre Wisplinghoff

1 0