December 2008 - Wine-Devel - list.winehq.org

Marshalling of remotable handles
by Michael Karcher Dec. 26, 2008

Dec. 26, 2008

Hello Wine developers, while trying to add proxy/stub code for shell32, I stumbled across the definition of remotable handles in IDL. We have - a RemotableHandle union. - the IDL typedefs for the wire representation of handles: | typedef [unique] RemotableHandle *wireHXXX; - the IDL declaration for the handle types itself: | typedef [wire_marshal(wireHXXX)] void*HXXX; This makes widl generate null pointer checks for HWND parameters, as HXXX is a void pointer without the unique attribute. My question is: Should widl really add this check? As the type is marshalled as wireHXXX, the null value is no problem for marshalling, so it could be safely left out. What I did in my repository was adding the [unique] attribute to the IDL typedef of the handle type: | typedef [unique, wire_marshal(wireHXXX)] void*HXXX; Is this the right approach to generally get rid of the NULL pointer checks for handles, or is widl to be fixed instead? Best regards and thanks for advice, Michael Karcher

2 2

AW: feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function
by Stefan D�singer Dec. 26, 2008

Dec. 26, 2008

>anything wrong with the patch >wined3d: Implement r5g6b5 to x8r8g8b8 function >David Probably alexandre wanted an ok from me. Can you resend the patch?

1 0

AW: [PATCH] Fix ddraw surface version setting (redux) (now withattachment)
by Stefan D�singer Dec. 26, 2008

Dec. 26, 2008

Looks ok

1 0

feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function
by paulo lesgaz Dec. 26, 2008

Dec. 26, 2008

Hello, anything wrong with the patch wined3d: Implement r5g6b5 to x8r8g8b8 function David

1 0

Bugzilla's down
by Austin English Dec. 25, 2008

Dec. 25, 2008

Newman/whomever else, if you're not busy with family etc., mind taking a look? Happy holidays everyone! -- -Austin

2 1

Re: oledlg: Implement OleUIAddVerbMenuA/W functions [resend]
by Vitaly Lipatov Dec. 25, 2008

Dec. 25, 2008

В сообщении от 24 декабря 2008 Вы написали: > On Wed, Dec 24, 2008 at 5:49 AM, Vitaly Lipatov <lav(a)etersoft.ru> wrote: > > Hello, > > > > Can anyone comment what bad with my > > OleUIAddVerbMenuA/W implementation. > > > > I know no one is interested in this function at your side, but it is > > really used function for more than one year. > > > > В сообщении от 20 декабря 2008 Vitaly Lipatov написал(a): > >> Real implementation of the OleUIAddVerbMenu function. > > > > -- > > Vitaly Lipatov, ALT Linux Team > > Russia, Saint-Petersburg, www.etersoft.ru > > Can you add a testcase for these functions? I know it is common question about testcase, but I think it does not means with this functions. Note, I do not fix some functions, I have implemented from scratch it instead stub. And my better test case is a popular account application used this functions. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

3 5

Re: [PATCH] Fix ddraw surface version setting (redux)
by Austin English Dec. 25, 2008

Dec. 25, 2008

On Wed, Dec 24, 2008 at 8:48 PM, Nick Burns <adger44(a)hotmail.com> wrote: > > Resubmitting patch with correct email address and against tot wine > > > This fixes the d3d6 rendering problem reported by Ben Slackin against Wine 1.1.3 > http://appdb.winehq.org/objectManager.php?sClass=version&iId=8524 > http://img216.imageshack.us/img216/2764/shogoiz3.png > > > SHOGO got MAD when it was not able to find the mipmaps (due to incorrect version) > > > With this fix the game looks correct (well if you apply my other menu blt patch) > > > Changelog > Fix surface version setting > Mipmaps need to be properly versioned after creation > > > - Nick > > > You forgot the patch. -- -Austin

1 0

Re: [PATCH] Fix ddraw surface version setting (redux)
by Vincent Povirk Dec. 25, 2008

Dec. 25, 2008

No attachment? Vincent Povirk

1 0

Re: gdi32: Correct order of matrix elements in World transform
by Konstantin Kondratyuk Dec. 25, 2008

Dec. 25, 2008

Oops, this patch is not full. I think, there is code with bad index also: /* Extra transformation specified by caller */ if (lpmat && !is_identity_MAT2(lpmat)) { FT_Matrix extraMat; extraMat.xx = FT_FixedFromFIXED(lpmat->eM11); extraMat.xy = FT_FixedFromFIXED(lpmat->eM21); // <<<<<<< extraMat.yx = FT_FixedFromFIXED(lpmat->eM12); // <<<<<<< extraMat.yy = FT_FixedFromFIXED(lpmat->eM22); pFT_Matrix_Multiply(&extraMat, &transMat); pFT_Matrix_Multiply(&extraMat, &transMatUnrotated); needsTransform = TRUE; } What can I do? Send second fix? Or send "full" patch for both transformations? -- Best regards, Konstantin Kondratyuk.

2 1

Feedback needed
by Andre Wisplinghoff Dec. 25, 2008

Dec. 25, 2008

Hi all, i need some feedback for my submitted patch (winecfg: Add a dll override instead of closing the dialog on pressing return in the combobox at 'libraries' tab): http://www.winehq.org/pipermail/wine-patches/2008-December/066619.html Thank you and Happy Holidays!! -- Andre Wisplinghoff

1 0