February 2008 - Wine-Devel - list.winehq.org

Re: tools: add a wrapper script for starting files from file managers and make wine.desktop use it
by Vincent Povirk Feb. 16, 2008

Feb. 16, 2008

Please do not commit this patch as explained in comment 18 of bug 5224: http://bugs.winehq.org/show_bug.cgi?id=5224#c18 Windows explorer's default behavior is to always start programs with double quotes around their filenames, even if the filename does not contain a space. Apparently, this is impossible (or more difficult than it's worth) to do in a shell script so I will need to rewrite this as a winelib program. On Feb 13, 2008 7:44 PM, Vincent Povirk <madewokherd+d41d(a)gmail.com> wrote: > This is an attempt to solve the problems with double-clicking .exe > files from file managers. > > The patch adds a script named winestartfile that mimics what happens > on windows when a file is double-clicked in explorer. It starts the > file using start.exe with the full path to the file and in the > directory that contains it. > > It also modifies the wine.desktop shortcut to use that script when > opening .exe files. > > My previous attempt at this incorrectly ran start without giving a > full path (so that if a file named start.exe exists in the current > path, it will take precedence) and probably tried to change too many > things at once. > > -- > Vincent Povirk > -- Vincent Povirk

1 0

New winetricks 20080216: fixed comctl32 override, hide winetrickscache, add --version option
by Dan Kegel Feb. 16, 2008

Feb. 16, 2008

Austin nudged me into fixing comctl32 override, which has been broken since wine added support for sxs assemblies. He also was the third person to suggest hiding winetrickscache, so I guess it's what people want. And I added a --version option for a guy who said it would make packaging easier. As always, it's available at http://kegel.com/wine/winetricks and the svn repository is http://code.google.com/p/winezeug/ -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: WineD3D: add separate alpha blend support 3/3
by Stefan Dösinger Feb. 16, 2008

Feb. 16, 2008

Am Samstag, 16. Februar 2008 17:29:31 schrieb Roderick Colenbrander: > Hi, > > This patch adds support for separate alpha blend one of the last > unimplemented D3D9 features. Here are a few suggestions: *) Setting WINED3DPMISCCAPS_SEPARATEALPHABLEND in directx.c should only be done if the extension is supported *) after the "GL_LINE_SMOOTH needs GL_BLEND to work, according to the", WINED3DRS_SEPARATEALPHABLENDENABLE should probably be removed from the if block. I don't think that blending should be enabled if the WINED3DRS_ALPHABLENDENABLE is off. A test would be helpful for certainty. *) The code translating the separate blending settings could be moved into the if(stateblock->renderState[WINED3DRS_SEPARATEALPHABLENDENABLE]) block. That way they are only executed if they're needed(The compiler may take care of that though) *) The separate blend states should be grouped with the alpha states, ie, set the representative to STATE_RENDER(WINED3DRS_ALPHABLENDENABLE) instead of STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE). Not doing that should not cause any rendering problems because the whole alpha blend states are set every time, but grouping them will improve performance. (e.g., if alphablendenable and separatealphaenable are changed state_blend is only executed once, not twice) *) The blendop is currently not reapplied if WINED3DRS_SEPARATEALPHABLENDENABLE is changed. One solution is to group the blendops with alphablend and move the code from state_blendop to state_blend. A better way is to make this a one-way dependency from state_alpha to state_blend. Compare STATE_RENDER(WINED3DRS_LIGHTING) and STATE_VDECL for a reference.

1 0

X developer's conference, April 16-18
by Dan Kegel Feb. 16, 2008

Feb. 16, 2008

http://www.x.org/wiki/Events/XDC2008 Seems like Wine might want a representative. What issues would we want to bring up there? - relative mouse motion events ...? - Dan

3 3

MSG_PEEK race in urlmon_test?
by Francois Gouget Feb. 16, 2008

Feb. 16, 2008

When I run the urlmon_test test the kernel (2.6.22.9) has this to say: Feb 16 05:53:54 amboise kernel: TCP(urlmon_test.exe:9836): Application bug, race in MSG_PEEK. Does anyone know what's up with that? Maybe someone who knows more than me about urlmon? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

1 0

Re: wined3d: Fix bug in swapchain release which causes incorrect display mode changes.
by Chris Robinson Feb. 16, 2008

Feb. 16, 2008

On Saturday 16 February 2008 06:01:48 am Peter Dons Tychsen wrote: > Fixed bug in wined3d swapchain, which caused the release of the > swap-chain to mess around with the display-modes set by ddraw. Also > added test-case for this scenario. Reworked test code minimally, to > re-use existing test code. You may want to test D3D8 and D3D9 too, to see what they do when presented by the situation (since the code is shared). Also I don't think you should make those 2-space indents just to avoid changing those few lines.

1 0

Re: winedos: Allocate a console when loading dos applications
by Maarten Lankhorst Feb. 16, 2008

Feb. 16, 2008

Hi all, 2008/2/14, Dmitry Timoshkov <dmitry(a)codeweavers.com>: > "Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > > > > It worked before ba896e75d7fce68e5183007b65eae7e35490ccd4. (Around > > wine 0.9.33 or so) After that it was broken. I have a wine 0.9.9 that > > when run does create a seperate console for dos apps. My guess is that > > somewhere in the initialisation allocconsole would have to be called. > > > You need to talk to Alexandre since that's his patch. Still, there is > no AllocConsole() call removed by that commit, so it has nothing to do > with the regression. I've done a bunch of tests with a simple mingw app linked with -mconsole and found the following results (in xp sp2 vmware): - Asynchronous calls are not available for console handles (ReadFile only works in synchronous mode, ReadFileEx doesn't work) - I can do WaitForSingleObject(GetStdHandle(STD_INPUT_HANDLE), INFINITE); and it will only return when there is data to be read, like a key being pressed. in wine it will return immediately, this causes the breakage of dos apps after wine 0.9.33. These things make me think that the old behavior of wine is more correct then the current one, with relation to console handles. -Maarten.

2 1

Re: d3dx9 patches
by tony.wasserka＠freenet.de Feb. 16, 2008

Feb. 16, 2008

Okay, thanks. Then I'll just resend them and see if they get in this time. Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

re: gecko download not robust?
by marco Feb. 15, 2008

Feb. 15, 2008

> > Hmm. gecko download hung for me once. I saw > fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 > in the log, which makes me wonder if our download code > doesn't handle transient network errors well. > > Time to get rid of the download, and just bundle gecko outright, I say... I make the mandriva rpms for wine. This would make the rpms 30% bigger. And you would download the same gecko binary over and over again with every new version. But if that is not a problem than it can be easily done.

7 12

[PATCH] msvcrt: Fix scanf floating-point exponent handling.
by Jānis Rūcis Feb. 15, 2008

Feb. 15, 2008

This patch modifies the scanf floating-point algorithm to pass the tests I sent in my previous message. --- dlls/msvcrt/scanf.h | 40 +++++++++++++++++++++++++--------------- 1 files changed, 25 insertions(+), 15 deletions(-) diff --git a/dlls/msvcrt/scanf.h b/dlls/msvcrt/scanf.h index 7fe3cc4..66df15e 100644 --- a/dlls/msvcrt/scanf.h +++ b/dlls/msvcrt/scanf.h @@ -241,6 +241,12 @@ _FUNCTION_ { case 'G': { /* read a float */ long double cur = 0; int negative = 0; + + int decimal_places = 0; + unsigned int exponent = 0; + int negexp = 0; + long double be; + /* skip initial whitespace */ while ((nch!=_EOF_) && _ISSPACE_(nch)) nch = _GETC_(file); @@ -268,20 +274,17 @@ _FUNCTION_ { } /* handle decimals */ if (width!=0 && nch == '.') { - float dec = 1; nch = _GETC_(file); if (width>0) width--; while (width!=0 && (nch!=_EOF_) && _ISDIGIT_(nch)) { - dec /= 10; - cur += dec * (nch - '0'); + cur = cur * 10 + (nch - '0'); + decimal_places += 1; nch = _GETC_(file); if (width>0) width--; } } /* handle exponent */ if (width!=0 && (nch == 'e' || nch == 'E')) { - int exponent = 0, negexp = 0; - float expcnt; nch = _GETC_(file); if (width>0) width--; /* possible sign on the exponent */ @@ -292,20 +295,27 @@ _FUNCTION_ { } /* exponent digits */ while (width!=0 && (nch!=_EOF_) && _ISDIGIT_(nch)) { - exponent *= 10; - exponent += (nch - '0'); + exponent = exponent * 10 + (nch - '0'); nch = _GETC_(file); if (width>0) width--; } - /* update 'cur' with this exponent. */ - expcnt = negexp ? .1 : 10; - while (exponent!=0) { - if (exponent&1) - cur*=expcnt; - exponent/=2; - expcnt=expcnt*expcnt; - } } + + /* Combine exponent with decimal point. */ + for (; decimal_places > 0; decimal_places--) + { + if (exponent == 0) + negexp = 1; + + exponent += negexp ? +1 : -1; + } + + /* Perform exponentiation. */ + for (be = 1.0; exponent > 0; exponent--) + be *= 10.0; + + cur = negexp ? cur / be : cur * be; + st = 1; if (!suppress) { if (L_prefix) _SET_NUMBER_(long double); -- 1.5.3.8

1 0