February 2008 - Wine-Devel - list.winehq.org

Re: include: Fix the C_ASSERT macro to not generate an unused variable warning when compiling with gcc.
by Alexandre Julliard Feb. 15, 2008

Feb. 15, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -279,10 +279,10 @@ extern "C" { > > /* Compile time assertion */ > > -#if defined(_MSC_VER) > +#if defined(_MSC_VER) || defined(__GNUC__) > # define C_ASSERT(e) typedef char __C_ASSERT__[(e)?1:-1] > -#elif defined(__GNUC__) > -# define C_ASSERT(e) extern char __C_ASSERT__[(e)?1:-1] > +#else > +# define C_ASSERT(e) This will break if you do two C_ASSERTs in the same scope. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] Add IRunnableTask interface (resend)
by Alexandre Julliard Feb. 15, 2008

Feb. 15, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > I have no idea why it wasn't applied, so this is a resend with no modifications. It should go in shobjidl.idl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: systray [4/4]: implement systray transparency
by Alexandre Julliard Feb. 15, 2008

Feb. 15, 2008

"Kirill K. Smirnov" <lich(a)math.spbu.ru> writes: > diff --git a/dlls/winex11.drv/winex11.drv.spec b/dlls/winex11.drv/winex11.drv.spec > index 36b83d7..126cbc5 100644 > --- a/dlls/winex11.drv/winex11.drv.spec > +++ b/dlls/winex11.drv/winex11.drv.spec > @@ -130,6 +130,7 @@ # Desktop > > # System tray > @ cdecl wine_make_systray_window(long) X11DRV_make_systray_window > +@ cdecl wine_systray_window_clear(long) X11DRV_systray_window_clear We don't want to export such a specific function. Besides, it should really be setting the window shape. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winedos: Allocate a console when loading dos applications
by Dmitry Timoshkov Feb. 14, 2008

Feb. 14, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Fixes bug 9178. > > I was looking hard at it, then I had to laugh, hard, when I found this > simple fix. This patch is not correct, think for instance of all win16 applications. -- Dmitry.

1 0

re: Fixing the last failing tests
by Dan Kegel Feb. 14, 2008

Feb. 14, 2008

Maarten wrote: > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); Maybe you can do something like if (CreateWindowExW doesn't work) { /* win95 without MSLU */ ok(!IsWindowUnicode()); } else { /* win95 with MSLU, or something with native unicode support */ ok(IsWindowUnicode()); }

2 3

[RFC] winecfg enhancements
by Reece Dunn Feb. 14, 2008

Feb. 14, 2008

Hi, I am looking at how we can make winecfg more useful. I have already supplied patches to allow importing a ubuntu human theme to work :). So I am now looking at how to build on that. On the Desktop Integration tab, I am planning on adding the following improvements: * Split the Appearance section into Theme and Appearance. The rationale behind this is while the two are linked, they are also distinct. It will make it possible to simplify "Install theme..." to just "Install...", and support enhancements below. * Pre-populate the Theme list with themes in WINDOWS/Resources/Themes and with other *.theme files added by the user. The rationale behind this is that it simplifies the workflow for the average usage (e.g. install a theme, then select it). * Rename "Install theme..." to "Add...". The rationale is that we are not installing a theme, but setting it as the theme being used. Having the theme appear in the Themes list in the future further supports this name change and workflow. * Rename "(No Theme)" to "Wine Default". The rationale behind this is that it isn't true that there is no theme installed (in the sense that a theme can be a set of colours and metrics). * Provide an "Export..." button to the Themes section. The rationale behind this is that it makes it easier to create, modify and preview themes being created. Therefore, you could create a Ubuntu Human or Oxygen theme from winecfg. * Make the theme importer read the themes [Theme]/DisplayName property. The rationale behind this is to make the display name user friendly. * Add --import-theme command line support to winecfg. The rationale behind this is to support loading a theme via a script (e.g. post-install configuration), without resorting to the winecfg GUI. * Make the shell folders a drop down list. The rationale behind this is that it is unclear what "link to" applies to. An alternative is to make the listview have the showselalways flag, so it is clearer what folder "link to" is relating to. Q: Should we provide a --simple mode for winecfg that has the work flow that Ubuntu is planning? Not specifying --simple would bring up the standard winecfg dialog. - Reece

8 10

Re: mscms: [GS]etColorSpace() are not supposed to be defined in icm.h.
by Detlef Riekenberg Feb. 14, 2008

Feb. 14, 2008

On Mi, 2008-02-13 at 21:52 +0100, Francois Gouget wrote: > diff --git a/include/icm.h b/include/icm.h The end of the attached Patchfile is broken: > &#;& -- By by ... Detlef

2 1

gecko valgrind errors show up better now
by Dan Kegel Feb. 14, 2008

Feb. 14, 2008

The new version of valgrind shows better stack dumps for gecko valgrind errors. For instance, Invalid read of size 4 at (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by load_gecko (nsembed.c:396) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) Address 0x7f22e1e0 is not stack'd, malloc'd or (recently) free'd Invalid read of size 4 at (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) by notif_wnd_proc (binding.c:184) Address 0x7f22e108 is not stack'd, malloc'd or (recently) free'd Conditional jump or move depends on uninitialised value(s) at (within 0.1.0/wine_gecko/components/necko.dll) by nsURI_QueryInterface (nsio.c:1181) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by nsIOService_NewChannelFromURI (nsio.c:2111) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) Invalid read of size 4 at (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) by notif_wnd_proc (binding.c:184) by (within /home/dank/wine-git/dlls/user32/user32.dll.so) Address 0x7f22d1a8 is not stack'd, malloc'd or (recently) free'd etc., etc. Jacek, if you can give me a debug build of gecko, I can probably give you even better info. Interested? - Dan

2 1

Re: ddraw / wined3d fighting over the resolution!
by Peter Dons Tychsen Feb. 14, 2008

Feb. 14, 2008

Hello S. I have studied this a bit more. The app seems to do this purposely. In any case wined3d should not change the mode in this case. Either wined3d must detect this, or the code should be moved into d3d8/d3d9. On a similar note, i found i found a funny "RestoreDisplayMode()" call in "SetCooperateLevel()", when switching from full-screen. I tested with win-xp, and here this does not happen. This causes additional mode-switch flicker. I think i will chew on some nice German wine-gums (Haribo), and then send some patches :-). mmmmmm.... wine-gums.... they should sell them on wine.org... would be appropriate... :-) /p On Thu, 2008-02-14 at 09:18 +0100, Stefan Dösinger wrote: > Am Donnerstag, 14. Februar 2008 04:22:16 schrieb Peter Dons Tychsen: > > Why does the SwapChain-destroy function play around with the resolution > > at all. Is that really necessary? I think it should not do it if the > > caller is ddraw at least. > I thought I'm filtering this out in the case of ddraw, but maybe that got > lost. The reason why the swapchain restores the resolution is the different > way ddraw/d3d8 and d3d8/d3d9 set up the screen. > > In ddraw the app calls IDirectDraw7::SetDisplayMode. This sets the mode. Then > it creates a DDSCAPS_PRIMARYSURFACE surface, which creates the swapchain. > > In d3d8/d3d9 the swapchain controls the video mode > > I think the problem is that RestoreDisplayMode is called before the primary > surface is destroyed. The question is why this happens. I can think of the > following reasons: > > -> Refcounting problem, or the app just doesn't release the surfaces. Then > ddraw.dll destroys the objects on DLL_PROCESS_DETACH > > -> The app calls it that way. This needs a test, but I think it is not allowed > to call SetDisplayMode / RestoreDisplayMode while a primary surface is around

1 0

Re: Weird failure in kernel32 volume test
by Maarten Lankhorst Feb. 14, 2008

Feb. 14, 2008

Hi Jeremy, 2008/2/14, Jeremy White <jwhite(a)winehq.org>: > Anyone else has some tests that consistently fail on make test? > > > As of last nights git tip, I still had four failures: > > http://test.winehq.org/data/20080213/#Wine I submitted a patch for the comm test. I'm not 100% sure about the shelllink test. On that site there is also a failure for 'volume' which I experienced as well. I have really no idea what causes it though, but it looks like aj has done some work on it. Maybe you have any idea alexandre? Cheers, Maarten.

1 0