February 2008 - Wine-Devel - list.winehq.org

Regular bugzilla hygeine
by Dan Kegel Feb. 12, 2008

Feb. 12, 2008

When we do a release, all the bugs in RESOLVED FIXED state can be closed (since they were only waiting on a release to be closed). We haven't been doing that, and as a result, lots and lots of bugs stacked up in RESOLVED FIXED state. But I don't see any reason we shouldn't start doing it, so I'm about to do it in honor of the 0.9.55 release. (I think I've figured out how to avoid changing any bugs flipped into that state since the 0.9.55 release, let's see if I get it right. Next time I'll do it right when Alexandre releases.) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: comctl32: Fixed listview bug, when client sends bogus SETITEMSTATE request
by Dimi Paun Feb. 12, 2008

Feb. 12, 2008

On Tue, 2008-02-12 at 03:28 +0100, Peter Dons Tychsen wrote: > Fixed listview bug, when client sends bogus SETITEMSTATE request, > requesting all items to be focused. Looks good, tnx! -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: Resend patch from Norbert
by Vitaliy Margolen Feb. 11, 2008

Feb. 11, 2008

Rico Schüller wrote: > Hi, > > I only resend a patch because it isn't in the todays git and the author > didn't answer for a while. > > Cheers > Rico > > > ------------------------------------------------------------------------ > > > - memcpy(pRect, &This->updateStateBlock->scissorRect, sizeof(pRect)); > + memcpy(pRect, &This->updateStateBlock->scissorRect, sizeof(RECT)); To avoid such problems in the future one should use something like: *pRect = This->updateStateBlock->scissorRect; Doing a quick search through wined3d I've found number of places with memcpy instead of simple assignment of one struct to another struct. This is a good janitorial task to get rid of memcpy where simple assignment will work. Vitaliy.

3 2

Re: IStream interface for domdoc and terminate call
by Kornél Pál Feb. 11, 2008

Feb. 11, 2008

Also note you should test the behavior when call QueryInterface for IStream multiple times whether a new wrapper or the same wrapper is returned and whether the tree is cleared on QueryInterface. And I forgot to mention that calling Release on the IStream interface is the correct way of disposing the interface so that call may have effect on the object as well. Kornél ----- Original Message ----- From: "Kornél Pál" <kornelpal(a)gmail.com> To: "Josef Reidinger" <josef.reidinger(a)gmail.com>; <wine-devel(a)winehq.org> Sent: Monday, February 11, 2008 1:15 PM Subject: Re: IStream interface for domdoc and terminate call > OK, sorry I didn't realized that you try to modify the Wine > implementation. > > I think that delaying pasing for the fist time you call a method of the > DOMDocument object would be a good solution. This way you will not perform > any unnecessary parings. > > I don't know the exact details of MS implementations so you should check > when and how are parsing errors reported and when is the parsed document > available when you write the DOMDocument throug it's IStream interface and > you should dealy parsing to the latest possible time. > > Kornél > > ----- Original Message ----- > From: "Josef Reidinger" <josef.reidinger(a)gmail.com> > To: "Kornél Pál" <kornelpal(a)gmail.com> > Sent: Monday, February 11, 2008 12:58 PM > Subject: Re: IStream interface for domdoc and terminate call > > >> Hi >> I mean using call IStream_write like it is describe in bug #4811. >> >> Kornél Pál napsal(a): >>> Hi, >>> >>> If you mean passing an IStream interface to DOMDocument.save method: >>> As far as I know save method is synchronous (if I'm wrong you still can >>> set the async property to FALSE). So when the save method returns you >>> know that the entire document has been passed to the IStream. >>> >>> If you want to do something else please be more specific. >>> >>> Kornél >>> >>> ----- Original Message ----- From: "Josef Reidinger" >>> <josef.reidinger(a)gmail.com> >>> To: <wine-devel(a)winehq.org> >>> Sent: Monday, February 11, 2008 11:55 AM >>> Subject: IStream interface for domdoc and terminate call >>> >>> >>>> Hi, I try make IStream write interface for domdoc (msxml3). Problem is >>>> that microsoft doesn't have terminate string for write call and libxml >>>> have proble with it (more at >>>> http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does >>>> anyone has any idea how solve it? (test in each dom call if is some >>>> nonparsed characters and force parsing looks very ugly). >>>> JR >>>> >>>> >>> >> >

1 0

Re: IStream interface for domdoc and terminate call
by Kornél Pál Feb. 11, 2008

Feb. 11, 2008

OK, sorry I didn't realized that you try to modify the Wine implementation. I think that delaying pasing for the fist time you call a method of the DOMDocument object would be a good solution. This way you will not perform any unnecessary parings. I don't know the exact details of MS implementations so you should check when and how are parsing errors reported and when is the parsed document available when you write the DOMDocument throug it's IStream interface and you should dealy parsing to the latest possible time. Kornél ----- Original Message ----- From: "Josef Reidinger" <josef.reidinger(a)gmail.com> To: "Kornél Pál" <kornelpal(a)gmail.com> Sent: Monday, February 11, 2008 12:58 PM Subject: Re: IStream interface for domdoc and terminate call > Hi > I mean using call IStream_write like it is describe in bug #4811. > > Kornél Pál napsal(a): >> Hi, >> >> If you mean passing an IStream interface to DOMDocument.save method: >> As far as I know save method is synchronous (if I'm wrong you still can >> set the async property to FALSE). So when the save method returns you >> know that the entire document has been passed to the IStream. >> >> If you want to do something else please be more specific. >> >> Kornél >> >> ----- Original Message ----- From: "Josef Reidinger" >> <josef.reidinger(a)gmail.com> >> To: <wine-devel(a)winehq.org> >> Sent: Monday, February 11, 2008 11:55 AM >> Subject: IStream interface for domdoc and terminate call >> >> >>> Hi, I try make IStream write interface for domdoc (msxml3). Problem is >>> that microsoft doesn't have terminate string for write call and libxml >>> have proble with it (more at >>> http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does >>> anyone has any idea how solve it? (test in each dom call if is some >>> nonparsed characters and force parsing looks very ugly). >>> JR >>> >>> >> >

1 0

IStream interface for domdoc and terminate call
by Josef Reidinger Feb. 11, 2008

Feb. 11, 2008

Hi, I try make IStream write interface for domdoc (msxml3). Problem is that microsoft doesn't have terminate string for write call and libxml have proble with it (more at http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does anyone has any idea how solve it? (test in each dom call if is some nonparsed characters and force parsing looks very ugly). JR

2 1

Re: pdh[3:3]: remove unnecessary tests done in PdhLookupPerfNameByIndexW
by Dmitry Timoshkov Feb. 11, 2008

Feb. 11, 2008

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > --- a/dlls/pdh/pdh_main.c > +++ b/dlls/pdh/pdh_main.c > @@ -837,14 +837,7 @@ PDH_STATUS WINAPI PdhLookupPerfNameByIndexA( LPCSTR machine, DWORD index, LPSTR > > TRACE("%s %d %p %p\n", debugstr_a(machine), index, buffer, size); > > - if (machine) > - { > - FIXME("remote machine not supported\n"); > - return PDH_CSTATUS_NO_MACHINE; > - } > - > if (!buffer || !size) return PDH_INVALID_ARGUMENT; > - if (!index) return ERROR_SUCCESS; Changelog mentions PdhLookupPerfNameByIndexW by the change is in PdhLookupPerfNameByIndexA. Why are you removing the checks in one place by leave the same in other one? Why the tests are unnecessary? -- Dmitry.

2 6

Re: [1/9] WineD3D: Add a test for the vFace register
by H. Verbeet Feb. 11, 2008

Feb. 11, 2008

On 11/02/2008, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* TODO: vFace (ps_3_0) */ You should probably remove that one :-)

1 0

re: Is there a Git Repositories for Unaccept Patches or (work in Progress)?
by Dan Kegel Feb. 11, 2008

Feb. 11, 2008

Joeseph wrote: > Is there a Git Repositories for Unaccept Patches or (work in Progress)? Not really, but people often attach patches to bugzilla entries if they're not quite good enough to submit. And if anybody wants to start such a git repository, more power to them. >An ntoskrnl.exe was written a couple of years ago to load drivers, >specifically the Safedisc Windows kernel driver, > but it still hasn't been accepted. The article you read is out of date; ntoskrnl.exe is now part of wine. > Basically threat unaccepted patch as bugs(while keeping the patch out of wine), instead of chucking it out the window. As I said above, developers are free to attach patches to bug reports. What you're really trying to get at is: sometimes developers get discouraged at how hard it is to get patches into Wine. But no mechanical aid will really help there. The only cure is persistance on the part of the developer, and assistance (chiefly good feedback) from other Wine developers. After a developer gets a few patches committed, the wine process starts to feel a lot smoother. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

6 11

Wine patches integrated into Valgrind svn
by Dan Kegel Feb. 11, 2008

Feb. 11, 2008

Hey, the Valgrind developers finally merged the Wine support patches! I just built Valgrind from svn as described here: http://valgrind.org/downloads/repository.html and on a fresh install of Gutsy, it just worked, no patches. To run Valgrind's tests under Wine, I configure valgrind with --prefix=/usr/local/valgrind-svn, then do something like cd wine-git/tools wget http://kegel.com/wine/valgrind/runtests.patch wget http://kegel.com/wine/valgrind/valgrind-daily.sh wget http://kegel.com/wine/valgrind/valgrind-suppressions wget http://kegel.com/wine/valgrind/valgrind-split-pl.txt -O valgrind-split.pl patch -p2 < runtests.patch Then to run all the tests, I do cd ~/wine-git sh tools/valgrind-daily.sh or to run just one test, I do export RUNTEST_USE_VALGRIND=1 cd ~/wine-git/dlls/riched20/tests make test I've only verified that this works well on one machine so far, but I have high hopes. Anyone else feel like giving it a whirl? - Dan

3 4