February 2008 - Wine-Devel - list.winehq.org

Fixing the last failing tests
by Maarten Lankhorst Feb. 12, 2008

Feb. 12, 2008

Hi all, I'm very close to passing the whole wine conformance suite on my pc. The only tests failing are in user32. These tests are failing in any version of windows though. How do I make them pass on at least 1 version of windows and wine? Would patches to make it run on xp and wine be accepted? And if I can succeed with that, how do I make it work with other versions of windows as well. Cheers, Maarten. An example is IsWindowUnicode. It always returns TRUE on XP, but it won't do that on 9x. That would mean something like: ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?");

2 1

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
by Stefan Dösinger Feb. 12, 2008

Feb. 12, 2008

Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > This makes the tests pass on my pc. d3d8 might need it as well

1 0

Re: ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.
by Peter Dons Tychsen Feb. 12, 2008

Feb. 12, 2008

Hi Stefan. OK thanks for the fast, precise and well-cut review (and probably correct). I will fix the 3 issues and re-submit. /p On Wed, 2008-02-13 at 00:50 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 00:39:52 schrieb Peter Dons Tychsen: > > Hi Devs. > > > > I had this patch silently rejected. > > Can anybody spot what is wrong with this patch? > My first thought was that filtering the modes like this is kinda ugly, but > given that ddraw uses wined3d and wined3d uses the d3d9 interface this is the > only way. (I don't think adding an extra flag to wined3d is cleaner, > considering that ddraw can sort this out on its own). > > However, I think you shouldn't clone the application's bug you're trying to > work around and deal with the "out of mode buffer" case. you can e.g. use > HeapReAlloc to increase the buffer without loosing the content. > > Another minor thing is the if(buffer) HeapFree(buffer) code. HeapFree checks > against NULL, so the extra check isn't needed, and it is sorta a policy not > to have redundant checks before HeapFree >

1 0

ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.
by Peter Dons Tychsen Feb. 12, 2008

Feb. 12, 2008

Hi Devs. I had this patch silently rejected. Can anybody spot what is wrong with this patch? It is really needed for some older games like Grand Theft Auto, and other oldies (but goodies!). /pedro

2 1

dbghelp/dwarf.c: new valgrind warnings?
by Dan Kegel Feb. 12, 2008

Feb. 12, 2008

I'm now seeing some new valgrind warnings when wine is doing stack dumps after crashes: + Conditional jump or move depends on uninitialised value(s) + at dwarf2_load_one_entry (dwarf.c:983) + by dwarf2_lookup_type (dwarf.c:858) + by dwarf2_load_one_entry (dwarf.c:1020) + by dwarf2_parse (dwarf.c:2060) + by elf_load_debug_info (elf_module.c:1085) + by module_get_debug (module.c:303) + by SymFromAddr (symbol.c:1071) + by stack_get_current_symbol (stack.c:143) + by display_print (display.c:174) + by wait_exception (tgt_active.c:178) + by dbg_active_auto (tgt_active.c:951) + by main (winedbg.c:544) I don't know when this started, but maybe it's related to recent changes by Eric Pouech? - Dan

2 1

[winetest] Would it be worthwhile to send zipped version of the reports?
by Paul Vriens Feb. 12, 2008

Feb. 12, 2008

Hi, As more and more tests are developed I think it could make sense to zip the report files before sending. It will of course put a small extra burden on the winehq server but as the reports are text only we gain a 90% or so per report. Thoughts? -- Cheers, Paul.

2 2

Re: [advapi32/tests] Only use functions if they are implemented
by James Hawkins Feb. 12, 2008

Feb. 12, 2008

On Feb 12, 2008 10:34 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Added some verbosity to the GetProcAddress stuff. The skips prevent the > crash(es) I'm seeing on win95. > What is the point of this 'verbosity'? You already add the skips, so if a function isn't available for a test, you're going to see it twice now. Also, it adds to the code size. -- James Hawkins

2 1

Re: browseui: Add undocumented Component Category Cache Daemon class
by Dmitry Timoshkov Feb. 12, 2008

Feb. 12, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > --- /dev/null > +++ b/dlls/browseui/compcatcachedaemon.c > @@ -0,0 +1,159 @@ > +/* > + * Progress dialog > + * > + * Copyright 2007 Mikolaj Zalewski Is the above information correct? -- Dmitry.

1 0

Re: Oleview: Added Dutch translations
by Dmitry Timoshkov Feb. 12, 2008

Feb. 12, 2008

"Frans Kool" <frans.kool(a)gmail.com> wrote: > From 2e5bda68273038f924f8f0d1b325a2a4c71f17ae Mon Sep 17 00:00:00 2001 > From: Frans Kool <Frans.Kool(a)gmail.com> > Date: Tue, 12 Feb 2008 12:04:56 +0100 > Subject: Oleview: Added Dutch translations This your patch as well as a previous one are wrapped. -- Dmitry.

1 0

Regesstion Tests
by Alistair Leslie-Hughes Feb. 12, 2008

Feb. 12, 2008

Hi, If I have Msxml3 with SP7 installed all the msxml tests pass without issue, but if I have Msxml3 SP3 installed, some fail. Should I improve the tests so that they can handle both cases? Best Regards Alistair Leslie-Hughes

2 1