April 2008 - Wine-Devel - list.winehq.org

Re: fusion: Explicitly check for -1 for a missing table
by Marcus Meissner April 16, 2008

April 16, 2008

On Wed, Apr 16, 2008 at 11:48:31AM -0500, James Hawkins wrote: > Hi, > > Changelog: > * Explicitly check for -1 for a missing table. > > dlls/fusion/assembly.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > -- > James Hawkins > diff --git a/dlls/fusion/assembly.c b/dlls/fusion/assembly.c > index 024e611..eee889a 100644 > --- a/dlls/fusion/assembly.c > +++ b/dlls/fusion/assembly.c > @@ -416,7 +416,7 @@ HRESULT assembly_get_name(ASSEMBLY *assembly, LPSTR *name) > ULONG offset; > > offset = assembly->tables[0x20].offset; /* FIXME: add constants */ > - if (offset < 0) > + if (offset == -1) > return E_FAIL; > > asmtbl = (ASSEMBLYTABLE *)assembly_data_offset(assembly, offset); > @@ -527,7 +527,7 @@ HRESULT assembly_get_pubkey_token(ASSEMBLY *assembly, LPSTR *token) > *token = NULL; > > offset = assembly->tables[0x20].offset; /* FIXME: add constants */ > - if (offset < 0) > + if (offset == -1) > return E_FAIL; You should make offset "signed", or pass errors down in another way. This will not work this way. Ciao, Marcus

3 2

Re: dlls/fusion/assembly.c -- no-op error checks
by James Hawkins April 16, 2008

April 16, 2008

On Wed, Apr 16, 2008 at 12:47 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > On Wed, 16 Apr 2008, James Hawkins wrote: > > The offsets are explicity set to -1 on line 242, so the check needs to > > be for -1. It won't work at all otherwise. > > Thanks, James! I was looking for this, but must have missed it somehow. > I'm glad I Cc:d you. :-) > > Please find the real fix below. > Beat ya to the punch :) http://winehq.org/pipermail/wine-patches/2008-April/053446.html -- James Hawkins

2 1

Re: dlls/fusion/assembly.c -- no-op error checks
by James Hawkins April 16, 2008

April 16, 2008

On Wed, Apr 16, 2008 at 9:28 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > Both offset and tables[].offset are of unsigned types, so these two > checks for errors will never trigger. > The offsets are explicity set to -1 on line 242, so the check needs to be for -1. It won't work at all otherwise. -- James Hawkins

1 0

.NET 2.0 problematic DLL loading.
by Rhys McGuckin April 16, 2008

April 16, 2008

In reference to bug #11973, I've the following observation. Using the native .NET 2.0 installed via winetricks, I located what is potentially a problem with the method that .NET is using to locate the DLLs that it wishes to load. The problem seems to be that .NET is attempting to locate the various DLL's it is going to use, by searching various directory paths. Once this does not occur (by placing a native DLL into the windows/system32 path) it causing a crash further down. It doesn't seem to utilize the LoadLibrary initially to locate but another function (from memory I think it NtCreateFile). With the native DLL in place it starts to process properly, at least until it runs into other files not located (as stated above). I believe that .NET 2.0 is assuming that the files are located within the directory path (this may be so that it can independently utilize application supplied DLL files - I read that WinXP supposedly uses this policy to reduce problems with DLL dependencies). This of course, totally by-passes the built-in DLL files (which should be located using this method, except that they do not exist in the paths .NET searches). There are two possible ways currently that I can think of, which would potentially solve this problem: 1. Have symbolic links within the system directory (I find this to be bad method, for multiple reasons) 2. Have some interception of the searching for files located within the system32, to include all of built-in dlls. Unfortunately, since I don't know a huge amount about Wine yet, I have no idea on how to code the second one, and I think having a patch for this, may solve quite a few problems that currently exist with using .NET based programs. --------------------------------- Get the name you always wanted with the new y7mail email address.

2 2

re: Including Mono within a Wine package - should Wine expect this?
by Dan Kegel April 16, 2008

April 16, 2008

A wine-gecko package would be very useful. Wine-mono on the other hand is probably premature. How many apps are helped at the moment by winetricks mono12 ? I don't think it's a large number. The wine-gecko package should just be a repackaging of the same blob that is normally downloaded, at least until we figure out how to do a proper cross-build.

9 19

Help with configure option
by Alistair Leslie-Hughes April 16, 2008

April 16, 2008

Hi, I need to add an option, HAS_TEXTCONCAT_BUG to the configure script to check for a bug in libxml. What file(s) do I have to change? The file attached is an example to test for this issue. (returns -1 if the error exists) Best Regards Alistair Leslie-Hughes

2 1

Re: [Fwd: Bug#476232: winebuild fails to build for powerpc]
by Alexandre Julliard April 16, 2008

April 16, 2008

Ove Kaaven <ovek(a)arcticnet.no> writes: > @@ -368,7 +368,7 @@ void BuildSpec32File( DLLSPEC *spec ) > else > { > output( "\n\t.section \".init\",\"ax\"\n" ); > - output( "\tjmp 1f\n" ); > + output( "\t%s 1f\n", get_asm_branch_mnemonic() ); > output( "__wine_spec_pe_header:\n" ); > output( "\t.skip %u\n", 65536 + page_size ); > output( "1:\n" ); I don't think it makes sense to add functions that return specific asm mnemonics, there's no guarantee that all platforms would use a single jump instruction here. You should add a switch the way it is done for instance in output_asm_constructor(). -- Alexandre Julliard julliard(a)winehq.org

1 0

imm32: Implement the ImmSetConversionStatus.
by ByeongSik Jeon April 16, 2008

April 16, 2008

Tested with "MS IME 2002(imekr61.ime)", "MS IME 2003(imekr70.ime)", and "Saenaru(saenaru.ime, Korean Free IME)". --- dlls/imm32/imm.c | 29 ++++++++++++++++++++--------- 1 files changed, 20 insertions(+), 9 deletions(-)

1 0

Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498
by Juan Lang April 15, 2008

April 15, 2008

> Have you tried patch without this "if"? In my case it crashes without it > when I try to open chm from bug #12498... i don't know if strdupW can > dup NULL as well as null? Aaaah... Sorry, my mistake, I missed this declaration: static const WCHAR null[] = {0}; That solves that mystery. In that case, one fix per patch, please. This fix and the other are unrelated: one fixes a crash, the other deals with a missing #STRINGS stream. Thanks, --Juan

3 3

ddiwrapper 0.3rc1
by Hin-Tak Leung April 15, 2008

April 15, 2008

I have uploaded my mod'ed version of ddiwrapper to http://www.linuxprinting.org/download/ddiwrapper/ and called it 0.3rc1. There are some stub codes which I added to try to get the Konica-Minolta MC2500W XP driver to work without success, so they probably should be taken out, but they are fairly harmless and maybe useful to somebody else. I tried one of the Canon drivers and ddiwrapper worked as advertised. I have updated the change log and also added the following paragraph to the bottom of the README: For Wine releases between Feb/March 2006 up to time of writing (April 2008), it is necessary to comment out one line in the wine loader code to make ddiwrapper work: ==================================================== diff --git a/libs/wine/loader.c b/libs/wine/loader.c index 0f05f0c..743d487 100644 --- a/libs/wine/loader.c +++ b/libs/wine/loader.c @@ -117,7 +117,7 @@ static void build_dll_path(void) if (dlldir) { dll_path_maxlen = strlen(dlldir); - dll_paths[nb_dll_paths++] = dlldir; + /* dll_paths[nb_dll_paths++] = dlldir; */ } else if ((build_dir = wine_get_build_dir())) { ==================================================== ___________________________________________________________ Yahoo! For Good helps you make a difference http://uk.promotions.yahoo.com/forgood/

1 0