April 2008 - Wine-Devel - list.winehq.org

Re: msi: Remove tentative definition of static array with no size specifier
by James Hawkins April 3, 2008

April 3, 2008

On Wed, Apr 2, 2008 at 5:07 PM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Whereas for a non-static array a tentative definition does not require a > size to be specified, for example: > > char ar[]; /* tentative definition */ > > char ar[] = "hello"; /* actual definition */ > > strictly, when the static storage specifier is applied, the size must be > specified: > > static char ar[5]; /* tentative definition */ > > static char ar[5] = "hello"; /* actual definition */ > > This patch avoids using a magic number by moving the definition of an array > and adding forward declarations for the functions affected, instead. > > -- Andy. > --- > Changelog: > msi: Remove tentative declaration of static array with no size specifier. > > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index 982c9f0..8cc36a0 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -47,6 +47,64 @@ WINE_DEFAULT_DEBUG_CHANNEL(msi); > static UINT ACTION_ProcessExecSequence(MSIPACKAGE *package, BOOL UIran); > static UINT ACTION_ProcessUISequence(MSIPACKAGE *package); > static UINT ACTION_PerformActionSequence(MSIPACKAGE *package, UINT seq, BOOL UI); > +static UINT ACTION_AllocateRegistrySpace( MSIPACKAGE *package ); > +static UINT ACTION_BindImage( MSIPACKAGE *package ); > +static UINT ACTION_CostFinalize(MSIPACKAGE *package); > +static UINT ACTION_CostInitialize(MSIPACKAGE *package); > +static UINT ACTION_CreateFolders(MSIPACKAGE *package); > +static UINT ACTION_CreateShortcuts(MSIPACKAGE *package); > +static UINT ACTION_DeleteServices( MSIPACKAGE *package ); > +static UINT ACTION_ExecuteAction(MSIPACKAGE *package); > +static UINT ACTION_FileCost(MSIPACKAGE *package); > +static UINT ACTION_InstallExecute(MSIPACKAGE *package); > +static UINT ACTION_InstallFinalize(MSIPACKAGE *package); > +static UINT ACTION_InstallInitialize(MSIPACKAGE *package); > +static UINT ACTION_InstallSFPCatalogFile( MSIPACKAGE *package ); > +static UINT ACTION_InstallValidate(MSIPACKAGE *package); > +static UINT ACTION_IsolateComponents( MSIPACKAGE *package ); > +static UINT ACTION_LaunchConditions(MSIPACKAGE *package); > +static UINT ACTION_MigrateFeatureStates( MSIPACKAGE *package ); > +static UINT ACTION_MoveFiles( MSIPACKAGE *package ); > +static UINT ACTION_MsiPublishAssemblies( MSIPACKAGE *package ); > +static UINT ACTION_MsiUnpublishAssemblies( MSIPACKAGE *package ); > +static UINT ACTION_InstallODBC( MSIPACKAGE *package ); > +static UINT ACTION_InstallServices( MSIPACKAGE *package ); > +static UINT ACTION_PatchFiles( MSIPACKAGE *package ); > +static UINT ACTION_ProcessComponents(MSIPACKAGE *package); > +static UINT ACTION_PublishComponents(MSIPACKAGE *package); > +static UINT ACTION_PublishFeatures(MSIPACKAGE *package); > +static UINT ACTION_PublishProduct(MSIPACKAGE *package); > +static UINT ACTION_RegisterComPlus( MSIPACKAGE *package ); > +static UINT ACTION_RegisterProduct(MSIPACKAGE *package); > +static UINT ACTION_RegisterTypeLibraries(MSIPACKAGE *package); > +static UINT ACTION_RegisterUser(MSIPACKAGE *package); > +static UINT ACTION_RemoveDuplicateFiles( MSIPACKAGE *package ); > +static UINT ACTION_RemoveEnvironmentStrings( MSIPACKAGE *package ); > +static UINT ACTION_RemoveExistingProducts( MSIPACKAGE *package ); > +static UINT ACTION_RemoveFolders( MSIPACKAGE *package ); > +static UINT ACTION_RemoveIniValues( MSIPACKAGE *package ); > +static UINT ACTION_RemoveODBC( MSIPACKAGE *package ); > +static UINT ACTION_RemoveRegistryValues( MSIPACKAGE *package ); > +static UINT ACTION_RemoveShortcuts( MSIPACKAGE *package ); > +static UINT ACTION_ResolveSource(MSIPACKAGE* package); > +static UINT ACTION_RMCCPSearch( MSIPACKAGE *package ); > +static UINT ACTION_SelfRegModules(MSIPACKAGE *package); > +static UINT ACTION_SelfUnregModules( MSIPACKAGE *package ); > +static UINT ACTION_StartServices( MSIPACKAGE *package ); > +static UINT ACTION_StopServices( MSIPACKAGE *package ); > +static UINT ACTION_UnpublishComponents( MSIPACKAGE *package ); > +static UINT ACTION_UnpublishFeatures(MSIPACKAGE *package); > +static UINT ACTION_UnregisterClassInfo( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterComPlus( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterExtensionInfo( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterFonts( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterMIMEInfo( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterProgIdInfo( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterTypeLibraries( MSIPACKAGE *package ); > +static UINT ACTION_ValidateProductID( MSIPACKAGE *package ); > +static UINT ACTION_WriteEnvironmentStrings( MSIPACKAGE *package ); > +static UINT ACTION_WriteIniValues(MSIPACKAGE *package); > +static UINT ACTION_WriteRegistryValues(MSIPACKAGE *package); > I object. Also, RFCs should be sent to wine-devel, not wine-patches. -- James Hawkins

4 7

batmeter exported functions
by andre furtado April 3, 2008

April 3, 2008

André Renato Furtado, talk2cod(a)hotmail.com add documentation for exported functions of the win32 batmeter library... BOOL BatMeterCapabilities( PUINT *ppuiBatCount) *\ description: is used to determine if the batmeter lib can run on the host machine. return true on success (battery meter can run). params: out -> ppuiBatCount - points to a pointer which will be filled in with a pointer to the global battery count.*\ HWND CreateBatMeter( HWND hWndParent, HWND hWndFrame, BOOL bShowMulti, PBATTERY_STATE pbsComposite) *\ description: create, fetch data for and draw the batmeter window. returns a handle to the newly created battery meter window on success, null on failure. param: hWndParent - parent of the battery meter dialog. hWndFrame - frame to locate the battery meter dialog. bShowMulti - display mode (true -> multiple battery). opt -> pbsComposite - pointer to composite battery state.*\ HWND DestroyBatMeter(HWND hWnd) *\ description: destroy the batmeter window created with CreateBatMeter function. returns the handle of the batmeter parent window. params: hWnd - handle to the window to be destroyed. *\ BOOL PowerCapabilities() *\ description: is used to determine if the system has any power management capabilities which require ui support. return true if power management ui should be displayed. *\ BOOL UpdateBatMeter( HWND hWnd, BOOL bShowMulti, BOOL bForceUpdate, PBATTERY_STATE pbsComposite) *\ description: this function should be called when the battery meter parent window receives a WM_POWERBROADCAST, PBT_APMPOWERSTATUSCHANGE message, it will update the data in the global battery state list. if needed the display will also be updated. PARAMETERS: hWndBatMeter, hwnd of the battery meter dialog bShowMulti, display mode bForceUpdate, forces a ui update opt -> pbsComposite, pointer to composite battery state. *\ WM_POWERBROADCAST == 0x218 PBT_APMPOWERSTATUSCHANGE == 0xa _________________________________________________________________ Instale a Barra de Ferramentas com Desktop Search e ganhe EMOTICONS para o Messenger! É GRÁTIS! http://www.msn.com.br/emoticonpack

1 0

Re: [PATCH 4/7] widl: Support __fastcall and __pascal calling conventions.
by Dan Hipschman April 3, 2008

April 3, 2008

On Wed, Apr 02, 2008 at 12:56:21PM +0100, Robert Shearman wrote: > @@ -186,13 +186,19 @@ static const struct keyword keywords[] = { > {"FALSE", tFALSE}, > {"TRUE", tTRUE}, > {"__cdecl", tCDECL}, > + {"__fastcall", tFASTCALL}, > + {"__pascal", tPASCAL}, > {"__int64", tINT64}, > {"__stdcall", tSTDCALL}, __pascal should come after __int64.

1 1

Re: msi: Remove tentative definition of static array with no size specifier
by Andrew Talbot April 2, 2008

April 2, 2008

Andrew Talbot wrote: > strictly, when the static storage specifier is applied, the size must be > specified: > > static char ar[5]; /* tentative definition */ > > static char ar[5] = "hello"; /* actual definition */ > Of course, the size need not be specified in the case of the actual definition, so the following is what I should have typed. static char a[] = "hello"; /* actual definition */ -- Andy.

1 0

testing 3d graphics with vmware workstation 6.5 beta?
by Lei Zhang April 2, 2008

April 2, 2008

I just got an email about the next vmware workstation beta: "Improved 3D graphics Support — Workstation 6.5 can now support DirectX9.0 accelerated 3D with shaders so you can run more applications inside your VM." Maybe this will help with running the 3d graphics test suite in virtual machines? http://communities.vmware.com/community/beta/workstation6.5

2 1

Nice feature?
by Warren Dumortier April 2, 2008

April 2, 2008

Hello! I have a little proposition for Wine 1.0! Why not creating an error dialog when a dll is missing, it would help a lot of users! For example there's a dialog to install geck, why not a dialog that simply says you have to add a dll in the correct directory?

2 1

How can i bypass my bug?
by Warren Dumortier April 2, 2008

April 2, 2008

Hi! Some time ago i fille din a bug report because a game (The Sims : Pet Stories) couldn't lanch, after some mails the problem was that Wine doesn't gave vertex shaders, is there anything i can do to have this game running on my linux box? The bug has been reported as duplicate, but her's the correct one: http://bugs.winehq.org/show_bug.cgi?id=8051 Is there any way t have the game running (vertex sharders emulation running?), by adding dlls maybe, installing DirectX and disable some dlls? Anything? Thanks, kind regards!

3 4

Re: mshtml: Added registry configuration to allow using Active Script engine for JavaScript scripts.
by Alexandre Julliard April 2, 2008

April 2, 2008

Jacek Caban <jacek(a)codeweavers.com> writes: > + static const WCHAR key_nameW[] = > + {'S','o','f','t','w','a','r','e', > + '\\','W','i','n','e', > + '\\','M','S','H','T','M','L', > + '\\','S','c','r','i','p','t','O','v','e','r','r','i','d','e','s',0}; > + > + /* @@ Wine registry key: HKCU\Software\Wine\MSHTML\ScriptOverrides */ > + res = RegOpenKeyW(HKEY_CURRENT_USER, key_nameW, &hkey); > + if(res != ERROR_SUCCESS) > + return ret; Why do we need a configuration option for this? When would a user want to change it? -- Alexandre Julliard julliard(a)winehq.org

2 1

Some considerations about the Wine FUSE project for GSoC
by Kai Blin April 2, 2008

April 2, 2008

Hi folks, after another chat about Wine's goals in respect to FUSE file systems on IRC, I just wanted to point the students who applied for this project already (I've Bcced them) at the goals Wine has for this GSoC project. For Wine, the goal is to create prototype FUSE file systems so we can figure out if this approach is useful to Wine at all. There is no immediate goal to include the file systems into Wine in the near future, we first want to know if they're what we need. I think it's important to be clear and outspoken about this so nobody starts working on this under the wrong assumptions. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 6

Recent imm changes triggered widespread valgrind errors?
by Dan Kegel April 2, 2008

April 2, 2008

Aric, can you have a look? Any call to CreateWindow now spews lots of Valgrind errors. For instance, http://kegel.com/wine/valgrind/logs-2008-04-01/vg-advpack_install-diff.txt contains: + Conditional jump or move depends on uninitialised value(s) + at RtlInitUnicodeString (unicode.h:212) + by LoadLibraryExW (module.c:924) + by LoadLibraryW (module.c:968) + by ImmCreateContext (imm.c:143) + by X11DRV_SetupXIM (xim.c:510) + by x11drv_init_thread_data (x11drv_main.c:654) + by X11DRV_SetWindowPos (x11drv.h:517) + by set_window_pos (winpos.c:1919) + by WIN_CreateWindowEx (win.c:1121) + by CreateWindowExW (win.c:1351) + by manage_desktop (desktop.c:224) + by WinMain (explorer.c:136) + by main (exe_main.c:48)

2 2