October 2009 - Wine-Devel - list.winehq.org

CPPcheck October 27 Git
by chris ahrendt Oct. 28, 2009

Oct. 28, 2009

Current Leaks: [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd Tool Leaks: [/home/cahrendt/wine-git/tools/fnt2bdf.c:779]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/fnt2fon.c:388]: (error) Memory leak: file_lens [/home/cahrendt/wine-git/tools/sfnt2fnt.c:877]: (error) Resource leak: ofp [/home/cahrendt/wine-git/tools/widl/write_msft.c:2536]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/winedump/pe.c:1547]: (error) Memory leak: map Ignored Test Leaks: [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (error) Array index out of bounds [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:1117]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:1101]: (possible error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:1108]: (possible error) Resource leak: stream4 [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem Chris

1 0

kernel32: add more tests for FormatMessage{A,W}
by Louis Lenders Oct. 28, 2009

Oct. 28, 2009

>FormatMessage uses the same backend to find the requested resource as >FindResource does, so I'd guess that they both fail in the same way >when a resource id or a language does not exist in the module. Parsing >an actual resource data is not necessary. ok, but isn't that test already in tests/resource.c? See code snippet below: Or do i get it wrong? rsrc = FindResourceExW( GetModuleHandle(0), (LPCWSTR)RT_MENU, (LPCWSTR)MAKEINTRESOURCE(1), MAKELANGID( LANG_NEUTRAL, SUBLANG_NEUTRAL )); ok( rsrc != 0, "resource not found\n" ); rsrc = FindResourceExW( GetModuleHandle(0), (LPCWSTR)RT_MENU, (LPCWSTR)MAKEINTRESOURCE(1), MAKELANGID( LANG_GERMAN, SUBLANG_DEFAULT )); ok( rsrc != 0, "resource not found\n" ); SetLastError( 0xdeadbeef ); rsrc = FindResourceW( GetModuleHandle(0), (LPCWSTR)MAKEINTRESOURCE(1), (LPCWSTR)RT_DIALOG ); ok( !rsrc, "resource found\n" ); ok( GetLastError() == ERROR_RESOURCE_TYPE_NOT_FOUND, "wrong error %u\n", GetLastError() ); SetLastError( 0xdeadbeef ); rsrc = FindResourceW( GetModuleHandle(0), (LPCWSTR)MAKEINTRESOURCE(2), (LPCWSTR)RT_MENU ); ok( !rsrc, "resource found\n" ); ok( GetLastError() == ERROR_RESOURCE_NAME_NOT_FOUND, "wrong error %u\n", GetLastError() ); SetLastError( 0xdeadbeef ); rsrc = FindResourceExW( GetModuleHandle(0), (LPCWSTR)RT_MENU, (LPCWSTR)MAKEINTRESOURCE(1), MAKELANGID( LANG_ENGLISH, SUBLANG_DEFAULT ) ); ok( !rsrc, "resource found\n" ); ok( GetLastError() == ERROR_RESOURCE_LANG_NOT_FOUND, "wrong error %u\n", GetLastError() ); SetLastError( 0xdeadbeef ); rsrc = FindResourceExW( GetModuleHandle(0), (LPCWSTR)RT_MENU, (LPCWSTR)MAKEINTRESOURCE(1), MAKELANGID( LANG_FRENCH, SUBLANG_DEFAULT ) ); ok( !rsrc, "resource found\n" ); ok( GetLastError() == ERROR_RESOURCE_LANG_NOT_FOUND, "wrong error %u\n", GetLastError() ); }

2 1

kernel32: add more tests for FormatMessage{A,W}
by Louis Lenders Oct. 28, 2009

Oct. 28, 2009

>A couple of suggestions: >1. There is no point in testing last error if an API didn't fail Couldn't it be that the API sets ERROR_SUCCES if it doesn't fail? >2. It would be helpful to simultaneously test return values and >last error for FindResource, which should have similar behaviour >(and the bug) to FormatMessage Could you explain a bit more what exactly to test? I can load the whole messagetable with FindResource from kernel32, but that always succeeds of course. Using the MESSAGE_RESOURCE_BLOCK and MESSAGE_RESOURCE_ENTRY structures I could I load a messagestring I guess, but that doesn't test the behaviour of FindResource anymore. Or do i see things wrong here? Trying to load a non existing messagetable from another dll with FindResource gives ERROR_RESOURCE_TYPE_NOT_FOUND. Or is that not what you meant? >and drop FormatMessageW tests. Ok i'll do that

2 1

Re: [PATCH 5] winmm/tests: Add MCI waveaudio tests.
by Alexandre Julliard Oct. 28, 2009

Oct. 28, 2009

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > -START_TEST(mci) > +#ifndef FULL_TEST > +/* Some tests hang or crash Wine. Enable once fixed. */ > +#define FULL_TEST 0 > +#endif Please don't introduce dead code. If the tests really can't work then don't add them at all until you have the corresponding fixes. -- Alexandre Julliard julliard(a)winehq.org

4 5

Extracting yet more wine tests from the chromium test suite
by Dan Kegel Oct. 27, 2009

Oct. 27, 2009

http://kegel.com/wine/chromium/ now has a precompiled tarball containing 13 of chromium's test programs: app_unittests base_unittests courgette_unittests googleurl_unittests ipc_tests media_unittests net_unittests printing_unittests sbox_unittests sbox_validation_tests setup_unittests tcmalloc_unittests unit_tests (These are, more or less, all the ones that run in under a minute on Windows. There are some big tests left, but I figured this was enough to chew on for a while.) http://kegel.com/wine/chromium/failures.txt lists the 50 test cases which fail (but not crash) in which executable. http://kegel.com/wine/chromium/chromium-runtests.sh.txt has a little documentation, and shows how to skip the handful of tests that crash or hang. I'm slowly starting to file bugs and/or testcases for these, starting with http://bugs.winehq.org/show_bug.cgi?id=20495. (It took me a while to do that one today - writing the wine test case was easy, but figuring out why it passed but the real test didn't required pulling out the important part of the logs for both and flipping back and forth between them in an editor. Once I did that, it was trivial.) I don't actually expect the sandbox tests to work any time soon, but they're there if anyone's interested. - Dan

1 1

Re: [1/2] shell32/tests: Program Manager DDE Conformance Tests
by Vitaliy Margolen Oct. 27, 2009

Oct. 27, 2009

Mike wrote: > Conformance Tests to test the Program Manager DDE. Currently stubbed in Wine, bug 9159. Has been tested on Win XP SP2 and Win 98 SE. > > --- > dlls/shell32/tests/Makefile.in | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/tests/Makefile.in b/dlls/shell32/tests/Makefile.in > index dd0587c..0cad860 100644 > --- a/dlls/shell32/tests/Makefile.in > +++ b/dlls/shell32/tests/Makefile.in > @@ -9,6 +9,7 @@ CTESTS = \ > appbar.c \ > autocomplete.c \ > generated.c \ > + progman_dde.c \ > shelllink.c \ > shellpath.c \ > shfldr_special.c \ > -- This can't work on it's own and should be merged with your next patch. > +HDDEDATA CALLBACK DdeCallback(UINT type, > + UINT format, > + HCONV hConv, > + HSZ hsz1, > + HSZ hsz2, > + HDDEDATA hDDEData, > + ULONG_PTR data1, > + ULONG_PTR data2) > +{ > + trace("Callback: type=%i, format=%i\n", type, format); > + return NULL; > +} > + Tabs should always be set to 8 spaces, not 4. For Wine please use 4-space indentations, no tabs please. > +int IsWin9x(void) > +{ > + return (GetVersion() & 0x80000000); > +} Don't add this sort of functions. All tests should work on all Windows versions. Or you should detect differences by other means. > +/* Transfer DMLERR's into text readable strings for Error Messages */ > +const char * GetStringFromError(UINT err) > +{ > + const char * retstr; > + switch (err) > + { > + case DMLERR_NO_ERROR: > + retstr = "DMLERR_NO_ERROR"; > + break; > + case DMLERR_ADVACKTIMEOUT: > + retstr = "DMLERR_ADVACKTIMEOUT"; > + break; > + case DMLERR_BUSY: Use ## macro for this instead. See examples throughout the code-base. > + window = FindWindow(NULL, winName); > + SendMessage(window, WM_SYSCOMMAND, SC_CLOSE, 0); You should explicitly specify A or W variant of the function in tests. > + path = (char *) malloc(MAX_PATH); Don't use malloc in tests, use HeapAllock instead. > + DdeExecuteCommand(instance, hConv, (char *) "[InvalidCommand()]", &hData, &error, DDE_TEST_MISC|testnum++); This is wrong - don't cast away const pointers. If you getting warnings that means you doing something wrong. Vitaliy.

1 0

re: d3d10: Parse local_variables.
by Dan Kegel Oct. 27, 2009

Oct. 27, 2009

(Spotted by http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-d3d10_effect.txt ) Hi Rico, the patch commit b55641f14a210f689cde8b08750a78779657c06e Author: Rico Schüller <kgbricola(a)web.de> Date: Sun Oct 25 17:11:49 2009 +0100 d3d10: Parse local_variables. seems to have introduced the following valgrind error: http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/vg-d3d10_effect.txt Invalid free() / delete / delete[] at notify_free (heap.c:222) by RtlFreeHeap (heap.c:1474) by d3d10_effect_Release (effect.c:1649) by test_effect_constant_buffer_type (effect.c:193) by func_effect (effect.c:1128) by run_test (test.h:535) by main (test.h:585) Address 0x7f03def0 is 104 bytes inside a block of size 112 alloc'd at notify_alloc (heap.c:214) by RtlAllocateHeap (heap.c:1421) by D3D10CreateEffectFromMemory (d3d10_main.c:218) by test_effect_constant_buffer_type (effect.c:93) by func_effect (effect.c:1128) by run_test (test.h:535) by main (test.h:585) and a number of small leaks of the form 0 bytes in 1 blocks are definitely lost at notify_alloc (heap.c:214) by RtlAllocateHeap (heap.c:1421) by parse_fx10_body (effect.c:1280) by parse_fx10 (effect.c:1394) by fx10_chunk_handler (effect.c:1408) by parse_dxbc (effect.c:157) by d3d10_effect_parse (effect.c:1418) by D3D10CreateEffectFromMemory (d3d10_main.c:230) by test_effect_variable_element (effect.c:665) by func_effect (effect.c:1131) by run_test (test.h:535) by main (test.h:585) Could you have a look? Thanks, Dan

2 1

[RFC] mshtml/tests: Fix events test when pointer is on a corner.
by Nicolas Le Cam Oct. 27, 2009

Oct. 27, 2009

Hi, Since commit 8272ecd3f2235b923f2ec67bb51d051bdfbf466f I'm having errors on events tests. I just found that it only fails if pointer is on any corner. As I'm always putting it on upper right corner when running winetest it was always failing for me. Minimizing the test window fixed it for me but I'm not sure it's the right fix, so I'm sending it to wine-devel. Tested on Win2k SP4 and WinXP SP2 (both with IE6). -- Nicolas Le Cam

1 0

New DOS drives handling patchset: testers wanted
by Charles Davis Oct. 27, 2009

Oct. 27, 2009

Hi, Attached is my latest attempt at moving DOS drive handling completely over to mountmgr. You might remember my last patchset that tried this. That patchset was a real piece of crap. I tested it, and there were compile warnings, crashes, and mysterious "dangling FD object" problems that I'd rather avoid. I fixed all of those, and I must say that this is a vast improvement over that early attempt. But since this is such a major change, I want to make sure I have this absolutely right before I send it in. That's why I need people to test this for me, and report any problems, failed tests, etc. It works on my system, so it just might work on yours. Enjoy. Chip

1 0

Re: RFC: ntdll: Implement CDROM_GetInterfaceInfo() on Mac OS (try 2)
by Charles Davis Oct. 27, 2009

Oct. 27, 2009

Charles Davis wrote: > Alexandre Julliard wrote: >> Charles Davis <cdavis(a)mymail.mines.edu> writes: >> >>> Here's a new version of my patch that's slightly less complicated. I >>> didn't get a response last time, so I'm sending it again. Please, >>> someone review my patch. I won't send it to wine-patches until I know I >>> have this right (yes, I am a bit of a perfectionist). >>> >>> To reiterate what I said about this patch last time, this patch will >>> implement the CDROM_GetInterfaceInfo() function on Mac OS, which allows >>> clients to, among other things, get a SCSI address to do whatever with. >>> (If this is over your head, you can stop reading now. :) >> That sort of thing should most likely be integrated with the >> diskarbitration stuff in mountmgr. >> > Really? I guess I could do it that way. But then how are > IOCTL_SCSI_GET_ADDRESS clients supposed to get the address? Oops, forgot to reply all again.

2 18