October 2009 - Wine-Devel - list.winehq.org

Re: rsaenh: Revert part of d3c482250a8232e9657ecefb3e61fff0194e3fbe
by Alexandre Julliard Oct. 21, 2009

Oct. 21, 2009

Juan Lang <juan.lang(a)gmail.com> writes: > Commit d3c482250a8232e9657ecefb3e61fff0194e3fbe added a test that > showed that the default provider should accept RC2 keys of up to 128 > bits in length. The trouble is the fix was wrong: the default > provider in Wine was the base cryptographic provider, but it has been > the enhanced cryptographic provider for some time in Windows. The > enhanced provider in Wine already supported 128 bit RC2 keys, and the > test also used the default provider. Commit > 7a6381e852a4daf0bbc77ffcb9da3bd85002e1d8 made the enhanced provider > the default, so the test succeeds without this portion of the patch > applied. It fails for me: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so crypt.c && touch crypt.ok crypt.c:972: Test failed: CryptImportKey error 2148073481 make: *** [crypt.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: comctl32: Scroll listview when performing a marquee selection
by Nikolay Sivov Oct. 21, 2009

Oct. 21, 2009

Owen Rudge wrote: > This patch adds support for scrolling a listview when performing a > marquee selection. In Windows, a listview will scroll around when > dragging and highlighting icons, picking up speed as you move the > mouse further past the window. > Hi, Owen. This patch is rather large, so few comments: > + RECT marqueeRect; /* absolute coordinates of marquee selection */ > + RECT marqueeDrawRect; /* relative coordinates for drawing marquee */ > + POINT marqueeOrigin; /* absolute coordinates of marquee click origin */ I don't think you need such duplication. Why not to use a single rectangle? Looks like you always offset it to listview origin, so these rectangle differ in offset only, that's why you introduced another iterator_* helper. If I'm right about that it's better to add another OffsetRect than consistently maintain two variables with same meaning.

2 3

Re: [PATCH] RESUBMIT: configure: also use LDFLAGS for DLL builds
by Alexandre Julliard Oct. 21, 2009

Oct. 21, 2009

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > While one usually does not pass in LDFLAGS to dll building, one > probably should be able to. This should be passed from the makefile, not expanded inside LDDLLFLAGS. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] programs: initial add extrac32 utility
by Austin English Oct. 21, 2009

Oct. 21, 2009

2009/10/21 Ilya Shpigor <shpigor(a)etersoft.ru>: You need to add the program to configure.ac, as well as add Makefile.in -- -Austin

2 1

Please test on Windows: waveOutGet/SetVolume
by Ken Thomases Oct. 21, 2009

Oct. 21, 2009

Hi, Can I ask folks with Windows available to them to run a test for me? I'm attaching a patch for the winmm wave.c test to test the behavior of waveOutSetVolume and waveOutGetVolume, in particular the difference between setting/getting the volume with a device identifier versus a handle to an open instance of the device. The new tests are designed to fail, in order to produce maximal diagnostic output. Thanks, Ken

1 0

Re: [shell32/tests] Fix a test failure on some Vista boxes
by Vincent Povirk Oct. 21, 2009

Oct. 21, 2009

I actually left the order out of the original test intentionally. The order is completely predictable on Windows and Wine (the window docked first ends up closer to the edge), but X docks work differently. They are controlled by the window manager. If we ever need to create real X docks for appbars (unlikely because of how rarely they're used, but possible), the order will be defined by the window manager, and it won't be possible to reliably pass the test. On Wed, Oct 21, 2009 at 4:43 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > "Fixes" a long standing failure on at least my Vista box. After the removal > of windows[0] there are no ABS_POSCHANGED messages around like on other > boxes. > > Marked as broken() as there seem to be only 2 Vista boxes that have this > issue. I'm running Vista Ultimate maybe that's it? > > This failure has been discussed with Vincent in the past but the thought was > that we were removing the wrong window. The added tests shows however that > the order of the windows is correct when we start. > > Changelog > Fix a test failure on some Vista boxes > > -- > Cheers, > > Paul. > > > > -- Vincent Povirk

2 3

Re: [7/7] msi: Avoid accessing uninitialized memory.
by Juan Lang Oct. 21, 2009

Oct. 21, 2009

Hi Hans, - size = (lstrlenW(value) + 1 + size) * sizeof(WCHAR); + size += (lstrlenW(value) + 1) * sizeof(WCHAR); I don't see how you're avoiding accessing uninitialize memory here. Could you enlighten me? I think it's complaining about value, by the way, which could be NULL according to line 5034: if (flags & ENV_ACT_REMOVEMATCH && (!value || !lstrcmpW(data, value))) --Juan

2 1

Re: [PATCH 1/2] Patch for bug 20227
by Juan Lang Oct. 21, 2009

Oct. 21, 2009

Hi Nate, the subject line isn't specific enough. We'd prefer you put a brief description of the change, rather than the bug that motivated it. E.g. your git commit tag for this, "Add tablename tracking to VIEW_find_column.", would be better. For your patch 2/2, you used "Test for bug 20227" as the git commit, which really isn't descriptive enough. Thanks. (Also, nit: > irregardless of any tablename modifier. irregardless is not a word. You probably mean either regardless or irrespective.) --Juan

1 0

Re: [1/2] (resend with array adaptation) user32/tests/class.c: Test extra value of standard dialog and edit classes
by Paul Vriens Oct. 21, 2009

Oct. 21, 2009

On 10/21/2009 11:46 AM, Julius Schwartzenberg wrote: > This is the test for bug #2181. The patch will follow. Currently the > test checks the value of just two classes, it may be useful to extend > this in the future. The test passes on Windows for Workgroups 3.11, > Windows 98, Windows XP 32-bit and with the broken call on Windows XP > 64-bit. > > > > Hi Julius, Tests that fail on Wine should be marked todo_wine: class.c:866: Test failed: expected 6, got 4 You can remove the todo_wine again in the patch that fixes Wine. Another approach is maybe send the fix as patch1 and the test as patch2? -- Cheers, Paul.

2 2

Re: [1/3] programs: initial add extrac32 utility
by Nikolay Sivov Oct. 21, 2009

Oct. 21, 2009

Ilya Shpigor wrote: > ------------------------------------------------------------------------ > > This is incomplete. How it's supposed to be built?

1 0