November 2009 - Wine-Devel - list.winehq.org

re: winmm: Don't stop parsing after MCI's alias keyword.
by Dan Kegel Nov. 23, 2009

Nov. 23, 2009

Joerg wrote: > I'm surprised that valgrind did not complain about the bug... Looks like I ignore files that only contain leak errors: http://code.google.com/p/winezeug/source/browse/trunk/valgrind/valgrind-spl… on the theory that we're already overwhelmed dealing with non-leak errors. You can still see the leaks in the full log, http://kegel.com/wine/valgrind/logs/2009-11-19-08.35.log What do people think - should we focus on non-leak errors for a while (in which case I should suppress all leak errors), or should I stop ignoring modules that only have leak errors? Also, mci tests hang on my system and need to be killed, so I may be missing some errors because of that. (Finally, my automated runs are on hold while I add use-after-free detection. I'm lame, and use the same source tree for develoment and for the automated runs. One of these days I should separate them. Or somebody else could do the automated runs...) - Dan

2 1

Re: winspool: Don't use 16Bit gdi.exe function for DeviceCapabilitiesA/W
by Alexandre Julliard Nov. 23, 2009

Nov. 23, 2009

Detlef Riekenberg <wine.dev(a)web.de> writes: > - if (!GDI_CallDeviceCapabilities16) > - { > - GDI_CallDeviceCapabilities16 = (void*)GetProcAddress( GetModuleHandleA("gdi32"), > - (LPCSTR)104 ); > - if (!GDI_CallDeviceCapabilities16) return -1; > - } > - ret = GDI_CallDeviceCapabilities16(pDevice, pPort, cap, pOutput, lpdm); > - > - /* If DC_PAPERSIZE map POINT16s to POINTs */ > - if(ret != -1 && cap == DC_PAPERSIZE && pOutput) { > - POINT16 *tmp = HeapAlloc( GetProcessHeap(), 0, ret * sizeof(POINT16) ); > - POINT *pt = (POINT *)pOutput; You can't remove the 16-bit conversion if you are still calling the existing driver. Probably a better approach is to first add a DrvDeviceCapabilities to the wineps driver. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: Only require REG_OPTION_VOLATILE when creating a new key.
by Paul Vriens Nov. 23, 2009

Nov. 23, 2009

Hi Alexandre, With this patch the following errors are introduced when starting anything on a clean .wine : err:setupapi:registry_callback could not create key 0x80000002 L"HARDWARE\\DEVICEMAP\\PARALLEL PORTS" err:setupapi:registry_callback could not create key 0x80000002 L"HARDWARE\\DEVICEMAP\\SERIALCOMM" -- Cheers, Paul.

1 0

[RFC] Handle process token groups in server/file.c::sd_to_mode
by Ben Peddell Nov. 22, 2009

Nov. 22, 2009

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This proposed patch (which I believe will contribute toward solving bugs 17672, 19588 and 20643, and any others where the permissions are set too restrictive) exposes the token_sid_present call in token.c, and uses it to check the SIDs in the security descriptor against those in the process token. Are there any changes anyone can think of before I submit it to wine-patches? Is there a better (already exposed) way of checking a SID against the process token's group list? - ---- server/file.c | 6 ++++-- server/security.h | 1 + server/token.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksBcpAACgkQTHDAI68Nsuny6ACfXu3vvWS6O27Z/mfozb4e/ZMG MYQAoItP8P75a3l54TYrLnQbk7lNyaaQ =7QsU -----END PGP SIGNATURE----- server/file.c | 6 ++++-- server/security.h | 1 + server/token.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/server/file.c b/server/file.c index a74de14..793c24a 100644 --- a/server/file.c +++ b/server/file.c @@ -485,7 +485,8 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) if (access & FILE_EXECUTE) denied_mode |= S_IXUSR|S_IXGRP|S_IXOTH; } - else if (security_equal_sid( sid, owner )) + else if (security_equal_sid( sid, owner ) || + token_sid_present( current->process->token, sid, 1 )) { unsigned int access = generic_file_map_access( ad_ace->Mask ); if (access & FILE_READ_DATA) @@ -509,7 +510,8 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) if (access & FILE_EXECUTE) new_mode |= S_IXUSR|S_IXGRP|S_IXOTH; } - else if (security_equal_sid( sid, owner )) + else if (security_equal_sid( sid, owner ) || + token_sid_present( current->process->token, sid, 0 )) { unsigned int access = generic_file_map_access( aa_ace->Mask ); if (access & FILE_READ_DATA) diff --git a/server/security.h b/server/security.h index 39b1d2f..33cf5da 100644 --- a/server/security.h +++ b/server/security.h @@ -55,6 +55,7 @@ extern int token_check_privileges( struct token *token, int all_required, extern const ACL *token_get_default_dacl( struct token *token ); extern const SID *token_get_user( struct token *token ); extern const SID *token_get_primary_group( struct token *token ); +extern int token_sid_present( struct token *token, const SID *sid, int deny); static inline const ACE_HEADER *ace_next( const ACE_HEADER *ace ) { diff --git a/server/token.c b/server/token.c index ce896ac..461e79d 100644 --- a/server/token.c +++ b/server/token.c @@ -776,7 +776,7 @@ int token_check_privileges( struct token *token, int all_required, return (enabled_count > 0); } -static int token_sid_present( struct token *token, const SID *sid, int deny ) +int token_sid_present( struct token *token, const SID *sid, int deny ) { struct group *group;

3 7

Firefox not installing with winetricks. Reason: need to upgrade 3.5.3 to 3.5.5.
by Ido Tal Nov. 22, 2009

Nov. 22, 2009

Hi, I've just now tried to install firefox with winetricks and failed. A short scan reveals what the problem is (I think): the version winetricks is trying to install is 3.5.3. Looking at http://releases.mozilla.org/pub/mozilla.org/firefox/releases/ shows that it's not there anymore. Hope this helps... Ido

3 2

Re: [PATCH 1/3] gdi32/tests: Test BitBlt() to an enhanced metafile.
by Charles Davis Nov. 22, 2009

Nov. 22, 2009

Austin English wrote: > On Sat, Nov 21, 2009 at 11:15 PM, Charles Davis <cdavis(a)mymail.mines.edu> wrote: >> Dmitry Timoshkov wrote: >>> "Charles Davis" <cdavis(a)mymail.mines.edu> wrote: >>> >>>>> You forgot to remove if (1). >>>>> >>>> It goes away in patch #3. I thought I already had this discussion with >>>> Paul. >>>> >>>> There's a reason it's there. EMF_BITBLT contains two BitBlt() records, >>>> but the EMF we're comparing it to only has one. That's because one of >>>> them is if(0)'d out because it crashes on Wine. So, if we try to compare >>>> the EMF we produced to the EMF we expect, it will fail. Last I checked, >>>> Alexandre doesn't like it when tests fail. All tests must pass on his >>>> box. >>> There are 2 solutions for that: >>> 1. use todo_wine in the test, and remove it in a patch with the fix >> The test will fail on Windows if I do that. > > That won't affect windows. It will only fail on wine if it passes. > You don't understand. The expected EMF bits contain TWO BitBlt() records, but the EMF produced by the test contains only one. It will contain only one on both Wine and Windows, because one of the calls to BitBlt() is if(0)'d out. So the test will fail on Windows if the call to compare_emf_bits() is marked todo_wine. Oh, and you didn't reply to all. Was that intentional?

2 1

Someone please update the german translation of Ubuntu download page
by Scott Ritchie Nov. 22, 2009

Nov. 22, 2009

My German is inadequate and there are no instructions for Karmic users there at the moment. Thanks, Scott Ritchie

2 1

Re: [PATCH 1/3] gdi32/tests: Test BitBlt() to an enhanced metafile.
by Dmitry Timoshkov Nov. 21, 2009

Nov. 21, 2009

"Charles Davis" <cdavis(a)mymail.mines.edu> wrote: > + if(1 || compare_emf_bits(hMetafile, EMF_BITBLT, sizeof(EMF_BITBLT), > + "emf_BitBlt", FALSE) != 0) > + { > + dump_emf_bits(hMetafile, "emf_BitBlt"); > + dump_emf_records(hMetafile, "emf_BitBlt"); > + } You forgot to remove if (1). -- Dmitry.

2 3

Next step: detect double-frees and use-after-free
by Dan Kegel Nov. 21, 2009

Nov. 21, 2009

Now that the heap tail check is more or less working, I'm on to implementing protection against double frees and use-after-free for recently freed blocks. The idea is that HEAP_MakeInUseBlockFree() will take the block it's called with, push it onto a FIFO, pull an old block off the FIFO, and mark that old block free. The blocks languishing in the FIFO will be marked inaccessible. If you try to free one, realloc one, or even get its size, you'll get an immediate error; if you write to one, you'll get an error when it comes out of the FIFO or when the heap is validated; and if you're running Valgrind, you'll get an immediate error on read or write to the freed block. The FIFO will be drained when the heap is destroyed. It will be implemented using a standard wine list in an optional fixed-sized block at the tail of each allocation. Remind me again why we didn't do this years ago...

1 0

Re: Difficulties with Regression Testing
by James Mckenzie Nov. 20, 2009

Nov. 20, 2009

>From: Austin English <austinenglish(a)gmail.com> >Sent: Nov 19, 2009 10:31 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Wine Development Mailing List <wine-devel(a)winehq.org> >Subject: Re: Difficulties with Regression Testing > >On Thu, Nov 19, 2009 at 8:51 AM, James Mckenzie ><jjmckenzie51(a)earthlink.net> wrote: >> All: >> >> I've been running regression tests to find a commit between wine-1.1.10 and wine-1.1.11 that breaks the EM_FORMATRANGE >> patch or to discover what I need to do to fix the patch to make it work with wine-1.1.11. I've been following the >> instructions on the Regression Testing Wiki page. I am on the fourth git bisect good and I run into two different >> problems: >> >> 1. The tools/Makefile.in file gets corrupted on the fourth git bisect good. This is unexpected as I am not aware of >> any changes to this file that would cause corruption. This happens interrmittently and a git fetch sometimes causes >> the error that tools/Makefile.in needs to be updated to appear when I apply/remove a patch which is needed to correct >> wordpad, one of the programs I am using to test the EM_FORMATRANGE patch. The build fails when attempting to build >> makedep.c. The includes appear to be incorrect and do not pick up the files in the source directory thus the Wine >> includes are not included. > >Try doing a make clean / make distclean. > I don't think this will do anything, but I'll try it. >> 2. Something else is causing the check.bmp file not to be found and thus the tests fail on the fourth git bisect >> good. The .rc file that calls this file is located in two different directorys but the check.bmp file only exists in >> the tools/subdirectory. > >IIRC, that was a file for the cryptui manager that AJ forgot to >include with the commit needing it. Try either putting it there >manually from another git branch, or using make -k. > Where does this need to be added? I might be able to figure it out, but I don't want to go guessing. James McKenzie

2 2

UMR in CertIsRDNAttrsInCertificateName()
by Dan Kegel Nov. 20, 2009

Nov. 20, 2009

http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-crypt32_cert.txt shows a new UMR (purify-speak for uninitialized memory read) error Conditional jump or move depends on uninitialised value(s) at strncmp (mc_replace_strmem.c:386) by find_matching_rdn_attr (cert.c:1877) by CertIsRDNAttrsInCertificateName (cert.c:1907) by testIsRDNAttrsInCertificateName (cert.c:2698) Uninitialised value was created by a client request at mark_block_uninitialized (heap.c:192) by RtlAllocateHeap (heap.c:1526) by HeapAlloc (heap.c:276) by GlobalAlloc (heap.c:369) by LocalAlloc (heap.c:969) by CRYPT_DecodeEnsureSpace (decode.c:218) by CRYPT_AsnDecodeName (decode.c:1918) by CryptDecodeObjectEx (decode.c:5909) by CertIsRDNAttrsInCertificateName (cert.c:1901) by testIsRDNAttrsInCertificateName (cert.c:2698) Juan, I think that's yours, could you have a look? - Dan

2 1

Re: [PATCH 2/2] mshtml: Also search by node name attribute in IHTMLDocument3::getElementById
by Jacek Caban Nov. 20, 2009

Nov. 20, 2009

Hi Andrew, Andrew Eikum wrote: > --- > dlls/mshtml/htmldoc3.c | 58 > +++++++++++++++++++++++++++++++++++++++++++--- > dlls/mshtml/nsiface.idl | 33 ++++++++++++++++++++++++++ > dlls/mshtml/tests/dom.c | 29 ++++++++++++++++++++++- > 3 files changed, 115 insertions(+), 5 deletions(-) [ object, + uuid(29fb2a18-1dd2-11b2-8dd9-a6fd5d5ad12f), + local + /* FROZEN */ +] This interface is not frozen, please change the comment to NOT_FROZEN so that I we will know that we have to check it for changes on the next Gecko update. + hres = IHTMLElement_get_tagName(elem2, &str); + ok(hres == S_OK, "IHTMLElement_get_tagName failed: 0x%08x\n", hres); + ok(!strcmp_wa(str, "A"), "Got wrong tag: %s\n", wine_dbgstr_w(str)); + SysFreeString(str); There is generic test_elem_tag that is meant for this. + /* getElementById with node name attributes */ + hres = IHTMLDocument2_QueryInterface(doc, &IID_IHTMLDocument3, (void**)&doc3); + ok(hres == S_OK, "Unable to get IHTMLDocument3: 0x%08x\n", hres); + if(FAILED(hres)) + return; + bstr = a2bstr("nm1"); + hres = IHTMLDocument3_getElementById(doc3, bstr, &elem); + SysFreeString(bstr); + IHTMLDocument3_Release(doc3); + ok(hres == S_OK, "getElementById failed: 0x%08x\n", hres); + if(FAILED(hres)) + return; Same here for get_doc_elem_by_id. + + hres = IHTMLElement_get_id(elem, &bstr); + ok(hres == S_OK, "IHTMLElement_get_id failed: 0x%08x\n", hres); + ok(!strcmp_wa(bstr, "fr1"), "Found ID should have been \"fr1\", was: %s", wine_dbgstr_w(bstr)); + SysFreeString(bstr); Same here for test_elem_id. Thanks, Jacek

2 1

re: Running server applications under Wine?
by Dan Kegel Nov. 20, 2009

Nov. 20, 2009

임은지 wrote: > Is there anyone who uses Wine for server applications (game server, web server, etc.)? It's been done. See e.g. http://www.fpsadmin.com/forum/showthread.php?t=16481 for how one fellow ran a game server in wine. > Performance is very important issue for such applications. A server should serve a large number of clients at reasonable speeds. Yes, it would be interesting to run ab or dkftpbench against an http or ftp server running on wine. > What do you think about implementing wineserver kernel module or handling only performance critical items in kernel? There has long been talk of doing that. Linus is even willing to take patches to implement win32 APIs in the linux kernel. But it turns out to not be what most people need. If you want to do some server performance stress testing and file bugs for problems you find, by all means, go ahead! - Dan

2 3

New version of my test for bug 4543
by Charles Davis Nov. 20, 2009

Nov. 20, 2009

Hi, This is a new version of my test for bug 4543. This time, I followed Dmitry's suggestion of using the existing functions for comparing the contents of EMFs. I can't build tests for Windows both due to bug 20763 and due to the fact that I don't have any Windows boxes, so once again I need people to run this test on Windows to make sure it's an accurate representation of Windows' behavior. The test currently succeeds on Wine. Thanks in advance. Chip >From 574bb4f7b2b90a209b1693b7f8048a2eb271ada8 Mon Sep 17 00:00:00 2001 From: Charles Davis <cdavis(a)mymail.mines.edu> Date: Tue, 17 Nov 2009 11:10:50 -0700 Subject: [PATCH] gdi32/tests: Test BitBlt() to an enhanced metafile. To: wine-patches <wine-patches(a)winehq.org> Reply-To: wine-devel <wine-devel(a)winehq.org> --- dlls/gdi32/tests/metafile.c | 125 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 125 insertions(+), 0 deletions(-) diff --git a/dlls/gdi32/tests/metafile.c b/dlls/gdi32/tests/metafile.c index b559901..3bd413b 100644 --- a/dlls/gdi32/tests/metafile.c +++ b/dlls/gdi32/tests/metafile.c @@ -1030,6 +1030,63 @@ static const unsigned char EMF_LINETO_MM_TEXT_BITS[] = { 0x14, 0x00, 0x00, 0x00 }; +static const unsigned char EMF_BITBLT[] = +{ + 0x01, 0x00, 0x00, 0x00, 0x6c, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x03, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x94, 0x00, 0x00, 0x00, 0x79, 0x00, 0x00, 0x00, + 0x20, 0x45, 0x4d, 0x46, 0x00, 0x00, 0x01, 0x00, + 0xa0, 0x01, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, + 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x04, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, + 0xfc, 0x01, 0x00, 0x00, 0x38, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x60, 0xc0, 0x07, 0x00, + 0xc0, 0xc2, 0x04, 0x00, 0x4c, 0x00, 0x00, 0x00, + 0xbc, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, + 0x03, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, + 0x04, 0x00, 0x00, 0x00, 0x20, 0x00, 0xcc, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x80, 0x3f, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x80, 0x3f, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x64, 0x00, 0x00, 0x00, 0x28, 0x00, 0x00, 0x00, + 0x8c, 0x00, 0x00, 0x00, 0x30, 0x00, 0x00, 0x00, + 0x28, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, + 0x04, 0x00, 0x00, 0x00, 0x01, 0x00, 0x18, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x30, 0x00, 0x00, 0x00, + 0xc4, 0x0e, 0x00, 0x00, 0xc4, 0x0e, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x4c, 0x00, 0x00, 0x00, 0x64, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x03, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x04, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, + 0x62, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x80, 0x3f, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x80, 0x3f, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x64, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x64, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x0e, 0x00, 0x00, 0x00, + 0x14, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x10, 0x00, 0x00, 0x00, 0x14, 0x00, 0x00, 0x00 +}; + + /* For debugging or dumping the raw metafiles produced by * new test functions. */ @@ -1382,6 +1439,73 @@ static int compare_emf_bits(const HENHMETAFILE mf, const unsigned char *bits, return 0; } + +/* tests blitting to an EMF */ +static void test_emf_BitBlt(void) +{ + HDC hdcDisplay, hdcMetafile, hdcBitmap; + HBITMAP hBitmap, hOldBitmap; + HENHMETAFILE hMetafile; +#define BMP_DIM 4 + BITMAPINFOHEADER bmih = + { + sizeof(BITMAPINFOHEADER), + BMP_DIM,/* biWidth */ + BMP_DIM,/* biHeight */ + 1, /* biPlanes */ + 24, /* biBitCount */ + BI_RGB, /* biCompression */ + 0, /* biXPelsPerMeter */ + 0, /* biYPelsPerMeter */ + 0, /* biClrUsed */ + 0, /* biClrImportant */ + }; + void *bits; + BOOL ret; + + hdcDisplay = CreateDCA("DISPLAY", NULL, NULL, NULL); + ok( hdcDisplay != 0, "CreateDCA error %d\n", GetLastError() ); + + hdcBitmap = CreateCompatibleDC(hdcDisplay); + ok( hdcBitmap != 0, "CreateCompatibleDC failed\n" ); + bmih.biXPelsPerMeter = MulDiv(GetDeviceCaps(hdcDisplay, LOGPIXELSX), 100, 3937); + bmih.biYPelsPerMeter = MulDiv(GetDeviceCaps(hdcDisplay, LOGPIXELSY), 100, 3937); + hBitmap = CreateDIBSection(hdcDisplay, (const BITMAPINFO *)&bmih, + DIB_RGB_COLORS, &bits, NULL, 0); + hOldBitmap = SelectObject(hdcBitmap, hBitmap); + + hdcMetafile = CreateEnhMetaFileA(hdcBitmap, NULL, NULL, NULL); + ok( hdcMetafile != 0, "CreateEnhMetaFileA failed\n" ); + + /* First fill the bitmap DC with something recognizable, like BLACKNESS */ + ret = BitBlt(hdcBitmap, 0, 0, BMP_DIM, BMP_DIM, 0, 0, 0, BLACKNESS); + ok( ret, "BitBlt(BLACKNESS) failed\n" ); + + ret = BitBlt(hdcMetafile, 0, 0, BMP_DIM, BMP_DIM, hdcBitmap, 0, 0, SRCCOPY); + ok( ret, "BitBlt(SRCCOPY) failed\n" ); + if(0) /* Crashes on wine */ + { + ret = BitBlt(hdcMetafile, 0, 0, BMP_DIM, BMP_DIM, 0, 0, 0, WHITENESS); + ok( ret, "BitBlt(WHITENESS) failed\n" ); + } + + hMetafile = CloseEnhMetaFile(hdcMetafile); + ok( hMetafile != 0, "CloseEnhMetaFile failed\n" ); + + if(1 || compare_emf_bits(hMetafile, EMF_BITBLT, sizeof(EMF_BITBLT), + "emf_BitBlt", FALSE) != 0) + { + dump_emf_bits(hMetafile, "emf_BitBlt"); + dump_emf_records(hMetafile, "emf_BitBlt"); + } + + SelectObject(hdcBitmap, hOldBitmap); + DeleteObject(hBitmap); + DeleteDC(hdcBitmap); + DeleteDC(hdcDisplay); +#undef BMP_DIM +} + /* Test a blank metafile. May be used as a template for new tests. */ static void test_mf_Blank(void) @@ -2628,6 +2752,7 @@ START_TEST(metafile) /* For enhanced metafiles (enhmfdrv) */ test_ExtTextOut(); test_SaveDC(); + test_emf_BitBlt(); /* For win-format metafiles (mfdrv) */ test_mf_SaveDC(); -- 1.6.5.2

3 5

Re: [PATCH 1/3] gdi32/tests: Test BitBlt() to an enhanced metafile.
by Paul Vriens Nov. 20, 2009

Nov. 20, 2009

On 11/20/2009 04:21 PM, Charles Davis wrote: > + if(1 || compare_emf_bits(hMetafile, EMF_BITBLT, sizeof(EMF_BITBLT), > + "emf_BitBlt", FALSE) != 0) Shouldn't you get rid of that '1 ||' ? -- Cheers, Paul.

1 1

what should happen when selecting no audio in winecfg?
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 20, 2009

Nov. 20, 2009

Hi, I've observed 2 seemingly opposed behaviours when no audio driver is selected in winecfg's audio tab (or when winecfg's audio tab had never been opened before in this .wine prefix): - On one hand, some tests and apps still manage to produce sound. - On the other hand (OTOH), some apps cease to produce sound -- this is a simple method worth trying when some apps hang with sound issues. So I'm left wondering what a) wine's default .wine creation behaviour or b) unselecting all audio drivers in the tab ought to do. Remember that when you first visit winecfg's audio tab, you get to see a note that a default driver was chosen, which lead me to believe that no driver at all is enabled until then. Thanks, Jörg Höhle.

1 0

Running server applications under Wine?
by 임은지 Nov. 20, 2009

Nov. 20, 2009

Is there anyone who uses Wine for server applications (game server, web server, etc.)? Performance is very important issue for such applications. A server should serve a large number of clients at reasonable speeds. What do you think about implementing wineserver kernel module or handling only performance critical items in kernel?

1 0

Re: d3dx9_36: add a stub for D3DXCreateTextureFromFileInMemory
by Jeff Zaroyko Nov. 20, 2009

Nov. 20, 2009

On Fri, Nov 20, 2009 at 4:56 AM, Austin English <austinenglish(a)gmail.com> wrote: > Should fix http://bugs.winehq.org/show_bug.cgi?id=13605 > > -- > -Austin > Does it really fix it, the function still remains unimplemented, crash or no crash... a bug will probably just be filed after it to say the function needs to be implemented if the app really uses it, so what is gained?

2 3

Re: New version of my test for bug 4543
by Charles Davis Nov. 19, 2009

Nov. 19, 2009

Paul Vriens wrote: > On 11/19/2009 11:17 PM, Charles Davis wrote: >> Hi, >> >> This is a new version of my test for bug 4543. This time, I followed >> Dmitry's suggestion of using the existing functions for comparing the >> contents of EMFs. I can't build tests for Windows both due to bug 20763 >> and due to the fact that I don't have any Windows boxes, so once again I >> need people to run this test on Windows to make sure it's an accurate >> representation of Windows' behavior. The test currently succeeds on Wine. >> >> Thanks in advance. >> >> Chip >> >> >> >> > I'll give it a try on some of my (VMware) boxes tomorrow. > Thanks. I almost forgot: some of the test is if(0)'d out because it crashes on Wine (right now). So, you may wish to un-if(0) the crashing test when you run on Windows. I'm particularly interested in the EMF that the test produces on Windows (it should dump it to the console if you run with WINETEST_DEBUG=1), so that would be really helpful. Chip

1 0

Re: msi regression in today's git -- NEVER MIND
by Susan Cragin Nov. 19, 2009

Nov. 19, 2009

I had a bad git. Re-did everything and now it works. Sorry about that. Susan -----Original Message----- >Installed Dragon NaturallySpeaking using clean prefix and today's git. >Instal went "without errors" but when I tried to open the program it said that the install hadn't completed correctly. >Specifically, iexplore.exe was missing. >I looked at the terminal output for the run but there wasn't anything interesting. > >Susan >

1 0

Write-past-end in FileMonikerImpl_DecomposePath()
by Dan Kegel Nov. 19, 2009

Nov. 19, 2009

http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/diff-hlink_hlink.txt http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-hlink_hlink.txt shows a new error thanks to the heap tail check. Looks like a level-of-indirection-during-allocation error, 1039 strgtable = CoTaskMemAlloc(len*sizeof(WCHAR)); should be 1039 strgtable = CoTaskMemAlloc(len*sizeof(WCHAR *)); Ulrich, you were in there last, could you have a look? Invalid write of size 4 at FileMonikerImpl_DecomposePath (filemoniker.c:1056) by FileMonikerImpl_Construct (filemoniker.c:1375) by CreateFileMoniker (filemoniker.c:1443) by FileMoniker_CreateFromDisplayName (filemoniker.c:1484) by MkParseDisplayName (moniker.c:1130) by HlinkCreateFromString (hlink_main.c:124) by test_persist (hlink.c:479) by func_hlink (hlink.c:1122) by run_test (test.h:535) by main (test.h:585) Address 0x7f04416c is 4 bytes inside a block of size 6 alloc'd at notify_alloc (heap.c:279) by RtlAllocateHeap (heap.c:1521) by IMalloc_fnAlloc (ifs.c:186) by CoTaskMemAlloc (ifs.c:562) by FileMonikerImpl_DecomposePath (filemoniker.c:1039) by FileMonikerImpl_Construct (filemoniker.c:1375) by CreateFileMoniker (filemoniker.c:1443) by FileMoniker_CreateFromDisplayName (filemoniker.c:1484) by MkParseDisplayName (moniker.c:1130) by HlinkCreateFromString (hlink_main.c:124) by test_persist (hlink.c:479)

1 1

Re: winspool.drv: Acroread 9.2 relies on the buffer sizes returned by GetPrinterA and GetPrinterDriverA being large enough to hold their respective unicode versions' data.
by Detlef Riekenberg Nov. 19, 2009

Nov. 19, 2009

On Do, 2009-11-19 at 13:18 +0000, Huw Davies wrote: > --- > dlls/winspool.drv/info.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) ANSI functions in winspool.drv have this behavior since w2k. We have already a test for EnumPrintersA/W [required by Outlook2003) I prefer to make such buffer size requirements also the default in Wine. We are able to simplify a lot of ANSI Functions, when we use this way. Alexandre, is this acceptable for you? -- By by ... Detlef

1 0

Problem to download git
by paulo lesgaz Nov. 19, 2009

Nov. 19, 2009

Hello, when I try to download git, I have the following error. Is it for me only, or does it occur for anyone? I tried to download it several times. I obtain always the same error. dadam(a)analyst:~$ export http_proxy=”http://proxy.upf.pf:8080″ dadam(a)analyst:~$ git clone http://source.winehq.org/git/wine.git ~/wine Initialized empty Git repository in /home/dadam/wine/.git/ Getting alternates list for http://source.winehq.org/git/wine.git Getting pack list for http://source.winehq.org/git/wine.git Getting index for pack 0ece042377e5e1fe77ac71b065cf360c0244774e Getting index for pack 72c84da3f0d9b4fd0dad04f1ce7244dadce37a43 Getting index for pack 6c18f6d3a2d8e85a33e7981ead83b64e4c36bc8c Getting index for pack 7c2ab792c6e1c8f603b784f9dcb81f56f03bbf75 Getting pack 7c2ab792c6e1c8f603b784f9dcb81f56f03bbf75 which contains 7f5b24ed9186d457acd7803a97d4171f332c5fb2 error: Unable to get pack file http://source.winehq.org/git/wine.git/objects/pack/pack-7c2ab792c6e1c8f603b… transfer closed with 1152650 bytes remaining to read error: Unable to find 7f5b24ed9186d457acd7803a97d4171f332c5fb2 under http://source.winehq.org/git/wine.git Cannot obtain needed object 7f5b24ed9186d457acd7803a97d4171f332c5fb2 fatal: Fetch failed. D. Adam

3 3

GdiplusAbort type needs to be translated from C++ to C
by Vincent Povirk Nov. 19, 2009

Nov. 19, 2009

The Windows SDK defines the following type: struct __declspec(novtable) GdiplusAbort { virtual HRESULT __stdcall Abort(void) = 0; }; I think that the following is a workable translation: diff --git a/include/gdiplustypes.h b/include/gdiplustypes.h index 4f97432..444123f 100644 --- a/include/gdiplustypes.h +++ b/include/gdiplustypes.h @@ -55,6 +55,18 @@ typedef BOOL (CALLBACK * ImageAbort)(VOID *); typedef ImageAbort DrawImageAbort; typedef ImageAbort GetThumbnailImageAbort; +struct GdiplusAbort; + +typedef struct gpabort_vtable +{ + HRESULT WINAPI (*Abort)(struct GdiplusAbort*); +} + +typedef struct GdiplusAbort +{ + struct gpabort_vtable *vtable_ptr; +} GdiplusAbort; + #ifdef __cplusplus } #endif I don't think I can provide a proper C++ definition because the abi depends on the compiler. Does this look correct? -- Vincent Povirk

2 2

msi regression in today's git
by Susan Cragin Nov. 19, 2009

Nov. 19, 2009

Installed Dragon NaturallySpeaking using clean prefix and today's git. Instal went "without errors" but when I tried to open the program it said that the install hadn't completed correctly. Specifically, iexplore.exe was missing. I looked at the terminal output for the run but there wasn't anything interesting. Susan

1 0