November 2009 - Wine-Devel - list.winehq.org

Garmin watches and USB
by Chris Teague Nov. 26, 2009

Nov. 26, 2009

I'm trying to get the Garmin ANT Agent 2.2.7 to run (http://www8.garmin.com/fitness/ant_product_page.jsp) This software talks over the ANT+ protocol (carried over USB) to the watch, to download Heart Rate and GPS info. I cannot get the program to install because it checks that the ANT dongle is plugged in before it will complete installation, and it won't detect it. I also cannot debug this .exe using IDA very effectively because it is a self-extracting zip executable. When I plug in the ANT dongle, it is recognized by Linux and mapped to ttyUSB0. The dongle came with the watch and is Garmin branded, but it's really a Dynastream ANT2USB chip. Below is what /var/log/messages shows when I insert the device. Nov 22 15:23:27 desktop kernel: [1982277.092697] usb 4-1: reset full speed USB device using uhci_hcd and address 24 Nov 22 15:23:27 desktop kernel: [1982277.335442] cp210x 4-1:1.0: cp210x converter detected Nov 22 15:23:27 desktop kernel: [1982277.452593] usb 4-1: reset full speed USB device using uhci_hcd and address 24 Nov 22 15:23:27 desktop kernel: [1982277.610343] usb 4-1: cp210x converter now attached to ttyUSB0 I'm trying to figure out exactly what the installer is looking for to see if the dongle is present. I get a "You must connect your USB ANT Stick.." message in a dialogbox, and a Retry button. I thought it was checking for the presence of a new COM port or maybe something in the Windows device tree? I have installed the app on a Windows box, copied over the directory to Linux and run the program successfully under Wine. I do not know if it is communicating with the ttyUSB0 device though, I suspect it is not and I test that out tonight. On Windows, inserting the USB Dongle does not create a new COM port - so my guess is that the software is not treating this as a virtual COM port. If so using the old dosdevices file won't work. Any suggestions for either of these problems: - debugging a self extracting zip installer - getting a Windows app to use ttyUSB0 instead of whatever Windows USB device it would normally read/write from Thanks for any ideas, Chris

5 5

Re: kernel32.dll: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible
by Maarten Lankhorst Nov. 26, 2009

Nov. 26, 2009

Paul Chitescu schreef: > Changelog: > kernel32.dll: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever > possible > > In many places reading the Registry is enough to work even when write access > is denied. > Your patches cannot be applied with -Np1, consider using git for sending patches, rather than diffing them :)

2 1

Re: [PATCH] server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions.
by Ben Peddell Nov. 26, 2009

Nov. 26, 2009

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 4 Oct 2007, Rob Shearman submitted the patch "server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions.", which calculated the owner permissions solely based on the grant/deny permissions for the owner's SID. On 17 Oct 2007, in bug #10067, "Daniel" reported a bug about FAT32 support being broken in 0.9.47 (which included the above patch) On 21 Oct 2007, Rob Shearman submitted the patch "server: Fix file_set_sd to handle NULL DACLs.", which added support for setting permissions from NULL ACLs. On 21 Nov 2007, Rob Shearman submitted the patch "server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions.", which added the world permissions to the owner permissions. On 10 Mar 2009, in bug #17672, Nathan Lineback reported a bug about wine incorrectly setting permissions when installing Oracle DB. On 17 Mar 2009, in bug #17776, Richard Hendrikse reported a bug about FAT32 support being broken. On 5 Aug 2009, in bug #19588, Ken Sharp reported that wine was setting the wrong permissions in some cases. On 10 Nov 2009, in bug #20643, Marshall Davis reported that wine was removing owner permissions when World of Warcraft was giving only the users group permission to access the World of Warcraft directory. On 17 Nov 2009, I posted an initial patch here to take the permissions of the groups the user is a member of when calculating the UNIX mode. Rob Shearman replied: > While I agree that there is a problem that needs to be fixed, I'm not > sure this is the right approach. I think you need to take a step back > and consider the meanings of the different SIDs in a token by default > and how they map wine running inside the Unix permissions model. Later on 17 Nov 2009, I revised the patch to only look at the user's groups if the user was the owner of the file. If permissions should be revoked from a user when (1) they are the owner of the file, (2) they are not a trustee in the file's security descriptor, and (3) they are removed from all groups in the file's security descriptor, then there needs to be some other way of storing the owner of the file and the security descriptor in the filesystem (such as POSIX ACLs), and the owner in the security descriptor cannot be the UNIX owner of the file, as the UNIX owner permissions cannot be overridden by POSIX ACLs. In the meantime, the owner of the file cannot access the file when they are not a trustee in the security descriptor, even if token_access_check says they should be able to access the file. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksO/KUACgkQTHDAI68NsunTzwCfVdptQ8sFkFr42r2KOJjvbE2p U7YAoIGowA5ncsgts+p+twCxNDrEedKd =knqg -----END PGP SIGNATURE-----

1 0

Ctrl/Shift don't autorepeat
by Nikolay Sivov Nov. 26, 2009

Nov. 26, 2009

Hi, guys. I've noticed some problems with keyboard input while testing my favorite Listview control code. The problem is that Ctrl/Shift don't fire WM_KEYDOWNs properly: they don't trigger autorepeat. Is it a known input processing problem? P.S. Alt key is different cause it generates WM_SYSKEYDOWN which isn't supported by control yet.

4 6

My script for doing testing
by Jeremy White Nov. 25, 2009

Nov. 25, 2009

So I have done my penance for failing to set up a cron to run testing. I've got routine testing going every night on 2 boxes. It seems solid. I see that many others have done this as well - test.winehq.org wine results are really looking good. As promised, I'm attaching the script I'm using. This is my crontab line: 06 02 * * 2-6 /home/jwhite/bin/winetestcron --repo /home/jwhite/w/wine/.git --tag jw-nv-32 e.g. run the script at 2:06 am Tuesdays through Saturdays. I don't want this to be a general call for everyone to run this script; rather, this might be a handy tool for developers who are already running winetest to save them a little hassle. My script probably has only one materially useful feature - it uses a trap to enforce a timeout. The rest is all pretty easy/obvious stuff. Also, I've only tested on Linux, not Mac. Sorry :-(. Cheers, Jeremy #!/bin/bash #---------------------------------------------------- # winetestcron # script to run the Wine tests in an unattended fashion # Intended to be run from cron. If you run it in the # crontab of the user that is logged in to DISPLAY :0, # it should work. Otherwise, you might want to do a # xauth extract /your/file in your .xsession, and an # xauth merge /your/file in this script. #---------------------------------------------------- function usage() { echo -n "$0 --repo /path/to/your/.git/dir " echo "[--tag tag-to-report] " echo -n " [--gecko gecko-path] " echo "[--timeout secs] [--update-repo]" echo " [--configure extra-configure-args]" echo "repo is mandatory, must give the location of a .git directory, and " echo "will not be changed by default. If you specify update-repo, then a " echo "git fetch will be done in your repository before running winetest. " echo "The working tree will not be changed in any case." echo "tag is the tag name to report; see common tags on test.winehq.org for guidance." echo "timeout sets an overall script timeout, in seconds. Default is $TIMEOUT" echo "gecko specifies a path to the Gecko CAB file. Default is $GECKO_LOCATION" echo "configure will pass through the options to ./configure" } function parse_args() { GOPT=`getopt -o "" -l repo:,tag:,gecko:,timeout:,configure:,update-repo -- "$@"` GOPTERR=`getopt -o "" -l repo:,tag:,gecko:,timeout:,configure:,update-repo -- "$@" 2>&1` eval set -- "$GOPT" if [ $? != 0 -o "$GOPT" != "$GOPTERR" ] ; then usage exit 1 fi while true ; do case "$1" in --repo) export REFERENCE_GIT="$2"; shift 2;; --tag) export TAG="$2"; shift 2;; --gecko) export GECKO_LOCATION="$2"; shift 2;; --configure) export CONFIG_EXTRAS="$2"; shift 2;; --update-repo) export UPDATE_REPO="y"; shift;; --) shift; break;; *) echo "Error: uknown option $@"; usage ; exit ;; esac done if [ $# -gt 0 ] ; then echo "Error: Unexpected parameters $@" usage exit 1 fi if [ ! -d "$REFERENCE_GIT" ] ; then echo "Error: --repo must point to the .git directory of a valid WineHQ clone." usage exit 1 fi } function cleanup { "$TESTDIR/wine/server/wineserver" -k find /tmp -maxdepth 1 -type d -name 'winetest*' -ctime +2 -exec rm -rf {} \; exit } #--- # Set defaults #---- export GECKO_LOCATION=/usr/share/wine/gecko/ export TIMEOUT=3600 export TAG=`echo -n \`whoami\`-\`uname -m\` | sed 's/_/-/g'` #--- # Validate arguments #---- parse_args "$@" #--- # Get going... #---- TESTDIR=`mktemp -d /tmp/winetest.XXXXXXXX` TMPGITDIR="$TESTDIR/wine" mkdir "$TESTDIR/gecko" if [ -f "$GECKO_LOCATION/wine_gecko-1.0.0-x86.cab" ] ; then cp "$GECKO_LOCATION/wine_gecko-1.0.0-x86.cab" "$TESTDIR/gecko/" else echo $GECKO_LOCATION/wine_gecko-1.0.0-x86.cab not found. Bandwidth being wasted... ( cd "$TESTDIR/gecko" ; \ wget -o "$TESTDIR/wget.log" http://downloads.sourceforge.net/wine/wine_gecko-1.0.0-x86.cab \ ) fi if [ "$UPDATE_REPO" = "y" ] ; then git "--git-dir=$REFERENCE_GIT" fetch origin fi git clone --reference "$REFERENCE_GIT" git://source.winehq.org/git/wine.git "$TMPGITDIR" >"$TESTDIR/clone.log" 2>&1 cd "$TMPGITDIR" (./configure "$CONFIG_EXTRAS" && nice make ) > "$TESTDIR/build.log" 2>&1 export WINEPREFIX="$TESTDIR/.wine" export PATH="$TMPGITDIR:$PATH" export DISPLAY=:0 cd "$TESTDIR" # Set a trap to cleanup when a child exits. We either exit when # the Wine tests are complete, or the timeout happens; whichever # comes first set -m trap cleanup CHLD # Run the actual tests "$TMPGITDIR/wine" "$TMPGITDIR/programs/winetest/winetest.exe.so" -c -t "$TAG" >wine.log 2>&1 & # Set a timer to force an exit after $TIMEOUT sleep $TIMEOUT

6 9

Re: openal32: Add alBufferSubDataEXT
by Chris Robinson Nov. 25, 2009

Nov. 25, 2009

I'm not sure it's very appropriate to add this yet, since the extension isn't finalized. Until it's finalized, there could be changes that modify the API calls (I don't expect changes, but it's best to err on the side of caution, I think). The alBufferDataStatic patch is fine, though.

1 0

Re: wineserver: Added support for read/only Registry, similar to unprivileged users
by Paul Chitescu Nov. 25, 2009

Nov. 25, 2009

On Wednesday 25 November 2009 06:36:46 pm Paul Chitescu wrote: > Changelog: > wineserver: Added support for read/only Registry, similar to unprivileged > users > [...] How to test (if it gets accepted): chmod -w $WINEPREFIX/system.reg $WINEPREFIX/userdef.reg What to expect: Major breakage :-( for now err:font:delete_external_font_keys Can't create Windows font reg key err:wineboot:start_services_process Unexpected termination of services.exe - exit code 5 err:font:update_reg_entries Can't create Windows font reg key err:font:delete_external_font_keys Can't create Windows font reg key err:font:update_reg_entries Can't create Windows font reg key err:winspool:WINSPOOL_EnumPrinters Can't create Printers key err:winspool:CUPS_LoadPrinters Can't create Printers key err:winspool:PRINTCAP_ParseEntry Can't create Printers key err:winspool:WINSPOOL_EnumPrinters Can't create Printers key err:menubuilder:init_xdg error looking up the desktop directory err:font:delete_external_font_keys Can't create Windows font reg key err:font:update_reg_entries Can't create Windows font reg key err:winecfg:get_config_key RegOpenKey failed on wine config key (res=5) err:winecfg:get_config_key RegOpenKey failed on wine config key (res=5) err:winecfg:get_config_key RegOpenKey failed on wine config key (res=5) err:winecfg:get_config_key RegOpenKey failed on wine config key (res=5) err:winecfg:get_config_key RegOpenKey failed on wine config key (res=5) err:winecfg:get_config_key RegOpenKey failed on wine config key (res=5) err:winecfg:open_mountmgr failed to open mount manager err 2

1 0

Re: Whitespace cleanups
by James Mckenzie Nov. 25, 2009

Nov. 25, 2009

Nate/Nikolay: Make sure that your patch has no white space errors and stay away from tabs, unless the current file is using them. git -apply should run without any errors. Cleaning up whitespace errors outside of code you are fixing should be very conservative. AJ likes it that way... BTW, I found whitespace errors in the code I'm working on and had to fix them as well. James McKenzie -----Original Message----- >From: Nikolay Sivov <bunglehead(a)gmail.com> >Sent: Nov 25, 2009 7:55 AM >To: Nate Gallaher <ngallaher(a)deepthought.org> >Cc: wine-devel(a)winehq.org >Subject: Re: Whitespace cleanups > >Nate Gallaher wrote: >> I'm looking at working on a new area of wine (for me) and the file I'm >> going to be working >> with is rife with whitespace issues. Literal tabs are sprinkled >> around and the 80-col limit >> has been broken badly and often in easily fixable ways. I'm wondering >> what the acceptable >> approach is to these issues. >> >> I'd like to fix these issues before I start submitting functional >> patches. My question is this: >> Is it acceptable to fix the whole file in one patch (80-cols), >No. >> or should I just fix the >> one function I'm planning on touching? Or should I grit my teeth and >> ignore the style issues >> entirely? >Yes, in most cases. If you plan to rework the whole file with functional >patches feel free to touch >formatting a bit. The common rule is to preserve existing format and >remove things like spaces before >tabs or trailing spaces (the rest is done while committing automatically). > >What file are you talking about? > > >

1 0

Re: Patch Tracker?
by James Mckenzie Nov. 25, 2009

Nov. 25, 2009

Austin English wrote: >Sent: Nov 24, 2009 2:09 PM >To: Nate Gallaher <ngallaher(a)deepthought.org> >Cc: wine-devel(a)winehq.org >Subject: Re: Patch Tracker? > >On Tue, Nov 24, 2009 at 3:07 PM, Nate Gallaher ><ngallaher(a)deepthought.org> wrote: >> There's a new patch tracker? > >http://source.winehq.org/patches/ > Congratulations, Austin and Patch tracker team. James McKenzie

3 3

Re: RFC: visual.c:783: Test failed: DSTALPHA on frame buffer returned color 0x00ff0000, expected 0x000000ff
by chris ahrendt Nov. 25, 2009

Nov. 25, 2009

Roderick Colenbrander wrote: > On Wed, Nov 25, 2009 at 3:46 AM, chris ahrendt <celticht32(a)yahoo.com> wrote: >> Roderick Colenbrander wrote: >>> On Tue, Nov 24, 2009 at 5:12 AM, chris ahrendt <celticht32(a)yahoo.com> wrote: >>>> Ok going through and looking at the next failure in wine tests I found this one : >>>> >>>> >>>> If you look at the code its: >>>> >>>> >>>> 779 color = getPixelColor(device, 160, 120); >>>> 780 red = (color & 0x00ff0000) >> 16; >>>> 781 green = (color & 0x0000ff00) >> 8; >>>> 782 blue = (color & 0x000000ff); >>>> 783 ok(red == 0x00 && green == 0x00 && blue >= 0xfe && blue <= 0xff , >>>> 784 "DSTALPHA on frame buffer returned color 0x%08x, expected 0x000000ff\n", color); >>>> >>>> >>>> but in MSDN it says : >>>> >>>> This value is a 32-bit value used to specify an RGB color or CLR_INVALID >>>> >>>> Format of the rgb color is : >>>> >>>> 0x00bbggrr >>>> >>>> The low-order byte contains a value for the relative intensity of red, the second byte contains a value for green, and >>>> the third byte contains a value for blue. >>>> >>>> The high-order byte must be zero. >>>> >>>> The maximum value for a single byte is 0xFF. >>>> >>>> so shouldn't it be something like this: >>>> >>>> red = color & 0x000000FF; >>>> green = ( color & 0x0000FF00 ) >> 8; >>>> blue = ( color & 0x00FF0000 ) >> 16; >>>> >>>> not the what is in the test? because of the following C action >>>> >>>> expression1 >> shift_value >>>> >>>> Returns expression1 with its bits shifted to the right by the shift_value. The leftmost bits are replaced with zeros if >>>> the value is nonnegative or unsigned. This result is the integer part of expression1 divided by 2 raised to the power of >>>> shift_value. If expression1 is signed, then the result is implementation specific. >>>> >>>> so the test seems to be assigning the wrong values to the RGB.... Correct? >>>> >>>> chris >>>> >>> We are creating the framebuffer in the ARGB format (see init_d3d9). >>> D3D supports a variety of formats and we don't use the gdi RGB macro. >>> >>> Roderick >>> >>> >> Ok... but apparently this is returning it though in the above bbggrr format when color comes back so how do you set it >> to come back in the ARGB format??? Is that setup in the init_d3d9? >> >> chris >> > > The test passes properly on Wine + Nivida and I believe even on Intel. > There are just some bugs in the ATI drivers. That's the case with most > of the failing ddraw/d3d tests on ATI and other drivers. > > Roderick > > Oh I realise that... thats why I am trying to figure out where so I can open a bug with ATI... chris

1 0

Re: RFC: visual.c:783: Test failed: DSTALPHA on frame buffer returned color 0x00ff0000, expected 0x000000ff
by chris ahrendt Nov. 25, 2009

Nov. 25, 2009

Roderick Colenbrander wrote: > On Tue, Nov 24, 2009 at 5:12 AM, chris ahrendt <celticht32(a)yahoo.com> wrote: >> Ok going through and looking at the next failure in wine tests I found this one : >> >> >> If you look at the code its: >> >> >> 779 color = getPixelColor(device, 160, 120); >> 780 red = (color & 0x00ff0000) >> 16; >> 781 green = (color & 0x0000ff00) >> 8; >> 782 blue = (color & 0x000000ff); >> 783 ok(red == 0x00 && green == 0x00 && blue >= 0xfe && blue <= 0xff , >> 784 "DSTALPHA on frame buffer returned color 0x%08x, expected 0x000000ff\n", color); >> >> >> but in MSDN it says : >> >> This value is a 32-bit value used to specify an RGB color or CLR_INVALID >> >> Format of the rgb color is : >> >> 0x00bbggrr >> >> The low-order byte contains a value for the relative intensity of red, the second byte contains a value for green, and >> the third byte contains a value for blue. >> >> The high-order byte must be zero. >> >> The maximum value for a single byte is 0xFF. >> >> so shouldn't it be something like this: >> >> red = color & 0x000000FF; >> green = ( color & 0x0000FF00 ) >> 8; >> blue = ( color & 0x00FF0000 ) >> 16; >> >> not the what is in the test? because of the following C action >> >> expression1 >> shift_value >> >> Returns expression1 with its bits shifted to the right by the shift_value. The leftmost bits are replaced with zeros if >> the value is nonnegative or unsigned. This result is the integer part of expression1 divided by 2 raised to the power of >> shift_value. If expression1 is signed, then the result is implementation specific. >> >> so the test seems to be assigning the wrong values to the RGB.... Correct? >> >> chris >> > We are creating the framebuffer in the ARGB format (see init_d3d9). > D3D supports a variety of formats and we don't use the gdi RGB macro. > > Roderick > > Ok... but apparently this is returning it though in the above bbggrr format when color comes back so how do you set it to come back in the ARGB format??? Is that setup in the init_d3d9? chris

2 1

Next release
by Alexandre Julliard Nov. 24, 2009

Nov. 24, 2009

Folks, I'll be out for the rest of the week, so there won't be a release this Friday. 1.1.34 will be released on December 4. And with the new patch tracker you can watch the patches pile up while I'm away ;-) -- Alexandre Julliard julliard(a)winehq.org

4 3

mapistub: add stubbed dll mapistub.dll
by Louis Lenders Nov. 24, 2009

Nov. 24, 2009

I guess we can forward those functions to mapi32 later on. While running the app, no functions were called at all, it was even enough to copy a random dll into system32 , and call it mapistub.dll. That was enough to get the app going

1 0

Re: ole32: Fix circular reference count in default handler objects.
by Rob Shearman Nov. 24, 2009

Nov. 24, 2009

2009/11/24 Rob Shearman <robertshearman(a)gmail.com>: > This is caused by caching a pointer and reference to the data cache's > IPersistStorage interface without managing reference counts > appropriately. > --- > dlls/ole32/defaulthandler.c | 22 ++++++++++++++++++++++ > 1 files changed, 22 insertions(+), 0 deletions(-) > > Fixes memory leaks in defaulthandler tests. May also fix bugs 12419 & 14863. I should also note that the rules for aggregating objects implemented by this patch are listed here: http://msdn.microsoft.com/en-us/library/ms686558(VS.85).aspx -- Rob Shearman

1 0

Re: wineserver: Mark registry hives clean after being loaded initially from file
by Alexandre Julliard Nov. 24, 2009

Nov. 24, 2009

Paul Chitescu <paulc(a)voip.null.ro> writes: > @@ -1393,6 +1393,7 @@ > fprintf( stderr, "%s is not a valid registry file\n", filename ); > return; > } > + make_clean( key ); It would be better to create them with the correct flags in the first place. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: opengl32: fix wglCreateContextAttribsARB on nvidia
by Dmitry Timoshkov Nov. 24, 2009

Nov. 24, 2009

"Roderick Colenbrander" <thunderbird2k(a)gmail.com> wrote: > +/* Nvidia converts win32 error codes to (0xc007 << 16) | win32_error_code */ > +#define NVIDIA_HRESULT_FROM_WIN32(x) (HRESULT_FROM_WIN32(x) | 0x40000000) Using MAKE_HRESULT() with appropriate severity and facility would be cleaner IMO. -- Dmitry.

2 1

RFC: visual.c:783: Test failed: DSTALPHA on frame buffer returned color 0x00ff0000, expected 0x000000ff
by chris ahrendt Nov. 24, 2009

Nov. 24, 2009

Ok going through and looking at the next failure in wine tests I found this one : If you look at the code its: 779 color = getPixelColor(device, 160, 120); 780 red = (color & 0x00ff0000) >> 16; 781 green = (color & 0x0000ff00) >> 8; 782 blue = (color & 0x000000ff); 783 ok(red == 0x00 && green == 0x00 && blue >= 0xfe && blue <= 0xff , 784 "DSTALPHA on frame buffer returned color 0x%08x, expected 0x000000ff\n", color); but in MSDN it says : This value is a 32-bit value used to specify an RGB color or CLR_INVALID Format of the rgb color is : 0x00bbggrr The low-order byte contains a value for the relative intensity of red, the second byte contains a value for green, and the third byte contains a value for blue. The high-order byte must be zero. The maximum value for a single byte is 0xFF. so shouldn't it be something like this: red = color & 0x000000FF; green = ( color & 0x0000FF00 ) >> 8; blue = ( color & 0x00FF0000 ) >> 16; not the what is in the test? because of the following C action expression1 >> shift_value Returns expression1 with its bits shifted to the right by the shift_value. The leftmost bits are replaced with zeros if the value is nonnegative or unsigned. This result is the integer part of expression1 divided by 2 raised to the power of shift_value. If expression1 is signed, then the result is implementation specific. so the test seems to be assigning the wrong values to the RGB.... Correct? chris

2 1

Re: mapistub: add stubbed dll mapistub.dll
by Rob Shearman Nov. 24, 2009

Nov. 24, 2009

2009/11/23 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk>: > This fixes http://bugs.winehq.org/show_bug.cgi?id=20050 > > The dll is present on my XP system This DLL is already partially implemented in a DLL called mapi32, so there should be no need to add this completely stubbed out. -- Rob Shearman

1 0

Re: shell32/tests: Remove atime tests in ITEMIDLIST_format test.
by Paul Vriens Nov. 24, 2009

Nov. 24, 2009

On 11/19/2009 01:23 PM, Austin Lund wrote: > - ok (pFileStructA->uFileDate == pFileStructW->uDate2&& > - pFileStructA->uFileTime == pFileStructW->uTime2, > - "Last write time should match last access time!\n"); > - Hi Austin, Is there no other way to get around this? I think it's a bit of a shame having tests removed for that odd system that has a FAT filesystem on a NT4+ box. -- Cheers, Paul.

2 6

Re: [2/3] msi/tests: Test for SELECT table.column FROM table
by Nikolay Sivov Nov. 24, 2009

Nov. 24, 2009

On Tue, Nov 24, 2009 at 11:14 AM, Nathan Gallaher <ngallaher(a)deepthought.org> wrote: > Make sure that mixing table columns returns the expected > data. eg: SELECT t1.action, t2.action FROM t1, t2 > should return distinct data. > > > + // Test that selection based on prefixing the column with the table + // actually selects the right data Cpp style isn't allowed, please resend it with plain C comments. Thanks.

1 0

Re: RFC : query.c d3d9 test...
by chris ahrendt Nov. 24, 2009

Nov. 24, 2009

Roderick Colenbrander wrote: > On Mon, Nov 23, 2009 at 9:23 PM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: >> Am 23.11.2009 um 21:00 schrieb chris ahrendt: >>> The test fails with : >>> >>> query.c:224: Test failed: IDirect3DQuery9_GetData a 2nd time on a ended query returned 00000001 >> This is Windows, right? Which GPU/driver? >> >> My guess is that its ok to modify the test to accept both results. Ie, ok(hr == S_OK | hr == S_FALSE, "..."); >> > > I see it all the time on my Radeon 3400 on Wine. > > Roderick > > this is the wine test I run on linux.... and I get this all the time on my Radeon as well... which is why I was asking here... do I need to open a bug on the test to fix it since what I documented is the correct behavior.... chris

1 0

Re: [PATCH] ole32: Some missing error checking in FileMonikerImpl_CommonPrefixWith (Coverity)
by Rob Shearman Nov. 23, 2009

Nov. 23, 2009

2009/11/23 Marcus Meissner <marcus(a)jet.franken.de>: > if(mkSys==MKSYS_FILEMONIKER){ > HRESULT ret; > > - CreateBindCtx(0,&pbind); > + ret = CreateBindCtx(0,&pbind); > + if (FAILED(ret)) > + return ret; > > /* create a string based on common part of the two paths */ > > - IMoniker_GetDisplayName(iface,pbind,NULL,&pathThis); > - IMoniker_GetDisplayName(pmkOther,pbind,NULL,&pathOther); > + ret = IMoniker_GetDisplayName(iface,pbind,NULL,&pathThis); > + if (FAILED(ret)) > + return ret; pbind is leaked here. > + ret = IMoniker_GetDisplayName(pmkOther,pbind,NULL,&pathOther); > + if (FAILED(ret)) > + return ret; pbind and pathThis are leaked here. > > nb1=FileMonikerImpl_DecomposePath(pathThis,&stringTable1); > + if (FAILED(nb1)) > + return nb1; Ditto plus pathOther. > nb2=FileMonikerImpl_DecomposePath(pathOther,&stringTable2); > + if (FAILED(nb2)) > + return nb2; Ditto plus stringTable1. > > if (nb1==0 || nb2==0) > return MK_E_NOPREFIX; > > commonPath=HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*(min(lstrlenW(pathThis),lstrlenW(pathOther))+1)); > + if (!commonPath) > + return E_OUTOFMEMORY; Ditto plus stringTable2. > > *commonPath=0; -- Rob Shearman

1 0

Re: msvcrt: Calculate floating point decimals in internally used long double precision.
by Austin English Nov. 23, 2009

Nov. 23, 2009

On Mon, Nov 23, 2009 at 2:43 PM, Gregor Schneider <grschneider(a)gmail.com> wrote: > This patch proposes to calculate the fp digits in scanf with the internally > used long double precision instead of simple float accuracy. > With the current implementation small errors are added with each calculation > step originating from the used float type. > This becomes obvious when parsing to more precise fp types like double or > long double and outputting a large number of digits from the created number. > Example code like the following > > double d; > swscanf(L"3.1415", L"%lf", &d); > wprintf(L"%3.12f\n", d); > > produces an output of "3.141500000478", while "3.141500000000" would be the > expected result with this precision. The attached patch fixes this problem. Please add a testcase for this behavior, to prevent regressions. -- -Austin

1 0

RFC : query.c d3d9 test...
by chris ahrendt Nov. 23, 2009

Nov. 23, 2009

Looking at the wine test results for the following test: query.c in the d3d9 tests directory... hr = IDirect3DQuery9_GetData(pQuery, data, IDirect3DQuery9_GetDataSize(pQuery), D3DGETDATA_FLUSH); ok(hr == S_OK, "IDirect3DQuery9_GetData on a ended query returned %08x\n", hr); hr = IDirect3DQuery9_GetData(pQuery, data, IDirect3DQuery9_GetDataSize(pQuery), D3DGETDATA_FLUSH); ok(hr == S_OK, "IDirect3DQuery9_GetData a 2nd time on a ended query returned %08x\n", hr); the MSDK says the following : IDirect3DQuery9::GetData Polls a queried resource to get the query state or a query result. For more information about queries, see Queries (Direct3D 9). Return Values The return type identifies the query state (see Queries (Direct3D 9)). The method returns S_OK if the query data is available and S_FALSE if it is not. These are considered successful return values. If the method fails when D3DGETDATA_FLUSH is used, the return value can be D3DERR_DEVICELOST. The test fails with : query.c:224: Test failed: IDirect3DQuery9_GetData a 2nd time on a ended query returned 00000001 which is a S_FALSE (1) which just means the data is not available... which according to the MSDN site is an ok value to return... and is a success... so not sure what is being tested here? Is this a valid test? Also reading the MSDN the D3DGETDATA_FLUSH is supposed to flush the query so the value its returning may be ok... So If I am understanding the above code the first one should return a S_OK saying that it flushed the query code.... Then the second call should return a S_FALSE because the query has nothing in it..... Thoughts? Explinations??? Inpuut... <G> Chris

3 3

Re: Add .cvsignore entries for .fake files
by Paul Chitescu Nov. 23, 2009

Nov. 23, 2009

On Monday 16 November 2009 04:11:25 pm Paul Chitescu wrote: > Changelog: > Add .cvsignore entries for .fake files. What's wrong with this? Applies cleanly to my pristine wine-CVS, tried with patch taken from wine-patches bounce. Whoever rejected with "fails to apply" please reply with the output.

4 4

re: winmm: Don't stop parsing after MCI's alias keyword.
by Dan Kegel Nov. 23, 2009

Nov. 23, 2009

Joerg wrote: > I'm surprised that valgrind did not complain about the bug... Looks like I ignore files that only contain leak errors: http://code.google.com/p/winezeug/source/browse/trunk/valgrind/valgrind-spl… on the theory that we're already overwhelmed dealing with non-leak errors. You can still see the leaks in the full log, http://kegel.com/wine/valgrind/logs/2009-11-19-08.35.log What do people think - should we focus on non-leak errors for a while (in which case I should suppress all leak errors), or should I stop ignoring modules that only have leak errors? Also, mci tests hang on my system and need to be killed, so I may be missing some errors because of that. (Finally, my automated runs are on hold while I add use-after-free detection. I'm lame, and use the same source tree for develoment and for the automated runs. One of these days I should separate them. Or somebody else could do the automated runs...) - Dan

2 1

Re: winspool: Don't use 16Bit gdi.exe function for DeviceCapabilitiesA/W
by Alexandre Julliard Nov. 23, 2009

Nov. 23, 2009

Detlef Riekenberg <wine.dev(a)web.de> writes: > - if (!GDI_CallDeviceCapabilities16) > - { > - GDI_CallDeviceCapabilities16 = (void*)GetProcAddress( GetModuleHandleA("gdi32"), > - (LPCSTR)104 ); > - if (!GDI_CallDeviceCapabilities16) return -1; > - } > - ret = GDI_CallDeviceCapabilities16(pDevice, pPort, cap, pOutput, lpdm); > - > - /* If DC_PAPERSIZE map POINT16s to POINTs */ > - if(ret != -1 && cap == DC_PAPERSIZE && pOutput) { > - POINT16 *tmp = HeapAlloc( GetProcessHeap(), 0, ret * sizeof(POINT16) ); > - POINT *pt = (POINT *)pOutput; You can't remove the 16-bit conversion if you are still calling the existing driver. Probably a better approach is to first add a DrvDeviceCapabilities to the wineps driver. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: Only require REG_OPTION_VOLATILE when creating a new key.
by Paul Vriens Nov. 23, 2009

Nov. 23, 2009

Hi Alexandre, With this patch the following errors are introduced when starting anything on a clean .wine : err:setupapi:registry_callback could not create key 0x80000002 L"HARDWARE\\DEVICEMAP\\PARALLEL PORTS" err:setupapi:registry_callback could not create key 0x80000002 L"HARDWARE\\DEVICEMAP\\SERIALCOMM" -- Cheers, Paul.

1 0

[RFC] Handle process token groups in server/file.c::sd_to_mode
by Ben Peddell Nov. 23, 2009

Nov. 23, 2009

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This proposed patch (which I believe will contribute toward solving bugs 17672, 19588 and 20643, and any others where the permissions are set too restrictive) exposes the token_sid_present call in token.c, and uses it to check the SIDs in the security descriptor against those in the process token. Are there any changes anyone can think of before I submit it to wine-patches? Is there a better (already exposed) way of checking a SID against the process token's group list? - ---- server/file.c | 6 ++++-- server/security.h | 1 + server/token.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksBcpAACgkQTHDAI68Nsuny6ACfXu3vvWS6O27Z/mfozb4e/ZMG MYQAoItP8P75a3l54TYrLnQbk7lNyaaQ =7QsU -----END PGP SIGNATURE----- server/file.c | 6 ++++-- server/security.h | 1 + server/token.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/server/file.c b/server/file.c index a74de14..793c24a 100644 --- a/server/file.c +++ b/server/file.c @@ -485,7 +485,8 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) if (access & FILE_EXECUTE) denied_mode |= S_IXUSR|S_IXGRP|S_IXOTH; } - else if (security_equal_sid( sid, owner )) + else if (security_equal_sid( sid, owner ) || + token_sid_present( current->process->token, sid, 1 )) { unsigned int access = generic_file_map_access( ad_ace->Mask ); if (access & FILE_READ_DATA) @@ -509,7 +510,8 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) if (access & FILE_EXECUTE) new_mode |= S_IXUSR|S_IXGRP|S_IXOTH; } - else if (security_equal_sid( sid, owner )) + else if (security_equal_sid( sid, owner ) || + token_sid_present( current->process->token, sid, 0 )) { unsigned int access = generic_file_map_access( aa_ace->Mask ); if (access & FILE_READ_DATA) diff --git a/server/security.h b/server/security.h index 39b1d2f..33cf5da 100644 --- a/server/security.h +++ b/server/security.h @@ -55,6 +55,7 @@ extern int token_check_privileges( struct token *token, int all_required, extern const ACL *token_get_default_dacl( struct token *token ); extern const SID *token_get_user( struct token *token ); extern const SID *token_get_primary_group( struct token *token ); +extern int token_sid_present( struct token *token, const SID *sid, int deny); static inline const ACE_HEADER *ace_next( const ACE_HEADER *ace ) { diff --git a/server/token.c b/server/token.c index ce896ac..461e79d 100644 --- a/server/token.c +++ b/server/token.c @@ -776,7 +776,7 @@ int token_check_privileges( struct token *token, int all_required, return (enabled_count > 0); } -static int token_sid_present( struct token *token, const SID *sid, int deny ) +int token_sid_present( struct token *token, const SID *sid, int deny ) { struct group *group;

3 7

Firefox not installing with winetricks. Reason: need to upgrade 3.5.3 to 3.5.5.
by Ido Tal Nov. 22, 2009

Nov. 22, 2009

Hi, I've just now tried to install firefox with winetricks and failed. A short scan reveals what the problem is (I think): the version winetricks is trying to install is 3.5.3. Looking at http://releases.mozilla.org/pub/mozilla.org/firefox/releases/ shows that it's not there anymore. Hope this helps... Ido

3 2

Re: [PATCH 1/3] gdi32/tests: Test BitBlt() to an enhanced metafile.
by Charles Davis Nov. 22, 2009

Nov. 22, 2009

Austin English wrote: > On Sat, Nov 21, 2009 at 11:15 PM, Charles Davis <cdavis(a)mymail.mines.edu> wrote: >> Dmitry Timoshkov wrote: >>> "Charles Davis" <cdavis(a)mymail.mines.edu> wrote: >>> >>>>> You forgot to remove if (1). >>>>> >>>> It goes away in patch #3. I thought I already had this discussion with >>>> Paul. >>>> >>>> There's a reason it's there. EMF_BITBLT contains two BitBlt() records, >>>> but the EMF we're comparing it to only has one. That's because one of >>>> them is if(0)'d out because it crashes on Wine. So, if we try to compare >>>> the EMF we produced to the EMF we expect, it will fail. Last I checked, >>>> Alexandre doesn't like it when tests fail. All tests must pass on his >>>> box. >>> There are 2 solutions for that: >>> 1. use todo_wine in the test, and remove it in a patch with the fix >> The test will fail on Windows if I do that. > > That won't affect windows. It will only fail on wine if it passes. > You don't understand. The expected EMF bits contain TWO BitBlt() records, but the EMF produced by the test contains only one. It will contain only one on both Wine and Windows, because one of the calls to BitBlt() is if(0)'d out. So the test will fail on Windows if the call to compare_emf_bits() is marked todo_wine. Oh, and you didn't reply to all. Was that intentional?

2 1

Someone please update the german translation of Ubuntu download page
by Scott Ritchie Nov. 22, 2009

Nov. 22, 2009

My German is inadequate and there are no instructions for Karmic users there at the moment. Thanks, Scott Ritchie

2 1

Re: [PATCH 1/3] gdi32/tests: Test BitBlt() to an enhanced metafile.
by Dmitry Timoshkov Nov. 22, 2009

Nov. 22, 2009

"Charles Davis" <cdavis(a)mymail.mines.edu> wrote: > + if(1 || compare_emf_bits(hMetafile, EMF_BITBLT, sizeof(EMF_BITBLT), > + "emf_BitBlt", FALSE) != 0) > + { > + dump_emf_bits(hMetafile, "emf_BitBlt"); > + dump_emf_records(hMetafile, "emf_BitBlt"); > + } You forgot to remove if (1). -- Dmitry.

2 3

Next step: detect double-frees and use-after-free
by Dan Kegel Nov. 22, 2009

Nov. 22, 2009

Now that the heap tail check is more or less working, I'm on to implementing protection against double frees and use-after-free for recently freed blocks. The idea is that HEAP_MakeInUseBlockFree() will take the block it's called with, push it onto a FIFO, pull an old block off the FIFO, and mark that old block free. The blocks languishing in the FIFO will be marked inaccessible. If you try to free one, realloc one, or even get its size, you'll get an immediate error; if you write to one, you'll get an error when it comes out of the FIFO or when the heap is validated; and if you're running Valgrind, you'll get an immediate error on read or write to the freed block. The FIFO will be drained when the heap is destroyed. It will be implemented using a standard wine list in an optional fixed-sized block at the tail of each allocation. Remind me again why we didn't do this years ago...

1 0

Re: Difficulties with Regression Testing
by James Mckenzie Nov. 21, 2009

Nov. 21, 2009

>From: Austin English <austinenglish(a)gmail.com> >Sent: Nov 19, 2009 10:31 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Wine Development Mailing List <wine-devel(a)winehq.org> >Subject: Re: Difficulties with Regression Testing > >On Thu, Nov 19, 2009 at 8:51 AM, James Mckenzie ><jjmckenzie51(a)earthlink.net> wrote: >> All: >> >> I've been running regression tests to find a commit between wine-1.1.10 and wine-1.1.11 that breaks the EM_FORMATRANGE >> patch or to discover what I need to do to fix the patch to make it work with wine-1.1.11. I've been following the >> instructions on the Regression Testing Wiki page. I am on the fourth git bisect good and I run into two different >> problems: >> >> 1. The tools/Makefile.in file gets corrupted on the fourth git bisect good. This is unexpected as I am not aware of >> any changes to this file that would cause corruption. This happens interrmittently and a git fetch sometimes causes >> the error that tools/Makefile.in needs to be updated to appear when I apply/remove a patch which is needed to correct >> wordpad, one of the programs I am using to test the EM_FORMATRANGE patch. The build fails when attempting to build >> makedep.c. The includes appear to be incorrect and do not pick up the files in the source directory thus the Wine >> includes are not included. > >Try doing a make clean / make distclean. > I don't think this will do anything, but I'll try it. >> 2. Something else is causing the check.bmp file not to be found and thus the tests fail on the fourth git bisect >> good. The .rc file that calls this file is located in two different directorys but the check.bmp file only exists in >> the tools/subdirectory. > >IIRC, that was a file for the cryptui manager that AJ forgot to >include with the commit needing it. Try either putting it there >manually from another git branch, or using make -k. > Where does this need to be added? I might be able to figure it out, but I don't want to go guessing. James McKenzie

2 2

UMR in CertIsRDNAttrsInCertificateName()
by Dan Kegel Nov. 20, 2009

Nov. 20, 2009

http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-crypt32_cert.txt shows a new UMR (purify-speak for uninitialized memory read) error Conditional jump or move depends on uninitialised value(s) at strncmp (mc_replace_strmem.c:386) by find_matching_rdn_attr (cert.c:1877) by CertIsRDNAttrsInCertificateName (cert.c:1907) by testIsRDNAttrsInCertificateName (cert.c:2698) Uninitialised value was created by a client request at mark_block_uninitialized (heap.c:192) by RtlAllocateHeap (heap.c:1526) by HeapAlloc (heap.c:276) by GlobalAlloc (heap.c:369) by LocalAlloc (heap.c:969) by CRYPT_DecodeEnsureSpace (decode.c:218) by CRYPT_AsnDecodeName (decode.c:1918) by CryptDecodeObjectEx (decode.c:5909) by CertIsRDNAttrsInCertificateName (cert.c:1901) by testIsRDNAttrsInCertificateName (cert.c:2698) Juan, I think that's yours, could you have a look? - Dan

2 1

Re: [PATCH 2/2] mshtml: Also search by node name attribute in IHTMLDocument3::getElementById
by Jacek Caban Nov. 20, 2009

Nov. 20, 2009

Hi Andrew, Andrew Eikum wrote: > --- > dlls/mshtml/htmldoc3.c | 58 > +++++++++++++++++++++++++++++++++++++++++++--- > dlls/mshtml/nsiface.idl | 33 ++++++++++++++++++++++++++ > dlls/mshtml/tests/dom.c | 29 ++++++++++++++++++++++- > 3 files changed, 115 insertions(+), 5 deletions(-) [ object, + uuid(29fb2a18-1dd2-11b2-8dd9-a6fd5d5ad12f), + local + /* FROZEN */ +] This interface is not frozen, please change the comment to NOT_FROZEN so that I we will know that we have to check it for changes on the next Gecko update. + hres = IHTMLElement_get_tagName(elem2, &str); + ok(hres == S_OK, "IHTMLElement_get_tagName failed: 0x%08x\n", hres); + ok(!strcmp_wa(str, "A"), "Got wrong tag: %s\n", wine_dbgstr_w(str)); + SysFreeString(str); There is generic test_elem_tag that is meant for this. + /* getElementById with node name attributes */ + hres = IHTMLDocument2_QueryInterface(doc, &IID_IHTMLDocument3, (void**)&doc3); + ok(hres == S_OK, "Unable to get IHTMLDocument3: 0x%08x\n", hres); + if(FAILED(hres)) + return; + bstr = a2bstr("nm1"); + hres = IHTMLDocument3_getElementById(doc3, bstr, &elem); + SysFreeString(bstr); + IHTMLDocument3_Release(doc3); + ok(hres == S_OK, "getElementById failed: 0x%08x\n", hres); + if(FAILED(hres)) + return; Same here for get_doc_elem_by_id. + + hres = IHTMLElement_get_id(elem, &bstr); + ok(hres == S_OK, "IHTMLElement_get_id failed: 0x%08x\n", hres); + ok(!strcmp_wa(bstr, "fr1"), "Found ID should have been \"fr1\", was: %s", wine_dbgstr_w(bstr)); + SysFreeString(bstr); Same here for test_elem_id. Thanks, Jacek

2 1

re: Running server applications under Wine?
by Dan Kegel Nov. 20, 2009

Nov. 20, 2009

임은지 wrote: > Is there anyone who uses Wine for server applications (game server, web server, etc.)? It's been done. See e.g. http://www.fpsadmin.com/forum/showthread.php?t=16481 for how one fellow ran a game server in wine. > Performance is very important issue for such applications. A server should serve a large number of clients at reasonable speeds. Yes, it would be interesting to run ab or dkftpbench against an http or ftp server running on wine. > What do you think about implementing wineserver kernel module or handling only performance critical items in kernel? There has long been talk of doing that. Linus is even willing to take patches to implement win32 APIs in the linux kernel. But it turns out to not be what most people need. If you want to do some server performance stress testing and file bugs for problems you find, by all means, go ahead! - Dan

2 3

New version of my test for bug 4543
by Charles Davis Nov. 20, 2009

Nov. 20, 2009

Hi, This is a new version of my test for bug 4543. This time, I followed Dmitry's suggestion of using the existing functions for comparing the contents of EMFs. I can't build tests for Windows both due to bug 20763 and due to the fact that I don't have any Windows boxes, so once again I need people to run this test on Windows to make sure it's an accurate representation of Windows' behavior. The test currently succeeds on Wine. Thanks in advance. Chip >From 574bb4f7b2b90a209b1693b7f8048a2eb271ada8 Mon Sep 17 00:00:00 2001 From: Charles Davis <cdavis(a)mymail.mines.edu> Date: Tue, 17 Nov 2009 11:10:50 -0700 Subject: [PATCH] gdi32/tests: Test BitBlt() to an enhanced metafile. To: wine-patches <wine-patches(a)winehq.org> Reply-To: wine-devel <wine-devel(a)winehq.org> --- dlls/gdi32/tests/metafile.c | 125 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 125 insertions(+), 0 deletions(-) diff --git a/dlls/gdi32/tests/metafile.c b/dlls/gdi32/tests/metafile.c index b559901..3bd413b 100644 --- a/dlls/gdi32/tests/metafile.c +++ b/dlls/gdi32/tests/metafile.c @@ -1030,6 +1030,63 @@ static const unsigned char EMF_LINETO_MM_TEXT_BITS[] = { 0x14, 0x00, 0x00, 0x00 }; +static const unsigned char EMF_BITBLT[] = +{ + 0x01, 0x00, 0x00, 0x00, 0x6c, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x03, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x94, 0x00, 0x00, 0x00, 0x79, 0x00, 0x00, 0x00, + 0x20, 0x45, 0x4d, 0x46, 0x00, 0x00, 0x01, 0x00, + 0xa0, 0x01, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, + 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x04, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, + 0xfc, 0x01, 0x00, 0x00, 0x38, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x60, 0xc0, 0x07, 0x00, + 0xc0, 0xc2, 0x04, 0x00, 0x4c, 0x00, 0x00, 0x00, + 0xbc, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, + 0x03, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, + 0x04, 0x00, 0x00, 0x00, 0x20, 0x00, 0xcc, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x80, 0x3f, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x80, 0x3f, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x64, 0x00, 0x00, 0x00, 0x28, 0x00, 0x00, 0x00, + 0x8c, 0x00, 0x00, 0x00, 0x30, 0x00, 0x00, 0x00, + 0x28, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, + 0x04, 0x00, 0x00, 0x00, 0x01, 0x00, 0x18, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x30, 0x00, 0x00, 0x00, + 0xc4, 0x0e, 0x00, 0x00, 0xc4, 0x0e, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x4c, 0x00, 0x00, 0x00, 0x64, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x03, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x04, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, + 0x62, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x80, 0x3f, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x80, 0x3f, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x64, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x64, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x0e, 0x00, 0x00, 0x00, + 0x14, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x10, 0x00, 0x00, 0x00, 0x14, 0x00, 0x00, 0x00 +}; + + /* For debugging or dumping the raw metafiles produced by * new test functions. */ @@ -1382,6 +1439,73 @@ static int compare_emf_bits(const HENHMETAFILE mf, const unsigned char *bits, return 0; } + +/* tests blitting to an EMF */ +static void test_emf_BitBlt(void) +{ + HDC hdcDisplay, hdcMetafile, hdcBitmap; + HBITMAP hBitmap, hOldBitmap; + HENHMETAFILE hMetafile; +#define BMP_DIM 4 + BITMAPINFOHEADER bmih = + { + sizeof(BITMAPINFOHEADER), + BMP_DIM,/* biWidth */ + BMP_DIM,/* biHeight */ + 1, /* biPlanes */ + 24, /* biBitCount */ + BI_RGB, /* biCompression */ + 0, /* biXPelsPerMeter */ + 0, /* biYPelsPerMeter */ + 0, /* biClrUsed */ + 0, /* biClrImportant */ + }; + void *bits; + BOOL ret; + + hdcDisplay = CreateDCA("DISPLAY", NULL, NULL, NULL); + ok( hdcDisplay != 0, "CreateDCA error %d\n", GetLastError() ); + + hdcBitmap = CreateCompatibleDC(hdcDisplay); + ok( hdcBitmap != 0, "CreateCompatibleDC failed\n" ); + bmih.biXPelsPerMeter = MulDiv(GetDeviceCaps(hdcDisplay, LOGPIXELSX), 100, 3937); + bmih.biYPelsPerMeter = MulDiv(GetDeviceCaps(hdcDisplay, LOGPIXELSY), 100, 3937); + hBitmap = CreateDIBSection(hdcDisplay, (const BITMAPINFO *)&bmih, + DIB_RGB_COLORS, &bits, NULL, 0); + hOldBitmap = SelectObject(hdcBitmap, hBitmap); + + hdcMetafile = CreateEnhMetaFileA(hdcBitmap, NULL, NULL, NULL); + ok( hdcMetafile != 0, "CreateEnhMetaFileA failed\n" ); + + /* First fill the bitmap DC with something recognizable, like BLACKNESS */ + ret = BitBlt(hdcBitmap, 0, 0, BMP_DIM, BMP_DIM, 0, 0, 0, BLACKNESS); + ok( ret, "BitBlt(BLACKNESS) failed\n" ); + + ret = BitBlt(hdcMetafile, 0, 0, BMP_DIM, BMP_DIM, hdcBitmap, 0, 0, SRCCOPY); + ok( ret, "BitBlt(SRCCOPY) failed\n" ); + if(0) /* Crashes on wine */ + { + ret = BitBlt(hdcMetafile, 0, 0, BMP_DIM, BMP_DIM, 0, 0, 0, WHITENESS); + ok( ret, "BitBlt(WHITENESS) failed\n" ); + } + + hMetafile = CloseEnhMetaFile(hdcMetafile); + ok( hMetafile != 0, "CloseEnhMetaFile failed\n" ); + + if(1 || compare_emf_bits(hMetafile, EMF_BITBLT, sizeof(EMF_BITBLT), + "emf_BitBlt", FALSE) != 0) + { + dump_emf_bits(hMetafile, "emf_BitBlt"); + dump_emf_records(hMetafile, "emf_BitBlt"); + } + + SelectObject(hdcBitmap, hOldBitmap); + DeleteObject(hBitmap); + DeleteDC(hdcBitmap); + DeleteDC(hdcDisplay); +#undef BMP_DIM +} + /* Test a blank metafile. May be used as a template for new tests. */ static void test_mf_Blank(void) @@ -2628,6 +2752,7 @@ START_TEST(metafile) /* For enhanced metafiles (enhmfdrv) */ test_ExtTextOut(); test_SaveDC(); + test_emf_BitBlt(); /* For win-format metafiles (mfdrv) */ test_mf_SaveDC(); -- 1.6.5.2

3 5

Re: [PATCH 1/3] gdi32/tests: Test BitBlt() to an enhanced metafile.
by Paul Vriens Nov. 20, 2009

Nov. 20, 2009

On 11/20/2009 04:21 PM, Charles Davis wrote: > + if(1 || compare_emf_bits(hMetafile, EMF_BITBLT, sizeof(EMF_BITBLT), > + "emf_BitBlt", FALSE) != 0) Shouldn't you get rid of that '1 ||' ? -- Cheers, Paul.

1 1

what should happen when selecting no audio in winecfg?
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 20, 2009

Nov. 20, 2009

Hi, I've observed 2 seemingly opposed behaviours when no audio driver is selected in winecfg's audio tab (or when winecfg's audio tab had never been opened before in this .wine prefix): - On one hand, some tests and apps still manage to produce sound. - On the other hand (OTOH), some apps cease to produce sound -- this is a simple method worth trying when some apps hang with sound issues. So I'm left wondering what a) wine's default .wine creation behaviour or b) unselecting all audio drivers in the tab ought to do. Remember that when you first visit winecfg's audio tab, you get to see a note that a default driver was chosen, which lead me to believe that no driver at all is enabled until then. Thanks, Jörg Höhle.

1 0

Running server applications under Wine?
by 임은지 Nov. 20, 2009

Nov. 20, 2009

Is there anyone who uses Wine for server applications (game server, web server, etc.)? Performance is very important issue for such applications. A server should serve a large number of clients at reasonable speeds. What do you think about implementing wineserver kernel module or handling only performance critical items in kernel?

1 0

Re: d3dx9_36: add a stub for D3DXCreateTextureFromFileInMemory
by Jeff Zaroyko Nov. 20, 2009

Nov. 20, 2009

On Fri, Nov 20, 2009 at 4:56 AM, Austin English <austinenglish(a)gmail.com> wrote: > Should fix http://bugs.winehq.org/show_bug.cgi?id=13605 > > -- > -Austin > Does it really fix it, the function still remains unimplemented, crash or no crash... a bug will probably just be filed after it to say the function needs to be implemented if the app really uses it, so what is gained?

2 3

Re: New version of my test for bug 4543
by Charles Davis Nov. 20, 2009

Nov. 20, 2009

Paul Vriens wrote: > On 11/19/2009 11:17 PM, Charles Davis wrote: >> Hi, >> >> This is a new version of my test for bug 4543. This time, I followed >> Dmitry's suggestion of using the existing functions for comparing the >> contents of EMFs. I can't build tests for Windows both due to bug 20763 >> and due to the fact that I don't have any Windows boxes, so once again I >> need people to run this test on Windows to make sure it's an accurate >> representation of Windows' behavior. The test currently succeeds on Wine. >> >> Thanks in advance. >> >> Chip >> >> >> >> > I'll give it a try on some of my (VMware) boxes tomorrow. > Thanks. I almost forgot: some of the test is if(0)'d out because it crashes on Wine (right now). So, you may wish to un-if(0) the crashing test when you run on Windows. I'm particularly interested in the EMF that the test produces on Windows (it should dump it to the console if you run with WINETEST_DEBUG=1), so that would be really helpful. Chip

1 0

Re: msi regression in today's git -- NEVER MIND
by Susan Cragin Nov. 19, 2009

Nov. 19, 2009

I had a bad git. Re-did everything and now it works. Sorry about that. Susan -----Original Message----- >Installed Dragon NaturallySpeaking using clean prefix and today's git. >Instal went "without errors" but when I tried to open the program it said that the install hadn't completed correctly. >Specifically, iexplore.exe was missing. >I looked at the terminal output for the run but there wasn't anything interesting. > >Susan >

1 0

Write-past-end in FileMonikerImpl_DecomposePath()
by Dan Kegel Nov. 19, 2009

Nov. 19, 2009

http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/diff-hlink_hlink.txt http://kegel.com/wine/valgrind/logs/2009-11-18-21.51/vg-hlink_hlink.txt shows a new error thanks to the heap tail check. Looks like a level-of-indirection-during-allocation error, 1039 strgtable = CoTaskMemAlloc(len*sizeof(WCHAR)); should be 1039 strgtable = CoTaskMemAlloc(len*sizeof(WCHAR *)); Ulrich, you were in there last, could you have a look? Invalid write of size 4 at FileMonikerImpl_DecomposePath (filemoniker.c:1056) by FileMonikerImpl_Construct (filemoniker.c:1375) by CreateFileMoniker (filemoniker.c:1443) by FileMoniker_CreateFromDisplayName (filemoniker.c:1484) by MkParseDisplayName (moniker.c:1130) by HlinkCreateFromString (hlink_main.c:124) by test_persist (hlink.c:479) by func_hlink (hlink.c:1122) by run_test (test.h:535) by main (test.h:585) Address 0x7f04416c is 4 bytes inside a block of size 6 alloc'd at notify_alloc (heap.c:279) by RtlAllocateHeap (heap.c:1521) by IMalloc_fnAlloc (ifs.c:186) by CoTaskMemAlloc (ifs.c:562) by FileMonikerImpl_DecomposePath (filemoniker.c:1039) by FileMonikerImpl_Construct (filemoniker.c:1375) by CreateFileMoniker (filemoniker.c:1443) by FileMoniker_CreateFromDisplayName (filemoniker.c:1484) by MkParseDisplayName (moniker.c:1130) by HlinkCreateFromString (hlink_main.c:124) by test_persist (hlink.c:479)

1 1

Re: winspool.drv: Acroread 9.2 relies on the buffer sizes returned by GetPrinterA and GetPrinterDriverA being large enough to hold their respective unicode versions' data.
by Detlef Riekenberg Nov. 19, 2009

Nov. 19, 2009

On Do, 2009-11-19 at 13:18 +0000, Huw Davies wrote: > --- > dlls/winspool.drv/info.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) ANSI functions in winspool.drv have this behavior since w2k. We have already a test for EnumPrintersA/W [required by Outlook2003) I prefer to make such buffer size requirements also the default in Wine. We are able to simplify a lot of ANSI Functions, when we use this way. Alexandre, is this acceptable for you? -- By by ... Detlef

1 0

Problem to download git
by paulo lesgaz Nov. 19, 2009

Nov. 19, 2009

Hello, when I try to download git, I have the following error. Is it for me only, or does it occur for anyone? I tried to download it several times. I obtain always the same error. dadam(a)analyst:~$ export http_proxy=”http://proxy.upf.pf:8080″ dadam(a)analyst:~$ git clone http://source.winehq.org/git/wine.git ~/wine Initialized empty Git repository in /home/dadam/wine/.git/ Getting alternates list for http://source.winehq.org/git/wine.git Getting pack list for http://source.winehq.org/git/wine.git Getting index for pack 0ece042377e5e1fe77ac71b065cf360c0244774e Getting index for pack 72c84da3f0d9b4fd0dad04f1ce7244dadce37a43 Getting index for pack 6c18f6d3a2d8e85a33e7981ead83b64e4c36bc8c Getting index for pack 7c2ab792c6e1c8f603b784f9dcb81f56f03bbf75 Getting pack 7c2ab792c6e1c8f603b784f9dcb81f56f03bbf75 which contains 7f5b24ed9186d457acd7803a97d4171f332c5fb2 error: Unable to get pack file http://source.winehq.org/git/wine.git/objects/pack/pack-7c2ab792c6e1c8f603b… transfer closed with 1152650 bytes remaining to read error: Unable to find 7f5b24ed9186d457acd7803a97d4171f332c5fb2 under http://source.winehq.org/git/wine.git Cannot obtain needed object 7f5b24ed9186d457acd7803a97d4171f332c5fb2 fatal: Fetch failed. D. Adam

3 3

GdiplusAbort type needs to be translated from C++ to C
by Vincent Povirk Nov. 19, 2009

Nov. 19, 2009

The Windows SDK defines the following type: struct __declspec(novtable) GdiplusAbort { virtual HRESULT __stdcall Abort(void) = 0; }; I think that the following is a workable translation: diff --git a/include/gdiplustypes.h b/include/gdiplustypes.h index 4f97432..444123f 100644 --- a/include/gdiplustypes.h +++ b/include/gdiplustypes.h @@ -55,6 +55,18 @@ typedef BOOL (CALLBACK * ImageAbort)(VOID *); typedef ImageAbort DrawImageAbort; typedef ImageAbort GetThumbnailImageAbort; +struct GdiplusAbort; + +typedef struct gpabort_vtable +{ + HRESULT WINAPI (*Abort)(struct GdiplusAbort*); +} + +typedef struct GdiplusAbort +{ + struct gpabort_vtable *vtable_ptr; +} GdiplusAbort; + #ifdef __cplusplus } #endif I don't think I can provide a proper C++ definition because the abi depends on the compiler. Does this look correct? -- Vincent Povirk

2 2

msi regression in today's git
by Susan Cragin Nov. 19, 2009

Nov. 19, 2009

Installed Dragon NaturallySpeaking using clean prefix and today's git. Instal went "without errors" but when I tried to open the program it said that the install hadn't completed correctly. Specifically, iexplore.exe was missing. I looked at the terminal output for the run but there wasn't anything interesting. Susan

1 0