December 2009 - Wine-Devel - list.winehq.org

Re: [PATCH 1/6] mshtml: Forward IHTMLFrameElement::get_dispid and invoke to its content window
by Jacek Caban Dec. 7, 2009

Dec. 7, 2009

Hi Andrew, This idea looks bad. What are you trying to fix? Jacek

2 1

dxgi:device tests crash on X64_64
by Paul Vriens Dec. 7, 2009

Dec. 7, 2009

Hi Henri, I'm trying to fix at least the crashes on X64_64 for this test. The tests are done on a Windows 7 64bit VMware guest. The strange thing is that when I crosscompile the tests as is (64bit of course) the tests don't crash. When I add the following (first thing): BOOL is_wow64; IsWow64Process( GetCurrentProcess(), &is_wow64 ); the tests crashes at DXGID3D10CreateDevice() in create_device(). I added that IsWow64Process() just to see if I was indeed running the 64bit version of the test. Any idea what's going on? -- Cheers, Paul.

2 7

Re: [PATCH] winhttp: check for endCert being NULL (Coverity)
by Juan Lang Dec. 6, 2009

Dec. 6, 2009

Hi Marcus, - if (ret) + if (ret && endCert) ret = netconn_verify_cert( endCert, store, server ); In this case you'll return TRUE if endCert is NULL, implying that the certificate chain is valid when it most likely isn't, or at least its validity couldn't be verified. If you could add an "else ret = FALSE" branch that'd be preferable. Thanks, --Juan

1 0

Re: ole32: Fix invalid memory access in storage32
by Huw Davies Dec. 6, 2009

Dec. 6, 2009

Nathan Gallaher wrote: > > In StorageImpl_construct(): > For pwcsName strings shorter than DIRENTRY_NAME_BUFFER_LEN-1, an invalid > read would be noted by valgrind as the memcpy wanders off the end of the > string. Do the needful to calculate the required string length. By the way, in storage32.h the filename member of struct StorageBaseImpl is declared as WCHAR filename[DIRENTRY_NAME_BUFFER_LEN]; shouldn't it be WCHAR filename[DIRENTRY_NAME_MAX_LEN]; ? Huw.

3 2

Re: listview: Fix LISTVIEW_CancelEditLabel to not save the changed text
by Nikolay Sivov Dec. 6, 2009

Dec. 6, 2009

Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 2 +- > dlls/comctl32/tests/listview.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Hi, Jeff. This is obviously wrong. Test will fail on native systems after your patch. What is a problem with current code, any bugs reported?

2 2

Using trace in tests
by James McKenzie Dec. 5, 2009

Dec. 5, 2009

All: I'm asking a question again, don't 'shoot' me, but I've noticed the use of the trace() function in tests and I would like to use this to troubleshoot what is incorrect in the EM_FORMATRANGE patch as it is not passing on MacOSX builds. The test appears to pass on WindowsXP sp2 as the failures did not appear in the winetest_latest for Wine-1.1.33. So, how do I enable the trace's I've added for testing so that I can fix the patch? Thank you. James McKenzie

2 5

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now
by Robert Reif Dec. 5, 2009

Dec. 5, 2009

Maarten Lankhorst wrote: > -- > As I said, I'm confident nobody uses it, since wine never implemented it properly anyway > --- > I think you will find that you will have to add it back later because both interfaces are commonly used. The private interface is used for enumerating devices and is the only way of getting some information about the actual hardware. The buffer interface is commonly used to determine special hardware effects. Programs do check even if wine doesn't implement them because most windows sound cards don't either. In fact, now that you will be using openal you might have the opportunity to actually add real effects!

8 17

Re: shdocvw: Implement IWebBrowser2_get_Name
by Paul Vriens Dec. 5, 2009

Dec. 5, 2009

On 12/04/2009 12:51 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > shdocvw: Implement IWebBrowser2_get_Name > > Best Regards > Alistair Leslie-Hughes > > Hi Alistair, This one introduces a test failure on non-English boxes: https://winetestbot.geldorp.nl/JobDetails.pl?Key=49 or http://test.winehq.org/data/6b8c9aee4fd57ac1f2f949992b3c5a6702f780a2/xp_wtb… (which is the same box btw). Could you have a look? -- Cheers, Paul.

1 1

Re: shell32: Fix a test failure on 64-bit systems.
by Vincent Povirk Dec. 4, 2009

Dec. 4, 2009

Don't commit this. It seems the failure does not appear on 64-bit Windows systems, which means that the test is actually correct and the implementation needs to be fixed. On Fri, Dec 4, 2009 at 11:59 AM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > > -- Vincent Povirk

1 0

Re: Juan Lang : winhttp: Check the certificate in an https connection using the crypto api.
by Michael Stefaniuc Dec. 4, 2009

Dec. 4, 2009

Juan, On 12/04/2009 04:11 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 82d07c405168df59db17d298bc3b8476f13540e9 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=82d07c405168df59db17d298b… > > Author: Juan Lang<juan.lang(a)gmail.com> > Date: Thu Dec 3 11:28:40 2009 -0800 > > winhttp: Check the certificate in an https connection using the crypto api. this breaks compilation on Fedora 12; F11 works fine though. gcc -c -I/home/michi/work/wine/dlls/winhttp -I. -I/home/michi/work/wine/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o net.o /home/michi/work/wine/dlls/winhttp/net.c /home/michi/work/wine/dlls/winhttp/net.c: In function ‘netconn_secure_verify’: /home/michi/work/wine/dlls/winhttp/net.c:342: error: ‘struct stack_st_X509’ has no member named ‘num’ /home/michi/work/wine/dlls/winhttp/net.c:346: error: ‘struct stack_st_X509’ has no member named ‘data’ /home/michi/work/wine/dlls/winhttp/net.c: In function ‘netconn_init’: /home/michi/work/wine/dlls/winhttp/net.c:450: warning: assignment discards qualifiers from pointer target type make: *** [net.o] Error 1 bye michael

2 2