December 2009 - Wine-Devel - list.winehq.org

Re: shdocvw: Implement refresh in webbbrowser.c
by Jacek Caban Dec. 9, 2009

Dec. 9, 2009

Hi David, David Anderson wrote: > > Implements WebBrowser_Refresh in shdocvw/webbrowser.c . > > Now a VB app with a 'refresh' button works, refreshing a web page > displayed by gecko with the current web page (it used to crash the app > because refresh returned an E_NOTIMPL). > > Tested with linux winetest.exe.so on Ubuntu 9.10 > with ATI graphics card. No new fails (retests are not 100% stable, but > close to stable), I tested several times before and after the change. > Fails are like other linux-wine results shown on test.winehq.org. This is obviously not the right implementation. It's just a hack. Also we don't have any test for this function, so testing with existing tests doesn't make much sense. WebBrowser *This = WEBBROWSER_THIS(iface); - FIXME("(%p)\n", This); - return E_NOTIMPL; + BSTR url; + HRESULT res; + + TRACE("(%p)\n", This); + res = WebBrowser_get_LocationURL(iface, &url); You don't need this call, you can access WebBrowser object here. + if( res != S_OK) { + FIXME("(%p)-> ERROR calling WebBrowser_get_LocationURL\n", This); + return res; + } + TRACE("(%p)->(%s )\n", This, debugstr_w(url)); + return navigate_url(&This->doc_host, url, NULL,NULL,NULL,NULL); You leak url here. Thanks, Jacek

1 0

Re: ntdll/tests: Fix a memory leak.
by Paul Vriens Dec. 9, 2009

Dec. 9, 2009

On 12/08/2009 11:44 AM, Hans Leidekker wrote: > CloseHandle( dir ); > + pRtlFreeUnicodeString(&nameW ); This one makes the tests crash on 64bit Windows 7. Any idea why? The NtQueryDirectoryFile() just before that fails with ERROR_NO_MORE_ITEMS btw, but that's also true on my 32bit Win7 box. -- Cheers, Paul.

1 0

re: Wine performance improvement
by Dan Kegel Dec. 8, 2009

Dec. 8, 2009

Interesting! Clearly a long ways off from production-ready, but it's fun to see somebody trying this. A few notes: Please clean up the patch a bit to remove lines like this: +//FIXME("handle : %ld \n", handle); and extra files like dlls/ws2_32/tests/test.sh Please avoid hand-editing include/wine/server_protocol.h The start of the file even says: * This file is automatically generated; DO NO EDIT! * Edit server/protocol.def instead and re-run tools/make_requests Please switch to plain text for future posts. It's very hard to read in the archive; see http://www.winehq.org/pipermail/wine-devel/2009-December/080394.html Please identify the author(s) of the new code for copyright purposes, and ensure they agree to licensing their code under the LGPL (for Wine) and GPL (for Linux kernel). I'm sure other people will have more to say.

1 0

Wine performance improvement
by Eun-Ji, Lim Dec. 8, 2009

Dec. 8, 2009

1 0

Re: winhttp/tests: Fix test error when run as non-administrator
by Paul Vriens Dec. 8, 2009

Dec. 8, 2009

On 12/08/2009 12:58 AM, Juan Lang wrote: > - ok(ret, "WinHttpSetDefaultProxyConfiguration failed: %d\n", GetLastError()); > + ok(ret || GetLastError() == ERROR_ACCESS_DENIED, > + "WinHttpSetDefaultProxyConfiguration failed: %d\n", GetLastError()); > > - set_default_proxy_reg_value( saved_proxy_settings, len, type ); > + if (ret) > + set_default_proxy_reg_value( saved_proxy_settings, len, type ); > } Hi Juan, I'm not a big fan of this. In theory we can now mess up our implementation and return ERROR_ACCESS_DENIED without knowing that something is wrong as the tests will still succeed. I agree that ERROR_ACCESS_DENIED is a valid return value but I'd rather have some win_skip() or at least a skip() in there. win_skip() will work fine right now but as soon as we implement access rights to the registry (and multi-user) it should probably be a skip(). -- Cheers, Paul.

2 1

The XFORM matrix in PlgBlt is calculated incorrectly
by Alexander Almaleh Dec. 8, 2009

Dec. 8, 2009

2 1

Re: Wine sound discussion summary
by Stefan Dösinger Dec. 8, 2009

Dec. 8, 2009

> Though, how would MIDI be handled. I think that OpenAL doesn't handle MIDI... Good question. As far as I can see PulseAudio doesn't support MIDI either, but it is certainly available in Alsa, CoreAudio and on Windows Vista, even though its more tricky to activate HW midi on Vista. Emulating MIDI through a software synthesizer won't fly, as this will make it impossible to use hardware instruments. A related topic: How do Joysticks connected to the gameport work(which is the same hardware connector as MIDI). I think that a joystick already takes an entirely different path in the Linux kernel and it doesn't get anywhere near a sound system, so we don't have to bother about it. Is that correct?

7 18

Re: Author: Maarten Lankhorst <mlankhorst@patser.(none)>
by Stefan Dösinger Dec. 8, 2009

Dec. 8, 2009

> Author: Maarten Lankhorst <mlankhorst(a)patser.(none) Did you forget to configure your email address in git?

1 0

Re: shdocvw: Fix test for non-english IE MUI
by Jacek Caban Dec. 8, 2009

Dec. 8, 2009

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > Either use this patch or patch "Added support for non-enligh IE MUI". > > Changelog: > shdocvw: Fix test for non-english IE MUI - ok(!strcmp_wa(sName, "Microsoft Web Browser Control"), "got '%s', expected 'Microsoft Web Browser Control'\n", wine_dbgstr_w(sName)); + ok(sName, "get_Name return a NULL string.'\n"); You don't need to delete the whole test. You can check for the system language and do the compare only if it's English. Jacek

3 2

Re: 1/2 wined3d: print warning/error to winediag [try2]
by Alexandre Julliard Dec. 8, 2009

Dec. 8, 2009

Roderick Colenbrander <thunderbird2k(a)gmail.com> writes: > { > - ERR("Direct3D%d is not available without opengl\n", dxVersion); > + ERR_(winediag)("Unable to initialize Direct3D%d due to lack of OpenGL support.\nMake sure OpenGL drivers are installed on your system and that Wine was compiled with OpenGL support.\n", dxVersion); I don't think you want that. One of the ideas behind winediag is that it should be machine-parsable, and adding new lines in the middle of traces will make that harder. -- Alexandre Julliard julliard(a)winehq.org

1 0