June 2009 - Wine-Devel - list.winehq.org

Re: [3/3] wininet: Add missing empty line to end of headers list
by Alexandre Julliard June 5, 2009

June 5, 2009

Jason Green <jave27(a)gmail.com> writes: > @@ -4265,6 +4265,24 @@ static INT HTTP_GetResponseHeaders(LPWININETHTTPREQW lpwhr, BOOL clear) > } > }while(1); > > + /* make sure the response header is terminated with an empty line. Some apps really > + truly care about that empty line being there for some reason. If it's not present, > + just add it to the header. */ > + if (cchRawHeaders >= 4 && > + (strcmpW(&lpszRawHeaders[cchRawHeaders - 4], szCrLf) || > + strcmpW(&lpszRawHeaders[cchRawHeaders - 2], szCrLf))) > + { This check doesn't seem necessary, I don't see how you could already have an empty line in the buffer since we only store valid headers. -- Alexandre Julliard julliard(a)winehq.org

2 2

Implementation of User32.PrintWindow - Try 2
by Josselin Bardet June 5, 2009

June 5, 2009

Hi Second proposition patch for User32.PrintWindows Regards Jos

1 0

Implementation of the User32.PrintWindow
by Josselin Bardet June 5, 2009

June 5, 2009

Hi, As next of the discussion on the bug 18772 (http://bugs.winehq.org/show_bug.cgi?id=18772) I send here the implemenation for User32.PrintWindow function I've tested it with an application that was crashing because of this unimplemented function. Regards Jos

2 4

Re: [08/10] wined3d: Use FBOs for offscreen rendering by default.
by Alexandre Julliard June 5, 2009

June 5, 2009

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > From f8dd196de73ca81019b01f3fdae56b47985e63b6 Mon Sep 17 00:00:00 2001 > From: Henri Verbeet <hverbeet(a)codeweavers.com> > Date: Fri, 5 Jun 2009 10:10:48 +0200 > Subject: wined3d: Use FBOs for offscreen rendering by default. It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00ffffff for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_UYVY [...many more...] make: *** [visual.ok] Error 72 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: try3 [1/2] kernel32/tests: Fix tests to pass on Win9x and WinME
by Alexandre Julliard June 5, 2009

June 5, 2009

Guy Albertelli <galberte(a)neo.rr.com> writes: > Changelog > - Fix new tests for CreateFileA to pass on Win9x and WinME > - Fix tests for when GetVolumeNameForVolumeMountPointA fails. Please send separate changes as separate patches. > @@ -829,13 +830,17 @@ static void test_CreateFileA(void) > } > /* otherwise validate results with expectations */ > else if (p[i].todo_flag) > - todo_wine ok((hFile == INVALID_HANDLE_VALUE && p[i].err == GetLastError()) || > + todo_wine ok( > + (hFile == INVALID_HANDLE_VALUE && (p[i].err == GetLastError() || > + (p[i].err2 == -1 ? TRUE : p[i].err2 == GetLastError()))) || Please don't use -1 for DWORD values. Also your check will make the test useless for cases that have only one possible error. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mlang/tests: Fix failures with IE 5.5 and below
by Paul Vriens June 5, 2009

June 5, 2009

Detlef Riekenberg wrote: > On Mi, 2009-06-03 at 10:50 +0200, Paul Vriens wrote: >> This patch introduces test failures on what seems: >> >> - all Win95 boxes >> - some Win98 boxes >> - some W2K boxes > >> Could you have a look? > > Here is a fix. > > Hi Detlef, Is there no way to have a broken() in here: + /* IE <6.0 guess 0x412 (ko) from "kok" */ + if (lcid_table[i].alternate_lcid && (lcid_table[i].lcid != -1)) { + ok(ret == S_OK || ret == S_FALSE, + "#%02d: HRESULT 0x%x (expected S_OK or S_FALSE)\n", i, ret); and the same a bit further down? -- Cheers, Paul.

1 0

Re: gdiplus: Stub for GdipCreateBitmapFromDirectDrawSurface
by Alexandre Julliard June 4, 2009

June 4, 2009

Andrew Eikum <andrew(a)brightnightgames.com> writes: > diff --git a/include/gdiplusflat.h b/include/gdiplusflat.h > index 501e6ed..4ba329f 100644 > --- a/include/gdiplusflat.h > +++ b/include/gdiplusflat.h > @@ -27,6 +27,8 @@ > extern "C" { > #endif > > +#include <ddraw.h> gdiplusflat.h is not supposed to depend on ddraw.h. -- Alexandre Julliard julliard(a)winehq.org

2 1

Implementation of the User32.PrintWindow
by Josselin Bardet June 4, 2009

June 4, 2009

Hi, As next of the discussion on the bug 18772 (http://bugs.winehq.org/show_bug.cgi?id=18772) I send here the implemenation for User32.PrintWindow function I've tested it with an application that was crashing because of this unimplemented function. Regards Jos

1 0

Today's git may have a problem -- install takes forever then crashes
by Susan Cragin June 4, 2009

June 4, 2009

Today's git starts the installation of DNS very-very slowly. Then takes forever. I thought finally it was going to install but then it crashes at/near the end. Tail of log below. fixme:ole:CoCreateInstance no instance created for interface {d94a9b75-516c-41ec-8163-f1ac8ab03b29} of class {fff2d28f-e4ee-44d9-8104-8e71556757f6}, hres is 0xc0000005 wine: Unhandled page fault on read access to 0x00000000 at address 0x412f7d (thread 007d), starting debugger... susan(a)ubuntu:~/DNS$ Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00412f7d). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:00412f7d ESP:0033fb00 EBP:0033fe6c EFLAGS:00210212( R- -- I -A- - ) EAX:00000000 EBX:00000000 ECX:00000000 EDX:00000000 ESI:00475908 EDI:0046f754 Stack dump: 0x0033fb00: 001300fc 00000004 0044a687 00000000 0x0033fb10: 7b8c5ff4 0012fa88 0033fb38 7ffdf000 0x0033fb20: 7e1cfff4 00000001 7e1bc63b 7e1cfff4 0x0033fb30: 00000001 7e190000 0033fb78 7e1b1ff7 0x0033fb40: 00000003 7e1d7928 7e1c9207 7e1c7822 0x0033fb50: 7e190000 00000001 00000000 00000000 Backtrace: =>0 0x00412f7d in agent (+0x12f7d) (0x0033fe6c) 1 0x0044a767 in agent (+0x4a767) (0x0033fef8) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value szNlsKeyName (a) 2 0x7b8778ef start_process+0xdf(arg=(nil)) [/home/susan/wine/dlls/kernel32/process.c:941] in kernel32 (0x0033ffe8) 0x00412f7d: movl 0x0(%eax),%ecx Modules: Module Address Debug info Name (69 modules) PE 400000- 491000 Export agent ELF 7b800000-7b962000 Dwarf kernel32<elf> \-PE 7b820000-7b962000 \ kernel32 ELF 7bc00000-7bcb9000 Deferred ntdll<elf> \-PE 7bc10000-7bcb9000 \ ntdll ELF 7bf00000-7bf04000 Deferred <wine-loader> ELF 7e15e000-7e182000 Deferred mpr<elf> \-PE 7e160000-7e182000 \ mpr ELF 7e182000-7e1d8000 Deferred wininet<elf> \-PE 7e190000-7e1d8000 \ wininet ELF 7e226000-7e25a000 Deferred uxtheme<elf> \-PE 7e230000-7e25a000 \ uxtheme ELF 7e25a000-7e265000 Deferred libxcursor.so.1 ELF 7e265000-7e26b000 Deferred libxfixes.so.3 ELF 7e26b000-7e26f000 Deferred libxcomposite.so.1 ELF 7e26f000-7e278000 Deferred libxrandr.so.2 ELF 7e278000-7e282000 Deferred libxrender.so.1 ELF 7e282000-7e288000 Deferred libxxf86vm.so.1 ELF 7e288000-7e28b000 Deferred libxinerama.so.1 ELF 7e28b000-7e2ad000 Deferred imm32<elf> \-PE 7e290000-7e2ad000 \ imm32 ELF 7e2ad000-7e2b2000 Deferred libxdmcp.so.6 ELF 7e2b2000-7e2d0000 Deferred libxcb.so.1 ELF 7e2d0000-7e2d4000 Deferred libxau.so.6 ELF 7e2d4000-7e2d9000 Deferred libuuid.so.1 ELF 7e2d9000-7e409000 Deferred libx11.so.6 ELF 7e409000-7e419000 Deferred libxext.so.6 ELF 7e419000-7e434000 Deferred libice.so.6 ELF 7e434000-7e43d000 Deferred libsm.so.6 ELF 7e44d000-7e4ef000 Deferred winex11<elf> \-PE 7e460000-7e4ef000 \ winex11 ELF 7e51c000-7e543000 Deferred libexpat.so.1 ELF 7e543000-7e570000 Deferred libfontconfig.so.1 ELF 7e580000-7e596000 Deferred libz.so.1 ELF 7e596000-7e615000 Deferred libfreetype.so.6 ELF 7e615000-7e629000 Deferred lz32<elf> \-PE 7e620000-7e629000 \ lz32 ELF 7e629000-7e644000 Deferred version<elf> \-PE 7e630000-7e644000 \ version ELF 7e644000-7e73b000 Deferred oleaut32<elf> \-PE 7e660000-7e73b000 \ oleaut32 ELF 7e73b000-7e7ad000 Deferred rpcrt4<elf> \-PE 7e750000-7e7ad000 \ rpcrt4 ELF 7e7ad000-7e8bd000 Deferred ole32<elf> \-PE 7e7d0000-7e8bd000 \ ole32 ELF 7e8bd000-7e98b000 Deferred comctl32<elf> \-PE 7e8d0000-7e98b000 \ comctl32 ELF 7e98b000-7e9ee000 Deferred shlwapi<elf> \-PE 7e9a0000-7e9ee000 \ shlwapi ELF 7e9ee000-7eb83000 Deferred shell32<elf> \-PE 7ea00000-7eb83000 \ shell32 ELF 7eb83000-7ec2e000 Deferred gdi32<elf> \-PE 7eb90000-7ec2e000 \ gdi32 ELF 7ec2e000-7ed8a000 Deferred user32<elf> \-PE 7ec50000-7ed8a000 \ user32 ELF 7ed8a000-7ee14000 Deferred crypt32<elf> \-PE 7ed90000-7ee14000 \ crypt32 ELF 7ee14000-7ee6e000 Deferred advapi32<elf> \-PE 7ee20000-7ee6e000 \ advapi32 ELF 7ee6e000-7ee87000 Deferred libnsl.so.1 ELF 7ee87000-7ee90000 Deferred libnss_compat.so.2 ELF 7efca000-7eff0000 Deferred libm.so.6 ELF 7eff4000-7f000000 Deferred libnss_files.so.2 ELF b7c40000-b7c4b000 Deferred libnss_nis.so.2 ELF b7c4d000-b7c51000 Deferred libdl.so.2 ELF b7c51000-b7db4000 Deferred libc.so.6 ELF b7db5000-b7dce000 Deferred libpthread.so.0 ELF b7dde000-b7f1b000 Deferred libwine.so.1 ELF b7f1d000-b7f3b000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000c 00000012 0 0000000e 0 0000000d 0 0000000f 00000015 0 00000014 0 00000011 0 00000010 0 00000016 00000017 0 0000007c 0000002c 0 0000008b 0 00000093 0 0000008f 0 00000088 0 00000082 0 00000083 0 00000081 0 0000007f 0 00000096 0000007b 0 0000008c (D) C:\Program Files\Common Files\InstallShield\UpdateService\agent.exe 0000000b 0 0000008d 0 0000007d 0 <== Backtrace: =>0 0x00412f7d in agent (+0x12f7d) (0x0033fe6c) 1 0x0044a767 in agent (+0x4a767) (0x0033fef8) 2 0x7b8778ef start_process+0xdf(arg=(nil)) [/home/susan/wine/dlls/kernel32/process.c:941] in kernel32 (0x0033ffe8) susan(a)ubuntu:~/DNS$

1 0

re: wine question
by Dan Kegel June 4, 2009

June 4, 2009

Anna wrote: > I am trying to call Win32 Dll (that is built in VS 2003) from C++ > Linux application ( in Ubuntu ) through wine shared object without > rebuild the application with wine. Sorry, it's not generally possible to use Windows libraries inside a Linux program directly with Wine. Wine is jealous, and wants control of the whole program right from the start. Your main options are: 1) write a small Windows program that uses the DLL, run it via Wine, and talk to it from the Linux program using sockets and/or shared memory 2) run the Windows version of the app altogether in Wine There are ways to do what you want directly without Wine, but only for very restricted types of DLLs that do not make any Windows system calls. What does the DLL do? - Dan

1 0