October 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] urlmon: Added IInternetProtocolEx support to BindProtocol.
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/bindprot.c | 343 +++++++++++++++++++++++++++++------------------ > 1 files changed, 212 insertions(+), 131 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c && touch gameexplorer.ok gameexplorer.c:571: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:589: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:640: Test failed: IGameExplorer2::InstallGame failed (error 0x80004005) gameexplorer.c:643: Test failed: cannot find game with GDF path L"Z:\\home\\julliard\\wine\\wine\\dlls\\gameux\\tests\\gameux_test.exe" in scope 2 make: *** [gameexplorer.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/8] jscript: Added VBArray.dimensions() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6283 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/8] jscript: Implement VBArray constructor
by Jacek Caban Oct. 18, 2010

Oct. 18, 2010

Hi Piotr, +(tmp = new VBArray(createArray())).f = Object.prototype.toString; +ok(tmp.f() === "[object Object]", "tmp.f() = " + tmp.f()); We have Function.call implemented now, you can use String.prototype.toString.call(new VBArray ...). + case DISPATCH_METHOD: + if(arg_cnt(dp)<1 || V_VT((arg = get_arg(dp, 0)))!=(VT_ARRAY|VT_VARIANT)) + return throw_type_error(ctx, ei, IDS_NOT_VBARRAY, NULL); + + VariantCopy(retv, arg); Please add error handling. Also a test would be nice, at least something like getVT(createArray()). + case DISPATCH_CONSTRUCT: + if(arg_cnt(dp)<1 || V_VT((arg = get_arg(dp, 0)))!=(VT_ARRAY|VT_VARIANT)) + return throw_type_error(ctx, ei, IDS_NOT_VBARRAY, NULL); + + hres = alloc_vbarray(ctx, NULL,&vbarray); + if(FAILED(hres)) + return hres; + SafeArrayCopy(V_ARRAY(arg),&vbarray->safearray); Error handling. (From 'PATCH 4/8] jscript: Added VBArray.ubound() implementation'): + if(retv) + num_set_val(retv, dim); num_set_val is for DOUBLE and eventually abused for integers out of VT_I4 range. You can set value directly here to avoid conversions. It might be a good idea to introduce something like var_set_int helper given that we could use it in quite a few places. (From '[PATCH 6/8] jscript: Added VBArray.getItem() implementation'): + size = arg_cnt(dp); + if(size< SafeArrayGetDim(vbarray->safearray)) + return throw_range_error(ctx, ei, IDS_SUBSCRIPT_OUT_OF_RANGE, NULL); + + indexes = heap_alloc(sizeof(int)*size); Error handling. (From '[PATCH 8/8] jscript: Added VBArray handling to to_object()'): -exception_test(function() {(new VBArray(createArray())).lbound("aaa");}, "RangeError", -2146828279); -exception_test(function() {(new VBArray(createArray())).lbound(3);}, "RangeError", -2146828279); +exception_test(function() {createArray().lbound("aaa");}, "RangeError", -2146828279); +exception_test(function() {createArray().lbound(3);}, "RangeError", -2146828279); There is no reason to change these tests, esp. that they were better before the change. Please add proper to_object tests, for example by calling Object() function or doing proper call on explicitly converted object. + SafeArrayCopy(sa,&vbarray->safearray); Error handling. Jacek

1 0

Re: [PATCH 4/8] jscript: Added VBArray.ubound() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6282 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/8] jscrpt: Added VBScript.lbound() implementation
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6281 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.
by Alexandre Julliard Oct. 18, 2010

Oct. 18, 2010

Charles Davis <cdavis(a)mymail.mines.edu> writes: > @@ -1828,13 +2054,24 @@ static NTSTATUS find_file_in_dir( char *unix_name, int pos, const WCHAR *name, i > if (ret >= 0 && !used_default) > { > unix_name[pos + ret] = 0; > - if (!stat( unix_name, &st )) > + /* when checking case on a case insensitive but case preserving > + * fs, don't even bother doing the stat(), so we don't match the > + * file case-insensitively. > + */ > + if ((case_sensitive || !check_case) && !stat( unix_name, &st )) > { > if (is_win_dir) *is_win_dir = is_same_file( &windir, &st ); > return STATUS_SUCCESS; > } This still doesn't make sense. There's no reason to ever skip the stat. > @@ -2455,6 +2713,10 @@ static NTSTATUS lookup_unix_name( const WCHAR *name, int name_len, char **buffer > const WCHAR *end, *next; > int is_win_dir = 0; > > + unix_name[pos] = 0; > + stat( unix_name, &st ); > + unix_name[pos] = '/'; You can't add extra stat calls to the normal path. This is supposed to be an optimization. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/8] jscript: Added VBArray stub
by testbot＠testbot.winehq.org Oct. 18, 2010

Oct. 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6279 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

About: [PATCH 2/2] ntdll: Check for case-insensitive volumes.
by Joris Huizer Oct. 18, 2010

Oct. 18, 2010

Hello, In the proposed patch "[PATCH 2/2] ntdll: Check for case-insensitive volumes.", I found this piece: + /* Add a new entry */ + for (i = 0; i < sizeof(fs_cache)/sizeof(fs_cache[0]); i++) + if (fs_cache[i].dev == 0) + { + /* This entry is empty, use it */ + fs_cache[i].dev = dev; + fs_cache[i].fsid = fsid; + fs_cache[i].case_sensitive = case_sensitive; + } Maybe I'm missing something, but shouldn't you return from the function when finding a cache entry to fill? This seems to be filling every empty cache entry? HTH, Joris

2 1

About: msxml3: Partially implement ::setAttributeNode()
by Joris Huizer Oct. 18, 2010

Oct. 18, 2010

Hello, In proposed patch msxml3: Partially implement ::setAttributeNode() I think I found a little possible memory leak: + name = xmlChar_from_wchar(nameW); + value = xmlChar_from_wchar(V_BSTR(&valueW)); + + if (!name || !value) + { + SysFreeString(nameW); + VariantClear(&valueW); + return E_OUTOFMEMORY; + } Wouldn't you need to free memory allocated for both name and value, in case one of the allocations succeeded ? HTH, Joris

2 1

Re: [1/4]winegstreamer: add wine gstreamer parser filter
by Damjan Jovanovic Oct. 18, 2010

Oct. 18, 2010

On Mon, Oct 18, 2010 at 3:26 PM, Aric Stewart <aric(a)codeweavers.com> wrote: > --- > dlls/winegstreamer/regsvr.c | 951 +++++++++++++++++++ Please consider IRegistrar or inf file based registration instead, regsvr.c is the worst way to support DLL registration, especially if you have to customize it the way you have. Damjan

1 0