November 2010 - Wine-Devel - list.winehq.org

USB Device Support
by James Mckenzie Feb. 19, 2011

Feb. 19, 2011

Alexander: Before I go off and try to update your USB device support for the latest Wine release, are you continuing to maintain this code current to the Wine Development and Wine Stable trunks? Also, the USB Device Support in Wine Wiki page needs an update. The code at snicky.com is no longer available. Thank you for your efforts to support USB devices in Wine. James McKenzie

6 5

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov Jan. 19, 2011

Jan. 19, 2011

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

Re: wined3d: don't set cube and volume POW2 caps if np2 textures are supported
by Alexandre Julliard Jan. 17, 2011

Jan. 17, 2011

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From aa344834084ef89c654011804e6e2faccafe1e5e Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Stefan=20D=C3=B6singer?= <stefan(a)codeweavers.com> > Date: Sun, 21 Nov 2010 18:08:41 +0100 > Subject: [PATCH] wined3d: don't set cube and volume POW2 caps if np2 textures are supported It doesn't work here: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so texture.c && touch texture.ok texture.c:236: Test failed: Returned mipmaps 9, expected 10 texture.c:242: Test failed: Returned mipmaps 6, expected 7 texture.c:381: Test failed: Returned mipmaps 9, expected 10 make: *** [texture.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

4 7

Re: ws2_32: Add default case for family in debugstr_wsaioctl.
by Juan Lang Jan. 8, 2011

Jan. 8, 2011

Hi Gerald, > This mimicks what we already do a few lines above for buf_type. It's also unneeded: switch(ioctl & 0x18000000) There are only 4 possible combinations of ioctl & 0x18000000. Three are covered in this switch statement, and the fourth is eliminated due to the outer switch statement. You'd be adding dead code. --Juan

2 1

Re: Wine: Use GCC's -Wlogical-op if supported.
by Alexandre Julliard Dec. 11, 2010

Dec. 11, 2010

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > In the past this has found a dozen or two real issues and lead to some > simplifications. Now the tree is clean in that regard, so we can make > this a default. I still see a ton of warnings here (gcc 4.4.5), mostly because of the glibc string macros. -- Alexandre Julliard julliard(a)winehq.org

2 3

poor Wine performance creating fat dialogs
by Andreas Pflug Dec. 2, 2010

Dec. 2, 2010

I'm investigating running a commercial ERP system under Wine (only binary available). It mostly works, but creating the main dialogs for item, customer and such will need around 25 seconds, while running on Wxx it takes 2-3 seconds. After that, there's no serious performance impact working on these dialogs. The dialogs contain a lot of controls, like 500 or so each, so I suspect that's what makes things slow. I'm willing to investigate this in the wine sources, if it makes sense. So before I start I'd like to know if there are known or suspected inefficient code regions that might cause the problem? Maybe some win<->x11 translation tables that degrade with 1000+ windows? Or has this been observed before, and the problem is outside of wine's scope? Any hint appreciated. Regards, Andreas

3 3

Death to win9x?
by Dan Kegel Dec. 1, 2010

Dec. 1, 2010

I'm all for removing stuff that nobody needs anymore. I imagine there are still a few popular older apps that will force us to keep some old win9x behaviors around, though, so we probably won't be able to remove the 'emulate win98' choice from winecfg any time soon.

3 3

Re: [PATCH 2/2] opencl: Basic OpenCL 1.0 implementation. (try 2)
by Alexandre Julliard Dec. 1, 2010

Dec. 1, 2010

Peter Urbanec <winehq.org(a)urbanec.net> writes: > +static BOOL load_funcs(void *handle) > +{ > +#define LOAD_FUNCPTR(f) if((p##f = (void*)wine_dlsym(handle, #f, NULL, 0)) == NULL) \ > + { ERR("Can not find " #f "\n"); return FALSE; } else { TRACE("Loaded function " #f "\n"); }; > + > + /* Platform API */ > + LOAD_FUNCPTR(clGetPlatformIDs) > + LOAD_FUNCPTR(clGetPlatformInfo) > + > + /* Device APIs */ > + LOAD_FUNCPTR(clGetDeviceIDs) > + LOAD_FUNCPTR(clGetDeviceInfo) Why are you loading everything dynamically instead of simply linking to it? -- Alexandre Julliard julliard(a)winehq.org

2 4

Stopping Win9x testing
by Greg Geldorp Dec. 1, 2010

Dec. 1, 2010

> From: Paul Vriens > > On 11/30/2010 04:41 PM, Alexandre Julliard wrote: > > The value of running tests on Win9x these days is certainly questionable. > > We don't try to emulate the Win9x behavior anyway, except in a very few > > cases (which most likely don't have tests...) so it only serves to > > document historical behavior that nobody cares about any longer. > > > > I wouldn't be opposed to switching off win9x test runs and getting rid > > of the corresponding broken(). > > So the first thing is a patch to winetest.exe and the winetest website > and at the same time tell Greg to exclude it from 'patchwatcher' and the > batch running of the (almost) daily winetests. I'll mark the Win9x VMs offline when there's nothing queued to run on them. Then in a weeks time I can delete them after all jobs referring to them have been retired/deleted (referential integrity in the database). So for the next week you'll see a red dot with "One or more VMs are offline" on the testbot main page, don't be alarmed by this. Greg.

2 1

Re: mshtml: Added beginning ActiveX tests.
by Paul Vriens Nov. 30, 2010

Nov. 30, 2010

Hi Jacek, On 11/30/2010 01:38 PM, Jacek Caban wrote: > +static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) > +{ > + if(dispID == DISPID_READYSTATE){ > + BSTR state; > + HRESULT hres; > + > + static const WCHAR completeW[] = {'c','o','m','p','l','e','t','e',0}; > + > + hres = IHTMLDocument2_get_readyState(notif_doc,&state); > + ok(hres == S_OK, "get_readyState failed: %08x\n", hres); > + > + if(!lstrcmpW(state, completeW)) This will always succeed on Win9x. > +static HWND create_container_window(void) > +{ > + static const WCHAR wszHTMLDocumentTest[] = > + {'H','T','M','L','D','o','c','u','m','e','n','t','T','e','s','t',0}; > + static WNDCLASSEXW wndclass = { > + sizeof(WNDCLASSEXW), > + 0, > + wnd_proc, > + 0, 0, NULL, NULL, NULL, NULL, NULL, > + wszHTMLDocumentTest, > + NULL > + }; > + > + RegisterClassExW(&wndclass); > + return CreateWindowW(wszHTMLDocumentTest, wszHTMLDocumentTest, > + WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, > + 515, 530, NULL, NULL, NULL, NULL); > +} This will not work on Win9x as well. My Win98 box runs IE6 so it will run these tests I guess (unlike the win98 testbot). -- Cheers, Paul.

3 6