December 2010 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins Sept. 24, 2011

Sept. 24, 2011

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

re: make "bisected" a keyword in bugzilla?
by Dan Kegel Aug. 8, 2011

Aug. 8, 2011

I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday.

11 15

CD-ROM ioctl support on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com June 6, 2011

June 6, 2011

Hi, what's the state of CD-ROM support on the Mac? ntdll/cdrom.c contains quite a few #ifdef apple. I'm asking because the mcicda currently uses these ioctl: 1. READ_RAW 2. READ_TOC 3. READ_Q -> POSITION MCICDA could be changed to avoid the third one entirely -- when using the dsound output. Would that be enough to use mcicda on MacOS to play music? Thanks for your help, Jörg Höhle

2 3

Two enhancement requests for winetricks
by Dan Kegel Feb. 21, 2011

Feb. 21, 2011

OK, filed http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" and http://code.google.com/p/winezeug/issues/detail?id=128 "want status" - Dan

6 11

USB Device Support
by James Mckenzie Feb. 18, 2011

Feb. 18, 2011

Alexander: Before I go off and try to update your USB device support for the latest Wine release, are you continuing to maintain this code current to the Wine Development and Wine Stable trunks? Also, the USB Device Support in Wine Wiki page needs an update. The code at snicky.com is no longer available. Thank you for your efforts to support USB devices in Wine. James McKenzie

6 5

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov Jan. 19, 2011

Jan. 19, 2011

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

Re: wined3d: don't set cube and volume POW2 caps if np2 textures are supported
by Alexandre Julliard Jan. 17, 2011

Jan. 17, 2011

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From aa344834084ef89c654011804e6e2faccafe1e5e Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Stefan=20D=C3=B6singer?= <stefan(a)codeweavers.com> > Date: Sun, 21 Nov 2010 18:08:41 +0100 > Subject: [PATCH] wined3d: don't set cube and volume POW2 caps if np2 textures are supported It doesn't work here: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so texture.c && touch texture.ok texture.c:236: Test failed: Returned mipmaps 9, expected 10 texture.c:242: Test failed: Returned mipmaps 6, expected 7 texture.c:381: Test failed: Returned mipmaps 9, expected 10 make: *** [texture.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

4 7

ntdll/cdrom : implement CDROM_Verify to work on Mac Os
by maury loïc Jan. 9, 2011

Jan. 9, 2011

Hello, it's my first patch, and it implement the CDROM_Verify() to work on Mac Os. merci Loïc --- dlls/ntdll/cdrom.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..185f397 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,8 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

3 3

Re: ws2_32: Add default case for family in debugstr_wsaioctl.
by Juan Lang Jan. 8, 2011

Jan. 8, 2011

Hi Gerald, > This mimicks what we already do a few lines above for buf_type. It's also unneeded: switch(ioctl & 0x18000000) There are only 4 possible combinations of ioctl & 0x18000000. Three are covered in this switch statement, and the fourth is eliminated due to the outer switch statement. You'd be adding dead code. --Juan

2 1

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os
by James Mckenzie Jan. 1, 2011

Jan. 1, 2011

maury loïc <lmaury(a)gmail.com> wrote: > >Hello Ken and the Wine community, > Please bottom post or post directly to a question. Please do not top post. > >On Thu, Dec 30, 2010 at 12:51 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > >> Hi Loïc, >> >> On Dec 30, 2010, at 4:20 AM, maury loïc wrote: >> >> > it's my first patch, and it implement the CDROM_Verify() >> > to work on Mac Os. >> >> I think most people are going to need more explanation for why this is a >> legitimate way to implement this function on Mac OS X. :) >> >> Cheers, >> Ken >> >> >For what i understood, The function CDROM_Verify(), verify if the media is >present on the device, and Wine try to open >the device(in Mac Os case), before call the CDROM_Verify(). > >But Mac Os manage the device differently from the other Os. It create the >device, only if the media >is already present. Logically, CDROM_Verify() return success, because when >we are in CDROM_Verify() >we already know the device. > >What do you think ? > This has been critically examined by several people and if the solution were this simple it would have been put in place a long time ago. Charles Davis has spend over a year looking at how to implement CDROM functionality for MacOSX. So, here is my question: How can the community be 100% certain that: 1. The device has EXACTLY the same name on every available MacOSX installation? 2. How can you be 100% certain that if the 'device' exists that the code will end up in CDROM_Verify()? James McKenzie (Another Mac User/Wine Tester.)

4 6

Re: 64-bit Notepad2 crashes
by Susan Cragin Jan. 1, 2011

Jan. 1, 2011

>>> Does this 'path' exist in LD_LIBRARY_PATH or equivilent? >>> >>> Otherwise ld might not be able to 'find' it when starting the program. >>> >>> James McKenzie >>> >> James... >> You've just exhausted my technical knowledge. How do I do / find that? >Susan: > >For the BASH shell: >Type in set and look for the LD_LIBRARY_PATH line. >for the CSH/KSH shell: >Type in env >Look for the LD_LIBRARY_PATH line. > >Hopefully, /usr/local/lib is there. > >BTW, to make Wine work on a Mac, I have to add this line.... > >James McKenzie Typed "set" Did word search on "library." Nothing.

4 3

Another tests milestone hit
by Greg Geldorp Dec. 31, 2010

Dec. 31, 2010

Today we hit another milestone: the first 0-failure run of the 64-bit tests. All tests passed on both the WXPX64 and W2K3R2SEX64 machines. Sadly I missed my personal goal of having all tests pass on at least one VM for every Windows version by the end of the year, we still don't have a Win7 machine that passes all tests. I have a partial fix for msctf:inputprocessor (put a "Sleep(2000);" after the call to test_RegisterCategory()) but in spite of spending quite a bit of time on it haven't made much further progress. So anyone with msctf expertise: your help would be greatly appreciated. Same for ole32:clipboard and ole32:usrmarshal. A big thank you to all the people who contributed tests and fixed existing tests. I think a lot of progress has been made in the month since WineConf and the tests are in much better shape now. Greg.

2 1

sound issues (which are not cared since 1.3.1)
by wylda＠volny.cz Dec. 31, 2010

Dec. 31, 2010

Hi guys, there are bug reports showing random crashes with audio on, during winecfg etc. I was bit by those too... There is probably something wrong how regressions are handled here, which goes on and thus there are unneeded bugreports which cost everyone's time to read, evaluate, search, mark, retest... Why don't you use revert more offen like kernel guys? Back to the sound issue - my zero programming skill standing just on sound despair, i guess in dlls/winealsa.drv/mixer.c ALSA_MixerInit() should be int card, err, capcontrols=0 otherwise things like: mixdev[mixnum].chans += capcontrols; mixdev[mixnum].lines = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(line) * mixdev[mixnum].chans); mixdev[mixnum].controls = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(control) * CONTROLSPERLINE*mixdev[mixnum].chans); goes crazy like in http://bugs.winehq.org/show_bug.cgi?id=25231#c2. Could someone review this piece of code, please? Thanks, W.

2 2

re: JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder
by Dan Kegel Dec. 31, 2010

Dec. 31, 2010

Yegor wrote: > it's my first contribution to wine... Welcome! > so I wanted to start with some simple task. Changing memory allocation might not be simple. Your patch touches two different DLLs. You should probably split this patch up, one patch per dll. Also, the fact that your change to d3dcompiler_43 only changes a malloc and not a corresponding free is interesting. Is there a leak? Better run this past the author of that code. > The source code could be compiled without problems after applying the patch. Verifying that it compiles isn't enough. You also have to verify by eye that this change doesn't introduce any alloc/free mismatches, and check that it doesn't introduce any conformance test regressions. Since not all tests pass, you need to run the tests first without your change, and then with your change, and understand any differences in the results. Since you're messin' with malloc, you should also do that with WINEDEBUG=+heap. - Dan

2 2

Re: oleview: Fix a null pointer crash
by Alexandre Julliard Dec. 31, 2010

Dec. 31, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Fix a null pointer crash This is an internal function, the caller should take care of this. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msvcrxx: Forward _setjmp on x86_64
by Alexandre Julliard Dec. 31, 2010

Dec. 31, 2010

André Hentschel <nerv(a)dawncrow.de> writes: > needed for ratGPU > --- > dlls/msvcr80/msvcr80.spec | 2 +- > dlls/msvcr90/msvcr90.spec | 2 +- Please fix all the msvcrt dlls, not just these two. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite
by Vitaliy Margolen Dec. 30, 2010

Dec. 30, 2010

On 12/30/2010 12:23 PM, Travis Athougies wrote: > Tests to ensure the HLSL compiler won't crash on malformed input. You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on with the correct style. Adding more invalid strings because file already contains some of them isn't a valid reason for broken code. Vitaliy.

2 1

Re: oledb32: Use correct 32/64-bit typedefs
by Marvin Dec. 30, 2010

Dec. 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7981 Your paranoid android. === WNT4WSSP6 (32 bit convert) === Can't copy TestLauncher to VM: Cannot connect to the virtual machine === WVISTAADM (32 bit convert) === No test summary line found === W2K8SE (32 bit convert) === No test summary line found

1 0

Re: gdi32/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 30, 2010

Dec. 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7979 Your paranoid android. === WXPPROSP3 (32 bit gdiobj) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\gdi32_test.exe === W7PRO (32 bit gdiobj) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\gdi32_test.exe === WVISTAADM (32 bit pen) === No test summary line found === W2K8SE (32 bit pen) === No test summary line found

1 0

Re: imagehlp/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 30, 2010

Dec. 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7970 Your paranoid android. === W7PRO (32 bit integrity) === No test summary line found

1 0

Re: riched32/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 30, 2010

Dec. 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7969 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W7PRO (32 bit editor) === No test summary line found

1 0

Re: mscms/tests: Fix test message
by Marvin Dec. 30, 2010

Dec. 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7968 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 30, 2010

Dec. 30, 2010

IGNORE MY LAST POST. I'm away from home and don't have my glasses with me. >Wine build complete. >susan(a)ubuntu:~/wine$ wine checkinstall >wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory > > >

1 0

Re: wininet/tests: Don't call GetLastError() twice
by Marvin Dec. 30, 2010

Dec. 30, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7966 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 30, 2010

Dec. 30, 2010

>>>>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>>>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>>>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>>>> >>contain any dwarf information >>>>> >>maybe you're loading another instance of libwine? >>>>> >>A+ >>>>> >> >>>>> >>-- >>>>> >>Eric Pouech >>>>> > >>>>> >I did a search of the file system. >>>>> > >>>>> >Under /usr/local/lib64 I have >>>>> >libwine.so (link) >>>>> >libwine.so.1 (link) >>>>> >libwine.so.1.0 >>>>> >wine [folder} >>> >>>Then I ran ldconfig on the 64-bit, and then tried wine notepad. >>>I got the following error: >>>wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory >> >>Does this 'path' exist in LD_LIBRARY_PATH or equivilent? >> >>Otherwise ld might not be able to 'find' it when starting the program. >> >>James McKenzie >> >susan(a)ubuntu:~$ ldd /usr/local/bin/wine > linux-gate.so.1 => (0xf77c6000) > libwine.so.1 => not found > libpthread.so.0 => /lib32/libpthread.so.0 (0xf778c000) > libc.so.6 => /lib32/libc.so.6 (0xf762f000) > /lib/ld-linux.so.2 (0xf77c7000) > >Eureka, I think. > Just compiled today's git. Could compile but not install. Here's the message. Wine build complete. susan(a)ubuntu:~/wine$ wine checkinstall wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory

1 0

Re: kernel32/tests: Skip some debugger tests on 64-bit
by Jacek Caban Dec. 30, 2010

Dec. 30, 2010

On 12/30/10 4:31 PM, Greg Geldorp wrote: > I get very different results for the kernel32:debugger tests depending on > which compiler I use. With VS2008, the test runs fine. With mingw64 > 4.4.1-1a (used by the TestBot build VM), the child process that's supposed > to crash keeps running, re-executing the instruction that causes the > exception (an assignment through a NULL pointer) again and again. With > mingw64 4.4.0 (used by Alexandre to build winetest.exe) the child process > terminates, but doesn't launch the debugger. FWIW here are results with GCC 4.5.1, mingw-w64 SVN: http://testbot.winehq.org/JobDetails.pl?Key=7956 It fails as well. > One other observation is that the function table in mingw64-generated > executables seems to be borked (or at least incompatible with what the > Microsoft tools expect). When running "dumpbin /unwindinfo" on > mingw64-generated executables, no unwind info is displayed. Since the > function table/unwind info is closely related to exception handling on > x64, I'm blaming the test failures on mingw64. That's not yet supported by GCC. Proper unwind info as well as SEH exception support is planned for GCC 4.6. Jacek

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 30, 2010

Dec. 30, 2010

-----Original Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: Dec 30, 2010 10:38 AM >To: Susan Cragin <susancragin(a)earthlink.net>, Marcus Meissner <marcus(a)jet.franken.de> >Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >Subject: Re: 64-bit Notepad2 crashes > >Susan Cragin <susancragin(a)earthlink.net> wrote: >>Sent: Dec 30, 2010 8:30 AM >>To: Marcus Meissner <marcus(a)jet.franken.de> >>Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >>Subject: Re: 64-bit Notepad2 crashes >> >>>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>>> >>contain any dwarf information >>>> >>maybe you're loading another instance of libwine? >>>> >>A+ >>>> >> >>>> >>-- >>>> >>Eric Pouech >>>> > >>>> >I did a search of the file system. >>>> > >>>> >Under /usr/local/lib64 I have >>>> >libwine.so (link) >>>> >libwine.so.1 (link) >>>> >libwine.so.1.0 >>>> >wine [folder} >> >>Then I ran ldconfig on the 64-bit, and then tried wine notepad. >>I got the following error: >>wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory > >Does this 'path' exist in LD_LIBRARY_PATH or equivilent? > >Otherwise ld might not be able to 'find' it when starting the program. > >James McKenzie > susan(a)ubuntu:~$ ldd /usr/local/bin/wine linux-gate.so.1 => (0xf77c6000) libwine.so.1 => not found libpthread.so.0 => /lib32/libpthread.so.0 (0xf778c000) libc.so.6 => /lib32/libc.so.6 (0xf762f000) /lib/ld-linux.so.2 (0xf77c7000) Eureka, I think.

1 0

Re: 64-bit Notepad2 crashes
by James Mckenzie Dec. 30, 2010

Dec. 30, 2010

Susan Cragin <susancragin(a)earthlink.net> wrote: >Sent: Dec 30, 2010 8:30 AM >To: Marcus Meissner <marcus(a)jet.franken.de> >Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >Subject: Re: 64-bit Notepad2 crashes > >>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>> >>contain any dwarf information >>> >>maybe you're loading another instance of libwine? >>> >>A+ >>> >> >>> >>-- >>> >>Eric Pouech >>> > >>> >I did a search of the file system. >>> > >>> >Under /usr/local/lib64 I have >>> >libwine.so (link) >>> >libwine.so.1 (link) >>> >libwine.so.1.0 >>> >wine [folder} > >Then I ran ldconfig on the 64-bit, and then tried wine notepad. >I got the following error: >wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory Does this 'path' exist in LD_LIBRARY_PATH or equivilent? Otherwise ld might not be able to 'find' it when starting the program. James McKenzie

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 30, 2010

Dec. 30, 2010

>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >> >>contain any dwarf information >> >>maybe you're loading another instance of libwine? >> >>A+ >> >> >> >>-- >> >>Eric Pouech >> > >> >I did a search of the file system. >> > >> >Under /usr/local/lib64 I have >> >libwine.so (link) >> >libwine.so.1 (link) >> >libwine.so.1.0 >> >wine [folder} >> > >> >Under /usr/local/lib64/wine I have >> >libwinecrt0.a >> >libwined3d.def >> >> I purged wine yesterday and hand-removed all wine files I could find, including my repository and prefix. >> And I downloaded yesterday's git. >> And now I'm getting a different error. >> wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory >> This error is for all wine commands, including wine --version >> >> I have the same files under /usr/local/lib64 >> but under user/local/lib64/wine I have lots of so's and def's. >> ?? > >Is /etc/ld.so.conf listing /usr/local/lib64 ? >Did you try running "ldconfig" once? > >Ciao, Marcus No, it is not listing it. It lists only: include /etc/ld.so.conf.d/*.conf Then I checked ld.so.conf.d, which is a directory containing the following conf files: GL lib32asound2 libasound2 libc x86_64-linux-gnu So, I compared those files to those generated with my 32-bit partition. The last file is replaced by the following: i686-linux-gnu.conf and i-486-linux-gnu.conf Then I ran ldconfig on the 64-bit, and then tried wine notepad. I got the following error: wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory ?Susan

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 30, 2010

Dec. 30, 2010

>> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>contain any dwarf information >>maybe you're loading another instance of libwine? >>A+ >> >>-- >>Eric Pouech > >I did a search of the file system. > >Under /usr/local/lib64 I have >libwine.so (link) >libwine.so.1 (link) >libwine.so.1.0 >wine [folder} > >Under /usr/local/lib64/wine I have >libwinecrt0.a >libwined3d.def I purged wine yesterday and hand-removed all wine files I could find, including my repository and prefix. And I downloaded yesterday's git. And now I'm getting a different error. wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory This error is for all wine commands, including wine --version I have the same files under /usr/local/lib64 but under user/local/lib64/wine I have lots of so's and def's. ??

2 1

[PATCH] JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder
by Yegor Yefremov Dec. 30, 2010

Dec. 30, 2010

Hello, it's my first contribution to wine, so I wanted to start with some simple task. After fixing the files mentioned in the attached patch, following files in dlls folder still contain malloc/free calls: dlls/ntdll/server.c: if (!(tmp_dir = malloc( p + 1 - config_dir ))) fatal_error( "out of memory\n" ); dlls/msvcrt/heap.c: * malloc (MSVCRT.@) dlls/msvcrt/tests/printf.c: str = malloc(1024); dlls/msvcrt/tests/printf.c: str = malloc(1024); dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); dlls/msvcrt/tests/heap.c: mem = malloc(0); dlls/msvcrt/tests/file.c: buffer = malloc( len * sizeof(WCHAR) ); dlls/msvcrt/tests/cpp.c: * or at program exit malloc() checking if these methods haven't been As far as I understand those files test the core functionality and should use malloc. If this is so, then malloc/free replacement for dlls is complete. The source code could be compiled without problems after applying the patch. I'm behind a firewall and couldn't clone the repository even via http (for some other projects it is functioning). That's why my patch was made with quilt. Best regards, Yegor

2 1

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 29, 2010

Dec. 29, 2010

>> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >if you've compiled wine yourself, it's strange that libwine.so doesn't >contain any dwarf information >maybe you're loading another instance of libwine? >A+ > >-- >Eric Pouech I did a search of the file system. Under /usr/local/lib64 I have libwine.so (link) libwine.so.1 (link) libwine.so.1.0 wine [folder} Under /usr/local/lib64/wine I have libwinecrt0.a libwined3d.def Do you want copies of so.1.0?

1 0

Re: shlwapi/tests: Fix typo
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7951 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msi/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7950 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: urlmon/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7948 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: comdlg32/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7933 Your paranoid android. === WVISTAADM (32 bit filedlg) === No test summary line found === W7PRO (32 bit filedlg) === No test summary line found

1 0

Re: dsound/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7930 Your paranoid android. === WVISTAADM (32 bit dsound) === No test summary line found

1 0

Re: setupapi/tests: Don't test function directly when reporting GetLastError() (try 2)
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7929 Your paranoid android. === WVISTAADM (32 bit devinst) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\setupapi_test.exe, error 32 === W7PRO (32 bit devinst) === Failure running script in VM: Exceeded timeout limit of 315 sec

1 0

Re: shlwapi/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7932 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

64-bit Notepad2 crashes
by Susan Cragin Dec. 29, 2010

Dec. 29, 2010

I just compiled today's git wine-1.3.10-82-g10b1a7e and tried to run Notepad2's 64-bit version. Below is the crash. Wine's Notepad appears to work fine. Can anyone tell if I should file a wine bug or a Notepad2 bug? I'm on Ubuntu Natty. Thanks. $ wine64 Notepad2 fixme:heap:HeapSetInformation 0x2b4000 0 0x22fce0 4 fixme:commdlg:GetFileName95 Flags 0x02000000 not yet implemented wine: Unhandled page fault on read access to 0x00000026 at address 0x7f3a9dd5cafb (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000026 in 64-bit code (0x00007f3a9dd5cafb). Register dump: rip:00007f3a9dd5cafb rsp:000000000022b470 rbp:000000000022b860 eflags:00010202 ( R- -- I - - - ) rax:0000000000000000 rbx:0000000000000026 rcx:0000000000000026 rdx:0000000000000026 rsi:000000000022bd40 rdi:0000000000000000 r8:000000000022afa0 r9:0000000000000004 r10:0000000000000000 r11:0000000000000246 r12:0000000000000001 r13:0000000000000001 r14:0000000000000000 r15:0000000000000000 Stack dump: 0x000000000022b470: 0000000000000000 0000000000000000 0x000000000022b480: 0000000000000000 0000000000000000 0x000000000022b490: 0000000000000000 0000000000000000 0x000000000022b4a0: 0000000000000000 0000000000000000 0x000000000022b4b0: 0000000000000000 0000000000000000 0x000000000022b4c0: 0000000000000000 0000000000000000 0x000000000022b4d0: 0000000000000000 0000000000000000 0x000000000022b4e0: 0000000000000000 0000000000000000 0x000000000022b4f0: 0000000000000000 0000000000000000 0x000000000022b500: 0000000000000000 0000000000000000 0x000000000022b510: 0000000000000026 000000000022bd40 0x000000000022b520: 0000000000000000 00007f3a9dd5e951 Backtrace: =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) 0x00007f3a9dd5cafb PathIsUNCW+0x7b in shlwapi: cmpw $5c,(%rbx) Modules: Module Address Debug info Name (83 modules) ELF 7b800000- 7bbb5000 Deferred kernel32<elf> \-PE 7b820000- 7bbb5000 \ kernel32 ELF 7be00000- 7c103000 Deferred <wine-loader> PE 140000000- 140167000 Deferred notepad2 ELF 7f3a978cd000- 7f3a97ae0000 Deferred msimg32<elf> \-PE 7f3a978d0000- 7f3a97ae0000 \ msimg32 ELF 7f3a97ae0000- 7f3a97ce9000 Deferred librt.so.1 ELF 7f3a97ce9000- 7f3a97eed000 Deferred libgpg-error.so.0 ELF 7f3a97eed000- 7f3a98108000 Deferred libresolv.so.2 ELF 7f3a98108000- 7f3a9830b000 Deferred libkeyutils.so.1 ELF 7f3a9830b000- 7f3a9854f000 Deferred libdbus-1.so.3 ELF 7f3a9854f000- 7f3a987c9000 Deferred libgcrypt.so.11 ELF 7f3a987c9000- 7f3a989da000 Deferred libtasn1.so.3 ELF 7f3a989da000- 7f3a98be2000 Deferred libkrb5support.so.0 ELF 7f3a98be2000- 7f3a98de6000 Deferred libcom_err.so.2 ELF 7f3a98de6000- 7f3a9900d000 Deferred libk5crypto.so.3 ELF 7f3a9900d000- 7f3a992d1000 Deferred libkrb5.so.3 ELF 7f3a992d1000- 7f3a994e2000 Deferred libavahi-client.so.3 ELF 7f3a994e2000- 7f3a996ee000 Deferred libavahi-common.so.3 ELF 7f3a996ee000- 7f3a9998f000 Deferred libgnutls.so.26 ELF 7f3a9998f000- 7f3a99bc4000 Deferred libgssapi_krb5.so.2 ELF 7f3a99bc4000- 7f3a99e14000 Deferred libcups.so.2 ELF 7f3a99e76000- 7f3a9a0b0000 Deferred uxtheme<elf> \-PE 7f3a99e80000- 7f3a9a0b0000 \ uxtheme ELF 7f3a9a0b0000- 7f3a9a2b6000 Deferred libxfixes.so.3 ELF 7f3a9a2b6000- 7f3a9a4c0000 Deferred libxcursor.so.1 ELF 7f3a9a4c0000- 7f3a9a6c3000 Deferred libxcomposite.so.1 ELF 7f3a9a6c3000- 7f3a9a8cc000 Deferred libxrandr.so.2 ELF 7f3a9a8cc000- 7f3a9aad6000 Deferred libxrender.so.1 ELF 7f3a9aad6000- 7f3a9acdc000 Deferred libxxf86vm.so.1 ELF 7f3a9acdc000- 7f3a9aedf000 Deferred libxinerama.so.1 ELF 7f3a9aedf000- 7f3a9b0e5000 Deferred libxdmcp.so.6 ELF 7f3a9b0e5000- 7f3a9b2e8000 Deferred libxau.so.6 ELF 7f3a9b2e8000- 7f3a9b505000 Deferred libxcb.so.1 ELF 7f3a9b505000- 7f3a9b70a000 Deferred libuuid.so.1 ELF 7f3a9b70a000- 7f3a9b925000 Deferred libice.so.6 ELF 7f3a9b925000- 7f3a9bc5c000 Deferred libx11.so.6 ELF 7f3a9bc5c000- 7f3a9be6e000 Deferred libxext.so.6 ELF 7f3a9be6e000- 7f3a9c076000 Deferred libsm.so.6 ELF 7f3a9c093000- 7f3a9c358000 Deferred winex11<elf> \-PE 7f3a9c0b0000- 7f3a9c358000 \ winex11 ELF 7f3a9c3c7000- 7f3a9c5f0000 Deferred libexpat.so.1 ELF 7f3a9c5f0000- 7f3a9c826000 Deferred libfontconfig.so.1 ELF 7f3a9c826000- 7f3a9ca3e000 Deferred libz.so.1 ELF 7f3a9ca3e000- 7f3a9ccc5000 Deferred libfreetype.so.6 ELF 7f3a9cce2000- 7f3a9cf24000 Deferred winspool<elf> \-PE 7f3a9ccf0000- 7f3a9cf24000 \ winspool ELF 7f3a9cf24000- 7f3a9d1e9000 Deferred comdlg32<elf> \-PE 7f3a9cf30000- 7f3a9d1e9000 \ comdlg32 ELF 7f3a9d1e9000- 7f3a9d410000 Deferred imm32<elf> \-PE 7f3a9d1f0000- 7f3a9d410000 \ imm32 ELF 7f3a9d410000- 7f3a9d6a3000 Deferred rpcrt4<elf> \-PE 7f3a9d420000- 7f3a9d6a3000 \ rpcrt4 ELF 7f3a9d6a3000- 7f3a9da23000 Deferred ole32<elf> \-PE 7f3a9d6d0000- 7f3a9da23000 \ ole32 ELF 7f3a9da23000- 7f3a9dd1e000 Deferred comctl32<elf> \-PE 7f3a9da30000- 7f3a9dd1e000 \ comctl32 ELF 7f3a9dd1e000- 7f3a9dfae000 Export shlwapi<elf> \-PE 7f3a9dd30000- 7f3a9dfae000 \ shlwapi ELF 7f3a9dfae000- 7f3a9e3e8000 Deferred shell32<elf> \-PE 7f3a9dfc0000- 7f3a9e3e8000 \ shell32 ELF 7f3a9e3e8000- 7f3a9e601000 Deferred version<elf> \-PE 7f3a9e3f0000- 7f3a9e601000 \ version ELF 7f3a9e601000- 7f3a9e87d000 Deferred advapi32<elf> \-PE 7f3a9e610000- 7f3a9e87d000 \ advapi32 ELF 7f3a9e87d000- 7f3a9eb44000 Deferred gdi32<elf> \-PE 7f3a9e890000- 7f3a9eb44000 \ gdi32 ELF 7f3a9eb44000- 7f3a9eedb000 Deferred user32<elf> \-PE 7f3a9eb60000- 7f3a9eedb000 \ user32 ELF 7f3a9f17f000- 7f3a9f38c000 Deferred libnss_files.so.2 ELF 7f3a9f38c000- 7f3a9f598000 Deferred libnss_nis.so.2 ELF 7f3a9f598000- 7f3a9f7b2000 Deferred libnsl.so.1 ELF 7f3a9f7b2000- 7f3a9f9bb000 Deferred libnss_compat.so.2 ELF 7f3a9f9bb000- 7f3a9fbd1000 Deferred libgcc_s.so.1 ELF 7f3a9fbd1000- 7f3a9fe55000 Deferred libm.so.6 ELF 7f3a9fe55000- 7f3aa0145000 Deferred ntdll<elf> \-PE 7f3a9fe70000- 7f3aa0145000 \ ntdll ELF 7f3aa0148000- 7f3aa034c000 Deferred libdl.so.2 ELF 7f3aa034c000- 7f3aa06cf000 Deferred libc.so.6 ELF 7f3aa06d0000- 7f3aa08ee000 Deferred libpthread.so.0 ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 ELF 7f3aa0c3f000- 7f3aa0e61000 Deferred ld-linux-x86-64.so.2 ELF 7fffd69ff000- 7fffd6a00000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\susan\Notepad2.exe 0000001b 0 00000009 0 <== 0000000e services.exe 00000016 0 00000015 0 00000014 0 00000010 0 0000000f 0 00000011 winedevice.exe 00000018 0 00000017 0 00000013 0 00000012 0 00000019 explorer.exe 0000001a 0 Backtrace: =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) err:seh:setup_exception stack overflow 2560 bytes in thread 0009 eip 00007f3a9fe9ce7b esp 0000000000130c00 stack 0x130000-0x131000-0x230000

3 2

Re: [PATCH 1/3 resend] jscript: Don't unescape '\v'.
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7912 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] jscript: Don't unescape '\v'.
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7908 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/3] jscript: Return 'unknown' in typeof operator for native object's values that can't be retrieved
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7909 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 29, 2010

Dec. 29, 2010

>> >On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: >> >> Stack dump: >> >> 0x000000000022b470: 0000000000000000 0000000000000000 >> >> 0x000000000022b480: 0000000000000000 0000000000000000 >> >> 0x000000000022b490: 0000000000000000 0000000000000000 >> >> 0x000000000022b4a0: 0000000000000000 0000000000000000 >> >> 0x000000000022b4b0: 0000000000000000 0000000000000000 >> >[snip] >> >> Backtrace: >> >> =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) >> > >> >The stack has been blitzed? Or is this local variables (even though >> >PathIsUNCW doesn't have any)? It's hard to know what's going on >> >without a proper stack trace. PathIsUNCW is such a small function, the >> >problem is almost certainly further up the call chain. >> >> Well, anybody up for seeing a couple of thousand lines of WINEDEBUG-+all, or should I run relay only? >> >> There used to be a place to post log files so people could look at them... but I've forgotten where it is. > >I was not able to reproduce this here on openSUSE 11.3, >using Notepad2-4.1.24-x86-64.zip from http://www.flos-freeware.ch/notepad2.html > >Is this the one you used? > >The sourcecode shows it calling PathIsUNCW just with a stackbuffer in >src/Dialog.c, which should be safe. > >Ciao, Marcus That is the one I used. To be clear about what I did, that file on the download site is an installation exe. I opened the compressed file and just used the program's exe and ini files by copying them to my home directory. I have compiled three logs, all, seh & relay, and have compressed them, and a copy of the program and ini file I used, and have downloaded all to the following. https://www.yousendit.com/download/RlRxT20zT2JYSHhjR0E9PQ I did not configure any special compiler optimizations. I am running Ubuntu's Natty 64-bit Studio with linux 2.6.37-11-generic.

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin Dec. 29, 2010

Dec. 29, 2010

-----Original Message----- >From: Austin Lund <austin.lund(a)gmail.com> >Sent: Dec 28, 2010 6:14 PM >To: Susan Cragin <susancragin(a)earthlink.net> >Cc: Wine Developers <wine-devel(a)winehq.org> >Subject: Re: 64-bit Notepad2 crashes > >On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: >> Stack dump: >> 0x000000000022b470: 0000000000000000 0000000000000000 >> 0x000000000022b480: 0000000000000000 0000000000000000 >> 0x000000000022b490: 0000000000000000 0000000000000000 >> 0x000000000022b4a0: 0000000000000000 0000000000000000 >> 0x000000000022b4b0: 0000000000000000 0000000000000000 >[snip] >> Backtrace: >> =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) > >The stack has been blitzed? Or is this local variables (even though >PathIsUNCW doesn't have any)? It's hard to know what's going on >without a proper stack trace. PathIsUNCW is such a small function, the >problem is almost certainly further up the call chain. Well, anybody up for seeing a couple of thousand lines of WINEDEBUG-+all, or should I run relay only? There used to be a place to post log files so people could look at them... but I've forgotten where it is.

2 1

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt (msvcr80, 90 and 100 benefits from this) (resend)
by Alexandre Julliard Dec. 29, 2010

Dec. 29, 2010

Arno Teigseth <arnotixe(a)gmail.com> writes: > @@ -47,9 +76,16 @@ static void __cdecl test_invalid_parameter_handler(const wchar_t *expression, > const wchar_t *function, const wchar_t *file, > unsigned line, uintptr_t arg) > { > - /* we just ignore handler calls */ > + /* we USED TO just ignore handler calls */ > + CHECK_EXPECT(invalid_parameter_handler); > + ok(expression == NULL, "expression is not NULL\n"); > + ok(function == NULL, "function is not NULL\n"); > + ok(file == NULL, "file is not NULL\n"); > + ok(line == 0, "line = %u\n", line); > + ok(arg == 0, "arg = %lx\n", (UINT_PTR)arg); msvcrt doesn't allow changing the handler. Invalid parameter tests have to be in msvcr90. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: xmllite/tests: Use an iface instead of a vtbl pointer in testinput.
by Marvin Dec. 29, 2010

Dec. 29, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7894 Your paranoid android. === WVISTAADM (32 bit reader) === No test summary line found === W7PRO (32 bit reader) === No test summary line found

2 1

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt take 4 Can't believe I forgot to commit before creating the patch...
by James Mckenzie Dec. 28, 2010

Dec. 28, 2010

Arno Teigseth <arnotixe(a)gmail.com> wrote: > You'll have to resend both parts of the patch for the testbot to recognize them. Use (resend) in the subject line for us humans. James McKenzie

1 0

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt (The function was moved from msvcr90 to msvcrt so that msvcr80, 90 and 100
by Marvin Dec. 28, 2010

Dec. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7897 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: ntdll/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 28, 2010

Dec. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7877 Your paranoid android. === W7PROX64 (32 bit exception) === No test summary line found === WVISTAADM (32 bit directory) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\ntdll_test.exe, error 32

1 0

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value [try 2]
by Alexandre Julliard Dec. 28, 2010

Dec. 28, 2010

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -49,6 +49,7 @@ echo %UNKNOWN%S > echo P%UNKNOWN% > echo P%UNKNOWN%S > echo %ERRORLEVEL > +cmd /c exit 0 > echo %ERRORLEVEL% > echo %ERRORLEVEL%%ERRORLEVEL% > echo %ERRORLEVEL%ERRORLEVEL% It already has a defined value. What is this supposed to fix? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: Implement _fcvt_s. (resend)
by Alexandre Julliard Dec. 28, 2010

Dec. 28, 2010

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > @@ -1127,9 +1127,9 @@ int CDECL _ecvt_s( char *buffer, MSVCRT_size_t length, double number, int ndigit > /* special case - inf */ > if(number == HUGE_VAL || number == -HUGE_VAL) > { > - memset(buffer, '0', ndigits); > + memset(buffer, '0', max(ndigits, 0)); > memcpy(buffer, infret, min(ndigits, sizeof(infret) - 1 ) ); > - buffer[ndigits] = '\0'; > + buffer[max(ndigits, 0)] = '\0'; You'd have to fix the memcpy too, though the whole thing doesn't make much sense if ndigits is negative. Probably needs to be rethought, with some test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/8] jscript: Ensure that the whole script is parsed
by Marvin Dec. 28, 2010

Dec. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7868 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/8] jscript: Better syntax error tests
by Marvin Dec. 28, 2010

Dec. 28, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7867 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: d3dx9_36 [patch 1/2, resend]: Implement D3DXCreateBox
by Henri Verbeet Dec. 28, 2010

Dec. 28, 2010

On 28 December 2010 11:25, David Adam <david.adam.cnrs(a)gmail.com> wrote: > > -HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 device, FLOAT width, FLOAT height, > - FLOAT depth, LPD3DXMESH* mesh, LPD3DXBUFFER* adjacency) > +/************************************************************************* > + * D3DXCreateMeshFVF > + */ > +HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 pDevice, FLOAT fWidth, FLOAT fHeight, FLOAT fDepth, LPD3DXMESH *ppMesh, LPD3DXBUFFER *ppAdjacency) Seriously.

1 0

Re: 64-bit works but Notepad takes a long time to come up, using today's git
by Susan Cragin Dec. 27, 2010

Dec. 27, 2010

>On Mon, Dec 27, 2010 at 12:41:37PM -0500, Susan Cragin wrote: >> I maybe should have filed this as a bug. >> I know Wine had a regression in 64-bit, and that such regression received a patch. >> I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. >> wine-1.3.10-48-g1288078 > > >Was the the first try or the second? >wineboot after a new version might take a bit. >It takes nearly no time here. > >Could you bisect to the slow down? Perhaps some printer stuff? > >Ciao, Marcus I think I've solved what is probably my problem. Notepad when started with the command "wine64" runs quickly. Notepad started with "wine" ran very slowly on one 64-bit partition that I've fiddled with a lot, and not at all on a cleaner 64-bit partition. Sorry for the confusion.

1 0

Re: [PATCH 1/2] mshtml: COM cleanup for the nsIWebBrowserChrome iface.
by Michael Stefaniuc Dec. 27, 2010

Dec. 27, 2010

Forgot to mention that this patch applies on top of Jacek's "mshtml: Fixed unsafe cast in CreateChromeWindow2 implementation" patch. On 12/27/2010 11:27 PM, Michael Stefaniuc wrote: > --- > dlls/mshtml/mshtml_private.h | 3 +- > dlls/mshtml/nsembed.c | 97 +++++++++++++++++++++-------------------- > dlls/mshtml/nsio.c | 8 ++-- > 3 files changed, 55 insertions(+), 53 deletions(-) bye michael

1 0

64-bit works but Notepad takes a long time to come up, using today's git
by Susan Cragin Dec. 27, 2010

Dec. 27, 2010

I maybe should have filed this as a bug. I know Wine had a regression in 64-bit, and that such regression received a patch. I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. wine-1.3.10-48-g1288078

2 1

Re: spoolss/tests: Skip tests on Win7
by Paul Vriens Dec. 27, 2010

Dec. 27, 2010

On 12/27/2010 12:35 PM, Greg Geldorp wrote: > --- > dlls/spoolss/tests/spoolss.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > But that means we will skip on Wine as well (when/if implemented). Is that OK? -- Cheers, Paul.

2 2

Re: [PATCH 2/2] jscript: Added ScriptEngine*Version functions implementation
by Marvin Dec. 27, 2010

Dec. 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7836 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] jscript: Added ScriptEngine() implementation
by Marvin Dec. 27, 2010

Dec. 27, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7835 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: mshtml: COM cleanup for the IHTMLWindow2 iface.
by Jacek Caban Dec. 27, 2010

Dec. 27, 2010

On 12/27/10 12:50 PM, Michael Stefaniuc wrote: > --- > Jacek, I don't like the usage of impl_from_IHTMLWindow2() in > HTMLWindow_invoke() as that isn't a method of the IHTMLWindow2 vtbl. Can > you please cross check that and clean it up if necessary? That's fine itself, the IUnknown passed there is defined by HTMLWindow object and it's IHTMLWindow2 iface in this case. However it can be done better and we can avoid this particular impl_from_IHTMLWindow2 call. I will send a patch after your patch will be in Git. Thanks, Jacek

1 0

Hebrew version of Wine History
by Yaron Shahrabani Dec. 27, 2010

Dec. 27, 2010

Hey, I translated the Wine History into Hebrew several weeks ago and I noticed that although the patches are in, when I click on Wine's History on the Hebrew website I'm being taken to the English version of the document in Wine's wiki. Wine's history is pretty important to the Israeli community in various aspects, can it be fixed? Kind regards, Yaron Shahrabani <Hebrew translator>

2 1

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value
by Marvin Dec. 26, 2010

Dec. 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7830 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 73 (got '0', wanted '5') batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2KPROSP4 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === WXPPROSP3 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2K3R2SESP2 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === WVISTAADM (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2K8SE (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PRO (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PROX64 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PROX64 (64 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55')

1 0

Feature Request: winefile: some way to open terminal in current folder
by Ilya Basin Dec. 26, 2010

Dec. 26, 2010

A typical scenario: - download a file with uTorrent - select "Open containing folder" - ??? - use a native program to work with the downloaded file I think, it would be convenient to add a button to start a terminal or do "xdg-open ."

1 0

None
by paulo lesgaz Dec. 25, 2010

Dec. 25, 2010

http://2nax.awardspace.com/page.php

3 2

d3dxcreatebox
by David Adam Dec. 25, 2010

Dec. 25, 2010

Hello, is there any problem with the patch for D3DXCreateBox? I think it was not commited. Thanks in advance for any feedback? A+ David

2 1

Re: [2/2]setupapi/tests: Don't test function directly when reporting GetLastError()
by Marvin Dec. 24, 2010

Dec. 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7825 Your paranoid android. === WNT4WSSP6 (32 bit misc) === No test summary line found

1 0

Re: Eryk Wieliczko : msvcrt/tests: Add _fcvt_s tests.
by Eryk Wieliczko Dec. 24, 2010

Dec. 24, 2010

Quick question: why todo_wine? Respectfully, Eryk Wieliczko 2010/12/23 Alexandre Julliard <julliard(a)winehq.org>: > Module: wine > Branch: master > Commit: b74ef16d99f3c2f7e4a0a7e453c71b6da2c70310 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=b74ef16d99f3c2f7e4a0a7e45… > > Author: Eryk Wieliczko <ewdevel(a)gmail.com> > Date: Wed Dec 22 23:10:56 2010 +0100 > > msvcrt/tests: Add _fcvt_s tests. > > --- > > dlls/msvcrt/tests/printf.c | 29 +++++++++++++++++++++++++++-- > 1 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c > index 87efd16..d32ef73 100644 > --- a/dlls/msvcrt/tests/printf.c > +++ b/dlls/msvcrt/tests/printf.c > @@ -40,6 +40,8 @@ static int (__cdecl *p__vsnwprintf_s)(wchar_t *str, size_t sizeOfBuffer, > __ms_va_list valist); > static int (__cdecl *p__ecvt_s)(char *buffer, size_t length, double number, > int ndigits, int *decpt, int *sign); > +static int (__cdecl *p__fcvt_s)(char *buffer, size_t length, double number, > + int ndigits, int *decpt, int *sign); > > static void init( void ) > { > @@ -49,6 +51,7 @@ static void init( void ) > p__vscwprintf = (void *)GetProcAddress(hmod, "_vscwprintf"); > p__vsnwprintf_s = (void *)GetProcAddress(hmod, "_vsnwprintf_s"); > p__ecvt_s = (void *)GetProcAddress(hmod, "_ecvt_s"); > + p__fcvt_s = (void *)GetProcAddress(hmod, "_fcvt_s"); > } > > static void test_sprintf( void ) > @@ -799,7 +802,7 @@ static void test_xcvt(void) > "_fcvt() decimal point wrong, got %d expected %d\n", decpt, > test_cvt_testcases[i].expdecpt_f); > ok( sign == test_cvt_testcases[i].expsign, > - "_ecvt() sign wrong, got %d expected %d\n", sign, > + "_fcvt() sign wrong, got %d expected %d\n", sign, > test_cvt_testcases[i].expsign); > } > > @@ -823,7 +826,29 @@ static void test_xcvt(void) > free(str); > } > else > - win_skip("_ecvt_s not available\n"); > + win_skip("_ecvt_s not available\n"); > + > + if (p__fcvt_s) > + { > + str = malloc(1024); > + for( i = 0; strcmp( test_cvt_testcases[i].expstr_e, "END"); i++){ > + decpt = sign = 100; > + err = p__fcvt_s(str, 1024, test_cvt_testcases[i].value, test_cvt_testcases[i].nrdigits, &decpt, &sign); > + ok(err == 0, "_fcvt_s() failed with error code %d", err); > + ok( 0 == strncmp( str, test_cvt_testcases[i].expstr_f, 15), > + "_fcvt_s() bad return, got \n'%s' expected \n'%s'\n", str, > + test_cvt_testcases[i].expstr_e); > + ok( decpt == test_cvt_testcases[i].expdecpt_f, > + "_fcvt_s() decimal point wrong, got %d expected %d\n", decpt, > + test_cvt_testcases[i].expdecpt_e); > + ok( sign == test_cvt_testcases[i].expsign, > + "_fcvt_s() sign wrong, got %d expected %d\n", sign, > + test_cvt_testcases[i].expsign); > + } > + free(str); > + } > + else > + todo_wine win_skip("_fcvt_s not available\n"); > } > > static int __cdecl _vsnwprintf_wrapper(wchar_t *str, size_t len, const wchar_t *format, ...) > > > >

2 1

Dear friend!
by paulo lesgaz Dec. 24, 2010

Dec. 24, 2010

Dear friend, How are you recently? I bought a laptop from a website: www.yedew.com last week. I have got the product. Its quality is very good and the price is competitive. They also sell phones, TV, psp, motor and so on. By the way, they import product from Korea and sell new and original products. They have good reputation and have many good feedbacks. If you need these products, look at this website will be a clever choice. I am sure you will get many surprise and benefits. Greetings!

1 0

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite
by Michael Stefaniuc Dec. 23, 2010

Dec. 23, 2010

Hello Travis, On 12/22/2010 10:31 PM, Travis Athougies wrote: > Tests to ensure the HLSL compiler won't crash on malformed input. > > --- > dlls/d3dcompiler_43/tests/hlsl.c | 87 ++++++++++++++++++++++++++++++++++++++ > 1 files changed, 87 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3dcompiler_43/tests/hlsl.c b/dlls/d3dcompiler_43/tests/hlsl.c > index 1f8e31c..a6a6099 100644 > --- a/dlls/d3dcompiler_43/tests/hlsl.c > +++ b/dlls/d3dcompiler_43/tests/hlsl.c > @@ -556,6 +556,92 @@ static void test_trig(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *quad_geo > } > } > > +static void test_fail(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *qquad_geometry, > + IDirect3DVertexShader9 *vshader_passthru) > +{ > + static const char *undefined_variable_shader = > + "float4 test(float2 pos: TEXCOORD0) : COLOR \ > + { \ > + return y; \ > + }"; please use proper C string literals. Escaping the newline is a gcc extension. You can use string literal concatenation to split the string on multiple lines. Something like this would do: "float4 test(float2 pos: TEXCOORD0) : COLOR" "{" " return y;" "}"; bye michael

3 2

(no subject)
by Greg Geldorp Dec. 23, 2010

Dec. 23, 2010

Ok, it didn't last very long, but for a brief period we had only greens for 4 different Windows versions on http://test.winehq.org, see attached screenshot. Nice to see some progress J Greg.

1 0

Re: uninstaller: Run msiexec if the WindowsInstaller value is set.
by Alexandre Julliard Dec. 23, 2010

Dec. 23, 2010

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > programs/uninstaller/main.c | 23 +++++++++++++++++++---- > 1 files changed, 19 insertions(+), 4 deletions(-) Note that appwiz.cpl will need the same change (of course uninstaller should really be calling appwiz.cpl in the first place). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] Added function _ui64tow_s to MSVCRT (sorry sent the last mail from the wrong address)
by Alexandre Julliard Dec. 23, 2010

Dec. 23, 2010

Arno Teigseth <arnotixe(a)gmail.com> writes: > --- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/string.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 46 insertions(+), 2 deletions(-) Please add it to all the msvcrt versions that need it, not only to msvcr90. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] shell32: Add IInputObject stub to ExplorerBrowser. (try 2)
by Alexandre Julliard Dec. 23, 2010

Dec. 23, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > + hr = IInputObject_TranslateAcceleratorIO(pio, &msg_a); > + todo_wine ok(hr == found ? S_OK : S_FALSE, "Got 0x%08x (%04x)\n", hr, i); That doesn't do what you want. -- Alexandre Julliard julliard(a)winehq.org

1 0

Death to win9x?
by Joerg-Cyril.Hoehle＠t-systems.com Dec. 23, 2010

Dec. 23, 2010

Dan Kegel wrote: >I'm all for removing stuff that nobody needs anymore. Who said nobody needs Win9x anymore? > I imagine there >are still a few popular older apps that will force us to keep some old >win9x behaviors around, though, so we probably won't be able >to remove the 'emulate win98' choice from winecfg any time soon. Probably half of the apps I bought during the last years work with Win9X. Just the other day I saw a mciSendCommand16 in a log. Well, 16bit != win9x. Is it "Death to 16bit" you meant? What's the motivation behind removing stuff *now* suddenly? Is it the perceived effort needed to fix the tests to all green colour on testbot's win9x machines? Why was this topic not discussed recently at Wineconf? It would be a very bad idea to remove win9x from testbot. We need these old systems to understand what behaviour old apps expect. And I'm very thankful to Greg for his testbot service. Without it, we would know next to nothing about win9x. The fact that a random old app works in native XP (in compatibility mode) teaches us nothing for Wine. Unless we start to run winetest in compatibility mode! I've already mentioned in the past the idea to run testbot sometimes with all broken() disabled, to assess failures on newer systems. broken() may shadow errors in the tests and lull Wine developers into wrong beliefs. Paul Vriens wrote: >The little bits and pieces we have in our code should stay as we >probably need that to cope with old apps that expect a different behavior. Actually, I've even been thinking about implementing the opposite behaviour: Old APIs are mostly used by old apps, while newer apps moved to newer ones (e.g. DirectSound, then mmdev). Therefore it would make a lot of sense to have old APIs (e.g. WINMM/MCI/VfW) mimic the behaviour observable when these apps were developed: win9x! (win3.x?) We don't even know whether MS' compatibility mode does precisely that. Regards, Jörg Höhle

7 10

Phoronix benchmarked opengl games on wine...
by Dan Kegel Dec. 22, 2010

Dec. 22, 2010

http://www.phoronix.com/scan.php?page=article&item=wine_win7_2010 "With this testing we ran eight games/benchmarks natively under Ubuntu 10.10, the Windows binaries under the stable Wine 1.2.1, the Windows binaries under the Wine 1.3.9 development snapshot, and then finally under Microsoft Windows 7 Professional. The test profiles used had included OpenArena, Urban Terror, Warsow, Nexuiz, Lightsmark, Unigine Sanctuary, Unigine Tropics, and Unigine Heaven. The OpenGL renderer was used with all of them... >From this first round of 2010 Wine vs. Ubuntu vs. Windows 7 testing it is tough to draw any conclusions. About the only conclusion to draw would be that you cannot draw any definitive conclusions about the Wine performance compared to the native performance on either Linux or Windows. ... Stay tuned for our expanded Wine testing and to see how the Linux performance compares with some more popular Windows-only Direct3D-rendered games."

1 0

Re: shell32/tests: Fix a typo
by Marvin Dec. 22, 2010

Dec. 22, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7800 Your paranoid android. === W7PROX64 (64 bit shlexec) === shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2

1 0

New winetricks 20101222: new verbs icodecs, msnasn1, opensymbol, wmi, xmllite; removed obsolete verbs audioio, dcom98, eadm, urlmon
by Dan Kegel Dec. 22, 2010

Dec. 22, 2010

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Lots of bugfixes. wsh57 now works with vb scripts. The code has undergone some spring cleaning, so watch out for regressions. (We've fixed a few already.) In particular, the audioio, dcom98, eadm, and urlmon verbs are gone, let me know if you really need those! There's a new --optin commandline option that will tells winetricks to phone home after each run with info about which verbs really get used. Please consider using this, it will help future winetricks development. (You only have to give that option once, it sticks. You can turn it off with the --optout option, or by removing ~/.cache/winetricks.) Longer Changelog: Detlef Riekenberg: wmi: new verb Andrew Nguyen: steam: install corefonts first gfw: Avoid extracting the entire Win2k SP4 redist for msasn1.dll Austin English: Always use quiet and overwrite options for unzip. (issue 196) Lots of win64 fixes audioio: removed cmake: support silent install d3dx9_xx: only extract the desired dll (faster) dotnet11: work around wine bug 25120 eadm: remove, it's useless and its sha1sum changes way too often ie6: get rid of ie6 online installer, rename ie6_full to ie6 (which works around the inseng bug), support quiet installs mono28: bump to mono 2.8.1 mono28: remove mono registry keys, they are set by default in Wine since 1.2 msxml3: fix install opensymbol: added font set_psm: should set PixelShaderMode, not RenderTargetLockMode. (Issue 197) unset_winver: wine changed version setting, so make this a synonym for winver xp vcrun2003: use the correct programfiles directory. Fixes win64 install. w_call: if the subshell fails, exit immediately, otherwise w_die() is useless winver: update how setting a windows version works. w_warn: should return 0 in case of no-gui xact: fix for WINEPREFIXes with spaces/special characters Dan Kegel: Many small changes to start obeying new coding convention. Fix a few bugs found when running on windows Fix places where paths weren't quoted (bug 179). Thanks to Roberto Neri. Add --option, --optout options to control experimental opt-in usage tracking. crypt32: it was really broken, but works now. dcom98: it's obsolete, and causes problems, so removed. dotnet30: have to set XP mode now for install to work dotnet35: improved recipe per Louis, good enough to let some apps start icodecs: brought back, thanks to Alan Alberghini for the new URL. msasn1: new verb. urlmon: remove for now wsh57: improve so wscript hello.vbs works xmllite: new verb. (Hangs at end unless you give -q)

2 2

The Windows version of the "octave --version" command exposes an uncommon X network transparency issue for wine
by Alan W. Irwin Dec. 22, 2010

Dec. 22, 2010

I have been downloading lots of free software packages for Windows that are dependencies of PLplot so that I can add additional components of PLplot for my tests of PLplot under wine. Normally, I do all such testing on an X-terminal, and wine normally works without X transparency issues for everything I have tested up to now on wine. These tests include Windows GUI installers for lots of different free software packages and PLplot device drivers that generate interactive plots for the Windows platform. I have not done any such tests for games. This just-encountered network-transparency trouble occurred for the Windows version of octave, and the reason I am bringing it up here is to find out if this is a known issue or a new bug that I should report on your bug tracker. Here are the details. I am running a 32-bit version of wine-1.3.9 that I have built and installed on Debian testing 64-bit hardware. The GUI installer for octave obtained from "http://prdownloads.sourceforge.net/octave/Octave_Windows%20-%20MinGW/Octave…" worked fine under wine (on the X-terminal). I chose everything to be default other than the install prefix location. I am also using the latest version of Windows bash from MSYS and start running it as follows wineconsole --backend=curses MinGW/msys/1.0/bin/bash.exe Under that bash if I set the PATH to include the bin directory where octave.exe resides and run octave --version directly (i.e., not from an X-terminal) I get a good result which consists of the usual GNU octave version message. If I do the same thing from my X-terminal (where all X applications like the xterm where the wineconsole command is executed are running on a remote machine over the office LAN and a local X server on the X-terminal box transparently handles the X display, keyboard, and mouse), then I get the following errors (subject to rewrapping) bash.exe-3.1$ octave --version X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 1 (X_CreateWindow) Serial number of failed request: 208 Current serial number in output stream: 210 Since a rather large number of wineconsole or wine commands I have been running recently (including the octave installer GUI itself) work without issues for an X-terminal, my working hypothesis is the Windows version of octave (which can know absolutely nothing about X) generates a special version of a normal display request to wine that wine for some reason cannot handle in a network-transparent way when translating that display request to X. Are there known network transparency issues still remaining for some small subset of the display requests translated into X by wine or is this a new X network transparency bug for wine that I should report? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) PLplot scientific plotting software package (plplot.org) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

3 3

Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.
by jacek＠codeweavers.com Dec. 22, 2010

Dec. 22, 2010

On 12/22/10 2:17 PM, David Hedberg wrote: > Hi Jacek, > On Wed, Dec 22, 2010 at 13:07, Jacek Caban<jacek(a)codeweavers.com> wrote: >>> + if(security_problem) { >>> + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, >> You shouldn't need the cast here. > I get warnings if I leave the casts out though, and I can't see any obvious problem with the declarations. Any ideas? I've read your patch wrongly, sorry. Please avoid using IUnknown_QueryService. It's an ugly named helper function and it causes confusions like mine. Explicitly QIing for IServiceProvider and calling QueryService on it is the way to go. Cheers, Jacek

1 0

Re: [PATCH 2/2] shell32: Add IInputObject stub to IExplorerBrowser.
by Alexandre Julliard Dec. 22, 2010

Dec. 22, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > + WPARAM supported_key_accels[] = { /* Win7 */ > + VK_RETURN, VK_PRIOR, VK_NEXT, VK_END, VK_HOME, VK_LEFT, VK_UP, VK_RIGHT, > + VK_DOWN, VK_F10, 0 }; > + MSG msg_a = { > + hwnd, > + supported_key_accels[1], This doesn't make sense, you should be passing a keyboard message here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.
by Jacek Caban Dec. 22, 2010

Dec. 22, 2010

Hi David, On 12/22/10 12:50 AM, David Hedberg wrote: > --- > dlls/urlmon/http.c | 99 +++++++++++++++++++++++++++++++++++++++++++++-- > dlls/urlmon/tests/url.c | 25 ++++++++++++ > 2 files changed, 120 insertions(+), 4 deletions(-) > > diff --git a/dlls/urlmon/http.c b/dlls/urlmon/http.c > index cfa2fc6..1ed5e15 100644 > --- a/dlls/urlmon/http.c > +++ b/dlls/urlmon/http.c > @@ -80,6 +80,92 @@ static LPWSTR query_http_info(HttpProtocol *This, DWORD option) > return ret; > } > > +static HRESULT handle_http_error(HttpProtocol *This, DWORD error) > +{ > + IWindowForBindingUI *wfb_ui; > + IHttpSecurity *http_security; > + BOOL security_problem; > + HRESULT hres; > + > + switch(error) { > + case ERROR_INTERNET_SEC_CERT_DATE_INVALID: > + case ERROR_INTERNET_SEC_CERT_CN_INVALID: > + case ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR: > + case ERROR_INTERNET_HTTPS_TO_HTTP_ON_REDIR: > + case ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION: > + case ERROR_INTERNET_INVALID_CA: > + case ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED: > + security_problem = TRUE; > + break; > + default: > + security_problem = FALSE; > + } > + > + if(security_problem) { > + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, You shouldn't need the cast here. > +&IID_IHttpSecurity,&IID_IHttpSecurity, (void **)&http_security); > + if(SUCCEEDED(hres)) { > + hres = IHttpSecurity_OnSecurityProblem(http_security, error); > + IHttpSecurity_Release(http_security); > + > + if(hres == S_OK || hres == E_ABORT) > + return E_ABORT; > + if(hres == RPC_E_RETRY) > + return RPC_E_RETRY; > + if(hres != S_FALSE) > + return INET_E_SECURITY_PROBLEM; > + } > + } > + > + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, > +&IID_IWindowForBindingUI,&IID_IWindowForBindingUI, (void **)&wfb_ui); Same here. > + if(SUCCEEDED(hres)) { > + HWND hwnd; > + const IID *iid_reason; > + > + if(security_problem) > + iid_reason =&IID_IHttpSecurity; > + else if(error == ERROR_INTERNET_INCORRECT_PASSWORD) > + iid_reason =&IID_IAuthenticate; > + else > + iid_reason =&IID_IWindowForBindingUI; > + > + hres = IWindowForBindingUI_GetWindow(wfb_ui, iid_reason,&hwnd); > + if(SUCCEEDED(hres)&& hwnd) > + { > + DWORD res; > + > + res = InternetErrorDlg(hwnd, This->base.request, error, > + FLAGS_ERROR_UI_FLAGS_CHANGE_OPTIONS | FLAGS_ERROR_UI_FLAGS_GENERATE_DATA, > + NULL); > + > + if(res == ERROR_INTERNET_FORCE_RETRY || res == ERROR_SUCCESS) > + hres = RPC_E_RETRY; > + else > + hres = E_FAIL; > + } > + IWindowForBindingUI_Release(wfb_ui); > + } > + > + if(hres == RPC_E_RETRY) > + return hres; > + > + switch(error) > + { > + case ERROR_INTERNET_SEC_CERT_DATE_INVALID: > + case ERROR_INTERNET_SEC_CERT_CN_INVALID: > + case ERROR_INTERNET_INVALID_CA: > + case ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED: > + return INET_E_INVALID_CERTIFICATE; > + case ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR: > + case ERROR_INTERNET_HTTPS_TO_HTTP_ON_REDIR: > + case ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION: > + return INET_E_REDIRECT_FAILED; > + default: > + return INET_E_DOWNLOAD_FAILURE; > + } > +} > + > static ULONG send_http_request(HttpProtocol *This) > { > INTERNET_BUFFERSW send_buffer = {sizeof(INTERNET_BUFFERSW)}; > @@ -282,13 +368,18 @@ static HRESULT HttpProtocol_open_request(Protocol *prot, IUri *uri, DWORD reques > if(!res) > WARN("InternetSetOption(INTERNET_OPTION_HTTP_DECODING) failed: %08x\n", GetLastError()); > > - error = send_http_request(This); > + do { > + error = send_http_request(This); > > - if(error == ERROR_IO_PENDING || error == ERROR_SUCCESS) > - return S_OK; > + if(error == ERROR_IO_PENDING || error == ERROR_SUCCESS) > + return S_OK; > + > + hres = handle_http_error(This, error); > + > + } while(hres == RPC_E_RETRY); > > WARN("HttpSendRequest failed: %d\n", error); > - return INET_E_DOWNLOAD_FAILURE; > + return hres; > } > > static HRESULT HttpProtocol_end_request(Protocol *protocol) > diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c > index 875294b..c2cf152 100644 > --- a/dlls/urlmon/tests/url.c > +++ b/dlls/urlmon/tests/url.c > @@ -91,10 +91,12 @@ DEFINE_EXPECT(QueryInterface_IInternetBindInfo); > DEFINE_EXPECT(QueryInterface_IAuthenticate); > DEFINE_EXPECT(QueryInterface_IInternetProtocol); > DEFINE_EXPECT(QueryInterface_IWindowForBindingUI); > +DEFINE_EXPECT(QueryInterface_IHttpSecurity); > DEFINE_EXPECT(QueryService_IAuthenticate); > DEFINE_EXPECT(QueryService_IInternetProtocol); > DEFINE_EXPECT(QueryService_IInternetBindInfo); > DEFINE_EXPECT(QueryService_IWindowForBindingUI); > +DEFINE_EXPECT(QueryService_IHttpSecurity); > DEFINE_EXPECT(BeginningTransaction); > DEFINE_EXPECT(OnResponse); > DEFINE_EXPECT(QueryInterface_IHttpNegotiate2); > @@ -627,6 +629,7 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, > IServiceProvider *service_provider; > IHttpNegotiate *http_negotiate; > IHttpNegotiate2 *http_negotiate2; > + IHttpSecurity *http_security; > LPWSTR ua = (LPWSTR)0xdeadbeef, accept_mimes[256]; > LPWSTR additional_headers = (LPWSTR)0xdeadbeef; > BYTE sec_id[100]; > @@ -708,6 +711,18 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, > ok(hres == E_FAIL, "GetRootSecurityId failed: %08x, expected E_FAIL\n", hres); > ok(size == no_callback ? 512 : 13, "size=%d\n", size); > > + if(!no_callback) { > + SET_EXPECT(QueryService_IHttpSecurity); > + SET_EXPECT(QueryInterface_IHttpSecurity); > + } > + hres = IServiceProvider_QueryService(service_provider,&IID_IHttpSecurity, > +&IID_IHttpSecurity, (void**)&http_security); > + ok(hres == E_NOINTERFACE, "QueryService failed: 0x%08x\n", hres); > + if(!no_callback) { > + CHECK_CALLED(QueryService_IHttpSecurity); > + CHECK_CALLED(QueryInterface_IHttpSecurity); > + } > + > IServiceProvider_Release(service_provider); > > IInternetProtocolSink_AddRef(pOIProtSink); > @@ -1212,6 +1227,11 @@ static HRESULT WINAPI ServiceProvider_QueryService(IServiceProvider *iface, > return E_NOTIMPL; > } > > + if(IsEqualGUID(&IID_IHttpSecurity, guidService)) { > + CHECK_EXPECT(QueryService_IHttpSecurity); > + return E_NOTIMPL; > + } > + > ok(0, "unexpected service %s\n", debugstr_guid(guidService)); > return E_NOINTERFACE; > } > @@ -1292,6 +1312,11 @@ static HRESULT WINAPI statusclb_QueryInterface(IBindStatusCallbackEx *iface, REF > CHECK_EXPECT2(QueryInterface_IWindowForBindingUI); > return E_NOINTERFACE; > } > + else if(IsEqualGUID(&IID_IHttpSecurity, riid)) > + { > + CHECK_EXPECT2(QueryInterface_IHttpSecurity); > + return E_NOINTERFACE; > + } > else > { > ok(0, "unexpected interface %s\n", debugstr_guid(riid)); Please add some real tests. At least a connection to an invalid certificate should be easy to achieve. Cheers, Jacek

2 1

Shell.Application
by Alexander Morozov Dec. 22, 2010

Dec. 22, 2010

Some Windows programs use Shell.Application object (sample: http://bugs.winehq.org/show_bug.cgi?id=8987) This object has IShellDispatch, IShellDispatch2, IShellDispatch3, ... interfaces (http://www.com.it-berater.org/COM/windows_shell/interfaces/IShellDispatch.h…) If IShellDispatch is sufficient for some application and I am going to add its declaration should I add IShellDispatch2, 3, ..., 5 in addition?

1 0

Re: [PATCH 5/6] urlmon: Add new on_error function to protocol vtbl.
by Jacek Caban Dec. 22, 2010

Dec. 22, 2010

Hi David On 12/22/10 12:50 AM, David Hedberg wrote: > --- > dlls/urlmon/protocol.c | 6 +++++- > dlls/urlmon/urlmon_main.h | 1 + > 2 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/dlls/urlmon/protocol.c b/dlls/urlmon/protocol.c > index 669343b..bb17453 100644 > --- a/dlls/urlmon/protocol.c > +++ b/dlls/urlmon/protocol.c > @@ -107,7 +107,11 @@ static void request_complete(Protocol *protocol, INTERNET_ASYNC_RESULT *ar) > TRACE("(%p)->(%p)\n", protocol, ar); > > if(!ar->dwResult) { > - WARN("request failed: %d\n", ar->dwError); > + if(protocol->vtbl->on_error) > + protocol->vtbl->on_error(protocol, ar->dwError); > + else > + WARN("request failed: %d\n", ar->dwError); We want it in all protocol handlers. Please add stubs (with FIXME) to all of them and remove NULL-check here. Also you will leave the object in an invalid state if we're in a middle of downloading at this point. You can limit this patch to the first request_complete notification (using FLAG_FIRST_CONTINUE_COMPLETE flag) or make sure we're doing things right. Cheers, Jacek

1 0

RE: shdocvw/tests: need to save .url before committing extra props for
by Greg Geldorp Dec. 22, 2010

Dec. 22, 2010

Discard this one, should have run the modified tests on Wine too... Greg.

1 0

Re: [PATCH 1/3] msvcrt/tests: Add _fcvt_s tests.
by Marvin Dec. 21, 2010

Dec. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7749 Your paranoid android. === W2KPROSP4 (32 bit printf) === printf: unhandled exception c0000005 at 77FCD79A === WXPPROSP3 (32 bit printf) === printf: unhandled exception c0000005 at 7C911689 === W2K3R2SESP2 (32 bit printf) === printf: unhandled exception c0000005 at 7C82CAC2

1 0

Re: sane.ds: sync resource headers
by Michael Stefaniuc Dec. 21, 2010

Dec. 21, 2010

On 12/21/2010 08:00 PM, André Hentschel wrote: > --- > dlls/sane.ds/sane_Ko.rc | 2 +- > dlls/sane.ds/sane_Ro.rc | 2 ++ > 2 files changed, 3 insertions(+), 1 deletions(-) > diff --git a/dlls/sane.ds/sane_Ro.rc b/dlls/sane.ds/sane_Ro.rc > index 5b162fd..20893a6 100644 > --- a/dlls/sane.ds/sane_Ro.rc > +++ b/dlls/sane.ds/sane_Ro.rc > @@ -1,4 +1,6 @@ > /* > + * Romanian resources for Twain > + * > * Copyright 2006 CodeWeavers, Aric Stewart > * Copyright 2008 Michael Stefaniuc > * That wasn't an omission on my part but I explicitly leave that out as that info is redundant. And people tend to forget to update that when they copy the file. bye michael

2 2

Possible problem with Natty 64-bit compile
by Susan Cragin Dec. 21, 2010

Dec. 21, 2010

I have downloaded the git, compiled and installed wine as 64-bit on the current 64-bit version of Natty. This all works fine, no errors I can see, but then it doesn't run. My executables can be found, including: /usr/local/bin/wine64 and wine64-preloader But I can't run anything. A "wine" command tells me wine isn't installed, which I guess it isn't, and "wine64" gives me a segmentation fault. Do I need a symlink? ubuntu$ wine notepad The program 'wine' can be found in the following packages: * wine-bin-unstable * wine1.2 * wine1.0 Try: sudo apt-get install <selected package> ubuntu:~$ wine64 notepad Segmentation fault ubuntu:~$

2 1

Re: kernel32/tests: Quote command line arguments that might contain spaces
by Marvin Dec. 21, 2010

Dec. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7737 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:306: Test failed: Timed out waiting for the child to crash debugger.c:320: Test failed: wrong exit code : 00000103 debugger.c:331: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtFF83.tmp': read=0 debugger.c:336: Test failed: wrong debugger argument count: -26989168 debugger.c:337: Test failed: the child and debugged pids don't match: 2644 != 2046 debugger.c:306: Test failed: Timed out waiting for the child to crash debugger.c:313: Test failed: wrong exit code : 00000103 debugger.c:331: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtD465.tmp': read=0 debugger.c:336: Test failed: wrong debugger argument count: -26989168 debugger.c:337: Test failed: the child and debugged pids don't match: 2768 != 2046 Timeout === W7PROX64 (32 bit process) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\kernel32_test.exe

1 0

Re: kernel32/tests: Remove check of environment variables against registry
by Marvin Dec. 21, 2010

Dec. 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7738 Your paranoid android. === W7PROX64 (64 bit environ) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\kernel32_test64.exe

1 0

RFC: New winetricks options --optin, --optout
by Dan Kegel Dec. 20, 2010

Dec. 20, 2010

I'm interested in which winetricks verbs people are using, mostly so I can nuke the ones that nobody cares about, but also so I can pay more attention to making sure popular ones work. So I added an --optin option to winetricks; if you give that option, winetricks will report which verbs you use. You can turn this off again with --optout. This is only in svn, not yet in the released version, and it's only a commandline thing; GUI users are currently unaffected. See http://code.google.com/p/winezeug/source/detail?r=2137 I kind of expect not many people to find that option and turn it on, so it seemed safe to add. If the community agrees, at some point I'll change the GUI to ask users on first run whether they want to help winetricks development by reporting usage information. Comments? - Dan

3 2

Re: user32/cursoricon: Fix an uninitialized pointer.
by Adam Martinson Dec. 20, 2010

Dec. 20, 2010

On 12/20/2010 01:40 PM, Adam Martinson wrote: > --- > dlls/user32/cursoricon.c | 15 +++++++++------ > 1 files changed, 9 insertions(+), 6 deletions(-) > > This is wrong, please ignore it.

1 0

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove
by Marvin Dec. 20, 2010

Dec. 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7721 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0