December 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 5/5] mshtml: Added GUID_CUSTOM_CONFIRMOBJECTSAFETY with CONFIRMSAFETYACTION_LOADOBJECT flag tests
by Marvin Dec. 9, 2010

Dec. 9, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7515 Your paranoid android. === WXPPROSP3 (32 bit script) === script.c:1462: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1393: Test failed: policy = 0, expected 3 script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1586: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1587: Test failed: policy = 0, expected 3 === WVISTAADM (32 bit script) === script.c:1462: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1393: Test failed: policy = 0, expected 3 script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1586: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1587: Test failed: policy = 0, expected 3

1 0

Re: [2/2] ntdll: Implement missing 64 bit shifts (try 2)
by Alexandre Julliard Dec. 9, 2010

Dec. 9, 2010

Mike Gibson <mike.gibson(a)storagecraft.com> writes: > @@ -144,8 +144,23 @@ LONGLONG WINAPI RtlLargeIntegerShiftRight( LONGLONG a, INT count ) > */ > LONGLONG WINAPI RtlLargeIntegerArithmeticShift( LONGLONG a, INT count ) > { > - /* FIXME: gcc does arithmetic shift here, but it may not be true on all platforms */ > - return a >> count; > +#ifdef HAVE_SIMPLE_ARITHMETIC_RIGHT_SHIFT > + return a >> count; > +#else > + /* create mask to extend the sign bit */ > + LONGLONG mask; > + mask = ( LONGLONG ) 1 << 63; > + mask &= a; > + mask >>= count; That's an arithmetic shift, you are only moving the problem. Also your calling convention for the _allsh* functions isn't correct, as a simple test case demonstrates. Do you really have an app that uses this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dsound: Standardize the COM usage in duplex.c.
by Alexandre Julliard Dec. 9, 2010

Dec. 9, 2010

Michael Stefaniuc <mstefani(a)redhat.de> writes: > --- > dlls/dsound/duplex.c | 86 ++++++++++++++++++++++++++++++------------------- > 1 files changed, 53 insertions(+), 33 deletions(-) > > diff --git a/dlls/dsound/duplex.c b/dlls/dsound/duplex.c > index 4a1fbd2..2fcf64c 100644 > --- a/dlls/dsound/duplex.c > +++ b/dlls/dsound/duplex.c > @@ -44,7 +44,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(dsound); > typedef struct IDirectSoundFullDuplexImpl > { > /* IUnknown fields */ > - const IDirectSoundFullDuplexVtbl *lpVtbl; > + IDirectSoundFullDuplex IDirectSoundFullDuplex_iface; > LONG ref; > > /* IDirectSoundFullDuplexImpl fields */ > @@ -57,23 +57,43 @@ typedef struct IDirectSoundFullDuplexImpl > } IDirectSoundFullDuplexImpl; > > typedef struct IDirectSoundFullDuplex_IUnknown { > - const IUnknownVtbl *lpVtbl; > + IUnknown IUnknown_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IUnknown; > > typedef struct IDirectSoundFullDuplex_IDirectSound8 { > - const IDirectSound8Vtbl *lpVtbl; > + IDirectSound8 IDirectSound8_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IDirectSound8; > > typedef struct IDirectSoundFullDuplex_IDirectSoundCapture { > - const IDirectSoundCaptureVtbl *lpVtbl; > + IDirectSoundCapture IDirectSoundCapture_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IDirectSoundCapture; All these objects are redundant, they should be merged. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Outlook-friendly stub for CreatePrivateObjectSecurity
by James Mckenzie Dec. 8, 2010

Dec. 8, 2010

Nick Sukharev <nicksukharev(a)gmail.com> wrote: > >Tab characters fixed. You need to resubmit as [Try 2] if you make a correction in the future in a new message, please. James McKenzie

1 0

Re: Outlook-friendly stub for CreatePrivateObjectSecurity
by Dmitry Timoshkov Dec. 8, 2010

Dec. 8, 2010

Nick Sukharev <nicksukharev(a)gmail.com> wrote: > + if (!InitializeSecurityDescriptor(*NewDescriptor, SECURITY_DESCRIPTOR_REVISION)) { > + HeapFree(GetProcessHeap(), 0, *NewDescriptor); > + return FALSE; > + } You are mixing tabs and spaces. -- Dmitry.

1 0

CreatePrivateObjectSecurity implementation
by Nick Sukharev Dec. 8, 2010

Dec. 8, 2010

I found that stub implementation for CreatePrivateObjectSecurity / DestroyPrivateObjectSecurity prevents Microsoft Exchange client from working properly. After changing these stubs to return an empty security descriptor and destroy it Exchange works much better. It can now read mail and calendar. I'm looking for suggestions what minimal implementation for these functions would be acceptable as a patch. Thank you PS. Sorry for double-post. It looks like I shouldn't be using nabble to post to wine-devel

1 0

Re: [PATCH 1/4] wineaddon.cpl: Added initial Wine Add-ons Manager stub.
by Alexandre Julliard Dec. 8, 2010

Dec. 8, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > The following series of patches is a first step towards Wine Add-ons > tool. These patches move Gecko installation to wineaddon.cpl. They do > nothing about making install code generic nor provide any new GUI yet. > They only place the code in the right place so that it can be improved > further. Is a separate control panel really the right place? It seems to me that it would be preferable if add-ons were treated more like normal packages, and in particular registered in the installed packages list. This would make it possible to manage them from the appwiz control panel, and from other tools that use install information like uninstaller. -- Alexandre Julliard julliard(a)winehq.org

9 18

Re: ntdll: Implement missing 64 bit shifts
by Alexandre Julliard Dec. 8, 2010

Dec. 8, 2010

Mike Gibson <mike.gibson(a)storagecraft.com> writes: > +/****************************************************************************** > + * _allshr (NTDLL.@) > + * > + * Right arithmetic shift a 64 bit integer > + * > + * PARAMS > + * a [I] Initial number. > + * count [I] Number of bits to shift by. > + * > + * RETURNS > + * The value of a following the shift. > + */ > +LONGLONG WINAPI _allshr( LONGLONG a, INT count ) > +{ > + return a >> count; > +} There's no guarantee that this would be an arithmetic shift, it's compiler-dependent. -- Alexandre Julliard julliard(a)winehq.org

3 2

winetricks dotnet30 install seems to be working again
by Dan Kegel Dec. 7, 2010

Dec. 7, 2010

For me, with today's winetricks from svn and wine from git, winetricks dotnet30 seems to work well. It appears to hang at the end because of http://bugs.winehq.org/show_bug.cgi?id=25059 but that's cosmetic; if you look for the icon hiding on the taskbar, you'll see the installer completed. Don't know if the resulting package works, but at least it installed for me just now once. Ship it! :-)

1 0

Re: winemenubuilder: Include icons in .url menus
by Paul Vriens Dec. 7, 2010

Dec. 7, 2010

On 12/07/2010 06:45 PM, Andrew Bogott wrote: > > This should supersede the previous version of this patch. This one plugs > a memory leak present in the last version. > Hi Andrew, The previous patch has already been committed. -- Cheers, Paul.

2 1