December 2010 - Wine-Devel - list.winehq.org

Re: user32/tests: skip more input tests on 98 and ME
by Marvin Dec. 2, 2010

Dec. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7412 Your paranoid android. === WVISTAADM (32 bit input) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: d3d8/d3d9: fix compiler warnings on non x86/x86_64
by Marvin Dec. 2, 2010

Dec. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7411 Your paranoid android. === WVISTAADM (32 bit device) === device.c:2512: Test failed: Expected foreground window 000101D6, got 000101D2. === W7PRO (32 bit device) === device.c:2512: Test failed: Expected foreground window 00020158, got 00020058. device.c:2651: Test failed: Expected foreground window 00030158, got 00020058. === W7PROX64 (64 bit device) === device.c:2512: Test failed: Expected foreground window 00000000000F0176, got 0000000000010068. device.c:2651: Test failed: Expected foreground window 0000000000100176, got 0000000000010068.

1 0

Re: d3d8/d3d9: fix compiler warnings on non x86/x86_64
by Marvin Dec. 2, 2010

Dec. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7410 Your paranoid android. === W2K8SE (32 bit device) === device.c:1671: Test failed: Expected foreground window 00010126, got 0001011A. === W7PROX64 (32 bit device) === device.c:1671: Test failed: Expected foreground window 00030186, got 00010068. device.c:1810: Test failed: Expected foreground window 00040186, got 00010068.

1 0

Re: Death to win9x?
by James Mckenzie Dec. 2, 2010

Dec. 2, 2010

Austin English <austinenglish(a)gmail.com> wrote: > >On Thu, Dec 2, 2010 at 8:00 PM, K.King <k.king177(a)ntlworld.com> wrote: >> <<< >> That's not useful. The whole point is that we don't want to spend the >> effort required to keep the tests error-free on platforms that we don't >> care about. That makes it easier to write tests for platforms that >> actually matter, which is a more productive use of everybody's time. >>>>> >> You may not care, but I know a number of people who do. >> For some running the older software is more important, of interest, or use. > >A majority of that effort is rewriting tests to make win9x happy, not >rewriting behavior to fix win9x applications. > >Few people (if any) want to intentionally break win9x applications, >but spending a large amount of developer effort to maintain the tests >there isn't really the best investment, when it could instead be spent >fixing real bugs. > This I do agree with. I'm working on tests for richedit and the expected reaction of the Win9x version is much different than the reaction of the WindowsXP version. I could drop the Win9x tests and concentrate on Windows 2000 and higher. Would this be a good course of action? James McKenzie

1 0

Re: Death to win9x?
by K.King Dec. 2, 2010

Dec. 2, 2010

<<< That's not useful. The whole point is that we don't want to spend the effort required to keep the tests error-free on platforms that we don't care about. That makes it easier to write tests for platforms that actually matter, which is a more productive use of everybody's time. >>> You may not care, but I know a number of people who do. For some running the older software is more important, of interest, or use.

2 1

Re: [PATCH 5/7] npmshtml: Added Mozilla plugin for mshtml ActiveX controls.
by Alexandre Julliard Dec. 2, 2010

Dec. 2, 2010

Jacek Caban <jacek(a)codeweavers.com> writes: > I know that this patch is the most questionable. Gecko expects us to > give it a DLL named np*.dll, so we can't do it in mshtml. Also, this > plugin will be visible to other NPAPI-based browsers running in Wine > (that's a matter of change in the next Gecko release), so it's good > that it's a tiny wrapper that fails to load if mshtml is not loaded > (meaning that we're not running in Wine Gecko). This prevents the dll registration code from running, since mshtml is not loaded at that point. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [1/2] wininet: Use proper error code define instead of its value
by Alexandre Julliard Dec. 2, 2010

Dec. 2, 2010

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -270,7 +270,7 @@ static DWORD netconn_verify_cert(PCCERT_CONTEXT cert, HCERTSTORE store, > else if (chain->TrustStatus.dwErrorStatus & ~supportedErrors) > err = ERROR_INTERNET_SEC_INVALID_CERT; > } > - if (!err) > + if (err == ERROR_SUCCESS) There's no reason to change this. 0 meaning success is a common convention, and at least as clear as using an error code for no error. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wineps.drv: return error if unable to select a builtin font
by Alexandre Julliard Dec. 2, 2010

Dec. 2, 2010

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -191,6 +191,12 @@ BOOL PSDRV_SelectBuiltinFont(PSDRV_PDEVICE *physDev, HFONT hfont, > if(!family) > family = physDev->pi->Fonts; > > + if (!family) > + { > + ERR("Unable to get any font for printer\n"); > + return FALSE; > + } If this is something that can legitimately happen it should be handled correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] shdocvw: In PersistFile_Save, output the Icon Path and Icon Index properties
by Damjan Jovanovic Dec. 2, 2010

Dec. 2, 2010

On Thu, Dec 2, 2010 at 5:39 AM, Andrew Bogott <Andrew(a)codeweavers.com> wrote: > This gets Icon Path and Icon Index written out to .url files if they've been > set previously. > > > > I think you leak a reference to pPropStgRead here. Nice patch set otherwise :-) Damjan

1 0

Re: [2/2] msi: Clear last error on success in MsiQueryFeatureState and MsiQueryProductState.
by Marvin Dec. 2, 2010

Dec. 2, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7392 Your paranoid android. === W2KPROSP4 (32 bit msi) === msi.c:618: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:633: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:646: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:666: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:677: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:695: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:705: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:716: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:727: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:736: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:972: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:979: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:994: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1004: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1028: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1037: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1046: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1055: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1064: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1086: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1095: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1104: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1114: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1124: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1134: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1144: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1154: Test failed: expected ERROR_SUCCESS, got 1008

1 0