May 2010 - Wine-Devel - list.winehq.org

Re: msvcrt (1/2): add fstat64i32
by Piotr Caban May 24, 2010

May 24, 2010

Hi, fstat64i32 and stat64i32 are not exported by native msvcrt.dll. This functions should be implemented in msvcr90. Cheers, Piotr

2 2

Release plans
by Joerg-Cyril.Hoehle＠t-systems.com May 24, 2010

May 24, 2010

Hi, >The 64-bit support is now more or less complete I hope I can finish my MCI parser patches in time. Without them, every 64bit app using MCI string commands is likely to crash (OTOH MCI commands work (those using the MCI_*_PARAMS structures)). What can Mac users expect from this release? Yesterday I installed an app with wine-1.1.44 on Mac OS (instead of moving it from a Linux install). It was disappointing from a user POV: - Wine created .desktop files that work on Linux but don't make sense on Mac OS. Here I've been thinking about a simple patch that would instead generate a .command file like I've described in the FAQ. OTOH, Steven Edwards IIRC once had a much more elaborate patch about better Mac OS integration, rejected last year. - In the hidden directory ~/.local/share/icons/ it created .xpm files that the Finder does not display. .png would be displayed. I have no idea how the other packages built atop Wine behave on MacOS behave: - Kronenberg's WineBottler - doh's WineSkin - Macports build - CodeWeaver's CrossOver4Mac I assume they create nice icons that the user can click after an install. Regarding the former 2 packages, I've always been wondering why there's some sort of split in the Wine+Mac user community. Obviously the stock Wine fails to meet the Mac user's expectations, such that several people start and write something better integrated with the GUI -- but not integrated into the Wine source. And I didn't write trivial Mac patches either, e.g. to have wineprefixcreate symlink c:\users\xyz\ Desktop + Videos + Documents + Music to /Users/xyz/Desktop/ etc. This happens on Linux, not on MacOS. That's another (example of a) missing element. (Why didn't I write it? Because I was unsure where to put the #ifdef) Regards, Jörg Höhle

5 12

Re: [PATCH 4/4] shell32: Add IShellBrowser stub to ExplorerBrowser.
by testbot＠testbot.winehq.org May 24, 2010

May 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2284 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.
by testbot＠testbot.winehq.org May 24, 2010

May 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2283 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.
by testbot＠testbot.winehq.org May 24, 2010

May 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2280 Your paranoid android. === WINEBUILD (build) === Make failed

3 2

Re: shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.
by Nikolay Sivov May 24, 2010

May 24, 2010

On 5/24/2010 16:25, David Hedberg wrote: Hi, David. > +} > + > +static ULONG WINAPI IExplorerBrowser_fnRelease(IExplorerBrowser *iface) > +{ > + ExplorerBrowserImpl *This = (ExplorerBrowserImpl*)iface; > + TRACE("This: %p\n", This); > + > + This->ref--; > + TRACE("Ref: %d\n", This->ref); > Use interlocked increment/decrement here. > + > +static HRESULT WINAPI IExplorerBrowser_fnSetRect( > + IExplorerBrowser *iface, > + HDWP *phdwp, > + RECT rcBrowser) > +{ > + ExplorerBrowserImpl *This = (ExplorerBrowserImpl*)iface; > + TRACE("This: %p\n", This); > + > + return E_NOTIMPL; > If it isn't tested to really return E_NOTIMPL you should output a FIXME() with a stub comment. }; > > diff --git a/dlls/shell32/shell32_main.h b/dlls/shell32/shell32_main.h > index 8f51850..78b37a8 100644 > --- a/dlls/shell32/shell32_main.h > +++ b/dlls/shell32/shell32_main.h > @@ -99,6 +99,7 @@ HRESULT WINAPI FolderShortcut_Constructor(IUnknown * pUnkOuter, REFIID riid, LPV > HRESULT WINAPI MyDocuments_Constructor(IUnknown * pUnkOuter, REFIID riid, LPVOID *ppv); > HRESULT WINAPI RecycleBin_Constructor(IUnknown * pUnkOuter, REFIID riif, LPVOID *ppv); > HRESULT WINAPI QueryAssociations_Constructor(IUnknown *pUnkOuter, REFIID riid, LPVOID *ppOutput); > +HRESULT WINAPI ExplorerBrowser_Constructor(IUnknown *pUnkOuter, REFIID riid, LPVOID *ppv); > extern HRESULT CPanel_GetIconLocationW(LPCITEMIDLIST, LPWSTR, UINT, int*); > HRESULT WINAPI CPanel_ExtractIconA(LPITEMIDLIST pidl, LPCSTR pszFile, UINT nIconIndex, HICON *phiconLarge, HICON *phiconSmall, UINT nIconSize); > HRESULT WINAPI CPanel_ExtractIconW(LPITEMIDLIST pidl, LPCWSTR pszFile, UINT nIconIndex, HICON *phiconLarge, HICON *phiconSmall, UINT nIconSize); > diff --git a/dlls/shell32/shellole.c b/dlls/shell32/shellole.c > index 10244fd..54ae017 100644 > --- a/dlls/shell32/shellole.c > +++ b/dlls/shell32/shellole.c > @@ -77,6 +77,7 @@ static const struct { > {&CLSID_ShellLink, IShellLink_Constructor}, > {&CLSID_UnixDosFolder, UnixDosFolder_Constructor}, > {&CLSID_UnixFolder, UnixFolder_Constructor}, > + {&CLSID_ExplorerBrowser,ExplorerBrowser_Constructor}, > {NULL, NULL} > }; > Use consistent indentation style please. > + } > + > + ZeroMemory(&rc, sizeof(RECT)); > You don't test for a rectangle later, so there's no point to initialize it. > + > + hres = IExplorerBrowser_Initialize(lpEB, hwnd,&rc, NULL); > + ok(SUCCEEDED(hres), "got (0x%08x)\n", hres); > + > + hres = IExplorerBrowser_Destroy(lpEB); > + ok(SUCCEEDED(hres), "got (0x%08x)\n", hres); > + > + /* Initialize again */ > + IExplorerBrowser_Initialize(lpEB, hwnd,&rc, NULL); > + ok(SUCCEEDED(hres), "got (0x%08x)\n", hres); > + > + /* Initialize twice */ > + IExplorerBrowser_Initialize(lpEB, hwnd,&rc, NULL); > + ok(SUCCEEDED(hres), "got (0x%08x)\n", hres); > Please avoid these HRESULT macros in tests, use explicit return values like S_OK. SUCCEEDED() hides things.

2 2

Re: [PATCH 4/4] shell32: Add IShellBrowser stub to ExplorerBrowser.
by testbot＠testbot.winehq.org May 24, 2010

May 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2281 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add IShellBrowser stub to ExplorerBrowser.
by testbot＠testbot.winehq.org May 24, 2010

May 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2279 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.
by testbot＠testbot.winehq.org May 24, 2010

May 24, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2278 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: d3drm [patch 4/4]: Put private definitions in private header
by Alexandre Julliard May 24, 2010

May 24, 2010

David Adam <david.adam.cnrs(a)gmail.com> writes: > From ee208ac901d7defe8ae5ddacfd4c65e36d290c4a Mon Sep 17 00:00:00 2001 > From: David Adam <david.adam.cnrs(a)gmail.com> > Date: Sun, 23 May 2010 05:37:35 +0200 > Subject: Put private definitions in the private header > > --- > dlls/d3drm/d3drm_private.h | 25 +++++++++++++++++++++++++ > dlls/d3drm/meshbuilder.c | 25 ------------------------- > 2 files changed, 25 insertions(+), 25 deletions(-) That's not an improvement. If the definitions are only needed in one file they should be in that file, not in a shared header. -- Alexandre Julliard julliard(a)winehq.org

1 0