June 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 2/3] shell32: Use more accurate PathIsURL instead of searching for a colon
by Alexandre Julliard June 28, 2010

June 28, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > diff --git a/dlls/shell32/shfldr_desktop.c b/dlls/shell32/shfldr_desktop.c > index 30aea3b..54d13dc 100644 > --- a/dlls/shell32/shfldr_desktop.c > +++ b/dlls/shell32/shfldr_desktop.c > @@ -193,7 +193,7 @@ static HRESULT WINAPI ISF_Desktop_fnParseDisplayName (IShellFolder2 * iface, > *ppidl = pidlTemp; > return S_OK; > } > - else if (strchrW(lpszDisplayName,':')) > + else if (PathIsURLW(lpszDisplayName)) > { A better way would be to check the result of the ParseURLW call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [hhctrl.ocx] Null pointer fix, new patch
by Dmitry Timoshkov June 28, 2010

June 28, 2010

Jaroslav Šmíd <jardasmid(a)gmail.com> wrote: > diff -urN Wine-git.orig/dlls/hhctrl.ocx/chm.c Wine-git/dlls/hhctrl.ocx/chm.c > --- Wine-git.orig/dlls/hhctrl.ocx/chm.c 2010-06-22 12:41:54.034540000 +0200 > +++ Wine-git/dlls/hhctrl.ocx/chm.c 2010-06-22 12:51:07.454541388 +0200 > @@ -238,11 +238,11 @@ > info->WinType.pszIndex = strdupW(null); > info->WinType.fsValidMembers=0; > info->WinType.fsWinProperties=HHWIN_PROP_TRI_PANE; > - info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle); > + info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle ? > info->pCHMInfo->defTitle : null); > info->WinType.dwStyles=WS_POPUP; > info->WinType.dwExStyles=0; > info->WinType.nShowState=SW_SHOW; > - info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic); > + info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic ? > info->pCHMInfo->defTopic : null); > info->WinType.curNavType=HHWIN_NAVTYPE_TOC; > return TRUE; > } The patch is wrapped. -- Dmitry.

3 2

Re: Release plans
by wylda＠volny.cz June 27, 2010

June 27, 2010

Hi, another week and Sunday gone so time for simple numbers... 340 regressions <-- release announcement 356 regressions <-- release announcement + 1week 339 regressions <-- release announcement + 2weeks(rc1) 322 regressions <-- release announcement + 3weeks(rc2) 325 regressions <-- release announcement + 4weeks 326 regressions <-- release announcement + 5weeks(rc3) List of fixed bugs on rc3 release was long and impressive. Unfortunately for regressions there is a stagnation.

4 5

How do you make x64 crosstests?
by Ilya Basin June 27, 2010

June 27, 2010

_

4 3

Re: Reg ukrainian translation update
by Michael Stefaniuc June 27, 2010

June 27, 2010

Hello Igor, On 06/27/2010 12:35 PM, Igor Paliychuk wrote: > Updated translation, changed cyrillic 'i' to latin 'i' because first one in cmd is shown as '?'. you don't need that because there is no problem with that. Wine needs a proper windows console. Try it out in "wineconsole cmd" and there it will show up correctly. bye michael

1 0

Re: [1/3] msvcrt.dll: Tests for getenv_s and _wgetenv_s
by Piotr Caban June 27, 2010

June 27, 2010

> Is there any known MSVCRT version in which getenv_s is exported and > _set_invalid_parameter_handler is not? Both under Windows Vista and Windows 7 getenv_s is exported and _set_invalid_paramter_handler is not.

1 0

Debian package backorder
by Ben Klein June 27, 2010

June 27, 2010

Unless someone wants to donate an AM2/DDR2 motherboard to me, someone is going to have to take over the packaging of Debian Stable, Testing and Unstable packages.

2 3

Re: Wine on cygwin now compiles!
by Stefan Dösinger June 27, 2010

June 27, 2010

For dx10 you just need wined3d and the client libs. Those work since quite a while without any other wine component

1 0

Re: add russian translation for winerrs messages
by Nikolay Sivov June 27, 2010

June 27, 2010

On 6/26/2010 18:23, Vitaly Lipatov wrote: > It patch adds russian translation for kernel32 windows error code descriptions This one: --- +LanguageNames=(RUS=0x419:winerr) --- should be --- +LanguageNames=(RUS=0x19:winerr) --- cause #define LANG_RUSSIAN 0x19

1 0

Re: [hhctrl.ocx] Make sure pszCaption and pszFile are never 0
by Charles Davis June 26, 2010

June 26, 2010

On Jun 26, 2010, at 2:32 PM, Jaroslav Šmíd wrote: > --- > dlls/hhctrl.ocx/chm.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/hhctrl.ocx/chm.c b/dlls/hhctrl.ocx/chm.c > index 4c85bd9..f0452fa 100644 > --- a/dlls/hhctrl.ocx/chm.c > +++ b/dlls/hhctrl.ocx/chm.c > @@ -238,11 +238,11 @@ BOOL LoadWinTypeFromCHM(HHInfo *info) > info->WinType.pszIndex = strdupW(null); > info->WinType.fsValidMembers=0; > info->WinType.fsWinProperties=HHWIN_PROP_TRI_PANE; > - info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle); > + info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle ? > info->pCHMInfo->defTitle : null); > info->WinType.dwStyles=WS_POPUP; > info->WinType.dwExStyles=0; > info->WinType.nShowState=SW_SHOW; > - info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic); > + info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic ? > info->pCHMInfo->defTopic : null); > info->WinType.curNavType=HHWIN_NAVTYPE_TOC; > return TRUE; > } Your mailer mangled the patch, such that long lines are broken into two lines. THAT is what we mean by "your patch got wrapped". We can't apply your patch in this state, so you'll have to send it again after configuring your mail client not to wrap long lines. Chip

4 4

Re: add russian translation for winerrs messages
by Paul Vriens June 26, 2010

June 26, 2010

On 06/26/2010 04:23 PM, Vitaly Lipatov wrote: > + > +LanguageNames=(RUS=0x419:winerr) > + > +MessageId=0 Hi, It looks like the file is in UTF-8 so shouldn't we need a "CodePages=(RUS=65001:0)"? -- Cheers, Paul.

1 1

Re: Please resend the fixed gcov patch by tomorrow so I can test building with it :)
by Peter Davies June 26, 2010

June 26, 2010

On 18 June 2010 01:50, Scott Ritchie <scott(a)open-vote.org> wrote: > Hey Peter, > > Was just hoping you'd make the (I believe trivial) change to your gcov > patch that Alexandre wanted and submit it by tomorrow so it creeps into > the next RC. I want to start messing around with profiled package > builds this weekend :) > > Anyway, keep up the good work! > > Thanks, > Scott Ritchie > I didn't send it because the change was so trivial (I have now). Note you will need to build wine-preloader without PGO (and with a libport.a without PGO) or you will get libc linking errors. Peter

2 2

Re: Add files generated by "make depend", PGO and gcov to .gitignore
by Alexandre Julliard June 26, 2010

June 26, 2010

Peter Davies <ultratwo(a)gmail.com> writes: > @@ -79,6 +79,9 @@ my @ignores = ( > "*.ok", > "*.res", > "*.so", > + "*.gcno", > + "*.gcov", > + "/conf*", They are not generated by a standard build so they don't belong here. Put then in your local ignore file. -- Alexandre Julliard julliard(a)winehq.org

3 2

automated stack dumps broken, just output winedbg usage message now?
by Dan Kegel June 26, 2010

June 26, 2010

Is anybody else seeing winedbg fail to generate stack dumps? I'm seeing wine: Unhandled page fault on read access to 0x00000000 at address 0xb736bd68 (thread 0009), starting debugger... Usage: winedbg [ [ --gdb ] [ prog-name [ prog-args ] | <num> | file.mdmp | --help ] on a lot of apps when they crash. Could be me, but I figured I'd ask. This is with wine-1.2-rc3.

2 1

Re: [PATCH 6/6] d3dx9: Test raw vertex data for D3DXCreateSphere.
by testbot＠testbot.winehq.org June 26, 2010

June 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2935 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 5/6] d3dx9: Add tests for D3DXCreateSphere vertex buffer description.
by testbot＠testbot.winehq.org June 26, 2010

June 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2934 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 4/6] d3dx9: Test number of vertices for D3DXCreateSphere.
by testbot＠testbot.winehq.org June 26, 2010

June 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2933 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 3/6] d3dx9: Add framework for a more sophisticated D3DXCreateSphere test.
by testbot＠testbot.winehq.org June 26, 2010

June 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2932 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 2/6] d3dx9: Add a few more tests for D3DXCreateSphere.
by testbot＠testbot.winehq.org June 26, 2010

June 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2931 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/6] d3dx9: Add stub and basic test for D3DXCreateSphere.
by testbot＠testbot.winehq.org June 26, 2010

June 26, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2930 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

structure has #pragma pack(8) in Windows SDK (AMD64) and #pragma pack(1) in wine headers
by Ilya Basin June 25, 2010

June 25, 2010

The struct in question is CSFV defined in shlobh.h. If I try to compile shell32_test for x64 using headers from windows 2008 SDK, I get assertion failure here: http://source.winehq.org/source/dlls/shell32/tests/generated.c?v=wine-1.2-r… Is it normal for wine to have different structure packing?

2 1

Tests for msvcrt
by Paul Chitescu June 25, 2010

June 25, 2010

Hi! What would be the best way of testing MSVCRT.DLL considering that many functions may or may be not present in the native version? > > /********************************************************************* > > + * getenv_s - not exported in native msvcrt > > + */ > > +int CDECL getenv_s(size_t *size, char *buffer, size_t bufLen, const char *name > Both getenv_s and _wgetenv_s are exported in native msvcrt. In older versions of MSVCRT.DLL (XP and earlier, no idea about Vista) these functions are not exported. They were added first in Visual Studio 2005 (MSVCRT80.DLL) and somehow made they way back in MSVCRT. Using LoadLibrary / GetProcAddress would fail on all older Windows platforms. It would be possible to test MSVCR80 instead but that may not be installed on the tested system. Any thoughts? Paul Chitescu

3 3

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.
by Misha Koshelev June 25, 2010

June 25, 2010

> On 24 June 2010 05:18, Misha Koshelev <misha680 at gmail.com> wrote: > > Dan suggested tests ok during code freeze so blame Dan for my patches ;) > Certainly will. wine-devel is an open mailing list, and posting is > easy. You'll probably want to check with something like "git shortlog > -s -n" if the advice you're getting is actually worth taking. The way > I see it, you have more experience with getting patches accepted > yourself. More to the point, if you look at > http://source.winehq.org/patches/, you'll see 62909 is marked as > "Deferred", so resending in a slightly different form isn't going to > help much. > > As for the patch itself, I'm not convinced there's value in having a > separate file for "Shape Drawing Functions", these are clearly mesh > constructors. I thought the original patch was mostly ok in that > regard, although there are (very) minor issues like using %d for > unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 > over simply "IDirect3DDevice9 *". Oh and the LPDIRECT3DDEVICE9's are straight from line.c tests. But I will heed your advice on the %d's Misha

2 2

Re: [PATCH 2/7] d3dx9: Add IUnknown method calls to ID3DXMesh.
by Misha Koshelev June 25, 2010

June 25, 2010

> On 24 June 2010 05:18, Misha Koshelev <misha680 at gmail.com> wrote: > > +#if !defined(__cplusplus) || defined(CINTERFACE) > > +/*** IUnknown methods ***/ > > +#define ID3DXMesh_QueryInterface(p,a,b) (p)->lpVtbl->QueryInterface(p,a,b) > > +#define ID3DXMesh_AddRef(p) (p)->lpVtbl->AddRef(p) > > +#define ID3DXMesh_Release(p) (p)->lpVtbl->Release(p) > > +#else > > +/*** IUnknown methods ***/ > > +#define ID3DXMesh_QueryInterface(p,a,b) (p)->QueryInterface(a,b) > > +#define ID3DXMesh_AddRef(p) (p)->AddRef() > > +#define ID3DXMesh_Release(p) (p)->Release() > > +#endif > > + > Which version of the DX SDK do these match? > > > ______________________________________________________________________ Ok, now here I just have to plead ignorance my apologies... If I do not declare these functions, how do I call the Release method of the appropriate interfaces? Specifically, I started looking at the test for line.c - I believe that if I create a mesh, I have to release it. I have largely been learning from this page: http://www.mvps.org/directx/articles/d3dxmesh.htm (which is DirectX 8) but it seems I have to somehow release the functions no? Also, I'm probably going to start with the D3DXCreateBox function, as I need to figure out exactly what's going on with the vertices before I delve into something as complicated as spheres ;) Thanks y'all :) Misha

2 1

(no subject)
by Misha Koshelev June 25, 2010

June 25, 2010

> On 24 June 2010 05:18, Misha Koshelev <misha680 at gmail.com> wrote: > > Dan suggested tests ok during code freeze so blame Dan for my patches ;) > Certainly will. wine-devel is an open mailing list, and posting is > easy. You'll probably want to check with something like "git shortlog > -s -n" if the advice you're getting is actually worth taking. The way > I see it, you have more experience with getting patches accepted > yourself. More to the point, if you look at > http://source.winehq.org/patches/, you'll see 62909 is marked as > "Deferred", so resending in a slightly different form isn't going to > help much. > > As for the patch itself, I'm not convinced there's value in having a > separate file for "Shape Drawing Functions", these are clearly mesh > constructors. I thought the original patch was mostly ok in that > regard, although there are (very) minor issues like using %d for > unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 > over simply "IDirect3DDevice9 *". > So I don't think I'm going to be getting much productive done with 1.2 bugs done in a single day, and the one I started working on yesterday is now fixed. So might as well start thinking about D3DX9. So here is why I thought maybe having a separate shape.c file might be good. I am very new to D3DX9 so please pardon my ignorance, but simply looking at SDK, I see: i) http://msdn.microsoft.com/en-us/library/bb172976%28v=VS.85%29.aspx Shape Drawing Functions are all defined in "D3dx9shape.h" whereas http://msdn.microsoft.com/en-us/library/bb172973%28v=VS.85%29.aspx Mesh Functions are all defined in "D3dx9mesh.h" This is not a reason to implement shape drawing functions in a separate file _per se_, but additionally: ii) all the tests in mesh.c do not rely on CreateWindow calls or Direct3DCreate9 calls whereas those for shape functions inherently will (like line.c) Thus, since I'm going to try to focus on d3dx9 stuff (hope code-freeze is over July 4th), it seems like it might be good to have a separate file. What is the argument for keeping them all in the mesh file besides that they are mesh creation functions? Thank you Misha

2 1