June 2010 - Wine-Devel - list.winehq.org

Re: [PATCH 2/3] shell32: Use more accurate PathIsURL instead of searching for a colon
by Alexandre Julliard June 28, 2010

June 28, 2010

Andrew Eikum <aeikum(a)codeweavers.com> writes: > diff --git a/dlls/shell32/shfldr_desktop.c b/dlls/shell32/shfldr_desktop.c > index 30aea3b..54d13dc 100644 > --- a/dlls/shell32/shfldr_desktop.c > +++ b/dlls/shell32/shfldr_desktop.c > @@ -193,7 +193,7 @@ static HRESULT WINAPI ISF_Desktop_fnParseDisplayName (IShellFolder2 * iface, > *ppidl = pidlTemp; > return S_OK; > } > - else if (strchrW(lpszDisplayName,':')) > + else if (PathIsURLW(lpszDisplayName)) > { A better way would be to check the result of the ParseURLW call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [hhctrl.ocx] Null pointer fix, new patch
by Dmitry Timoshkov June 27, 2010

June 27, 2010

Jaroslav Šmíd <jardasmid(a)gmail.com> wrote: > diff -urN Wine-git.orig/dlls/hhctrl.ocx/chm.c Wine-git/dlls/hhctrl.ocx/chm.c > --- Wine-git.orig/dlls/hhctrl.ocx/chm.c 2010-06-22 12:41:54.034540000 +0200 > +++ Wine-git/dlls/hhctrl.ocx/chm.c 2010-06-22 12:51:07.454541388 +0200 > @@ -238,11 +238,11 @@ > info->WinType.pszIndex = strdupW(null); > info->WinType.fsValidMembers=0; > info->WinType.fsWinProperties=HHWIN_PROP_TRI_PANE; > - info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle); > + info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle ? > info->pCHMInfo->defTitle : null); > info->WinType.dwStyles=WS_POPUP; > info->WinType.dwExStyles=0; > info->WinType.nShowState=SW_SHOW; > - info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic); > + info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic ? > info->pCHMInfo->defTopic : null); > info->WinType.curNavType=HHWIN_NAVTYPE_TOC; > return TRUE; > } The patch is wrapped. -- Dmitry.

3 2

Re: Release plans
by wylda＠volny.cz June 27, 2010

June 27, 2010

Hi, another week and Sunday gone so time for simple numbers... 340 regressions <-- release announcement 356 regressions <-- release announcement + 1week 339 regressions <-- release announcement + 2weeks(rc1) 322 regressions <-- release announcement + 3weeks(rc2) 325 regressions <-- release announcement + 4weeks 326 regressions <-- release announcement + 5weeks(rc3) List of fixed bugs on rc3 release was long and impressive. Unfortunately for regressions there is a stagnation.

4 5

How do you make x64 crosstests?
by Ilya Basin June 27, 2010

June 27, 2010

_

4 3

Re: Reg ukrainian translation update
by Michael Stefaniuc June 27, 2010

June 27, 2010

Hello Igor, On 06/27/2010 12:35 PM, Igor Paliychuk wrote: > Updated translation, changed cyrillic 'i' to latin 'i' because first one in cmd is shown as '?'. you don't need that because there is no problem with that. Wine needs a proper windows console. Try it out in "wineconsole cmd" and there it will show up correctly. bye michael

1 0

Re: [1/3] msvcrt.dll: Tests for getenv_s and _wgetenv_s
by Piotr Caban June 27, 2010

June 27, 2010

> Is there any known MSVCRT version in which getenv_s is exported and > _set_invalid_parameter_handler is not? Both under Windows Vista and Windows 7 getenv_s is exported and _set_invalid_paramter_handler is not.

1 0

Debian package backorder
by Ben Klein June 27, 2010

June 27, 2010

Unless someone wants to donate an AM2/DDR2 motherboard to me, someone is going to have to take over the packaging of Debian Stable, Testing and Unstable packages.

2 3

Re: Wine on cygwin now compiles!
by Stefan Dösinger June 27, 2010

June 27, 2010

For dx10 you just need wined3d and the client libs. Those work since quite a while without any other wine component

1 0

Re: add russian translation for winerrs messages
by Nikolay Sivov June 27, 2010

June 27, 2010

On 6/26/2010 18:23, Vitaly Lipatov wrote: > It patch adds russian translation for kernel32 windows error code descriptions This one: --- +LanguageNames=(RUS=0x419:winerr) --- should be --- +LanguageNames=(RUS=0x19:winerr) --- cause #define LANG_RUSSIAN 0x19

1 0

Re: [hhctrl.ocx] Make sure pszCaption and pszFile are never 0
by Charles Davis June 26, 2010

June 26, 2010

On Jun 26, 2010, at 2:32 PM, Jaroslav Šmíd wrote: > --- > dlls/hhctrl.ocx/chm.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/hhctrl.ocx/chm.c b/dlls/hhctrl.ocx/chm.c > index 4c85bd9..f0452fa 100644 > --- a/dlls/hhctrl.ocx/chm.c > +++ b/dlls/hhctrl.ocx/chm.c > @@ -238,11 +238,11 @@ BOOL LoadWinTypeFromCHM(HHInfo *info) > info->WinType.pszIndex = strdupW(null); > info->WinType.fsValidMembers=0; > info->WinType.fsWinProperties=HHWIN_PROP_TRI_PANE; > - info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle); > + info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle ? > info->pCHMInfo->defTitle : null); > info->WinType.dwStyles=WS_POPUP; > info->WinType.dwExStyles=0; > info->WinType.nShowState=SW_SHOW; > - info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic); > + info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic ? > info->pCHMInfo->defTopic : null); > info->WinType.curNavType=HHWIN_NAVTYPE_TOC; > return TRUE; > } Your mailer mangled the patch, such that long lines are broken into two lines. THAT is what we mean by "your patch got wrapped". We can't apply your patch in this state, so you'll have to send it again after configuring your mail client not to wrap long lines. Chip

4 4