July 2010 - Wine-Devel - list.winehq.org

Re: comdlg32: Remove the ignored common resource attributes.
by testbot＠testbot.winehq.org July 21, 2010

July 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3685 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: comctl32: Remove the ignored common resource attributes.
by testbot＠testbot.winehq.org July 21, 2010

July 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3684 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] shlwapi: Implement SHSetIniStringW
by testbot＠testbot.winehq.org July 21, 2010

July 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3668 Your paranoid android. === W98SE (32 bit ordinal) === Failure running script in VM: Exceeded timeout limit of 315 sec === W2KPROSP4 (32 bit ordinal) === ordinal.c:604: Test failed: GetShellSecurityDescriptor should fail ordinal.c:627: Test failed: returned value is not valid SD No test summary line found === WVISTAADM (32 bit ordinal) === Timeout === W2K8SE (32 bit ordinal) === Timeout === W7PRO (32 bit ordinal) === Timeout === W7PROX64 (32 bit ordinal) === Timeout === W7PROX64 (64 bit ordinal) === Timeout

1 0

Re: [PATCH 1/2] shlwapi: Implement SHGetIniStringW
by testbot＠testbot.winehq.org July 21, 2010

July 21, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3667 Your paranoid android. === W98SE (32 bit ordinal) === Failure running script in VM: Exceeded timeout limit of 315 sec === W2KPROSP4 (32 bit ordinal) === ordinal.c:603: Test failed: GetShellSecurityDescriptor should fail ordinal.c:626: Test failed: returned value is not valid SD No test summary line found === WVISTAADM (32 bit ordinal) === Timeout === W2K8SE (32 bit ordinal) === Timeout === W7PRO (32 bit ordinal) === Timeout === W7PROX64 (32 bit ordinal) === Timeout === W7PROX64 (64 bit ordinal) === Timeout

1 0

Re: winhlp32 italian translation update
by Paul Vriens July 21, 2010

July 21, 2010

Hi Davide, On 07/21/2010 11:31 PM, Davide Pizzetti wrote: > @@ -53,9 +53,9 @@ MAIN_MENU MENU LANGUAGE LANG_ITALIAN, SUBLANG_NEUTRAL Your tree is not up-to-date. The above per-resource LANGUAGE settings have been removed by 6e8c900d1960e804227e83826a529f075e09443e. -- Cheers, Paul.

1 0

Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".
by Stefan Dösinger July 21, 2010

July 21, 2010

Am 20.07.2010 um 18:51 schrieb Henri Verbeet: > - || gl_info->supported[WINE_NORMALIZED_TEXRECT]) > + || gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT]) I understand the WINE->WINED3D part - it's a wined3d specific thing, nothing wine global. But why did you add GL to the name?

2 5

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info. Henri Verbeet hverbeet at gmail.com
by Louis Lenders July 21, 2010

July 21, 2010

Hi, @Chris: thanks for the remarks, i'll adjust patch [3\4] accordingly @Henry also thanks, i made a new patch here: http://pastebin.com/y5Kv52h0 would that be ok? >I also think the wined3d call should simply >retrieve all info, d3d9ex can discard it again if it feels like it. I don't exactly get what you mean here. Currently we can't retrieve display orientation as wine's EnumDisplaySettingsExW doesn't work as expected. Once EnumDisplaySettingsExW is implemented enough (for rotated stuff), IWineD3DImpl_GetAdapterDisplayMode will pass back the correct display orientation. Is that what you meant by remark above? Regards

2 1

Re: wined3d: Add Nvidia 8800GTX detection
by Luke Bratch July 21, 2010

July 21, 2010

--- On Tue, 20/7/10, Henri Verbeet <hverbeet(a)gmail.com> wrote: > Negative on using experimental extensions I'm afraid. > Writing a proof > of concept patch is ok, of course, and I'd be willing to > review that, > but it can't go in until the extension is finalized. Note > that this > wouldn't allow you to get rid of the current code though, > you still > need a fallback. It would just allow for more accurate > reporting on > cards that do support that extension. The attached uses that experimental extension [1] to report the correct total memory for cards that support it, while sticking with the existing hard coded values and code layout for those that don't. I would appreciate any comments. Thanks Luke Bratch [1] http://developer.download.nvidia.com/opengl/specs/GL_NVX_gpu_memory_info.txt

5 8

Re: [2/6] shdocvw: Implement InterneExplorer::ExecWB
by Jacek Caban July 21, 2010

July 21, 2010

On 7/21/10 2:08 PM, Alexander Nicolaysen Sørnes wrote: > Implement InterneExplorer::ExecWB > > + if(IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, (LPVOID*)&Target) != S_OK) + { + return E_NOTIMPL; It doesn't seem like a right error code. + } else + { You don't really need else block if you return in if anyway. + HRESULT ret = IOleCommandTarget_Exec(Target,&CGID_MSHTML, cmdID, cmdexecopt, pvaIn, pvaOut); Did you test that it should use CGID_MSHTML? I'm not saying that it's wrong and writing a test for winetest would be tricky, but I'd like to know that it's somehow confirmed, esp. because you depend on it in next patches. Jacek

2 2

D3DXCreateTeapot
by Ian Macfarlane July 21, 2010

July 21, 2010

Following the question as to how to implement D3DXCreateTeapot, might I suggest making it in the form of a wine glass? Given that is unlikely to negatively affect anything (indeed the entire method does border on the ridiculous) I think it would make a nice hidden touch. Regards Ian

6 5