July 2010 - Wine-Devel - list.winehq.org

Re: kernel32: Enhance EndUpdateResource
by Alexandre Julliard July 20, 2010

July 20, 2010

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > Fixes bugs 12017 and 22812 > --- > dlls/kernel32/resource.c | 113 +++++++++++---- > dlls/kernel32/tests/resource.c | 307 > +++++++++++++++++++++++++++++++--------- > 2 files changed, 326 insertions(+), 94 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so package.c && touch package.ok package.c:7660: Test failed: Expected "", got "Z:\home\julliard\wine\wine\dlls\msi\tests\FileName9.dll" package.c:8289: Test failed: Expected "", got "Z:\home\julliard\wine\wine\dlls\msi\tests\FileName4.dll" package.c:8626: Test failed: Expected "", got "Z:\home\julliard\wine\wine\dlls\msi\tests\FileName3.dll" package.c:8905: Test failed: Expected "Z:\home\julliard\wine\wine\dlls\msi\tests\FileName3.dll", got "" make: *** [package.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/kernel32/volume
by Alexandre Julliard July 20, 2010

July 20, 2010

stephenmsmith(a)blueyonder.co.uk writes: > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 7596864..4908739 100644 > --- a/dlls/kernel32/volume.c > +++ b/dlls/kernel32/volume.c > @@ -526,10 +526,17 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len, > } > else > { > - if (!root[0] || root[1] != ':' || root[lstrlenW(root)-1] != '\\' ) > + if (!isalphaW(root[0]) || root[1] != ':' || root[lstrlenW(root)-1] != '\\') > { > - SetLastError( ERROR_INVALID_NAME ); > - return FALSE; > + WCHAR curpath[MAX_PATH],winpath[MAX_PATH]; > + GetCurrentDirectoryW(MAX_PATH,curpath); > + GetWindowsDirectoryW(winpath,MAX_PATH); > + > + if(lstrlenW(curpath) > 3 && root[0] == winpath[0]) > + { > + SetLastError( ERROR_INVALID_NAME ); > + return FALSE; > + } This clearly makes no sense, path syntax doesn't depend on the windows directory. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/5] msi: Add a test for MsiSetFeatureState.
by testbot＠testbot.winehq.org July 20, 2010

July 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3600 Your paranoid android. === W7PROX64 (32 bit package) === package.c:7603: Test failed: Expected "C:\winetest\FileName1", got "" package.c:7609: Test failed: Expected "C:\winetest\FileName2", got "" package.c:7615: Test failed: Expected "C:\winetest\FileName3", got "" package.c:7627: Test failed: Expected "C:\winetest\FileName5", got "" package.c:7633: Test failed: Expected "C:\winetest\", got "" package.c:7639: Test failed: Expected "C:\winetest\", got "" package.c:7655: Test failed: Expected "C:\winetest\FileName8.dll", got "" package.c:7666: Test failed: Expected "C:\winetest\FileName10.dll", got "" package.c:11679: Test failed: Expected "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" package.c:11706: Test failed: Expected first 3 chars of "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" package.c:11716: Test failed: Expected first 37 chars of "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" package.c:11726: Test failed: Expected "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" package.c:11758: Test failed: Expected "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" === W7PROX64 (64 bit package) === package.c:8212: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8223: Test failed: Expected "C:\winetest\", got "" package.c:8234: Test failed: Expected "C:\winetest\", got "" package.c:8284: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8295: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8304: Test failed: Expected "C:\", got "" package.c:8310: Test failed: Expected "C:\winetest\", got "" package.c:8331: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8340: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

NPTL and kthreads in the developer guide
by Peter Davies July 20, 2010

July 20, 2010

Since kthreads has now been removed, references to it in the developer's guide should presumably be removed. What about NPTL? Should discussion comparing it to kthreads be removed? Peter

1 0

Re: [2/2] winhttp: Handle errors from SSL_read.
by testbot＠testbot.winehq.org July 20, 2010

July 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3599 Your paranoid android. === W2K3R2SESP2 (32 bit winhttp) === winhttp.c:219: Test failed: WinHttpSendRequest failed: 12007

1 0

Re: [1/2] winhttp: Add a partial implementation of WINHTTP_OPTION_SECURITY_CERTIFICATE_STRUCT.
by testbot＠testbot.winehq.org July 20, 2010

July 20, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3598 Your paranoid android. === W2K3R2SESP2 (32 bit winhttp) === winhttp.c:219: Test failed: WinHttpSendRequest failed: 12007 winhttp.c:301: Test failed: WinHttpSendRequest failed: 12007 winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:323: Test failed: WinHttpReceiveResponse failed: 12017. winhttp.c:327: Test failed: WinHttpReadData failed: 12019. winhttp.c:329: Test failed: Read 0 bytes instead of 15. winhttp.c:795: Test failed: failed to send request 12007 === W7PRO (32 bit winhttp) === winhttp.c:810: Test failed: failed to send request 12030

1 0

Re: [PATCH 4/8] include: Add INameSpaceTreeControlCustomDraw interface declaration. (try 2)
by Alexandre Julliard July 20, 2010

July 20, 2010

David Hedberg <david.hedberg(a)gmail.com> writes: > +/***************************************************************************** > + * INameSpaceTreeControlCustomDraw interface > + */ > +[ > + object, > + uuid(2D3BA758-33EE-42D5-BB7B-5F3431D86C78), > + local > +] > + > +interface INameSpaceTreeControlCustomDraw : IUnknown > +{ > + typedef DWORD NSTCCUSTOMDRAW; /*FIXME*/ Why aren't you defining this properly? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/4] d3dx9: Add shift modifiers parsing to the shader assembler.
by Henri Verbeet July 20, 2010

July 20, 2010

On 20 July 2010 15:11, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + const char *shiftstrings[] = { Minor, but you should probably declare that as "static const char * const shiftstrings[]".

1 0

Re: mmio: Wrap TRACE strings with debugstr_a / debugstr_an (try 2)
by Nicolas Le Cam July 20, 2010

July 20, 2010

2010/7/20 Tim Cadogan-Cowper <tccowper(a)yahoo.com.au>: > Fixes bug 10280 (http://bugs.winehq.org/show_bug.cgi?id=10280) Thanks to Eric > Pouech for some feedback on previous attempt and to Maarten Lankhorst for > pointing out a more appropriate way to solve the mmio TRACE buffer overflow > problem. > > IDs of the previous attempt and discussion (now redundant) are 63620, 63625 and > 63725. > > Tim > > Hi Tim, Format specifiers shouldn't be necessary now that you use debugstr_an. -- Nicolas Le Cam

1 0

Re: [5/5] msi: Set feature states to the installed state if the Preselected property is not set.
by Hans Leidekker July 20, 2010

July 20, 2010

Please ignore this one.

1 0