July 2010 - Wine-Devel - list.winehq.org

re: dlls/user.exec16/user.c: Use FIXME_ONCE for quieter reports
by Dan Kegel July 18, 2010

July 18, 2010

James wrote: > This whole line of thought was rejected, at least once. Yes, but see his later patchset. I think he's now just trying to provide a uniform abstraction for the existing ad-hoc single-shot FIXMEs without adding any new ones, following Henri's advice in http://www.winehq.org/pipermail/wine-devel/2010-July/085069.html

2 1

Re:
by GOUJON Alexandre July 18, 2010

July 18, 2010

On 07/18/2010 04:17 PM, Tom Wickline wrote: > You forgot to attach the patches :) and a subjust is nice as well. > > Tom > > On Sun, Jul 18, 2010 at 6:16 PM, Alexandre Goujon > <ale.goujon(a)gmail.com <mailto:ale.goujon(a)gmail.com>> wrote: > > > Here is another big path; should fix bug #18071. > These tests crash on NT4 but I don't really know how to handle this. > I found #ifdef CRASHES_ON_NT40 in advapi32/tests/crypt.c so I'm > using it. > > I don't know if I have to do git reset before submitting another > patch so let me know. > Yeah you're right. I did "git send-email --compse out" which let me type this comment (http://source.winehq.org/patches/data/63618) explaining data/63619. Then, I git-apply'ed another patch and I did again the same command. So the http://source.winehq.org/patches/data/63621 comment is for data/6362[2-3] As you can see, data/63623 is the same patch as data/63619 : I did't do git-reset but I rm'ed out/ What I want is to add a comment to some patch before the --- dlls/advapi32/security.c | 69 ++++++++++++++++++++++++++++----------- dlls/advapi32/tests/security.c | 27 +++++++++++++++ 2 files changed, 76 insertions(+), 20 deletions(-) for instance. Any idea how to do that ?

2 1

Re: mmio: Ensure FOURCC string conversions are null-terminated.
by Eric Pouech July 18, 2010

July 18, 2010

the explanations for the bug fix look really strange all the printf use %4.4s form, which will limit output to only 4 chars, whatever the string is terminated or not so the crash doesn't come from here looking quickly at the patch, several remark arise - in the second & third modification to the TRACE call, are you sure the test to srcType is relevant (I don't have the code handy, but it may be a wrong cut & paste) - more importantly, as the %4.4s form implies a 4 char strings, the strings used in case of NULL value must be 4 characters long, instead we may get into trouble A+ 2010/7/18 Tim Cadogan-Cowper <tccowper(a)yahoo.com.au> > Three TRACE debug calls in the mmioDescend function of mmio.c attempt > to print FOURCC data, by directly casting it to LPCSTR. This is > dangerous as: (i) FOURCC data types are DWORDs, i.e. four bytes (one for > each char), with no null terminating byte (see > http://msdn.microsoft.com/en-us/library/dd375802%28VS.85%29.aspx) and > (ii) it assumes the byte order on the host architecture is little endian. > > Because the LPCSTR casts are not necessarily null-terminated there will > occasionally be buffer overflows in mmio's TRACE debug strings, with a > consequent crash to desktop and debug output beginning with > 'wine_dbg_vprintf: > debugstr buffer overflow...' For a consistent and predictable case where > this > occurs, see Bug 10280 "Oblivion: Horse Armour Crash" > (http://bugs.winehq.org/show_bug.cgi?id=10280) > > This patch fixes the problem (and any crashes caused by it) by using a > new internal function in mmio - mmioFOURCCToString - which converts FOURCC > data to strings that are correctly null-terminated and respect byte order. > I have tested with Oblivion and can confirm it fixes Bug 10280 on my > machine (ubuntu 10.04). Furthermore the patch will ensure that chunk IDs > and > fourccTypes are correctly printed in the mmio debug channel (at the moment > they are not). > > Tim > > > > > > -- -- Eric Pouech

1 0

re: Anotated 'make test' log
by Dan Kegel July 18, 2010

July 18, 2010

What problem are you trying to solve? I gather you're just plowing through the output of 'make test', looking at each bit of noise, and trying to figure out a way to improve the tests? While that's a noble quest, and I'd like to encourage people to improve the tests, it might be more productive to do so around areas of pain for users. For instance, you could look at bugs in bugzilla that have patches attached that aren't committed yet because tests are needed, and write those tests. - Dan

4 6

Re: [4/5] gameux/tests: Add creating test for IGameExplorer
by Nikolay Sivov July 18, 2010

July 18, 2010

On 7/18/2010 15:59, Mariusz Pluciński wrote: > + /* interface available up from Vista */ > + hr = CoCreateInstance(&CLSID_GameExplorer, NULL, CLSCTX_INPROC_SERVER,&IID_IGameExplorer, (LPVOID*)&ge); > + ok(ge&& hr == S_OK, "IGameExplorer creating failed (result false)\n"); > + if(ge) > + { > + IGameExplorer_Release(ge); > + } It's still better to properly skip even if automated run won't try this test cause gameux module is missing. Nice way is to try to create object inside main function of a test, before any other test_* functions and skip properly with win_skip or skip (if wine can't create it either at this point).

1 0

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)
by testbot＠testbot.winehq.org July 18, 2010

July 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3459 Your paranoid android. === WXPPROSP3 (32 bit shlview) === shlview.c:921: Test failed: Failed to subclass listview

2 1

Re: [4/5] gameux/tests: Add creating test for IGameExplorer
by testbot＠testbot.winehq.org July 18, 2010

July 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3456 Your paranoid android. === W98SE (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === WNT4WSSP6 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2KPROSP4 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === WXPPROSP3 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2K3R2SESP2 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2K8SE (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)

1 0

Re: [PATCH 1/5 try2] jscript: Fixed sort_cmp for non-string arguments.
by testbot＠testbot.winehq.org July 18, 2010

July 18, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3449 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [1/2] imagehlp: Add tests for ImageGetDigestStream
by Henri Verbeet July 18, 2010

July 18, 2010

On 17 July 2010 09:07, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > +#ifdef NONAMELESSUNION > +# define U(x) (x).u > +#else > +# define U(x) (x) > +#endif I think this is already done in wine/test.h? > +static BOOL WINAPI accumulating_stream_output(DIGEST_HANDLE handle, BYTE *pb, > + DWORD cb) "pb" can probably be const.

2 1

Re: kernel32: Enhance EndUpdateResource
by Henri Verbeet July 18, 2010

July 18, 2010

On 17 July 2010 09:06, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > + if (nt->OptionalHeader.FileAlignment <= 0) I can't comment much on the changes themselves, but FileAlignment is unsigned, so can't be < 0.

2 1