July 2010 - Wine-Devel - list.winehq.org

Sending patches for bug #22918
by Misha Koshelev July 17, 2010

July 17, 2010

Dear All: Congrats on 1.2! I have begun sending my patches from my repository: http://github.com/misha680/wine/commits/master Specifically, I have sent the first 10 patches (of approx 70 currently). I look forward to your comments/commits ;) Also, if anyone knows how to make git format-patch only output the 10 _bottom-most_ patches, please let me know. I tried: git format-patch -n --stdout origin --branches --not --remotes=upstream -10 | git imap-send (note the -10 in the command above) but that sends the 10 topmost patches, sadly :( Thanks again! Misha

6 7

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview.
by Nikolay Sivov July 17, 2010

July 17, 2010

On 7/17/2010 19:08, David Hedberg wrote: > static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT mode) > { > - IShellViewImpl *This = impl_from_IFolderView(iface); > - FIXME("(%p)->(%u), stub\n", This, mode); > - return E_NOTIMPL; > + IShellViewImpl *This = impl_from_IFolderView(iface); > + RECT rc; > + TRACE("(%p)->(%u), stub\n", This, mode); > + > + if((mode< FVM_FIRST || mode> FVM_LAST)&& > + (mode != FVM_AUTO)) > + return E_INVALIDARG; > + > + /* Destroy the previous listview */ > + ShellView_DestroyView(This); > + > + /* Change the viewmode */ > + This->FolderSettings.ViewMode = mode; > + > + /* Create a new listview */ > + ShellView_CreateView(This); > + > + /* Size the new listview properly. */ > + GetClientRect(This->hWnd,&rc); > + MoveWindow(This->hWndList, 0, 0, rc.right, rc.bottom, TRUE); > + > + return S_OK; > } Why do you think you should destroy Listview here? It's not obvious at all. I think it's only about changing style.

2 4

If we can't open a device as stereo, try mono. This is necessary for snd-usb-audio mics.
by Jeff Cook July 17, 2010

July 17, 2010

--- dlls/winealsa.drv/waveinit.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)

2 1

Re: shell32: Implement IPersistFolder2 for the desktop folder.
by Nikolay Sivov July 17, 2010

July 17, 2010

On 7/17/2010 19:08, David Hedberg wrote: > +static HRESULT WINAPI ISF_Desktop_IPersistFolder2_fnInitialize( > + IPersistFolder2 *iface, LPCITEMIDLIST pidl) > +{ > + FIXME("Not implemented.\n"); > + return E_NOTIMPL; Call it just "stub" and dump parameters please. > + > + pidl = NULL; > + hr = IPersistFolder2_GetCurFolder(ppf2,&pidl); > + ok(hr == S_OK, "got %08x\n", hr); > + ok(pidl != NULL, "pidl was NULL.\n"); > + > + IPersistFolder2_Release(ppf2); > + } You're leaking pidl here.

1 0

Re: Please remove / block user from bugzilla
by James Mckenzie July 17, 2010

July 17, 2010

>> Would it be possible to add a line to the text above the comment entry box >> (by the "do not paste logs" warning) telling people more explicitly what sorts >> of comments are appropriate, and directing them to the forum for user support? >> Yes, I know some people will ignore it anyway, but it might help cut down on the >> noise. > >As you point out, people don't read... it might be more useful to >put a length limit check so that posting a long comment requires >privileges. Maybe that could be done as simply as "if this is user's >first bug, don't let him post more than ten lines". > Dan: Rosanne and you have a good point, but I would restrict it the limit to four lines. You should be able to describe a valid bug in that space. Anything more, and it becomes an attachement. This would take care of the log file that was dropped in one bug and the 'I can't figure this out so here's five screenshots' in another. +1 to the limit for my vote. James McKenzie

6 9

Re: [PATCH 5/5] mshtml: Added IHTMLDocument3::detachEvent implementation.
by testbot＠testbot.winehq.org July 17, 2010

July 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3405 Your paranoid android. === WVISTAADM (32 bit events) === Timeout

1 0

Init mixer on cards with a single Mic control, like snd_usb_audio mics
by Jeff Cook July 17, 2010

July 17, 2010

This patch fixes bug #12706 and creates a mixer for snd-usb-audio cards, which have only a single Mic control and nothing else. Subsequent patches may be needed to make this useful depending on configuration. I am including this here for commentary before I submit to wine-patches. This is my first patchset to WINE, so please forgive and correct me if I am "doing it wrong". Thanks Jeff --- dlls/winealsa.drv/mixer.c | 58 ++++++++++++++++++++++++++++++++++----------- 1 files changed, 44 insertions(+), 14 deletions(-)

1 0

Re: [RFC PATCH 0/2] GetRasterStatus: Needs to be tested on Windows
by Florian Köberle July 17, 2010

July 17, 2010

Sorry for the big attachment, didn't realize that crosstests executables are so large.

1 1

Re: [PATCH 1/5] jscript: Fixed sort_cmp for non-string arguments.
by testbot＠testbot.winehq.org July 17, 2010

July 17, 2010

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3401 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH] WEBSITE: fixed 1.2 tarball link
by Marcus Meissner July 17, 2010

July 17, 2010

On Sat, Jul 17, 2010 at 01:21:19PM +0200, Marcus Meissner wrote: > --- > news/de/2010071601.xml | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/news/de/2010071601.xml b/news/de/2010071601.xml > index b521984..5dc2a1a 100644 > --- a/news/de/2010071601.xml > +++ b/news/de/2010071601.xml > @@ -1,10 +1,10 @@ > <news> > <date>16. Juli 2010</date> > -<title>Wine 1.2 Freigegeben</title> > +<title>Wine 1.f Freigegeben</title> gnh, forget this patch. > <body> > Das Wine Team ist stolz verk??nden zu d??rfen, dass die stabile Version Wine 1.2 freigegeben wurde. > Dieses Release repr??sentiert zwei Jahre Entwicklungsaufwand und ??ber 23000 ??nderungen. Die haupts??chlichen Highlights sind die Unterst??tzung f??r 64-Bit Programme und die neuen, auf dem Tango Standard basierten Grafiken. > Weiterhin enthalten sind viele Verbesserungen quer durch die Bank und ??ber 3000 Fehlerbehebungen. Siehe auch den <a href="{$root}/announce/1.2">Freigabevermerk</a> f??r eine Zusammenstellung gr????erer ??nderungen. > -Der Quellcode ist jetzt <a href="http://prdownloads.sourceforge.net/wine/wine-1.2-rc7.tar.bz2">verfügbar</a>. > +Der Quellcode ist jetzt <a href="http://prdownloads.sourceforge.net/wine/wine-1.2.tar.bz2">verfügbar</a>. > Binär-Downloads werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Download-Seiten</a> zur Verfügung. > </body></news> > -- > 1.5.6 > >

1 0