January 2011 - Wine-Devel - list.winehq.org

wineserver hitting kernel bug?
by André Hentschel Jan. 12, 2011

Jan. 12, 2011

Hi all, i get err:process:start_wineboot failed to start wineboot, err 1359 which of course leads to major problems, i tracked it down to server/process.c in function process_poll_event it hits the line if (event & (POLLERR | POLLHUP)) kill_process( process, 0 ) because event is 0x19 what can cause that? maybe a kernelbug? that's with ext3 and after working around https://bugs.launchpad.net/ubuntu/+source/linux-ti-omap4/+bug/697004/ yes, it is on ARM (pandaboard) uname -a : Linux panda 2.6.35-903-omap4 #19-Ubuntu SMP PREEMPT Wed Nov 17 16:11:04 UTC 2010 armv7l GNU/Linux -- Best Regards, André Hentschel

3 3

Re: windowscodecs/tests: COM cleanup for converter.c.
by Marvin Jan. 11, 2011

Jan. 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8249 Your paranoid android. === WXPPROSP3 (32 bit converter) === No test summary line found === WVISTAADM (32 bit converter) === converter: unhandled exception c0000005 at 7749794D === W2K8SE (32 bit converter) === converter: unhandled exception c0000005 at 778A8C6B

1 0

sc2 performance (was: Wine and D3D)
by Dan Kegel Jan. 11, 2011

Jan. 11, 2011

emaentra(a)ngi.it wrote: >If during my tests I set the affinity of the executable (and >subsequently all its threads) to a particular core I have to say that >core gets fully used and FPS are better than general That's interesting. what cpu, gpu, and version of wine do you have, and what is the fps before and after pinning the game to one cpu? You should use, say, the fps on launching into one of the default scenarios without touching anything so that we can get a reproducible measurement. Tell us what mouseclicks to use to replicate your measurement. Or, if you think it's needed, right after launch, select all units and have them start moving, and use the lowest fps seen during those few seconds.

3 3

AppDB: Do not upload screenshots of error messages, installers, game menus
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 11, 2011

Jan. 11, 2011

Hi, the AppDB screenshot submission pages mentions this rule - Do not upload screenshots of error messages, installers, game menus yet it is continuously violated and e.g. screenshots of game menus are accepted, including recently. Is it still a useful rule? If yes, should matching screenshots be removed? While we are at it, should there be a rule about accepting or not screenshots showing bugs such as graphical artefacts? Probably it's better to have a screenshot with bugs than have none. Just curious, Jörg Höhle

3 3

re: crypt32: Fix Quote-Handling (try 2)
by Juan Lang Jan. 11, 2011

Jan. 11, 2011

Hi Christian, on second thought I don't have too much to say about this, other than style comments: take them or leave them. +/* Only use this function internally. */ This comment isn't all that useful. You might indicate that quotes are only needed by CertNameToStr when the string type is CERT_X500_NAME_STR, but that might be clear enough from the code. Also, since CertRDNValueToStr doesn't need quote_string, you should probably invert the order in which they appear in the file. Thanks, --Juan

2 2

Re: crypt32: Added Quoting-Tests
by Juan Lang Jan. 11, 2011

Jan. 11, 2011

Hi Christian, -static BYTE bin1[] = { 0x55, 0x53 }; -static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74, +static BYTE bin1[] = { 0x55, 0x53 }; +static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74, 0x61 }; Please don't introduce whitespace-only changes, it's harder to see what your patch is doing. + { "0", CERT_RDN_PRINTABLE_STRING, + { sizeof(bin9), bin9 }, "abc\"def" }, Since these changes pass on unpatched wine, they don't demonstrate the necessity for your patch. We need tests that show what the existing problem is. --Juan

2 5

Re: advapi32: Only attempt multibyte conversion in SetEntriesInAclA when ptstrName is a string.
by Alexandre Julliard Jan. 11, 2011

Jan. 11, 2011

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > dlls/advapi32/security.c | 19 ++++++++++++------- > 1 files changed, 12 insertions(+), 7 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so security.c && touch security.ok security.c:1449: Tests skipped: Well known SIDs starting from 62 are not implemented security.c:2681: Test failed: SetEntriesInAclA failed: 87 security.c:2682: Test failed: returned acl was NULL security.c:2694: Test failed: SetEntriesInAclA failed: 87 security.c:2695: Test failed: returned acl was NULL security.c:2720: Test failed: SetEntriesInAclA failed: 87 security.c:2721: Test failed: returned acl was NULL security.c:2728: Test failed: SetEntriesInAclA failed: 87 security.c:2729: Test failed: returned acl was NULL make[1]: *** [security.ok] Error 8 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] comctl32/rebar: Implemented dragging between rows
by Joris Huizer Jan. 11, 2011

Jan. 11, 2011

Hello, In this patch, in function REBAR_HandleUDDrag: + if(yOff < 0) + { + /* Place the band above the current top row */ + DPA_DeletePtr(infoPtr->bands, iHitBand); + hitBand->fStyle &= RBBS_BREAK; + REBAR_GetBand(infoPtr, 0)->fStyle |= RBBS_BREAK; + infoPtr->iGrabbedBand = DPA_InsertPtr( + infoPtr->bands, 0, hitBand); + } It looks like that should have been: hitBand->fStyle &= ~RBBS_BREAK; HTH, Joris

1 0

Re: [4/7] kernel32/tests: Demonstrate an input event handling peculiarity with WriteConsoleInputW.
by Eric Pouech Jan. 11, 2011

Jan. 11, 2011

Hi Andrew, I think the test should be enhanced by checking the information about mouse position it seems that windows coalesce two mouse messages, but does it also occur when the position is different (a cursory look seems to indicate that you resend the same coordinate for mouse move) I'd expect coalesce operation to happen only if coordinates are the same A+ 2011/1/11 Andrew Nguyen <anguyen(a)codeweavers.com> > --- > dlls/kernel32/tests/console.c | 165 > +++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 159 insertions(+), 6 deletions(-) > > > > > > > -- -- Eric Pouech

2 1

Re: po: Fix rc->po misconverted iccvid French translation
by Alexandre Julliard Jan. 11, 2011

Jan. 11, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > --- > po/fr.po | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) There are many more issues to fix. One of the motivations for po files is to reduce the patch churn caused by translations, so please don't send a separate patch for each string, do a review pass over the whole file and fix everything you can. The po format makes it easy to find places that need work. -- Alexandre Julliard julliard(a)winehq.org

2 2