January 2011 - Wine-Devel - list.winehq.org

Re: [3/7] kernel32: Improve parameter validation for ReadConsoleOutputAttribute.
by Marvin Jan. 11, 2011

Jan. 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8233 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: fusion/tests: Add some tests for IAssemblyCache_QueryAssemblyInfo.
by Marvin Jan. 11, 2011

Jan. 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8223 Your paranoid android. === W7PROX64 (32 bit asmcache) === No test summary line found

1 0

Re: gdiplus: Support for indexed formats in GdipBitmapSetPixel
by Paul Vriens Jan. 11, 2011

Jan. 11, 2011

On 01/11/2011 02:26 AM, MP wrote: > + case PixelFormat8bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; > + case PixelFormat4bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; > + case PixelFormat1bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; Hi, Didn't check the other part of the patch for correctness but you are calling the same function here for 3 different formats. -- Cheers, Paul.

1 0

Re: crypt32: Fix Quote-Handling
by Juan Lang Jan. 10, 2011

Jan. 10, 2011

Hi Christian, > As tested on Windows(R) 7 Home Premium x64, "CertRDNValueToStr" Doesn't > handle the quoting. > Instead it's made on "CertNameToStr" with CERT_X500_NAME_STR flag. Adding tests that demonstrate that would help a great deal. A minor comment regarding the patch itself: +/* Only use this function internally. */ +static DWORD QuoteCertRDNValueToStrA(DWORD dwValueType, PCERT_RDN_VALUE_BLOB pValue, Don't use Hungarian notation for internal functions, it's hard to distinguish them from Win32 API functions. --Juan

2 1

Re: makefiles: Ignore mo files
by Alexandre Julliard Jan. 10, 2011

Jan. 10, 2011

Luca Bennati <lucak3(a)gmail.com> writes: > They get automatically generated if you use poedit to translate This should go in your local config, .gitignore is for files generated by the standard build process. -- Alexandre Julliard julliard(a)winehq.org

1 0

Spammer on Wike
by Vitaliy Margolen Jan. 9, 2011

Jan. 9, 2011

Would Wiki admin please ban 201.21.186.95 ip? This user been spamming for the past several days. Vitaliy.

1 0

user32/test failing in cursoricon with proper results
by James Mckenzie Jan. 9, 2011

Jan. 9, 2011

All: I just ran the user32 tests to validate what I am seeing with my richedit test in progress but the test failed in the cursoricon check with valid results. Before I open a bug report, can anyone on a Mac validate that they receive 23 errors with valid test results? Thank you. James McKenzie

2 1

Re: Wine and D3D
by Emanuele Oriani Jan. 9, 2011

Jan. 9, 2011

Hi Stefan, First of all thanks for the answer. It's a shame you lost that presentation, but it'd be great if you could in some way point out what are the current issues and where we spend CPU time (did I understand correctly). I don't have much free time, but would be more than happy to contribute as much as I can. About SC2 specifically, how do I execute the +d3d9,tid command line? Keep in mind SC2.exe is a (child detached) process spawned by the 'parent' launcher (it's not so straightforward to execute it without launcher because of dlls and other stuff) so would it be like: wine +d3d9,tid SC2Switcher.exe (where SC2Switcher.exe is the launcher)? More information about the CPU usage. If during my tests I set the affinity of the executable (and subsequently all its threads) to a particular core I have to say that core gets fully used and FPS are better than general... apparently with multiple cores set the OS tries to balance the workload, thus decreasing the FPS. I'll be looking into dlls/wined3d/context.c as well. Thanks again, Cheers, Ps. When I said multiple threads directly invoke SleepEx, didn't mean it's a bad thing, just we have like 10+ threads which are inactive 95~99% of the time... and themselves set into this state I reckon. On 08/01/11 23:20, Stefan Dösinger wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > I am afraid some of your conclusions are not correct, more about that at the end of the mail. Basically most of the performance issues are caused by wined3d and the opengl driver requiring too much CPU time. That slows down the game as-is, and means that the GPU can never live up to its full potential(except if you have a really weak GPU). > > Unfortunately that is not one single bug, but rather 10-15 issues that sum up - and that is just covering the simplest possible rendering cases(just draw a few vertices), by adding extra stuff like textures, dynamic resources, render target switches, etc there will be many more. Fixing that will require a lot of work. > > I gave a talk about this topic at wineconf 2010, but unfortunately there was no recording and I even lost my slides. However, one thing survived: My very basic drawprim benchmark at https://84.112.174.163/git/?p=perftest;a=summary (self-signed certificate). With it you can benchmark how fast wine can dispatch draw calls and optimize this very basic functionality. Once this benchmark is fixed we'll have to write many more for other d3d features(shader changes, resource loading, texture changes, thread switching, etc etc etc). So it is a lot of work. Coding help is always welcome of course :-) > > Cheers, > Stefan > > Am 08.01.2011 um 19:34 schrieb Emanuele Oriani: >> My fear is that Blizzard has introduced some sort of FPS limit and probably wine doesn't cope very well with that. >> >> And, potentially they're using multi-threaded rendering as well. > Not as far as I know, but it is easy to check: Run the game with +d3d9,+tid and see if there are d3d drawing calls from multiple threads. If the game switches threads every now and then I wouldn't count it as multithreaded, if it constantly calls d3d from more than one thread it is multithreaded. >> I've done some thread analysis and apparently the many threads the game execute stay in sleep (they actively invoke SleepEx) for 95% of the time, which is very strange. > No, not necessarily. The threads may be waiting for something, e.g. user input or network messages. Waiting threads don't have to be a bug, quite to the contrary. > >> This is why if we leave the CPU frequency in 'Ondemand' mode it goes to 800MHz (or the lowest frequency). >> Could it be related to the rendering infrastructure? > I doubt it, I guess that depends on the cpufreq settings and your CPU. I'd expect cpufreq to clock down all but one core. > >> I know OpenGL is essentially mono-threaded (I've used it for quite a bit in the past years). >> During some research I came across a Stefan's email from July 2006, were he was proposing the right thing (imho) to do to support multi-threaded D3D: a GL rendered thread per device/buffer. >> What happened with that? >> How is currently multi-threaded D3D rendering implemented in wine? > It is implemented pretty much in the way I outlined it in 2006. dlls/wined3d/context.c is responsible for multithreading, see context_acquire() and context_release(). > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG/MacGPG2 v2.0.16 (Darwin) > > iQIcBAEBAgAGBQJNKPE3AAoJEN0/YqbEcdMwo9EP/jfJyeZlVx0AsHoxWLtZ77OV > ttBwCsIKs4IqJyJXgv8hNkeNQaDwk0QoJqxHkw/2AlGDO2sdaNR9EGbRMTmtH3OP > 8x+UeiEntJRP3zHamxRxCus6F86cEqfca9PV/PYiVLSCdIb7v2i091n4z6o2nk7t > b5yutdJsMx7jgH1QLCluS2dWs50SgFw/UXgs3nTGmg0vPefhDd4846uBKgi+yCL9 > Ol5RcRz8N8VxD3dJTCgjKt8kPxlIRFiIB9Og3F9T4UowmVMTiYKvuJ/TTz/jAgTe > zHzNqwNjSXScupRTFWV9EesJZKkYY5+GO0JVX1OXMWbeWG0vdmgaAsUhkLc4PHIF > kFUdAnx9uOlu//F5opL9LGzwiyTfsAXNVstEs7m1jCpBoed80OfZMFNY0wH5wN9h > 3c5kWIY1UoIaWkeMNLt+O3k6Xwsbfl0UAo6tgBxzx6sBff6MNxzCR6mZdz+hwhE7 > eekK3N+r5nvOp9yuCQTdm+PEoaH/uPRPTqt2Z8zhABeZMdrzjcXghWRc+7dkwFic > nw7qKEGoXW0zt+p58HAM8PbhMlhp6L784U3/Td11y7moXlcPh7MiaUcgYq1kBALf > nOaBinWgGmzhvU5ub6l6HwAMpZl6MEKn0GeHBUMBuLhEgYdXG/l7K4hxXgYvyulg > ySRGDcxFEqJezQPHNg9w > =diUG > -----END PGP SIGNATURE----- >

2 1

ntdll/cdrom : implement CDROM_Verify to work on Mac Os
by maury loïc Jan. 9, 2011

Jan. 9, 2011

Hello, it's my first patch, and it implement the CDROM_Verify() to work on Mac Os. merci Loïc --- dlls/ntdll/cdrom.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..185f397 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,8 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

3 3

Re: [1/1][user32.dll]Adding Arabic Translation resources
by Yaron Shahrabani Jan. 9, 2011

Jan. 9, 2011

Hi Nowres, just looked at your patch, there are some things missing, when you translate a dialog you should add EXSTYLE WS_EX_LAYOUTRTL. For example, instead of this header: +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "إخ&تيار النافذة" +FONT 8, "MS Shell Dlg" It should be like this: +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +EXSTYLE WS_EX_LAYOUTRTL +CAPTION "إخ&تيار النافذة" +FONT 8, "MS Shell Dlg" Kind regards, Yaron Shahrabani <Hebrew translator> 2011/1/9 Nowres <nss.zpeedzter(a)gmail.com> > From a5d9d1e4599ce5a6c2f45df7948182401526f997 Mon Sep 17 00:00:00 2001 > From: Nowres Rafid <nss.zpeedzter(a)gmail.com> > Date: Sun, 9 Jan 2011 00:54:00 +0000 > Subject: [user32]Adding Arabic translation resources > > --- > dlls/user32/Makefile.in | 1 + > dlls/user32/resources/user32_Ar.rc | 89 > ++++++++++++++++++++++++++++++++++++ > 2 files changed, 90 insertions(+), 0 deletions(-) > create mode 100644 dlls/user32/resources/user32_Ar.rc > > diff --git a/dlls/user32/Makefile.in b/dlls/user32/Makefile.in > index 3dbde26..e33d83e 100644 > --- a/dlls/user32/Makefile.in > +++ b/dlls/user32/Makefile.in > @@ -51,6 +51,7 @@ C_SRCS = \ > wsprintf.c > > RC_SRCS = \ > + resources/user32_Ar.rc \ > resources/user32_Bg.rc \ > resources/user32_Ca.rc \ > resources/user32_Cs.rc \ > diff --git a/dlls/user32/resources/user32_Ar.rc > b/dlls/user32/resources/user32_Ar.rc > new file mode 100644 > index 0000000..5dd397c > --- /dev/null > +++ b/dlls/user32/resources/user32_Ar.rc > @@ -0,0 +1,89 @@ > +/* > + * User32 > + * Arabic language support > + * > + * Copyright 2010 Nowres Rafid > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > + */ > + > +#include "resources.h" > + > +/* UTF-8 */ > +#pragma code_page(65001) > + > +LANGUAGE LANG_ARABIC, SUBLANG_DEFAULT > + > +SYSMENU MENU > +{ > + MENUITEM "إسترجا&ع", 61728 > + MENUITEM "تحري&ك", 61456 > + MENUITEM "حج&م", 61440 > + MENUITEM "تصغي&ر", 61472 > + MENUITEM "تكبي&ر", 61488 > + MENUITEM SEPARATOR > + MENUITEM "إغلا&ق\tAlt-F4", 61536 > + MENUITEM SEPARATOR > + MENUITEM "Wine معلومات حو&ل", 61761 > +} > + > +EDITMENU MENU > +{ > + POPUP "" > + BEGIN > + MENUITEM "إلغاء التغيير&ات", EM_UNDO > + MENUITEM SEPARATOR > + MENUITEM "ق&ص", WM_CUT > + MENUITEM "نس&خ", WM_COPY > + MENUITEM "لصق&", WM_PASTE > + MENUITEM "مس&ح", WM_CLEAR > + MENUITEM SEPARATOR > + MENUITEM "تحد&يد الكل", EM_SETSEL > + END > +} > + > +MSGBOX DIALOG 100, 80, 216, 168 > +STYLE DS_MODALFRAME | DS_NOIDLEMSG | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +BEGIN > + ICON "", 1088, 8, 20, 16, 16, WS_CHILD | WS_VISIBLE > + LTEXT "", 100, 32, 4, 176, 48, WS_CHILD | WS_VISIBLE | WS_GROUP | > SS_NOPREFIX > + PUSHBUTTON "موافق&", 1, 16, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إلغ&اء", 2, 64, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إنه&اء", 3, 112, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إعادة المحاول&ة", 4, 160, 56, 40, 14, WS_CHILD | > WS_VISIBLE | WS_TABSTOP > + PUSHBUTTON "تجاه&ل", 5, 208, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "نع&م", 6, 256, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "ك&لا", 7, 304, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "أعد& المحاولة", 10, 352, 56, 40, 14, WS_CHILD | > WS_VISIBLE | WS_TABSTOP > + PUSHBUTTON "إستمرا&ر", 11, 400, 56, 40, 14, WS_CHILD | WS_VISIBLE > | WS_TABSTOP > + PUSHBUTTON "مس&اعدة", 9, 448, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > +END > + > +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 > +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "إخ&تيار النافذة" > +FONT 8, "MS Shell Dlg" > +BEGIN > + LISTBOX MDI_IDC_LISTBOX, 5, 7, 222, 90, WS_VSCROLL | > WS_HSCROLL /* defined in mdi.h */ > + DEFPUSHBUTTON "مو&افق", IDOK, 75, 100, 35, 14 > + PUSHBUTTON "إلغ&اء", IDCANCEL, 120, 100, 35, 14 > +END > + > + > +STRINGTABLE > +{ > + IDS_ERROR "خطأ" > + IDS_MDI_MOREWINDOWS "نوا&فذ أخرى" > +} > -- > 1.7.1 > > > > >

1 0