September 2011 - Wine-Devel

Re: Old imagehlp patches
by Juan Lang Sept. 19, 2011

Sept. 19, 2011

Hi Thomas, wrong mailing list. You wanted wine-devel instead (now cc'ed.) > I don't know about wine development, but are these patches still likely to > work? What would need to happen for them to be merged in? To your first question, try them and see! To your second question, a lot. They're much too large to be merged at a single go, they lack tests, and they should be sent by their original author. I wouldn't hold your breath expecting these patches to go in as-is: if they weren't good enough in 2004-5, they're not any better now. You'd want someone who has an active interest in this area to have a go at them, I believe, unless you can convince the original author to take them up again. --Juan

3 2

Re: comctl32: Don't crash when getting a bad image list handle. (try 2)
by Nikolay Sivov Sept. 19, 2011

Sept. 19, 2011

On 9/19/2011 17:32, Francois Gouget wrote: > --- > > Don't return from inside the block this time. > > dlls/comctl32/imagelist.c | 13 ++++++++++++- > dlls/comctl32/tests/imagelist.c | 17 +++++++++++++++-- > 2 files changed, 27 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c > index ec62370..83b8b44 100644 > --- a/dlls/comctl32/imagelist.c > +++ b/dlls/comctl32/imagelist.c > @@ -54,6 +54,7 @@ > #include "commoncontrols.h" > #include "imagelist.h" > #include "wine/debug.h" > +#include "wine/exception.h" > > WINE_DEFAULT_DEBUG_CHANNEL(imagelist); > > @@ -3587,7 +3588,17 @@ static const IImageListVtbl ImageListImpl_Vtbl = { > > static inline BOOL is_valid(HIMAGELIST himl) > { > - return himl&& himl->lpVtbl ==&ImageListImpl_Vtbl; > + BOOL valid; > + __TRY > + { > + valid = himl&& himl->lpVtbl ==&ImageListImpl_Vtbl; > + } > + __EXCEPT_PAGE_FAULT > + { > + valid = FALSE; > + } > + __ENDTRY > + return valid; > } Maybe use IsBadReadPtr() with sizeof(void*) is better? You need only vtable pointer to be accessible.

3 3

re: mscoree: Add .Net debugging interfaces
by Dan Kegel Sept. 19, 2011

Sept. 19, 2011

Doesn't apply here: $ wget http://source.winehq.org/patches/data/79041 $ git reset --hard origin $ patch -p1 < 79041 patching file include/Makefile.in patching file include/cordebug.idl patch: **** malformed patch at line 998: -- $ git reset --hard origin $ git apply 79041 79041:99: trailing whitespace. interface ICorDebugValueBreakpoint; fatal: corrupt patch at line 999

1 0

Ole16 to Ole32 mapping
by Bruno Jesus Sept. 19, 2011

Sept. 19, 2011

Hi, I would like some advice about Ole function redirection. The winsock16 dll maps some operations to ws2_32 dll, I thought I could do the same with Ole16disp to Oleaut32. For example the function SAFEARRAYALLOCDESCRIPTOR in Ole16disp have a similar counterpart named SafeArrayAllocDescriptor in Oleaut32. There are dozens of functions like this if you look in the spec files of these dlls. I added oleaut32 to the imports and started mapping by making one line functions, for example SAFEARRAYALLOCDESCRIPTOR simply return calling SafeArrayAllocDescriptor from Ole32. Is it ok to do it like this? I implemented SafeArrayAlloc[Descriptor/Data] and SafeArrayDestroy[Descriptor/Data] and they seem to be working, then I started implementing some of the others and testing with the application winverbs from bug #28113. Is there any msdn documentation like to these old functions? I would like to compare the function parameters in some cases. Thanks in advance, Bruno -- universe* god::bigbang (void); //and then it all began...

3 2

Re: [po]updated korean resource(2011-09-19)
by Francois Gouget Sept. 19, 2011

Sept. 19, 2011

msgstr "" +"Wine is free software; you can redistribute it and/or modify it under the " +"terms of the GNU Lesser General Public License as published by the Free " +"Software Foundation; either version 2.1 of the License, or (at your option) " +"any later version.\n" +"\n" +"Wine is distributed in the hope that it will be useful, but WITHOUT ANY " +"WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS " +"FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for " +"more details.\n" +"\n" +"You should have received a copy of the GNU Lesser General Public License " +"along with Wine; if not, write to the Free Software Foundation, Inc., 51 " +"Franklin St, Fifth Floor, Boston, MA 02110-1301, USA." This is not a translation so I don't think it should be put in the PO file[1]. Copying the English string is not needed by Wine and it will only make it less likely that a proper translation is provided later. [1] Also Korean is not an RTL language so the 'Hebrew' exception does not apply<g>. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ La terre est une bêta...

1 0

Re: [PATCH 16/17] vbscript: Added interp_me implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14384 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 14/17] vbscript: Added support for SCRIPTITEM_ISVISIBLE named items
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14383 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 12/17] vbscript: Added error object stub implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14382 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/17] vbscript: Added is expression implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14380 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: vbscript: Make vbdisp_get_id() static.
by Jacek Caban Sept. 19, 2011

Sept. 19, 2011

Hi Francois, On 09/18/11 19:37, Francois Gouget wrote: > --- > dlls/vbscript/vbdisp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/vbscript/vbdisp.c b/dlls/vbscript/vbdisp.c > index 14fb8b0..db1c864 100644 > --- a/dlls/vbscript/vbdisp.c > +++ b/dlls/vbscript/vbdisp.c > @@ -52,7 +52,7 @@ static BOOL get_func_id(vbdisp_t *This, const WCHAR *name, vbdisp_invoke_type_t > return FALSE; > } > > -HRESULT vbdisp_get_id(vbdisp_t *This, BSTR name, vbdisp_invoke_type_t invoke_type, BOOL search_private, DISPID *id) > +static HRESULT vbdisp_get_id(vbdisp_t *This, BSTR name, vbdisp_invoke_type_t invoke_type, BOOL search_private, DISPID *id) > { > unsigned i; Good catch, but my recent patch series needs it being non-static. Jacek

1 0