October 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] ntoskrnl.exe: Add include/ddk/ntifs.h header with EPROCESS struct definition.
by Paul Chitescu Oct. 5, 2012

Oct. 5, 2012

On Friday 05 October 2012 10:00:00 am Christian Costa wrote: > --- > include/ddk/ntifs.h | 555 > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 555 > insertions(+) > create mode 100644 include/ddk/ntifs.h > > diff --git a/include/ddk/ntifs.h b/include/ddk/ntifs.h > new file mode 100644 > [...] What version of Windows were these extracted from?

2 2

Re: [PATCH 1/3] ntoskrnl.exe: Add include/ddk/ntifs.h header with EPROCESS struct definition.
by Dmitry Timoshkov Oct. 5, 2012

Oct. 5, 2012

Did you check the DDK where it's supposed to be declared? -- Dmitry.

1 0

Help getting amd64 assembly patch into wine?
by Dan Kegel Oct. 4, 2012

Oct. 4, 2012

As you might know from watching too many of my patches scroll by, I've been working on adding support for OpenMP to wine. (A handful of games, and a lot of serious apps, seem to use that api.) After getting it nicely organized and cleaned up to the point where it passed all the tests I could throw at it, I submitted it as http://source.winehq.org/patches/data/90524, Alexandre rejected the patch, saying it had multiple problems, but declining to provide any further hints. He suggested I find someone to work with to get it in... so here I am, hat in hand, asking for help. The patch adds support for OpenMP programs like this: // Compile with "cl test.c /openmp" #include <omp.h> #include <stdio.h> int main (int argc, char **argv) { #pragma omp parallel { printf("%d\n", omp_get_thread_num()); } } Later patches add support for other OpenMP constructs. My patch doesn't actually parallelize the app, but it does let it run rather than crash on unimplemented _vcomp_fork. Visual C will happily provide an assembly listing of this program showing how _vcomp_fork is called, so understanding that interface well enough to pass simple tests wasn't hard. The main challenge was figuring out how to get the variable list of arguments off the stack, and then put them back onto the stack when calling the provided function pointer. This bit of varargs hackery can't be done in pure C as far as I can tell, so I used assembly. I started programming in machine language long ago, so getting that working wasn't too hard once I realized that's what was needed. Getting it to pass the Alexandre test is another matter. Alexandre did give feedback on one earlier iteration of the patch, telling me I was re-inventing the wheel, so I tossed my old assembly and copied the helper-calling code nearly verbatim from call_method in oleaut32/typelib.c. Maybe he objects to not passing copies of the arguments in the floating point registers on amd64... but the arguments are always pointers, so that shouldn't be needed. I'm definitely not yet comfortable with the ASM_CFI stuff, so perhaps there's a problem there, but I did at least verify that injecting a fault into _test_vcomp_fork_worker5() still yielded a good stack trace on both x86 and amd64 in winedbg. There aren't many comments, and the ones I did add aren't the greatest, but I doubt that's the issue. Perhaps he objects to breaking up _vcomp_fork into three functions, but I couldn't see any other way to write it without making later patches like http://source.winehq.org/patches/data/90527 (and a future patch that adds actual multiple threads) put more logic than seems wise into assembly. So maybe it's none of the above. If someone can suggest what I might be missing, I'd appreciate it. Even just "It will break if..." or "Better compare how this was done in..." would be very helpful. Thanks!

2 2

Re: [PATCH 2/2] mshtml: Added ActiveX event binding test
by Marvin Oct. 4, 2012

Oct. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22013 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 5/5] winex11: Don't send SC_RESTORE when a maximized window switches to fullscreen.
by Dmitry Timoshkov Oct. 4, 2012

Oct. 4, 2012

Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > - if (style & WS_MAXIMIZE) > + if ((style & WS_MAXIMIZE) && (style & WS_CAPTION) == WS_CAPTION) Probably you should test for WS_MAXIMIZEBOX instead. -- Dmitry.

1 0

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.
by Dmitry Timoshkov Oct. 4, 2012

Oct. 4, 2012

Christian Costa <titan.costa(a)gmail.com> wrote: > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > - FIXME("() stub\n"); > - return NULL; > + TRACE("()\n"); > + > + /* Return current process id since PEPROCESS is opaque and drivers should not access the struct directly */ > + return (PEPROCESS)PsGetCurrentProcessId(); > } The returned pointer is supposed to be passed to various other ntoskrnl APIs, and it's needs to be a valid pointer to the kernel object. Besides many not trivial kernel drivers (if not all) really dig into internal kernel structures. Same for KeGetCurrentThread. -- Dmitry.

4 4

Re: [PATCH] reg.exe: comparing the names of registry keys
by Jacek Caban Oct. 4, 2012

Oct. 4, 2012

On 10/04/12 08:03, Mieczyslaw Nalewaj wrote: > +static BOOL strings_equal(LPWSTR lpString1, const WCHAR *lpString2) > +{ > + int cchCount; Please avoid Hungarian style variable names. Also is seems like the function not exactly compares strings, so something like is_subkey could be more appropriate function name. > + if ((!lpString1 || !*lpString1) && (!lpString2 || !*lpString2)) /* both empty */ > + return TRUE; > + if ( !lpString1 || !*lpString1 || !lpString2 || !*lpString2 ) /* one empty */ > + return FALSE; How about simplifying it to: if(!str1 || !*str1) return !str2 || !*str2; if(!str2 || !*str2) return FALSE; > + cchCount = strlenW(lpString2); > + if (strlenW(lpString1)<cchCount) /* too short */ > + return FALSE; > + > + if ( (CompareStringW(CP_ACP,NORM_IGNORECASE,lpString1,cchCount,lpString2,cchCount)==CSTR_EQUAL) > + && ((lpString1[cchCount] == 0) || (lpString1[cchCount] == (WCHAR){'\\'}))) > + return TRUE; > + else > + return FALSE; This could be simplified: len = strlenW(str2); return !strncmpiW(str1, str2, len) && (!str1[len] || str1[len] == '\\'); Cheers, Jacek

1 0

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.
by Dmitry Timoshkov Oct. 4, 2012

Oct. 4, 2012

Qian Hong <fracting(a)gmail.com> wrote: > --- > dlls/gdi32/tests/font.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) On what system do you see broken results? I'm asking because i did run this test with japanese locale at the time I touched it last time. -- Dmitry.

2 5

Re: [PATCH 2/2] ntoskrnl.exe: Implement MmMapLockedPagesSpecifyCache & MmUnmapLockedPages and improve MmUnlockPages stub.
by Dmitry Timoshkov Oct. 4, 2012

Oct. 4, 2012

Christian Costa <titan.costa(a)gmail.com> wrote: > + /* Read memory from the client process memory */ > + if (!ReadProcessMemory(process, (LPCVOID)((ULONG)(mdl->StartVa) + mdl->ByteOffset), (LPVOID)(((ULONG)mdl->MappedSystemVa) + mdl->ByteOffset), mdl->ByteCount, &bytes)) This kind of casts is broken. -- Dmitry.

2 1

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)
by Marvin Oct. 4, 2012

Oct. 4, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22000 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0