April 2012 - Wine-Devel - list.winehq.org

Re: [3/4] server: Perform an access check for kernel objects without a security descriptor using access rights of the owner'
by Marvin April 17, 2012

April 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17911 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:923: Test failed: DeleteTimerQueueTimer

2 1

[shlwapi] Add NULL checks to StrCpyW and StrCatW
by carlo.bramix＠libero.it April 16, 2012

April 16, 2012

Hello friends, according to these results, it looks like the test I added in the patch crashes win2k SP4 but it works on all others. And it does not seem to be a thing that it can be resolved with dynamic library loading. So, what should I do? Do I need to comment them like it has been done (for example) into test_StrChrA()? Do I need to remove interely the test and revive previous patch? Please excuse my inexperience... Sincerely, Carlo Bramini. >----Messaggio originale---- >Da: testbot(a)testbot.winehq.org >Data: 16/04/2012 22.48 >A: <carlo.bramix(a)libero.it> >Ogg: TestBot job 17900 results: [shlwapi] Add NULL checks to StrCpyW and StrCatW > >VM Status Number of test failures >WINEBUILD completed >WNT4WSSP6 completed 0 >W2KPROSP4 completed 1 >WXPPROSP3 completed 0 >W2K3R2SESP2 completed 0 >WVISTAADM completed 0 >W2K8SE completed 0 >W7PRO completed 0 >W7PROX64 completed 0 >TEST64_W7SP1 completed 0 >W7PROX64 completed 0 >TEST64_W7SP1 completed 0 > >=== WINEBUILD (build) === >No build failures found > >=== WNT4WSSP6 (32 bit string) === >No test failures found > >=== W2KPROSP4 (32 bit string) === > >shlwapi: >string: unhandled exception c0000005 at 77C7F8A8 > >=== WXPPROSP3 (32 bit string) === >No test failures found > >=== W2K3R2SESP2 (32 bit string) === >No test failures found > >=== WVISTAADM (32 bit string) === >No test failures found > >=== W2K8SE (32 bit string) === >No test failures found > >=== W7PRO (32 bit string) === >No test failures found > >=== W7PROX64 (32 bit string) === >No test failures found > >=== TEST64_W7SP1 (32 bit string) === >No test failures found > >=== W7PROX64 (64 bit string) === >No test failures found > >=== TEST64_W7SP1 (64 bit string) === >No test failures found

1 0

Re: [shlwapi] Add NULL checks to StrCpyW and StrCatW
by Marvin April 16, 2012

April 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17900 Your paranoid android. === W2KPROSP4 (32 bit string) === string: unhandled exception c0000005 at 77C7F8A8

1 0

Re: [PATCH] winealsa.drv: Init *num to 0 (Coverity)
by Andrew Eikum April 16, 2012

April 16, 2012

On Mon, Apr 16, 2012 at 09:09:58AM +0200, Marcus Meissner wrote: > Also initialize a "may be uninitialized" value the compiler sees. > Not sure what this means. *num is initialized at the beginning of alsa_enum_devices, which is always called from GetEndpointIDs. Seems like a Coverity oversight. I'd either leave it as-is, or also remove the *num=0 from alsa_enum_devices. Andrew > Ciao, Marcus > --- > dlls/winealsa.drv/mmdevdrv.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index e3c1d15..d84bbb2 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -345,7 +345,7 @@ static WCHAR *construct_device_id(EDataFlow flow, const WCHAR *chunk1, const cha > { > WCHAR *ret; > const WCHAR *prefix; > - DWORD len_wchars = 0, chunk1_len, copied = 0, prefix_len; > + DWORD len_wchars = 0, chunk1_len = 0, copied = 0, prefix_len; > > static const WCHAR dashW[] = {' ','-',' ',0}; > static const size_t dashW_len = (sizeof(dashW) / sizeof(*dashW)) - 1; > @@ -583,6 +583,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, GUID **guids, > > TRACE("%d %p %p %p %p\n", flow, ids, guids, num, def_index); > > + *num = 0; > *ids = NULL; > *guids = NULL; > > -- > 1.7.3.4 > > >

2 2

Re: msvcrt: Added more length modifiers in scanf function
by Marvin April 16, 2012

April 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17893 Your paranoid android. === WNT4WSSP6 (32 bit scanf) === scanf.c:144: Test failed: sprintf retuned 10 scanf.c:145: Test failed: got 1942892530, expected 12345678901234 === W2KPROSP4 (32 bit scanf) === scanf.c:144: Test failed: sprintf retuned 10 scanf.c:145: Test failed: got 1942892530, expected 12345678901234 === WXPPROSP3 (32 bit scanf) === scanf.c:144: Test failed: sprintf retuned 10 scanf.c:145: Test failed: got 1942892530, expected 12345678901234 === W2K3R2SESP2 (32 bit scanf) === scanf.c:144: Test failed: sprintf retuned 10 scanf.c:145: Test failed: got 1942892530, expected 12345678901234

1 0

Re: ws2_32: Fix hostent memory allocation
by Alexandre Julliard April 16, 2012

April 16, 2012

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -5546,24 +5546,70 @@ INT WINAPI WSAUnhookBlockingHook(void) > * pointers (via a template of some kind). > */ > > -static int list_size(char** l, int item_size) > +/*********************************************************************** > + * list_size (INTERNAL) > + * > + * Calculate the size of data and number of items from a list based on > + * a fixed item size or strings by using strlen. The source list must be > + * NULL terminated. > + * > + * PARAMS > + * l [I] Pointer to array of source items. > + * item_size [I] Fixed item size or zero if it's a string list. > + * size_sum [O] Pointer to where the sum of item bytes will be > + * stored. May be NULL if not required by the caller. > + * item_count [O] Pointer to where the number of items bytes will be > + * stored. May be NULL if not required by the caller. > + * > + * NOTES > + * When item_size is zero the byte sum will also count the NULL > + * terminator for each string. > + */ > +static void list_size(char** l, int item_size, int *size_sum, int *item_count) > { > - int i,j = 0; > - if(l) > - { for(i=0;l[i];i++) > - j += (item_size) ? item_size : strlen(l[i]) + 1; > - j += (i + 1) * sizeof(char*); } > - return j; > + int s, c, *sum = (size_sum ? size_sum : &s), *count = (item_count ? item_count : &c); > + *sum = *count = 0; > + if(l) > + { > + for(;l[*count];(*count)++) > + *sum += (item_size) ? item_size : strlen(l[*count]) + 1; > + } That's not a good helper function, with all the optional parameters and various behaviors. Also if you need a big documentation block like this for a 5-line function it's a sign that something is wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

WASAPI ISimpleAudioVolume::SetMasterVolume appears to not work
by adam smith April 16, 2012

April 16, 2012

Hi, I've been trying to get WASAPI audio output working for our app as Directsound output was very glitchy post the new audio stack. All seems to work great with WASAPI however I need to able to set the volume level independently for individual audio sessions / streams for crossfading however I'm having problems controlling the volume levels of a shared mode audio session / stream. specifically, ISimpleAudioVolume::SetMasterVolume http://msdn.microsoft.com/en-us/library/windows/desktop/dd316537(v=vs.85).a… Doesn't seem to work under Wine i.e. HRESULT hr; hr=audioClient_->GetService(IID_ISimpleAudioVolume,(void**)&simpleAudioVolume_); if (SUCCESS(hr)) hr=simpleAudioVolume_->SetMasterVolume(0.1,NULL); returns success but does not change the volume level though interestingly HRESULT hr; hr=audioClient_->GetService(IID_ISimpleAudioVolume,(void**)&simpleAudioVolume_); if (SUCCESS(hr)) hr=simpleAudioVolume_->SetMute(TRUE,NULL); does work and mute the volume. I've also tried usingsthe IAudioStreamVolume interface to control the volume again to no avail. Does anyone have any experience of these interfaces or know equivalent interfaces to use instead working I've tested on : Ubuntu 10.04, 11.10 Wine 1.4 , 1.5 , 1.5.2 PulseAudio 0.9.21 , 1.0 , no pulse audio (and windows 7 where the code works fine) Thanks, Adam

2 1

Re: jscript: Make sure to jump out of switch before entering implicit default clausule
by Marvin April 16, 2012

April 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17883 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Testbot certificate has expired
by Morten Rønne April 16, 2012

April 16, 2012

Hi testbot.winehq.com certificate expired on 13-04-2012. So now the wininet tests in dlls/wininet/tests/http.c are failing with an error for me. I can't determine if the fault are in the test or the function called should handle the error case. The error message is: err:wininet:NETCON_secure_connect SSL_connect failed: 12037 http.c:2873: Test failed: HttpSendRequest failed: 12037 wine: Unhandled page fault on read access to 0x00000008 at address 0x68a876c5 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x68a876c5). Best Regards Morten Rønne

2 1

Re: gdi32: Add support for emulating bold faces of bitmap fonts.
by Huw Davies April 16, 2012

April 16, 2012

On Mon, Apr 16, 2012 at 04:37:39PM +0900, Dmitry Timoshkov wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 0a5d3c3..eb3f9b5 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -5669,12 +5669,27 @@ static inline BYTE get_max_level( UINT format ) > return 255; > } > > -static const BYTE masks[8] = {0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01}; > +static void emulate_bold_glyph(BYTE *buf, int pitch, int height) > +{ > + int x, y; > + BYTE *p = buf; > + > + for (y = 0; y < height; y++) > + { > + for (x = pitch - 1; x >= 0; x--) > + { > + p[x] |= p[x] >> 1; > + if (x > 0) p[x] |= p[x - 1] << 7; > + } > + p += pitch; > + } > +} > Don't we need to add some bytes if glyph_width % 32 == 0 ? Huw.

2 3