June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Darryl Slack June 18, 2012

June 18, 2012

Well after fighting with pulseaudio after all this time I have tried this patch with wine 1.5.6 with a Presonus StudioLive 24.4.2 Fire-wire controller within wine, to control software known as Virtual DJ with timecoded vinyl records. With Andrew's patch, there are stalled buffer errors, and I wasn't able to measure latency very well because the controller just kept on reporting 'stalled' I did also try martaans driver, which was added to wine, and latency was much lower, and the controller worked well within Linux, in fact the first time i've actually been able to use it with pulseaudio. I was measuring latency much lower than I expected, 2-4ms. With Andrew's Driver I was not even able to play a timecode from start to finish without 'stalled' buffers. Please Take the time to QA this driver for things just other than 'cos we have it' and consider Martaan's driver as well, because there is a massive improvement in latency over Andrews, and applications requiring fire-wire work much nicer with pulseaudio. My Wine build is 1.5.4, Gentoo 3.4.2-r1. Thanks Darryl

1 0

Re: mshtml: Implement IHTMLScriptElement_put_src
by Jacek Caban June 18, 2012

June 18, 2012

André, On 06/15/12 23:45, André Hentschel wrote: > --- > dlls/mshtml/htmlscript.c | 14 ++++++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmlscript.c b/dlls/mshtml/htmlscript.c > index 376db7b..1714cfe 100644 > --- a/dlls/mshtml/htmlscript.c > +++ b/dlls/mshtml/htmlscript.c > @@ -101,8 +101,18 @@ static HRESULT WINAPI HTMLScriptElement_Invoke(IHTMLScriptElement *iface, DISPID > static HRESULT WINAPI HTMLScriptElement_put_src(IHTMLScriptElement *iface, BSTR v) > { > HTMLScriptElement *This = impl_from_IHTMLScriptElement(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); > - return E_NOTIMPL; > + nsAString src_str; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); > + > + nsAString_Init(&src_str, v); > + nsres = nsIDOMHTMLScriptElement_SetSrc(This->nsscript, &src_str); > + if (NS_FAILED(nsres)) > + ERR("SetSrc failed: %08x\n", nsres); > + nsAString_Finish (&src_str); > + > + return S_OK; > } > Unfortunately it's not so easy. That won't work this way. Jacek

1 0

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)
by Alexandre Julliard June 18, 2012

June 18, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); Zero-size arrays are not portable and should be avoided. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] wbemprox: Add tests for IWbemServices.
by Marvin June 18, 2012

June 18, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19208 Your paranoid android. === WNT4WSSP6 (32 bit services) === services.c:38: Test failed: failed to create IWbemLocator interface 80040154 services: unhandled exception c0000005 at 004019EE

1 0

Re: [2/2] comdlg32/tests: Test file name selection on init
by Marvin June 17, 2012

June 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19196 Your paranoid android. === WNT4WSSP6 (32 bit filedlg) === Timeout === W2KPROSP4 (32 bit filedlg) === Timeout === WXPPROSP3 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 7C809E32 === W2K3R2SESP2 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 77E63110 === WVISTAADM (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76A75031 === W2K8SE (32 bit filedlg) === filedlg: unhandled exception c0000005 at 76285DBE === W7PRO (32 bit filedlg) === filedlg.c:1158: Test failed: The EM_GETSEL message returned with no selection

1 0

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test
by Nikolay Sivov June 17, 2012

June 17, 2012

On 6/17/2012 13:11, Alexandre Goujon wrote: > > case DvdManufacturerDescriptor: > + nt_desc.manf->Header.Length = 0x0802; > + nt_desc.manf->Header.Reserved[0] = 0; > + nt_desc.manf->Header.Reserved[1] = 0; Does this length mean something? Looks a bit dirty to leave hardcoded things like that, but maybe I don't know details.

2 1

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)
by Nikolay Sivov June 17, 2012

June 17, 2012

On 6/17/2012 13:11, Alexandre Goujon wrote: > Superseeds the patch of the same name (#87003) > Definition and assert taken from Windows Driver Kit (WDK) 8 Consumer Preview > --- > include/ddk/ntddcdvd.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/ddk/ntddcdvd.h b/include/ddk/ntddcdvd.h > index 5313496..d0178c7 100644 > --- a/include/ddk/ntddcdvd.h > +++ b/include/ddk/ntddcdvd.h > @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE { > > /* From 0 to 4 */ > UCHAR LayerNumber; > -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE; > +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE; > + > +typedef struct _DVD_DESCRIPTOR_HEADER { > + USHORT Length; > + UCHAR Reserved[2]; > +#if !defined(_midl) > + UCHAR Data[0]; > +#endif > +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER; > +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4); This looks wrong, correct name for it __midl, and this also needs a check for __WIDL__ probably.

2 1

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines.
by Dmitry Timoshkov June 17, 2012

June 17, 2012

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > - static const struct test_data > + const int font[] = > { > - int id, weight, height, dpi; > + ANSI_FIXED_FONT, ANSI_VAR_FONT, SYSTEM_FONT, DEVICE_DEFAULT_FONT, DEFAULT_GUI_FONT > + /* SYSTEM_FIXED_FONT, OEM_FIXED_FONT */ > + }; > + const struct test_data > + { Please add back 'static' to test_data and add it to font. -- Dmitry.

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Maarten Lankhorst June 16, 2012

June 16, 2012

What happened to the stamped capture buffers? Why is held_frames added? This doesn't look like an attempt to get my driver in, it looks like a rewrite by someone who doesn't understand why I made the design decisions I made for correctness. If you don't paste all the mmdevapi tests with the fix in my git tree, it's a regression. I don't want to see held_Frames because it's a shadow buffer. If winmm and dsound don't work without it, they're wrong, fix those. The logic I kept for timestamping audio buffers was removed which just makes timestamping less accurate on capture buffers. Was this driver even tested on low latency? There was a reason I kept track of all packets in a linked list, no need to do held_frames logic. I genuinely do want a good driver to go in, but this just isn't it. There is also no reason to have an INCREASED period size for exclusive compared to shared. I'm currently not handling exclusive because there are no good tests for it. and "hooray_cb" ? If this is going to be accepted (likely, sadly) I want to have this added to the commit: Rejected-by: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> ~Maarten PS: Still sad that you chose to reject my original driver not based on any merits.

1 0

Re: [PATCH] sfnt2fnt: Fix broken .fon files on !x86 architectures
by Alexandre Julliard June 15, 2012

June 15, 2012

Hilko Bengen <bengen(a)hilluzination.de> writes: > @@ -46,6 +46,8 @@ > > #include "pshpack1.h" > > +#include <endian.h> endian.h is not portable, you should use the endianness defines from the Wine headers instead. -- Alexandre Julliard julliard(a)winehq.org

4 9