June 2012 - Wine-Devel - list.winehq.org

Re: [PATCH (try2)] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard June 15, 2012

June 15, 2012

Andrew Eikum <aeikum(a)codeweavers.com> writes: > The configure.ac changes and parts of the driver itself were written by > Maarten Lankhorst. It doesn't work here, it's apparently using the driver even though PulseAudio is not running on this box: ../../../tools/runtest -q -P wine -M amstream.dll -T ../../.. -p amstream_test.exe.so amstream.c && touch amstream.ok err:pulse:AudioClient_Initialize PulseAudio no longer running? err:quartz:DSoundRender_create Cannot create Direct Sound object (88890010) fixme:ole:CoCreateInstance no instance created for interface {56a86895-0ad4-11ce-b03a-0020af0ba770} of class {79376820-07d0-11cf-a24d-0020afd79767}, hres is 0x88890010 amstream.c:274: Test failed: IAMMultiMediaStream_AddMediaStream returned: 88890010 -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 1/4] DSS Test Suite: CryptAcquireContext tests for base DSS
by Alexandre Julliard June 15, 2012

June 15, 2012

Marek Chmiel <kcmark(a)gmail.com> writes: > From 748332765355ae099ab24cf1402bed86610984e7 Mon Sep 17 00:00:00 2001 > From: Marek Chmiel <kcmark(a)gmail.com> > Date: Fri, 1 Jun 2012 22:38:03 -0500 > Subject: [PATCH 1/4] Add CryptAcquireContext tests for base DSS CSP. > > --- > configure | 1 + > configure.ac | 1 + > dlls/dssenh/tests/Makefile.in | 7 +++ > dlls/dssenh/tests/dssenh.c | 119 +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 128 insertions(+) > create mode 100644 dlls/dssenh/tests/Makefile.in > create mode 100644 dlls/dssenh/tests/dssenh.c You are adding 4 almost identical copies of that code. Try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2 resend] advapi32: Pass service name as argv[0] to ServiceMain
by Alexandre Julliard June 15, 2012

June 15, 2012

Jacek Caban <jacek(a)codeweavers.com> writes: > Resend with tests. > > --- > dlls/advapi32/service.c | 3 +-- > programs/services/tests/service.c | 4 ++++ > 2 files changed, 5 insertions(+), 2 deletions(-) You will now get the name twice for autostart services. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard June 15, 2012

June 15, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > + while(min <= max) > + { > + const char *encoded_symbol; > + > + pos = (min+max)/2; > + encoded_symbol = html_encoded_symbols[pos].html_code; > + dir = strncmp(encoded_symbol, amp, len); You need to check the length, strncmp is not enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mmcndmgr: Implement IMMCVersionInfo (try 3)
by Marvin June 15, 2012

June 15, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19090 Your paranoid android. === WNT4WSSP6 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000 === W2KPROSP4 (32 bit mmcndmgr) === mmcndmgr.c:40: Test failed: got 0x80040154, expected 0x00000000

1 0

Re: ru.po: improved an Russian translation
by Oleg Yarigin June 15, 2012

June 15, 2012

Hi, Julian! > 1. Patches should be sent to wine-patches(a)winehq.org, not wine-devel. Thank you a lot, I didn't know these address! > I don't think that's a good idea... Afaik, the general guideline is to > not change formatting and punctuation (from the English original), > unless there's a rule in the Russian language that specifically > dictates it. In Russian there is different from English punctuation. We create a tool for humans, not machines, don't we? So, we must improve a punctuation according to a language's rules. Instead, I send my improves to Nikolay, as you recommended. > A normal, UTF-8 formatted textfile as an attachment ... should suffice, > you shouldn't need to pack it. > I guess an archive could also confuse the automated scripts I packed it to decrease a size. But if it isn't good for merging, I willn't do it. > Please understand this as constructive criticism, it will help getting > your patch accepted and not cause extra work for the maintainer > (Alexandre). It looks like you invested a lot of effort, thanks for > that. No, that's OK. There isn't something bad in constructive criticism, I think. --- Best regards, Oleg. P. S. I didn't know how to post messages into pipemail, so I replied privetly. There is a copy of my answer.

1 0

Re: [05/11] windowscodecs: Add support for more types of IFD fields. Resend.
by Alexandre Julliard June 15, 2012

June 15, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -650,30 +672,43 @@ static HRESULT load_IFD_entry(IStream *input, const struct IFD_entry *entry, > SWAP_ULONG(count); > type = entry->type; > SWAP_USHORT(type); > + item->value.vt = tag_to_vt(type); > value = entry->value; > SWAP_ULONG(value); > > switch (type) > { > + case IFD_BYTE: > + case IFD_SBYTE: > + if (count == 1) > + { > + item->value.u.bVal = *(BYTE *)&value; > + break; > + } > + FIXME("loading multiple byte fields is not implemented\n"); > + break; This seems to contradict the endianness support. Are you really supposed to byte-swap arrays of bytes? -- Alexandre Julliard julliard(a)winehq.org

2 1

RFC: comdlg32: Fix null lpstrFile uses in FILEDLG95_OnOpen
by Bruno Jesus June 15, 2012

June 15, 2012

Hi, I have written a patch to fix bug 17229 and would like to request help to complete the test part. The test creates a common dialog and select a filename (file does not need to exist), it was copied from other tests in the same file (comdlg32/tests/filedlg.c). It's not possible to have a default file name because lpstrFile is used to do this and it's NULL. To fill a filename in the common dialog control that appears I have used EnumChildWindows to find the textbox and set the filename in it. The main problem is how to detect that a HWND is a textbox? Currently I'm sending SetWindowText to every control and that does work but I think the patch may be rejected by that. The patch can be downloaded at: https://testbot.winehq.org/JobDetails.pl?Key=19074 The problem is in the line 56. Thanks in advance, Bruno

1 0

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard June 14, 2012

June 14, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. As of version > 3 of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and it also includes some additional cleanup. It > is important to note that HTML Help only supports characters within > the ANSI code pages, so support for multi-byte characters is not > necessary. I don't see why you'd want to use ANSI code pages for this, since they will be converted to Unicode anyway. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: msvcrt/tests: Fix portuguese locale test on NT4
by Marvin June 14, 2012

June 14, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19045 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1