June 2012 - Wine-Devel - list.winehq.org

Re: configure.ac: Get the needed libs from cups-config (for OpenBSD)
by Alexandre Julliard June 12, 2012

June 12, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > Inspired by Matias Colli, see bug 17896. > I made sure it doesn't hurt on other OS and send it because it doesn't seem he will do it and it's a oneliner. It doesn't work for me on Debian testing, not without manually creating symlinks for the libs that cups-config requires. It sounds like OpenBSD should fix their libcups build. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ntprint: Do not fail when the spooler service was stopped
by Alexandre Julliard June 12, 2012

June 12, 2012

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -88,22 +92,25 @@ static void test_PSetupDestroyMonitorInfo(VOID) > { > HANDLE mi; > > - > SetLastError(0xdeadbeef); > pPSetupDestroyMonitorInfo(NULL); > - /* lasterror is returned */ > - trace("returned with %u\n", GetLastError()); > + /* lasterror is untouched */ > + ok(GetLastError() == 0xdeadbeef, "returned with 0x%x\n", GetLastError()); Testing last error on success is not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.
by Marvin June 12, 2012

June 12, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18972 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH] loader: On Mac OS, don't use external symbols for the DOS and shared heap segments.
by Alexandre Julliard June 11, 2012

June 11, 2012

Charles Davis <cdavis(a)mymail.mines.edu> writes: > My first idea was to just add some '.globl' directives in the code. But > then I asked myself: why are we using an indirect symbol at all? Why are > we treating this like an external symbol when it clearly isn't? So now, > the arrays are declared static, and their owning section is explicitly > declared to the C compiler. While compile times have gone up, at least > the compiled loader executable actually works. This core dumps instantly when build with gcc on Mac OS 10.5, and doesn't even compile on 10.6. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] winspool: Install the ppd files into the driver directory.
by Alexandre Julliard June 11, 2012

June 11, 2012

Huw Davies <huw(a)codeweavers.com> writes: > @@ -488,18 +638,70 @@ static void *cupshandle; > DO_FUNC(cupsGetPPD); \ > DO_FUNC(cupsParseOptions); \ > DO_FUNC(cupsPrintFile); > +#define CUPS_OPT_FUNCS \ > + DO_FUNC(cupsGetPPD3); > > #define DO_FUNC(f) static typeof(f) *p##f > CUPS_FUNCS; > +CUPS_OPT_FUNCS; > #undef DO_FUNC This still requires the function to be defined: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_SPOOL32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/local/include/freetype2 -I/usr/local/include -g -O2 -o info.o info.c info.c:732: error: 'cupsGetPPD3' undeclared here (not in a function) info.c:732: warning: type defaults to 'int' in declaration of 'pcupsGetPPD3' info.c: In function 'cupsGetPPD3_wrapper': info.c:741: error: called object 'pcupsGetPPD3' is not a function info.c: In function 'get_cups_ppd': info.c:771: error: 'CUPS_HTTP_DEFAULT' undeclared (first use in this function) info.c:771: error: (Each undeclared identifier is reported only once info.c:771: error: for each function it appears in.) make[1]: *** [info.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update Russian translation (try 3) (resend)
by Nikolay Sivov June 11, 2012

June 11, 2012

On 6/9/2012 07:43, Oleg Yarigin wrote: > To avoid encode breaks I send a patch as an attachment. > > I packed it into *.GZ archive, becouse (I suppose so) some > intermediate servers can block messages with big attachments. > > Please split it to several patches with changes grouped by some criteria, it's really hard to review when it's that long.

1 0

Re: po: Update Italian translation
by Matteo Bruni June 11, 2012

June 11, 2012

Hi Luca, just a couple of nitpicks: -"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a href=" -"\"http://wiki.winehq.org/Gecko\">http://wiki.winehq.org/Gecko</a> per i " -"dettagli." +"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a " +"href=\"http://wiki.winehq.org/Mono\">http://wiki.winehq.org/Mono</a> " +"per i dettagli." This sounds a bit awkward, I'd go for something like "Nota: si raccomanda di usare i pacchetti forniti dalla tua distribuzione." #: cryptui.rc:413 -#, fuzzy -#| msgid "&Personal Information Exchange/PKCS #12 (.pfx)" msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" -msgstr "Scambia di Informazioni &Personali/PKCS #12 (.pfx)" +msgstr "Scambia di Informazioni &Personali/PKCS #12 (*.pfx)" "Scambio". #: joy.rc:33 msgid "Joysticks" -msgstr "" +msgstr "Joysticks" I'm quite sure foreign words are always wrote in singular form in Italian language, so this would be "Joystick".

1 0

Re: [1/4] msi: Add support for 64-bit registry components. (resend)
by Marvin June 11, 2012

June 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18942 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 1/4] kernel32/tests: Move a cdrom test to its own file
by Alexandre Julliard June 11, 2012

June 11, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > The cdrom test file will be used to test ioctl (results, structure size...) > Each drive is tested and skipped gracefully if ioctl not supported or not a CDROM drive. I don't see a need for a new file, particularly since disk extents are not CDROM-specific. But even DVD ioctls can be tested in volume.c. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard June 11, 2012

June 11, 2012

Andrew Eikum <aeikum(a)codeweavers.com> writes: > There's a lengthy comment in ready_pulse() describing why we're using > pthreads syncro primitives instead of Win32 primitives. I was under > the impression (thanks to the CoreAudio driver, mostly) that threads > not created through CreateThread() cannot use CRITICAL_SECTION, ERR, > WARN, TRACE, and so on. However, when I was testing, I noticed that > debug printing _does_ work in callbacks from the pthread thread. You can't do that, you need to create a proper Win32 thread, and solve the loader lock issue some other way. -- Alexandre Julliard julliard(a)winehq.org

1 0