July 2012 - Wine-Devel - list.winehq.org

Re: [12/18] windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts.
by Michael Stefaniuc July 24, 2012

July 24, 2012

Hello Dmitry, On 07/24/2012 08:12 AM, Dmitry Timoshkov wrote: > --- > dlls/windowscodecs/jpegformat.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c > index 53d7ec4..2c77d4f 100644 > --- a/dlls/windowscodecs/jpegformat.c > +++ b/dlls/windowscodecs/jpegformat.c > @@ -469,6 +470,8 @@ static const IWICBitmapDecoderVtbl JpegDecoder_Vtbl = { > static HRESULT WINAPI JpegDecoder_Frame_QueryInterface(IWICBitmapFrameDecode *iface, REFIID iid, > void **ppv) > { > + JpegDecoder *This = impl_from_IWICBitmapFrameDecode(iface); > + > TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > > if (!ppv) return E_INVALIDARG; > @@ -477,7 +480,7 @@ static HRESULT WINAPI JpegDecoder_Frame_QueryInterface(IWICBitmapFrameDecode *if > IsEqualIID(&IID_IWICBitmapSource, iid) || > IsEqualIID(&IID_IWICBitmapFrameDecode, iid)) > { > - *ppv = iface; > + *ppv = &This->IWICBitmapFrameDecode_iface; > } > else > { same here: not needed. bye michael

1 0

Re: [2/2] kernel32: Implement InitOnceExecuteOnce() for Linux platform
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20269 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PRO (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PROX64 (32 bit sync) === sync.c:1231: Test failed: got 0 === TEST64_W7SP1 (32 bit sync) === sync.c:1231: Test failed: got 0 === W7PROX64 (64 bit sync) === sync.c:1231: Test failed: got 0 === TEST64_W7SP1 (64 bit sync) === sync.c:1231: Test failed: got 0

1 0

Re: [1/2] kernel32: Some tests for blocking initialization with InitOnceBeginInitialize()
by Marvin July 24, 2012

July 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20268 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PRO (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PROX64 (32 bit sync) === sync.c:1225: Test failed: got 0 === TEST64_W7SP1 (32 bit sync) === sync.c:1225: Test failed: got 0 === W7PROX64 (64 bit sync) === sync.c:1225: Test failed: got 0 === TEST64_W7SP1 (64 bit sync) === sync.c:1225: Test failed: got 0

1 0

re: Have there been any problems with Wine on GCC 4.7?
by Dan Kegel July 24, 2012

July 24, 2012

Groveling around, I found a few possibilities: backtraces broken on gcc 4.7 http://bugs.winehq.org/show_bug.cgi?id=26791 ICE when compiling: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641056 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640864 https://bugs.launchpad.net/ubuntu/+source/gcc-4.6/+bug/842012 needs-new-prelink-to-avoid-crash-with -g option: http://bugs.winehq.org/show_bug.cgi?id=30862 steam overlays: http://bugs.winehq.org/show_bug.cgi?id=22053 enabling -fomit-frame-pointer by default breaks Wine: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46468 gcc shouldn't assume that the stack is aligned: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40838 wine's conformance test kernel32/thread.ok always fails/crashes on ubuntu 11.10: https://bugs.launchpad.net/ubuntu/+source/wine1.3/+bug/872063 http://wiki.winehq.org/GccVersions might be a place to record this kind of stuff, but it's outdated. There are some known fixes, possibly related to the above problems, e.g. http://bugs.winehq.org/show_bug.cgi?id=27692 http://bugs.winehq.org/show_bug.cgi?id=28753 http://bugs.winehq.org/show_bug.cgi?id=23137 And then there's debian's "wine uses an old gcc" bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654742

1 0

Re: kernel32: Reimplement GetLogicalDrives using the mountmgr
by Alexandre Julliard July 23, 2012

July 23, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Previous approach was patch #88280 > --- > dlls/kernel32/volume.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 8377e41..57453bb 100644 > --- a/dlls/kernel32/volume.c > +++ b/dlls/kernel32/volume.c > @@ -1435,27 +1435,15 @@ DWORD WINAPI QueryDosDeviceA( LPCSTR devname, LPSTR target, DWORD bufsize ) > */ > DWORD WINAPI GetLogicalDrives(void) > { > - const char *config_dir = wine_get_config_dir(); > - struct stat st; > - char *buffer, *dev; > DWORD ret = 0; > + WCHAR drive; > int i; > > - if (!(buffer = HeapAlloc( GetProcessHeap(), 0, strlen(config_dir) + sizeof("/dosdevices/a:") ))) > - { > - SetLastError( ERROR_NOT_ENOUGH_MEMORY ); > - return 0; > - } > - strcpy( buffer, config_dir ); > - strcat( buffer, "/dosdevices/a:" ); > - dev = buffer + strlen(buffer) - 2; > - > for (i = 0; i < 26; i++) > { > - *dev = 'a' + i; > - if (!stat( buffer, &st )) ret |= (1 << i); > + drive = 'A'+i; > + if (get_mountmgr_drive_type(&drive) != DRIVE_UNKNOWN) ret |= (1 << i); > } That's very inefficient. There are better way of enumerating drives, check for instance QueryDosDevice. -- Alexandre Julliard julliard(a)winehq.org

2 4

Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY
by Eduard Hasenleithner July 23, 2012

July 23, 2012

Hi I'm trying to use the TANITA Bodyvision software (http://www.tanita.co.uk/index.php?id=158) under wine. The software is supposed to read its data from an SD-Card. But under wine it cannot find the SD card. I managed to find out what it takes so that the software finds the SD card. Please see the attached small sample to see how the software iterates the drive letters, and how it determines a eligibile media using (data.MediaType == RemovableMedia). The reasons why this does not work are manyfold. Here are some events which happen when inserting the card. * The drive is reported using udisks. This creates a symlink in dosdevices to the raw block device /dev/sdf * The partition /dev/sdf1 is mounted automatically in /media/XXXX-YYYY * /dev/sdf and /dev/sdf1 are not user read/writable. * wine creates a drive letter symlink for /dev/sdf * no symlink is created for /media/XXXX-YYYY * When you open wine explorer, the drive does not show up in the drive list This means that the drive letter assigned for the sd card will not be returned in GetLogicalDrives(). When the symlink to the mountpoint is added manually, following output is produced: DbgPrint says: Drive f fixme:ntdll:server_ioctl_file Unsupported ioctl 70000 (device=7 access=0 func=0 method=0) DbgPrint says: DeviceIoControl failed When get_dos_device is made to unconditionally return STATUS_BAD_DEVICE_TYPE, the ioctl is properly delivered to harddisk_ioctl DeviceIoControl succeeds: DbgPrint says: Drive f DbgPrint says: Removable: 0 But still, the device is reported as non-removable. The reason for this is probably that udisks reports /dev/sdf as removable, but not its partition /dev/sdf1. Is it worth for working on patches for these issues, or is this completely impossible with the current architecture? Eduard

3 7

Re: [1/2] msvcrt: added wmemcpy_s and wmemmove_s
by Alexandre Julliard July 23, 2012

July 23, 2012

Dan Kegel <dank(a)kegel.com> writes: > Next patch will expose them for msvcr100. > > From 357c45971e1315e8f6cd1f9feac65cf96a006a41 Mon Sep 17 00:00:00 2001 > From: Dan Kegel <dank(a)kegel.com> > Date: Fri, 20 Jul 2012 10:39:32 -0700 > Subject: [PATCH 1/2] msvcrt: add wmemcpy_s and wmemmove_s > > --- > dlls/msvcrt/heap.c | 29 ++++++++++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 2 + > dlls/msvcrt/tests/misc.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 85 insertions(+), 0 deletions(-) You shouldn't need to put that in msvcrt. Also please check the parameters correctly like every other _s function does. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: Dmitry Timoshkov : gdiplus: GdipMeasureString operates internally in pixels but in/ out rectangles are in device units.
by Vincent Povirk July 23, 2012

July 23, 2012

> gdiplus: GdipMeasureString operates internally in pixels but in/out rectangles are in device units. I still don't understand this patch. Your subject implies that device units and pixels are not the same thing, but my understanding is that except for metafile HDCs (which we don't handle correctly anyway, and I suspect native doesn't either), they are. You're scaling sizes based on graphics->unit. Yet the conversion in get_graphics_transform (which we were already using in GdipMeasureString to convert between world and device units, indirectly through GdipTransformPoints) already takes graphics->unit into account. So I'm concerned that the original conversion apparently wasn't sufficient, and that you've added more code instead of fixing it. And I'm still concerned about whether the sizes returned by GdipMeasureString will match the size of the strings rendered by GdipDrawString with this patch applied.

2 6

Re: [1/6] windowscodecs: Add support for generating WICBitmapPaletteTypeFixedHalftone27 palette.
by Vincent Povirk July 23, 2012

July 23, 2012

Series looks good to me.

1 0

Re: [PATCH 4/4] mshtml: Added IHTMLFrameBase::frameBorder implementation
by Marvin July 23, 2012

July 23, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20256 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0