July 2012 - Wine-Devel - list.winehq.org

Re: [2/2] gdiplus: Add 8bpp to the list of supported formats.
by Vincent Povirk July 18, 2012

July 18, 2012

> + &GUID_WICPixelFormat8bppGray, This will give you a halftone palette instead of a grayscale palette, unless you add special handling for that format.

2 2

Re: [PATCH 5/5] d3dcompiler: Implement basic expressions parsing.
by Stefan Dösinger July 17, 2012

July 17, 2012

Am Montag, 16. Juli 2012, 20:39:23 schrieb Matteo Bruni: > + HLSL_IR_BINOP_MUL, > ... > + HLSL_IR_BINOP_DOT, HLSL has 3 somewhat related multiplication operations: "*", "mul" and "dot". Dot is fairly straightforward, but "*" and "mul" have subtle differences. I recommend to write tests to find out the exact details, but as far as I remember "float4 * float4" gives you a float4 with a component-wise multiplication, whereas mul(float, float) returns a scalar like the dot product. "float4x4 * float4" is an error, but mul(float4x4, float4) performs a matrix-vector multiplication and returns a float4. > +static struct hlsl_type *expr_common_type(struct hlsl_type *t1, struct > hlsl_type *t2, > + struct source_location *loc) This type inference system might be a bit too limited, you have to take the operation into account. e.g. a dot(float3, float4) returns a scalar and crs(float4, float4) returns a float3.

2 1

Re: riched20: Avoid uninitialized field in STGMEDIUM structure (LLVM/Clang).
by Alexandre Julliard July 17, 2012

July 17, 2012

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > @@ -1098,6 +1098,8 @@ static BOOL ME_RTFInsertOleObject(RTF_Info *info, HENHMETAFILE hemf, HBITMAP hbm > BOOL ret = FALSE; > DWORD conn; > > + memset(&stgm, 0, sizeof(stgm)); > + Please fix the bugs (if any) instead of silencing the warnings by memsetting everything to 0. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: msvcp90: handle npos as a len in basic_string<>::replace
by Dan Kegel July 16, 2012

July 16, 2012

Daniel Lehman wrote: @@ -1949,7 +1949,7 @@ basic_string_char* __thiscall basic_string_char_replace_cstr_len(basic_string_ch - if(off+len > this->size) + if(off+len < off || off+len > this->size) len = this->size-off; Wouldn't this be more elegant: if(num > this->size-pos) num = this->size-pos; ? Also, you may have missed the similar case in basic_string_char_compare_substr_cstr_len (which uses 'pos' and 'num' rather than 'off' and 'len'). See http://bugs.winehq.org/show_bug.cgi?id=31085#c5

2 1

Build failure of "[PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test (try 4)" ?
by GOUJON Alexandre July 16, 2012

July 16, 2012

Hi, My patch (http://source.winehq.org/patches/data/88072) is marked as "Build failure". I tried with the latest (today) HEAD and I successfully applied it. Compilation also works for me at least on my x86 and x86_64 computers. Moreover, the Wine Test Bot tested it without any issue, see https://testbot.winehq.org/JobDetails.pl?Key=19936. I know your machine is a bit "mystic". Can you show me your output to help me diagnosing your build failure ? Thanks

2 2

Re: msi/tests: Mark some test results as broken.
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20071 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: kernel32: Also report empty drives as available in GetLogicalDrives
by Alexandre Julliard July 16, 2012

July 16, 2012

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > --- > dlls/kernel32/volume.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 8377e41..67e2eb1 100644 > --- a/dlls/kernel32/volume.c > +++ b/dlls/kernel32/volume.c > @@ -1441,19 +1441,26 @@ DWORD WINAPI GetLogicalDrives(void) > DWORD ret = 0; > int i; > > - if (!(buffer = HeapAlloc( GetProcessHeap(), 0, strlen(config_dir) + sizeof("/dosdevices/a:") ))) > + if (!(buffer = HeapAlloc( GetProcessHeap(), 0, strlen(config_dir) + sizeof("/dosdevices/a::") ))) > { > SetLastError( ERROR_NOT_ENOUGH_MEMORY ); > return 0; > } > strcpy( buffer, config_dir ); > - strcat( buffer, "/dosdevices/a:" ); > - dev = buffer + strlen(buffer) - 2; > + strcat( buffer, "/dosdevices/a::" ); > + dev = buffer + strlen(buffer) - 3; > > for (i = 0; i < 26; i++) > { > *dev = 'a' + i; > + dev[2] = 0; > if (!stat( buffer, &st )) ret |= (1 << i); > + /* Windows also report empty drives as available */ > + else > + { > + dev[2] = ':'; > + if (!stat( buffer, &st )) ret |= (1 << i); > + } You can't do that, the device symlinks don't reflect the availability of the drive. It would have to go through the mountmgr. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/9] hhctrl.ocx: Centralize merging HH_WINTYPE data (resend).
by Alexandre Julliard July 16, 2012

July 16, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -28,6 +28,13 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(htmlhelp); > > +#define HHWIN_PARAM_MASK (HHWIN_PARAM_PROPERTIES|HHWIN_PARAM_STYLES|HHWIN_PARAM_EXSTYLES|HHWIN_PARAM_RECT\ > + |HHWIN_PARAM_NAV_WIDTH|HHWIN_PARAM_SHOWSTATE|HHWIN_PARAM_INFOTYPES\ > + |HHWIN_PARAM_TB_FLAGS|HHWIN_PARAM_EXPANSION|HHWIN_PARAM_TABPOS\ > + |HHWIN_PARAM_TABORDER|HHWIN_PARAM_HISTORY_COUNT|HHWIN_PARAM_CUR_TAB) > +#define MERGE_PARAM(s,d,o,p) ((s->fsValidMembers & p) && (!(d->fsValidMembers & p) || o)) > +#define MERGE_PROP(s,d,o,p) (s->p != 0 && (d->p == 0 || o)) These macros are fairly ugly, you should be able to do without that. > @@ -1752,16 +1752,16 @@ void ReleaseHelpViewer(HHInfo *info) > list_remove(&info->entry); > > /* Free allocated strings */ > - heap_free(info->pszType); > - heap_free(info->pszCaption); > - heap_free(info->pszToc); > - heap_free(info->pszIndex); > - heap_free(info->pszFile); > - heap_free(info->pszHome); > - heap_free(info->pszJump1); > - heap_free(info->pszJump2); > - heap_free(info->pszUrlJump1); > - heap_free(info->pszUrlJump2); > + heap_free((LPVOID)info->WinType.pszType); > + heap_free((LPVOID)info->WinType.pszCaption); > + heap_free((LPVOID)info->WinType.pszToc); > + heap_free((LPVOID)info->WinType.pszIndex); > + heap_free((LPVOID)info->WinType.pszFile); > + heap_free((LPVOID)info->WinType.pszHome); > + heap_free((LPVOID)info->WinType.pszJump1); > + heap_free((LPVOID)info->WinType.pszJump2); > + heap_free((LPVOID)info->WinType.pszUrlJump1); > + heap_free((LPVOID)info->WinType.pszUrlJump2); Don't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/6] jscript: Don't set constructor property to each object instance, it belongs to their prototypes
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20070 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/6] jscript: Expose RegExpError constructor in global object
by Marvin July 16, 2012

July 16, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20069 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0