January 2013 - Wine-Devel - list.winehq.org

Re: ws2_32/tests: Add SO_ERROR [set|get]sockopt tests
by Marvin Jan. 18, 2013

Jan. 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23986 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] kernel32/path : use code from copyfileW to implement copyfileexW
by Alexandre Julliard Jan. 17, 2013

Jan. 17, 2013

Patrick Rudolph <siro(a)das-labor.org> writes: > From 6ff3329003b6b9001ad608f802f235f5433b1c5d Mon Sep 17 00:00:00 2001 > From: Patrick Rudolph <siro(a)das-labor.org> > Date: Fri, 11 Jan 2013 15:55:32 +0100 > Subject: a > > --- > dlls/kernel32/path.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 86 insertions(+), 5 deletions(-) You need to move the code, not duplicate it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests : added tests for copyfileex try4
by Alexandre Julliard Jan. 17, 2013

Jan. 17, 2013

Patrick Rudolph <siro(a)das-labor.org> writes: > + if(!GetTempPathA( MAX_PATH,tmppath )) > + { > + win_skip("GetTempPathA failed\n"); > + return; > + } > + > + if(!GetTempFileNameA( tmppath,"CopyFileExAin",0,source_name )) > + { > + win_skip("GetTempFileNameA failed\n"); > + return; > + } > + > + if(!GetTempFileNameA( tmppath,"CopyFileExAout",0,dest_name )) > + { > + win_skip("GetTempFileNameA failed\n"); > + return; > + } > + > + source_handle = CreateFileA( source_name, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, 0 ); > + if(!source_handle) > + { > + win_skip("CreateFileA failed, no write permissions ?\n"); > + return; > + } > + > +#define COPYFILEEXFILESIZE 10000000 > + > + /* create a dummy file for copy tests */ > + buffer = malloc(COPYFILEEXFILESIZE); > + if(!WriteFile(source_handle,buffer,COPYFILEEXFILESIZE,&ret,NULL)) > + { > + free(buffer); > + win_skip("WriteFile failed, enough free disk space ?\n"); > + return; > + } > + free(buffer); > + CloseHandle(source_handle); There are better ways to create a test file than writing 10Mb of uninitialized data. Also you should check how GetTempFileName works. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] gdi32: Ensure a fixed-pitch full-width character has double width of a half-width character. (try 4)
by Marvin Jan. 17, 2013

Jan. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23979 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] winealsa.drv: Cleanup modLongData and Fix F0 and F7 byte insertion + memory leak.
by Alexandre Julliard Jan. 17, 2013

Jan. 17, 2013

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -927,12 +927,12 @@ static DWORD modData(WORD wDevID, DWORD dwParam) > } > > /************************************************************************** > - * modLongData [internal] > + * modLongData internal] > */ > static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > { > - int len_add = 0; > - LPBYTE lpData, lpNewData = NULL; > + int len_add = 0; > + BYTE *lpData, *lpNewData = NULL; > snd_seq_event_t event; > > TRACE("(%04X, %p, %08X);\n", wDevID, lpMidiHdr, dwSize); > @@ -941,23 +941,23 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > * but it seems to be used only for midi input. > * Taking a look at the WAVEHDR structure (which is quite similar) confirms this assumption. > */ > - > + > if (wDevID >= MODM_NumDevs) return MMSYSERR_BADDEVICEID; > if (!MidiOutDev[wDevID].bEnabled) return MIDIERR_NODEVICE; > > - if (midiSeq == NULL) { > - WARN("can't play !\n"); > - return MIDIERR_NODEVICE; > + if (!midiSeq) { > + WARN("Can't play !\n"); > + return MIDIERR_NODEVICE; > } > > - lpData = (LPBYTE) lpMidiHdr->lpData; > - > - if (lpData == NULL) > - return MIDIERR_UNPREPARED; > + lpData = (BYTE*)lpMidiHdr->lpData; > + > + if (!lpData) > + return MIDIERR_UNPREPARED; > if (!(lpMidiHdr->dwFlags & MHDR_PREPARED)) > - return MIDIERR_UNPREPARED; > + return MIDIERR_UNPREPARED; > if (lpMidiHdr->dwFlags & MHDR_INQUEUE) > - return MIDIERR_STILLPLAYING; > + return MIDIERR_STILLPLAYING; > lpMidiHdr->dwFlags &= ~MHDR_DONE; > lpMidiHdr->dwFlags |= MHDR_INQUEUE; Please avoid gratuitous formatting changes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] wmiutils: Implement IWbemPath::RemoveNamespaceAt.
by Marvin Jan. 17, 2013

Jan. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23977 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] wmiutils: Implement IWbemPath::GetNamespaceAt.
by Marvin Jan. 17, 2013

Jan. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23975 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/5] wmiutils: Implement IWbemPath::SetClassName.
by Marvin Jan. 17, 2013

Jan. 17, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23974 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

kernel32/path: tests and patches
by Patrick Rudolph Jan. 16, 2013

Jan. 16, 2013

Any comments on my copyfileexW patches ?

1 0

Re: [PATCH 2/3] d3d8/tests: Create a plain DS surface in test_reset_resources
by Marvin Jan. 16, 2013

Jan. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23963 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0