January 2013 - Wine-Devel - list.winehq.org

Re: fusion: Allow null to be the value of the public key
by Nikolay Sivov Jan. 31, 2013

Jan. 31, 2013

On 1/31/2013 12:35, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > fusion: Allow null to be the value of the public key > + static const WCHAR nullpublickey[] = { > + 'm','s','c','o','r','l','i','n',',','v','e','r','s','i','o','n','=','0', > + 'p','u','b','l','i','c','K','e','y','T','o','k','e','n','=','n','u','l', > + 'c','u','l','t','u','r','e','=','n','e','u','t','r','a','l',0}; You have 'nul' here, not 'null'.

1 0

Clang warnings on OS X ML
by C.W. Betts Jan. 31, 2013

Jan. 31, 2013

When compiling Wine using Clang, there are a bunch of warnings that pop up, such as: ld: warning: could not create compact unwind for .L__wine_spec_call16_p_pw: dwarf uses DW_CFA_same_value ld: warning: could not create compact unwind for ___wine_stub_VARBSTRFROMR8: stack subq instruction is too different from dwarf stack size On win16 DLLs. And these warnings are with general DLL: ld: warning: could not create compact unwind for ___wine_stub__aullshr: stack subq instruction is too different from dwarf stack size ld: warning: could not create compact unwind for .L__wine_spec_relay_entry_point_52: stack subq instruction is too different from dwarf stack size Another worrying warning is that __force_align_arg_pointer__ being an unknown attribute. There's also a lot of enum conversion warnings. There was also a linker warning about register usage, but I can't seem to find it again. I could upload the whole log, but it is fairly large: 6.4 MB.

2 1

Re: [website] Added Simplified Chinese translation
by Qian Hong Jan. 30, 2013

Jan. 30, 2013

On Thu, Jan 31, 2013 at 11:34 AM, Jactry Zeng <jactry92(a)gmail.com> wrote: > Hi folks, > this is Simplified Chinese translation for Wine's website The translation looks good to me, thanks for the great work! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

[PATCH for valgrind] coregrind: implement GS override for arch_prctl on linux
by Maarten Lankhorst Jan. 30, 2013

Jan. 30, 2013

Allows wine64 to run in valgrind! Apply with -Np0. :D Yes I know that %gs is still zero on linux amd64. Details details.. Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)ubuntu.com> --- Index: coregrind/m_translate.c =================================================================== --- coregrind/m_translate.c (revision 13279) +++ coregrind/m_translate.c (working copy) @@ -1486,7 +1486,7 @@ # if defined(VGP_amd64_linux) vex_abiinfo.guest_amd64_assume_fs_is_zero = True; # endif -# if defined(VGP_amd64_darwin) +# if defined(VGP_amd64_darwin) || defined(VGP_amd64_linux) vex_abiinfo.guest_amd64_assume_gs_is_0x60 = True; # endif # if defined(VGP_ppc32_linux) Index: coregrind/m_syswrap/syswrap-amd64-linux.c =================================================================== --- coregrind/m_syswrap/syswrap-amd64-linux.c (revision 13279) +++ coregrind/m_syswrap/syswrap-amd64-linux.c (working copy) @@ -564,6 +564,16 @@ *(unsigned long *)ARG2 = tst->arch.vex.guest_FS_ZERO; POST_MEM_WRITE(ARG2, sizeof(unsigned long)); } + else if (ARG1 == VKI_ARCH_SET_GS) { + tst = VG_(get_ThreadState)(tid); + tst->arch.vex.guest_GS_0x60 = ARG2; + } + else if (ARG1 == VKI_ARCH_GET_GS) { + PRE_MEM_WRITE("arch_prctl(addr)", ARG2, sizeof(unsigned long)); + tst = VG_(get_ThreadState)(tid); + *(unsigned long *)ARG2 = tst->arch.vex.guest_GS_0x60; + POST_MEM_WRITE(ARG2, sizeof(unsigned long)); + } else { VG_(core_panic)("Unsupported arch_prtctl option"); }

1 0

Re: [PATCH 8/8] wininet: Get rid of WORKREQ* types
by Juan Lang Jan. 30, 2013

Jan. 30, 2013

Hi Jacek, just wanted to say these series of patches make me happy :) lpfnHungarianNotationDieDieDie ;) --Juan

1 0

Re: windowscodecs: Implement GetThumbnail in the ICO frame decoder.
by Hans Leidekker Jan. 30, 2013

Jan. 30, 2013

On Wed, 2013-01-30 at 18:02 +0800, Dmitry Timoshkov wrote: > diff --git a/dlls/windowscodecs/icoformat.c b/dlls/windowscodecs/icoformat.c > index 7aec245..da5a733 100644 > --- a/dlls/windowscodecs/icoformat.c > +++ b/dlls/windowscodecs/icoformat.c > @@ -200,8 +200,12 @@ static HRESULT WINAPI IcoFrameDecode_GetColorContexts(IWICBitmapFrameDecode *ifa > static HRESULT WINAPI IcoFrameDecode_GetThumbnail(IWICBitmapFrameDecode *iface, > IWICBitmapSource **ppIThumbnail) > { > - FIXME("(%p,%p)\n", iface, ppIThumbnail); > - return E_NOTIMPL; > + TRACE("(%p,%p)\n", iface, ppIThumbnail); > + > + if (!ppIThumbnail) return E_INVALIDARG; > + > + *ppIThumbnail = NULL; > + return WINCODEC_ERR_CODECNOTHUMBNAIL; > } The test added by 6395af1ae7b0cc5f2f1f82796502e2a605bc5a6b says otherwise, GetThumbnail is supported for ICO frames.

2 3

Re: [2/6] windowscodecs: Implement ComponentFactory::CreateEncoderPropertyBag
by Alexandre Julliard Jan. 29, 2013

Jan. 29, 2013

Ludger Sprenker <Ludger(a)sprenker.net> writes: > Previous "[2/5]" should have been "[3/6]" ... It doesn't build on Mac: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DENTRY_PREFIX=WIC_ -DPROXY_DELEGATION -DWINE_REGISTER_DLL -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -gstabs+ -fno-omit-frame-pointer -Wpointer-arith -I/sw/include/freetype2 -I/sw/include -I/sw/include -g -O2 -o icnsformat.o icnsformat.c icnsformat.c: In function 'IcnsEncoder_CreateNewFrame': icnsformat.c:666: warning: passing argument 1 of 'CreatePropertyBag2' from incompatible pointer type icnsformat.c:666: error: too few arguments to function 'CreatePropertyBag2' -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdiplus: Avoid not necessary memory allocation for BITMAPINFO.
by Vincent Povirk Jan. 29, 2013

Jan. 29, 2013

Did you try running the tests in valgrind with this change? You're essentially reverting 0ecd8daa16e4aa3df157a1175c611cdffc66d6fe which I think was done to make valgrind happy.

1 0

Re: kernel32: dstlen < 0 causes error in codepage conversion
by Alexandre Julliard Jan. 29, 2013

Jan. 29, 2013

Alex Henrie <alexhenrie24(a)gmail.com> writes: > This is a pretty straightforward patch to resolve a couple of test > failures marked todo_wine. Hopefully it's not controversial, but if it > is, I am willing to make any reasonable modifications that are > communicated to me. If it was that easy it would have been done already. There are places in Wine that depend on being able to use negative sizes, so it would need a code review of all callers before we can make that change. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winealsa: Have the MIDI recorder wait in poll(), not snd_seq_event_input().
by Johannes Kroll Jan. 29, 2013

Jan. 29, 2013

On Thu, 24 Jan 2013 10:33:58 +0100 <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > Compare with wineoss which uses poll <= 0 already... > > Johannes Kroll mentioned that MIDIIn takes a long time to end. > Indeed, our testsuite ran 3 times into the "kill after 5s" timeout due to this bug. > Now the tests execute much faster. Just a quick note to confirm that this patch does fix the waiting problem for me. Thanks a lot! - Johannes

1 0