April 2013 - Wine-Devel - list.winehq.org

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 5).
by Sergey Guralnik April 12, 2013

April 12, 2013

On 2013-04-10 14:28, Sergey Guralnik wrote: >> >> It's better, but testing the message sequence doesn't seem very >> useful, >> particularly since you don't differentiate parent and child >> messages. >> Also you should test the region before the move to show that it's >> the >> move that's changing it. > > Changes since last version: > - message sequence testing removed at all > - added update region testing for all windows > before and after moving. > > --- > dlls/user32/tests/win.c | 68 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 68 insertions(+), 0 deletions(-) Is something wrong with this version? -- Sergey

1 0

Re: [PATCH 1/2] wined3d: Use the np2_fixup to find out if a RECT texture is used
by Henri Verbeet April 12, 2013

April 12, 2013

On 11 April 2013 11:32, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1069,17 +1069,17 @@ static void shader_generate_glsl_declarations(const struct wined3d_context *cont > shader_addline(buffer, "uniform sampler1D %s_sampler%u;\n", prefix, i); > break; > case WINED3DSTT_2D: > - texture = state->textures[i]; > + tex_rect = version->type == WINED3D_SHADER_TYPE_PIXEL && (ps_args->np2_fixup & (1 << i)); The basic idea is ok, but the conditions for when np2_fixup is set are a bit more complicated than that. Specifically, look at how the WINED3D_TEXTURE_POW2_MAT_IDENT texture flag is set / cleared in texture_init().

2 4

Re: [3/3] server: Add support for NtTerminateProcess(0). Resend.
by Alexandre Julliard April 12, 2013

April 12, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch fixes the problem reported in the bug 33331. Before you can start killing threads, you'll need to fix the various synchronization primitives (with appropriate tests of course) to take process shutdown into account, otherwise it will deadlock all over the place. Other things like protecting the loader data structures will also need more thought. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fresh WineWiki Theme, Straight from the Farm
by Kyle Auble April 11, 2013

April 11, 2013

So as usual, my estimate of how long it would take was way off, but I'm finally done adapting the WineHQ theme to Moinmoin. It's not perfect, but I feel it's ready to submit for switching over. I've tested it in Firefox, Chromium, Midori, and Opera (briefly in IE8 & IE9 too). I did do everything through Moinmoin's stand-alone server, but while I know there always seem to be ghosts in the machine, I'm guessing that Apache shouldn't interfere with layout issues. I mostly followed the WineHQ & current WineWiki theme for large things, just tweaking the CSS to make it fit what Moinmoin spits out. I did make more design choices of my own on the smaller stuff though. After wrestling with Moinmoin's theme system, I was surprised how many things are still hard-coded (at least as of v1.5). For example, Moinmoin wraps some things in divs without providing a CSS class for the div, just the child element. The fortune cookie on the RecentChanges page & the edit page are two cases of that. The dummy content in the search bar is another tricky one. It's set in the javascript for the search bar (don't remember where it was in the source tree) so I left that one alone. One other tricky issue was handling overflows & RTL support. They both seem to work ok in isolation, but go crazy when you mix them. I haven't checked RTL in IE, but if you force an RTL page to overflow in Webkit, it positions things based on what's actually in the window (so the sidebar winds up floating in the middle of the page). Firefox simply doesn't try to apply any of the overflow rules in RTL (which I guess is nice in a Hippocratic sense). Opera alone handled things exactly like I hoped. As for the tables, I think they should display ok now, although I don't know if everyone wants my exact values for paddings & such. The old theme had some table-based layout that may have had conflicting CSS rules, but I've div-vied everything up so the only table tags now should be when Moinmoin itself chooses them over a div and well... tables. I've pushed all of the changes to my Bitbucket repo at: https://bitbucket.org/kauble/wine-wiki-migration The "refined" branch is the one you want although I expect that once the code is hosted at WineHQ's git repo, it would become the new master branch. At that point, I can just reset my repo to point to the WineHQ one as the origin. - Kyle

3 4

Re: user32: SetTimer should respect the minimum and maximum timeout limits.
by Marvin April 11, 2013

April 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25036 Your paranoid android. === TEST64_W7SP1 (64 bit msg) === msg.c:8247: Test failed: did not get expected count for minimum timeout (57 != ~64).

1 0

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.
by Ken Thomases April 11, 2013

April 11, 2013

On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > --- a/dlls/secur32/schannel_macosx.c > +++ b/dlls/secur32/schannel_macosx.c > @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef transport, const void *buff, > return ret; > } > > +DWORD schan_imp_enabled_protocols(void) > +{ > + /* NOTE: No support for TLS 1.1 and TLS 1.2 */ > + return SP_PROT_SSL2_CLIENT | SP_PROT_SSL3_CLIENT | SP_PROT_TLS1_0_CLIENT; > +} Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. You can test at build time with: #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 ... #else ... #endif If we want to support building on 10.8 for deployment to earlier versions, we'd do something like: #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 SSLProtocol maxProtocol; if (SSLGetProtocolVersionMax != NULL && SSLGetProtocolVersionMax(context, &maxProtocol) == noErr) { ... compare maxProtocol against kTLSProtocol11 and kTLSProtocol12 ... } ... #else ... #endif The idea is that SSLGetProtocolVersionMax() would be weak linked, so we'd check if it was actually available before calling it. Of course, the other complication is that that function requires a context parameter, but we can create one just for the query if we're interested in the framework capabilities (as opposed to what's been configured for a particular context). -Ken

3 10

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.
by Alexandre Julliard April 11, 2013

April 11, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Alexandre Julliard <julliard(a)winehq.org> wrote: > >> > As far as I can see ExitProcess returns 'failures' as the child process exit >> > code, but variable 'failures' is not visible from the tests. Do you have a >> > suggestion how to fix that? >> >> You need to report the status a different way. For instance you could >> store it in a file. > > How does this one look like? (In theory this approach could be used > to transfer other child process information to the parent). Something like this would work, but it should be done in the test that needs it, not in the generic code. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 2/2] wined3d: Store ps 1.4 texture types in ps_compile_args
by Henri Verbeet April 11, 2013

April 11, 2013

On 11 April 2013 11:40, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + for (i = 0; i < 6; ++i) > + { This could probably do with an appropriate constant. > +enum shader_tex_types > +{ > + shader_tex_2d = 0, > + shader_tex_3d = 1, > + shader_tex_cube = 2, > +}; Please use uppercase for enum elements. Some "wined3d" prefixes probably wouldn't hurt either, although I guess it doesn't matter so much for things that are only used internally.

1 0

Google Summer of Code
by Liu Tuo April 10, 2013

April 10, 2013

Hi, I am Liu Tuo from National University of Singapore. I am interested in implementing missing D3DX9 APIs, how can I know more about this project and how can I apply for it? Is there anyone who can help me with this? Regards, Liu Tuo

2 1

We're in GSoC 2013
by Austin English April 10, 2013

April 10, 2013

If you're interested in mentoring, please apply at: https://www.google-melange.com/gsoc/org/google/gsoc2013/wine In either case, please take a look at http://wiki.winehq.org/SummerOfCodeand update/remove/any projects you're familiar with. If you have any questions, feel free to contact me. Thanks for your help everyone! -- -Austin

2 2