April 2013 - Wine-Devel - list.winehq.org

Re: gdi32/tests: Use if(0) instead of #if 0 to make sure the code still compiles.
by Marvin April 18, 2013

April 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25164 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

testbot: Default set of VMs to run the tests
by Dmitry Timoshkov April 18, 2013

April 18, 2013

Hi all, recently the set of VMs suggested to run the tests on by default has changed. It no more includes NT4, XP and Vista (although it does include win2000), 32-bit VMs for NT4, XP and Vista don't even exist in the list of available VMs (64-bit XP and Vista do exist, but for some reason are not used). Is there a reason for that? -- Dmitry.

2 5

Re: GetKeyboardState problems in Age of Empires II
by Dmitry Timoshkov April 18, 2013

April 18, 2013

[please don't omit wine-devel when replying] Stevie Trujillo <stevie.trujillo(a)gmail.com> wrote: > > Stevie Trujillo <stevie.trujillo(a)gmail.com> wrote: > > > Another (minor) problem raised in the bugzilla entry is that, if a > > > key is pressed when changing window, and released before returning, > > > GetKeyboardState() will claim the key is still pressed (0x80). But > > > this is easy to workaround, just hit the key again inside the game > > > and it will stop scrolling. > > > > dlls/winex11.drv/keyboard.c,X11DRV_KeymapNotify() should take care of > > that, if it doesn't - please debug why (probably a bug in your WM). > > I think this function only applies to "modifier keys". It was tested > with arrow keys. It should work for all keys. > Anyway I don't think it's a big issue, since it doesn't cause > any big problem, and it doesn't happen very often. It was just a > situation where Windows and Wine exhibited slightly different behavior. > > The first bug is much more annoying since one has to completely exit > the game each time. My comment was targeting both problems that you mentioned. -- Dmitry.

2 2

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool
by Jacek Caban April 18, 2013

April 18, 2013

On 04/17/13 18:18, larmbr zhan wrote: > + double tmp; > + WCHAR trueW[] = {'T','r','u','e','\0'}; > + WCHAR falseW[] = {'F','a','l','s','e','\0'}; > + > + TRACE("%s\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + switch(V_VT(arg)) { > + case VT_I2: > + tmp = V_I2(arg); > + break; > + case VT_I4: > + tmp = V_I4(arg); > + break; I don't think converting to double is a good idea here. Why don't you do conversions directly to BOOL for all cases? > + case VT_R4: > + tmp = V_R4(arg); > + break; > + case VT_R8: > + tmp = V_R8(arg); > + break; > + default: > + ERR("Not a numeric vaule: %s\n", debugstr_variant(arg)); > + return E_FAIL; > + } > + > + if (tmp < 0.0 || tmp > 0.0) > + str = SysAllocString(trueW); > + else > + str = SysAllocString(falseW); > + > + > + return return_bstr(res, str); Are you sure you want to return string type here? I'd expect a bool value (of type VT_BOOL) here... > } > > static HRESULT Global_CByte(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > diff --git a/dlls/vbscript/tests/api.vbs b/dlls/vbscript/tests/api.vbs > index 6bd4065..9b25e87 100644 > --- a/dlls/vbscript/tests/api.vbs > +++ b/dlls/vbscript/tests/api.vbs > @@ -442,4 +442,9 @@ Call ok(CInt(36.50) = 36, "CInt(36.50) = " & CInt(36.50)) > Call ok(CInt(36.75) = 37, "CInt(36.75) = " & CInt(36.75)) > Call ok(CInt(300) = 300, "CInt(300) = " & CInt(300)) > Call ok(CInt(-300) = -300, "CInt(-300) = " & CInt(-300)) > + > +Call ok(CBool(5) = "True", "CBool(5) = " & CBool(5)) > +Call ok(CBool(0) = "False", "CBool(0) = " & CBool(0)) > +Call ok(CBool(-5) = "True", "CBool(-5) = " & CBool(-5)) ...and that's why getVT(...) test would be nice here. Thanks, Jacek

2 1

Application for GSoC 2013
by larmbr zhan April 18, 2013

April 18, 2013

Hi all, I'm a junior student from a non-famous college, I apply to parcitipate in GSoC , to help do some vbscript module implementation. I've just submitted a patchset on this. Thanks. -- Regards, Zhan Jianyu

3 4

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Jacek Caban April 18, 2013

April 18, 2013

On 04/17/13 18:17, larmbr zhan wrote: > +static HRESULT to_int_banker_rounding(VARIANT *v, int *ret) > +{ I wonder if this conversion is used in any other place as well. I think this does not need a helper function until we find other use cases as well, esp. since you could simplify that to: if(V_VT(v) == VT_R8) { //... your conversion }else { hres = to_int(v); } + case VT_R8: { + double n = rint(V_R8(v)); rint is not portable. Please avoid using it. @@ -424,4 +424,22 @@ Call ok(getVT(vbYes) = "VT_I2", "getVT(vbYes) = " & getVT(vbYes)) Call ok(vbNo = 7, "vbNo = " & vbNo) Call ok(getVT(vbNo) = "VT_I2", "getVT(vbNo) = " & getVT(vbNo)) +Call ok(CInt(-36.75) = -37, "CInt(-36.75) = " & CInt(-36.75)) +Call ok(CInt(-36.50) = -36, "CInt(-36.50) = " & CInt(-36.50)) +Call ok(CInt(-36.25) = -36, "CInt(-36.25) = " & CInt(-36.25)) Please add some tests using getVT to verify underlying types. Thanks, Jacek

1 0

Re: [2/3] mountmgr.sys: Remove an artificial limitation for removable drive letters.
by Alexandre Julliard April 18, 2013

April 18, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Under Windows removable drives (USB sticks) can have drive letters such > as J: or K:. They are not considered floppy devices though. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] kernel32: Count precise amount of child process failures.
by Marvin April 18, 2013

April 18, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25160 Your paranoid android. === W2K8SE (32 bit loader) === lloader.c:1686: Test failed: expected exit code 0, got 196

2 1

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 3)
by Dmitry Timoshkov April 18, 2013

April 18, 2013

Austin English <austinenglish(a)gmail.com> wrote: > +LPTOP_LEVEL_EXCEPTION_FILTER MSVCR110__crtSetUnhandledExceptionFilter(LPTOP_LEVEL_EXCEPTION_FILTER filter) > +{ > + return SetUnhandledExceptionFilter(filter); > +} msvcrt APIs need an explicit calling convention specifier. -- Dmitry.

2 1

GetKeyboardState problems in Age of Empires II
by Stevie Trujillo April 18, 2013

April 18, 2013

"Age of Empires II scrolling gets stuck after Alt-Tab away and back" ( http://bugs.winehq.org/show_bug.cgi?id=30814 ) has been debugged now. The problem is that GetKeyboardState starts returning 0x40 after changing window. Documentation seems to only define LSB and MSB ( http://msdn.microsoft.com/en-us/library/windows/desktop/ms646299(v=vs.85).a… ). This leads Age of Empires II to believe that all keys are pressed after changing window, making it scroll unstoppably. Should this be fixed by removing extra bits in GetKeyboardState like in the bugzilla entry, or should it be fixed in wineserver? Also does the similar functions GetAsyncKeyboardState() and GetKeyState() need fixing? Another (minor) problem raised in the bugzilla entry is that, if a key is pressed when changing window, and released before returning, GetKeyboardState() will claim the key is still pressed (0x80). But this is easy to workaround, just hit the key again inside the game and it will stop scrolling.

2 1