April 2013 - Wine-Devel - list.winehq.org

[AppDB]: Recent UCE/Spam waves in AppDBs comments
by Joerg Schiermeier April 27, 2013

April 27, 2013

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: netapi32: Add stub for NetGetAnyDCName
by Christian Costa April 27, 2013

April 27, 2013

Hi, + FIXME("(%s, %s, %p) stub!\n", debugstr_w(servername), + debugstr_w(domainname), bufptr); + return ERROR_NO_SUCH_DOMAIN; +} Please use 4 spaces indentation as the rest of the file. Christian Le 27/04/2013 14:05, Ruslan Kabatsayev a écrit : > Hello, > > This patch adds a stub for netapi32!NetGetAnyDCName(), which is needed > for e.g. KDE's dolphin to launch first time. I've done it similarly to > already present NetGetDCName() stub, but with another error code > return, which is among valid ones listed in MSDN. > > Regards, > Ruslan > >

2 1

Re: user32: SetTimer should respect the minimum and maximum timeout limits (try 2).
by Alexandre Julliard April 26, 2013

April 26, 2013

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > So, this particular patch fixes the minimum and maximum timeout limits > for SetTimer, which has a significant impact on any application using > SetTimer to render video (Bug #32489). The old minimum timeout (55 > ms) is nowhere near short enough to render video at 24 FPS, causing > "choppy" video behavior in a variety of Silverlight apps. Even though > MSDN indicates that the minimum timeout should be 10 ms, I'm using the > value established from the included tests instead (15 ms). That doesn't mean you can change the constant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt.h: Use inline function to forward hypot to _hypot.
by Alexandre Julliard April 26, 2013

April 26, 2013

Jacek Caban <jacek(a)codeweavers.com> writes: > This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. > Previous versions had a separated library that contained forwards from > underscored functions to non-underscored, which I believe made using > hypot work. Those were currently moved directly to msvcr* import libs, > which we don't use in favour of our our own ones. Don't you need to do that for the other functions too? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)
by Jacek Caban April 26, 2013

April 26, 2013

Hi Zhan, It's better, thanks, but still needs more work. On 04/25/13 23:37, Zhan Jianyu wrote: > } > > + > + While we're at this, please put more attention into whitespace changes, esp. useless ones. > static HRESULT to_double(VARIANT *v, double *ret) > { > switch(V_VT(v)) { > @@ -217,6 +221,27 @@ static HRESULT to_string(VARIANT *v, BSTR *ret) > return S_OK; > } > > + > +static HRESULT banker_rounding(double dbval, int *result_val) > +{ > + double frac_part; > + double int_part; > + > + *result_val = round(dbval); This has two problems: - you don't handle values that are out of int range by assigning double value to int - round is not portable. As I mentioned you before, Wine needs to be C89 compatible. If we need some features that are not part of C89, we need to be careful about that and it often requires things like configure checks. In case of round, replacing it with floor(x+0.5) does the trick pretty well. Cheers, Jacek

2 3

Names with particles on South Africa and Namibia should be in the particle on the AUTHORS file.
by Tae Wong April 26, 2013

April 26, 2013

You have posted a message to show how surnames with particles of South Africa and Namibia show in the credits, like van Schayck listed in S and not under V: For example, van Schayck is under S and not in V. Note that the name of the file is in all capitals. Here is a correction of the va section, with van Schyack placed on the letter by letter system. The file name is AUTHORS. It is a file in all capitals and the file content contains just the heading and some names of the developers. Note that the file is out of date. Vainer, Moshe Valoska, Hleb Valtonen, Hannu Vance, Carroll Vanek, Tomas van Schaik, Carl Vaughn, Charles

1 0

Re: [PATCH 1/2] wined3d: Set GL_NONE for glReadBuffer / glDrawBuffer on FBO initialization.
by Henri Verbeet April 26, 2013

April 26, 2013

Seems ok, though a small comment explaining the issue this patch fixes probably wouldn't hurt. On 25 April 2013 20:43, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (target == GL_READ_FRAMEBUFFER) > + context_bind_fbo(context, GL_DRAW_FRAMEBUFFER, draw_binding ? &draw_binding : 0); > + else > + context_bind_fbo(context, GL_READ_FRAMEBUFFER, read_binding ? &read_binding : 0); > I don't think using 0 here is strictly wrong, but a proper NULL would probably be clearer. As a followup, I think we can actually get rid of the glGenFramebuffers() in context_bind_fbo() these days and just pass a GLuint instead of a pointer. The only place left that actually creates FBOs should be context_apply_fbo_entry().

2 2

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool(try 3)
by Marvin April 25, 2013

April 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25302 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)
by Marvin April 25, 2013

April 25, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25301 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] wined3d: Add a new structure for for d3d limits and other info
by Stefan Dösinger April 25, 2013

April 25, 2013

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Please ignore this patch. I figured that my series might collide with Henri's, so I canceled the send process. And indeed there are conflicts, so I'll resend my patches rebased on top of Henri's. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJReSS/AAoJEN0/YqbEcdMwElkP/AiDEqVSaMxTW+sOaQava97g a0cOBpHTU+lInUuUXIS2WVe65D+IhkdYJHnMIrSUVdquvT1x+pLVgr+2J4jczFX7 /9Ay0gAjMVbKsKIYO4tvOQgSru/RdAljTg6uaIw+qTDrHZvQLW/sJu3JcbAp0GW7 9pGEzPvRr6hNsOyXE+DQlTEsT3vkbEUTRr01j4+znF50laYV2s3e5saZHyXULyY8 ObEf3n2ppQgcO4keQg7wAPLydw+xiNcYOw9724fh/xyezj8MXoT1CDHeio7yPfhg xp76kNWzNERQcWaDT7QXwuWLRXy5H3VodWm4PEMXvqXyxkJJycm2jECvTOTjrrke iswKGqh9n0gTWQjse2eUY/fKxpjhh/ySxDcJq093swHHbvrCngL8Q5dYu/Ch3cFu JbLu4pHla3iAmJKftVTT/iRq6vwsLB7tzloCoA7e8T+GFmsA39RPFI6zttCIoA60 kui5a4Ofd6/sGMFaqg2VBK+2crGJzVzN6VRvglg63A0hNr0UGbkFC/6iQK8FzxyA A+uPGr5Xrd/vGpKZksMMH68JiK5kYXm+fsiVI1F1rcAcfdh6STQBoThcig1N/HXu fA8daluv4+PgQ9RhgzlioBsVFGxkZ1FbM8XjKlcnKQb0ZK3DXLHLEzspvmBnr3Pi MK94F9BvqMDa6Wi57sgT =Wh/i -----END PGP SIGNATURE-----

1 0