June 2013 - Wine-Devel - list.winehq.org

Need help with a rsaenh bug
by Qian Hong June 28, 2013

June 28, 2013

Hello, I was investigating Bug 33898 [1] hardly and get a partial result, I have a special test case demonstrate the behavior of Aliwangwang [2], however, I failed to expand the special case to a common test case. My attempting is shown in [3]. The hack in [3] works for Aliwangwang, but the test case in [3] doesn't fully pass on Windows as I expected [4]. I'm not sure if there is an APP bug rather than Wine bug here, is it valid to call multiple CryptDecrypt with only one CryptDeriveKey called? If true, is it correct to assume the second CryptDecrypt call should behavior identical as the first one? If there is a Wine bug here, what is the right way to write a common test case for it? Any hints on this bug is great appreciated! Thanks very much! [1] http://bugs.winehq.org/show_bug.cgi?id=33898 [2] http://bugs.winehq.org/attachment.cgi?id=44996 [3] http://bugs.winehq.org/attachment.cgi?id=44997&action=diff [4] https://testbot.winehq.org/JobDetails.pl?Key=26138 -- Regards, Qian Hong - http://www.winehq.org

3 9

Re: ntdll: NtAllocateVirtualMemory should fail to commit if an address range is already committed for a memory mapped file.
by Alexandre Julliard June 28, 2013

June 28, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch fixes the problem reported in the bug 2770, hopefully it's still > acceptable during code freeze. Is there an application that's fixed by this? According to bug 2770, that app only crashes a little further on (which is of course an improvement, but not worth the risk during code freeze). -- Alexandre Julliard julliard(a)winehq.org

2 1

riched20: ITextDocument implementation
by Tiger Soldier June 28, 2013

June 28, 2013

As bug 17042 [1] reported, the IUnknown object returned by CreateTextServices() does not support ITextDocument. I believe that's the root cause of some apps crash. richole.c has a very limited implementation of ITextDocument for IRichEditOle, which is totally unreusable. I'm trying to implement ITextDocument for both ITextServices and IRichEditOle. ME_Editor type provides most of the editor functionalities, and both of ITextServices and IRichEditOle use it. So I'm going to use it to implement ITextDocument. The proposal is: struct tagReTxtDoc { IUnknown *parentObj; ME_Editor *editor; } ReTxtDoc; ReTxtDoc *CreateReTxtDoc(IUnknown *parentObj, ME_Editor *editor); void DestroyReTxtDoc(ReTxtDoc); ReTxtDoc_addRef/QueryInterface/Release -> delegate to parentObj Other ITextDocument methods: use ME_Editor to implement. This is my first time to develop WINE. Any comments/suggestions? [1] http://bugs.winehq.org/show_bug.cgi?id=17042

3 2

Re: widl: Do not generate C structure for empty interfaces.
by André Hentschel June 27, 2013

June 27, 2013

Hi, The whitespace changes are bad, please don't do that.

3 4

Re: oleaut32/tests: Use bool instead of int when appropriate
by Marvin June 26, 2013

June 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: oleaut32/tests: Use bool instead of int when appropriate
by Marvin June 26, 2013

June 26, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.
by Henri Verbeet June 26, 2013

June 26, 2013

On 23 June 2013 21:57, Christian Costa <titan.costa(a)gmail.com> wrote: > When D3DTA_CONSTANT is use in a texture stage, the generated shader uses variables that are not defined making thus the compilation to fail. > This patch declare these variables with the value from the related texture stage state D3D_TSS_CONSTANT. > This fixes the text display in Spin Tires demo. This patch has several issues. Even without those, it should probably be deferred anyway.

4 11

Re: server: Update German translation of manpage.
by Alexandre Julliard June 26, 2013

June 26, 2013

Julian Rüger <jr98(a)gmx.net> writes: > I'm unsure about the second line. Is that supposed to be the "last > modified" date of the manpage, the wineserver or what? The English > version says October 2005. In general, it would be the last time there were changes to the program that required a manpage update. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: po: Update Ukrainian translation
by Nikolay Sivov June 26, 2013

June 26, 2013

On 6/26/2013 13:10, Микола wrote: Hi, please resubmit this patch with your full name transliterated in English.

1 0

Re: wined3d: print the architecture when showing driver problems
by Henri Verbeet June 26, 2013

June 26, 2013

On 23 June 2013 07:10, Austin English <austinenglish(a)gmail.com> wrote: > Please consider applying before the release of 1.6. It has no > functional changes, but would really help when diagnosing user > problems. > This is not really a wined3d patch. That said, while I agree that printing the architecture would be useful here, you can probably avoid the #ifdef by using something along the lines of sizeof(void *) == 8 ? "64-bit" : "32-bit", although ideally we'd probably get the actual architecture from somewhere like ntdll.

2 2