July 2013 - Wine-Devel - list.winehq.org

d3dx9: Replace M_PI by its D3DX equivalent
by Nozomi Kodama July 31, 2013

July 31, 2013

Hello What is the problem with patch http://source.winehq.org/patches/data/97500 M_PI is never used in D3DX. Nozomi

1 0

Re: msxml3: Unescape '&' back to '&' in attribute value
by Marvin July 31, 2013

July 31, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26523 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPPROSP2 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W2K3R2SESP2 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WVISTAX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W2K8SE (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W7PROX64 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WXPX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === WVISTAX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === W7PROX64 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & ) saxreader.c:2334: Test failed: len 30 (L" attr_value A & & "), expected 29 ( attr_value A & & )

1 0

Re: kernel32/tests: Improve GetVolumePathNameA tests
by Bruno Jesus July 30, 2013

July 30, 2013

Please ignore this patch, I understand that as is it will not be commited. On Tue, Jul 30, 2013 at 3:30 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Erich Hoover contacted me about a patch he sent months ago related to > GetVolumePathNameA. He developed a better test infrastructure using a > for loop instead of multiple repetitions of test lines. This patch > will make it easier for him to rebase and send his tests and function > implementation later. > > I used the same approach from [1] by decomposing the "todo_wine" in > winetest_start_todo("wine") and winetest_end_todo("wine"). > > http://source.winehq.org/source/programs/cmd/tests/batch.c#L292 -- universe* god::bigbang (void); //and then it all began...

1 0

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.
by Nikolay Sivov July 30, 2013

July 30, 2013

On 7/9/2013 16:50, Qian Hong wrote: > Fixed a crash in MS Office 2010 Chinese version. > Thanks Jiang Yike for the helps on testing :) > > --- > dlls/imm32/imm.c | 6 ++++++ > dlls/imm32/tests/imm32.c | 13 +++++++++++++ > 2 files changed, 19 insertions(+) > > > > > + if (IsBadReadPtr(internal, sizeof(HIMCC))) > + { > + SetLastError(ERROR_INVALID_HANDLE); > + return 0; > + } > + Do you really need this for Office 2010 or null check is enough? If it's passing 0 handle here that's what you should check imho. If HIMCC is really a handle and not a struct pointer like in wine, that's not how a handle validity check will look like.

2 4

Call for Windows tests
by Bruno Jesus July 30, 2013

July 30, 2013

Hi, I'm looking for help to test WSAEnumProtocols, I need to collect more information about the values returned from different versions of windows, especially 7 and 8. If you can help please download the file below, unzip, run the .bat and send me back the result.txt file (sources included). http://influenza.blog.br/wsa.zip There is no need to answer to the list. Virustotal.com scan: http://bit.ly/1catW4a Thanks in advance, Bruno

1 0

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 2.
by Vincent Povirk July 30, 2013

July 30, 2013

There's a TIFF_VERSION define that seems to have been renamed to TIFF_VERSION_CLASSIC in 4.0. It doesn't make sense to do the check at runtime, given we're only going to link to one of the versions.

3 7

Re: [1/2] msxml3: Implement IMXAttributes_removeAttributes()
by Jacek Caban July 30, 2013

July 30, 2013

Hi Nikolay, On 07/30/13 12:42, Nikolay Sivov wrote: > + dst = &This->attr[index]; > + src = &This->attr[index+1]; > + > + memmove(dst, src, This->length-index-1); *sizeof(*dst) Cheers, Jacek

1 0

Re: [2/2] wininet: Handle NULL input string in str_to_buffer.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26482 Your paranoid android. === WXPX64 (64 bit http) === http.c:4661: Test failed: 4832: expected status 100 got 10 http.c:4661: Test failed: 4876: expected status 100 got 40 http.c:4634: Test failed: ar->dwResult = 0, expected 1 http.c:4661: Test failed: 4885: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0

Re: [1/2] wininet: Ignore INTERNET_FLAG_NO_CACHE_WRITE only for GET requests.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26481 Your paranoid android. === WXPX64 (32 bit http) === http.c:4588: Test failed: 4759: expected status 100 got 10 http.c:4588: Test failed: 4803: expected status 100 got 40 http.c:4561: Test failed: ar->dwResult = 0, expected 1 http.c:4588: Test failed: 4812: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA

1 0

Re: [2/2] iphlpapi: Add partial support for the module classes in GetExtendedTcpTable and GetExtendedUdpTable.
by Marvin July 30, 2013

July 30, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26480 Your paranoid android. === WVISTAX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 74A19E2F === W2K8SE (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 7596A09A === W7PROX64 (32 bit iphlpapi) === iphlpapi: unhandled exception c0000005 at 77E03915 === WVISTAX64 (64 bit iphlpapi) === Timeout === W7PROX64 (64 bit iphlpapi) === No test summary line found

1 0