August 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 1/6] msvcrt: Use LOCK_ENV locking in _chdrive and do validatation of input argument.
by Alexandre Julliard Aug. 16, 2013

Aug. 16, 2013

Kai Tietz <ktietz70(a)googlemail.com> writes: > diff --git a/dlls/msvcrt/dir.c b/dlls/msvcrt/dir.c > index 44802b3..3b9e3c7 100644 > --- a/dlls/msvcrt/dir.c > +++ b/dlls/msvcrt/dir.c > @@ -365,14 +365,25 @@ int CDECL MSVCRT__chdrive(int newdrive) > { > WCHAR buffer[] = {'A', ':', 0}; > > + if (newdrive < 1 || newdrive > 31) > + { > + *MSVCRT___doserrno () = ERROR_INVALID_DRIVE; > + *MSVCRT__errno () = MSVCRT_EACCES; > + return -1; > + } > buffer[0] += newdrive - 1; > - if (!SetCurrentDirectoryW( buffer )) > + > + _lock (_ENV_LOCK); > + > + if (!SetCurrentDirectoryW (buffer)) > { > - msvcrt_set_errno(GetLastError()); > - if (newdrive <= 0) > - *MSVCRT__errno() = MSVCRT_EACCES; > + msvcrt_set_errno (GetLastError ()); > + _unlock (_ENV_LOCK); > return -1; > } > + > + _unlock (_ENV_LOCK); > + > return 0; > } Please add test cases at least for the error values. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: ntdll: empty APC queue before starting an application
by Alexandre Julliard Aug. 16, 2013

Aug. 16, 2013

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > --- > dlls/ntdll/loader.c | 3 +++ > dlls/ntdll/ntdll.spec | 2 +- > dlls/ntdll/sync.c | 16 ++++++++++++++++ > 3 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index b3abad0..1eaa123 100644 > --- a/dlls/ntdll/loader.c > +++ b/dlls/ntdll/loader.c > @@ -2747,6 +2747,9 @@ void WINAPI LdrInitializeThunk( void *kernel_start, ULONG_PTR unknown2, > > virtual_release_address_space(); > virtual_clear_thread_stack(); > + > + NtTestAlert(); > + > wine_switch_to_stack( start_process, kernel_start, NtCurrentTeb()->Tib.StackBase ); This would have to run on the thread stack. Also please try to add some tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [website] Update git URL
by Michael Stefaniuc Aug. 16, 2013

Aug. 16, 2013

On 08/16/2013 03:32 PM, Frédéric Delanoy wrote: > --- > templates/en/cvs.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/templates/en/cvs.template b/templates/en/cvs.template > index 202cf60..300b9e4 100644 > --- a/templates/en/cvs.template > +++ b/templates/en/cvs.template > @@ -3,9 +3,9 @@ > > <h1 class="title">The Wine CVS Tree</h1> Schouldn't the title change too? And nowadays people know what git is and that's kinda the default SCM that people expect. > > -<p><strong>Note: We have switched development from CVS to <a href="http://git.or.cz">Git</a>. > +<p><strong>Note: We have switched development from CVS to <a href="http://git-scm.com/">Git</a>. > Wine can no longer be downloaded via CVS. > - Instructions for using the <a href="{$root}/site/git">Wine Git tree</a> > + Instructions for using the Wine Git tree > can be found on the <a href="http://wiki.winehq.org/GitWine">GitWine</a> > page on the <a href="http://wiki.winehq.org">Wine Wiki</a>.</strong></p> bye michael

2 1

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.
by Alexandre Julliard Aug. 16, 2013

Aug. 16, 2013

Kai Tietz <ktietz70(a)googlemail.com> writes: > Due line wrap, I sent patch as attachment. > > Kai > > From 3fcedb770626535b56a789467951a4c9be5f08dc Mon Sep 17 00:00:00 2001 > From: Kai Tietz <ktietz70(a)googlemail.com> > Date: Thu, 8 Aug 2013 12:29:33 +0200 > Subject: [PATCH 01/11] widl: New option --rt for enabling rt's specific > language extensions. > > --- > tools/widl/widl.c | 6 ++++++ > tools/widl/widl.h | 1 + > 2 files changed, 7 insertions(+), 0 deletions(-) Please update the usage message and the manpage accordingly. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] apphelp: Add definitions
by Dmitry Timoshkov Aug. 16, 2013

Aug. 16, 2013

Mislav Blazevic <krofnica996(a)gmail.com> wrote: > --- > dlls/apphelp/apphelp.c | 10 +- > dlls/apphelp/apphelp.h | 272 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 273 insertions(+), 9 deletions(-) > create mode 100644 dlls/apphelp/apphelp.h Where all of this comes from? Is there an application that calls apphelp APIs and doesn't work because of failures? How are you testing your implementation? -- Dmitry.

3 6

Re: comsvcs: Add dll comsvcs (resend)
by André Hentschel Aug. 16, 2013

Aug. 16, 2013

Am 16.08.2013 12:39, schrieb Alistair Leslie-Hughes: > Hi, > > > Changelog: > comsvcs: Add dll comsvcs > > > Best Regards > Alistair Leslie-Hughes you missed the configure.ac part?

1 0

Re: [3/3] ntdll/tests: Add a bunch of overlapped IO tests for files.
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26708 Your paranoid android. === WXPX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === WVISTAX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1884: Test failed: expected STATUS_SUCCESS, got 0 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1903: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === W7PROX64 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3 === TEST64_W7SP1 (64 bit file) === file.c:1791: Test failed: expected STATUS_SUCCESS, got 0 file.c:1817: Test failed: expected STATUS_SUCCESS, got 0 file.c:1844: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1855: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1874: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:1884: Test failed: expected STATUS_SUCCESS, got 0 file.c:1894: Test failed: expected STATUS_SUCCESS, got 0 file.c:1903: Test failed: expected STATUS_SUCCESS, got 0 file.c:1927: Test failed: expected STATUS_SUCCESS, got 0 file.c:2030: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2037: Test failed: expected STATUS_END_OF_FILE, got 0xc0000011 file.c:2088: Test failed: expected STATUS_SUCCESS, got 0 file.c:2095: Test failed: expected STATUS_SUCCESS, got 0 file.c:2104: Test failed: expected STATUS_SUCCESS, got 0 file.c:2110: Test failed: expected STATUS_SUCCESS, got 0 file.c:1008: Test failed: Invalid ioSb.Information: 3

2 1

Re: [2/3] ntdll/tests: Use official path for temporary files instead of current directory.
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26707 Your paranoid android. === WXPX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === WVISTAX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === W7PROX64 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3 === TEST64_W7SP1 (64 bit file) === file.c:1008: Test failed: Invalid ioSb.Information: 3

1 0

Re: [3/3] ntdll: Implement compatible typelib section
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26698 Your paranoid android. === W2KPROSP4 (32 bit actctx) === Timeout === WXPPROSP2 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WXPX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W2K3R2SESP2 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WVISTAX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W7PROX64 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === TEST64_W7SP1 (32 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WXPX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === WVISTAX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === W7PROX64 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043 === TEST64_W7SP1 (64 bit actctx) === actctx.c:1375: Test failed: got 409, 1043

1 0

Re: [2/3] ntdll: Added support for all typelib section attributes
by Marvin Aug. 16, 2013

Aug. 16, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26697 Your paranoid android. === W2KPROSP4 (32 bit actctx) === Timeout === WXPPROSP2 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WXPX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W2K3R2SESP2 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WVISTAX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W2K8SE (32 bit actctx) === actctx.c:1357: Test failed: got 409 === W7PROX64 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === TEST64_W7SP1 (32 bit actctx) === actctx.c:1357: Test failed: got 409 === WXPX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === WVISTAX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === W7PROX64 (64 bit actctx) === actctx.c:1357: Test failed: got 409 === TEST64_W7SP1 (64 bit actctx) === actctx.c:1357: Test failed: got 409

1 0