August 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.
by André Hentschel Aug. 9, 2013

Aug. 9, 2013

Am 08.08.2013 17:51, schrieb Kai Tietz: > Hi, > > this patch adds new --rt option to widl. By it you can control, if > RT's IDL-language-extension(?s) getting active. > This initial patch just adds the option-scanning and the global > flag-variable to widl. > > Ok for apply? I'd say no, you are adding dead code, so you might want to merge it with 2/11 to avoid that.

3 2

Re: [2/2] wineserver: perform access check when creating event objects (try 2)
by Andrew Cook Aug. 9, 2013

Aug. 9, 2013

Actually ignore this patch, the problem was introduced by 92db6d2c back in 2007, server: Don't do access checks on the security descriptors of newly created objects which fixes sync.c:363 "CreateEventW with blank sd failed" i'll need to take another look at this, calling CreateEventEx with generic flags fails to correctly set permissions, the patch as it stands though will likely cause regressions. On 02/08/13 21:58, Andrew Cook wrote: > --- > dlls/ntdll/tests/om.c | 4 ++-- > server/event.c | 5 +---- > 2 files changed, 3 insertions(+), 6 deletions(-) > >

1 0

Re: configure.ac: allow disabling winemac.drv
by Ken Thomases Aug. 8, 2013

Aug. 8, 2013

On Aug 8, 2013, at 5:56 PM, Austin English wrote: > +AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build native Mac (Cocoa) driver]), > + [if test "x$withval" = "xno"; then ac_cv_header_ApplicationServices_ApplicationServices_h=no; fi]) A switch to disable the Mac driver is fine with me, but you can't pretend that the ApplicationServices framework header isn't present. There are other places within Wine which check that. http://source.winehq.org/source/dlls/windowscodecs/icnsformat.c#L24 http://source.winehq.org/source/dlls/winspool.drv/info.c#L48 -Ken

1 0

Re: [PATCH 04/11] widl: Handle default value for public vs hidden attribute.
by André Hentschel Aug. 8, 2013

Aug. 8, 2013

Am 08.08.2013 17:57, schrieb Kai Tietz: > - if (! is_attr(attrs, ATTR_PUBLIC)) > + if (! is_attr(attrs, ATTR_PUBLIC) && ! is_attr (attrs, ATTR_HIDDEN)) style issue: space after !

2 1

Re: [PATCH 09/11] widl: Handle LLP64 target same as LP64 one.
by André Hentschel Aug. 8, 2013

Aug. 8, 2013

Am 08.08.2013 18:07, schrieb Kai Tietz: > Hi, > > this thing here puzzles me most. I reject this patch, but would like > to get here some discussion to find the actual intended meaning of > this xstrtoul function. Then you should remove it from the patchset and send it as RFC to wine-devel

1 0

Re: Synchronization-patches of widl
by André Hentschel Aug. 8, 2013

Aug. 8, 2013

Am 08.08.2013 10:56, schrieb Kai Tietz: > All these changes were necessary to support the VLC-people to begin > with their WinRT port. By this we began on mingw-w64 to improve - > thanks to Jacek - our IDL-generated header-sources. So you are on a good way with WinRT, nice. What about Windows RT, was there already some ARM work? > A general note I would like to make about the use of sizeof(void*) in > widl to make out what type-library-variant to be choosen. That seems > to be a bit wacky variant, as it makes widl non-useable as cross-tool > on host with different pointer-size. isn't that controled by command line arguments?

1 0

winetestbot question
by Stefan Leichter Aug. 8, 2013

Aug. 8, 2013

Hello, i like to know why the WXPX64 VM of winetestbot does not have the 32 bit vc runtime 2008. The other 64 bit VMs have the runtime installed. Because of the missing runtime each patch for the unit tests of the dlls msvcr90 and msvcp90 is marked as "Failed" at http://source.winehq.org/patches -- Stefan

2 1

re: msvcrt: strncpy doesn't compliant C standard (try 3)
by Dan Kegel Aug. 8, 2013

Aug. 8, 2013

Minor problem: +static void test_strncpy(void) +{ + size_t len = 10; + char *ret; + char dst[len + 1]; Hmm. That last line is a VLA, and might not compile in all C compilers because it's not allowed in C89. http://stackoverflow.com/questions/448844/variable-sized-arrays-in-c Wine seems to want to build in c89 compilers: http://www.winehq.org/pipermail/wine-cvs/2011-April/076721.html Try using a #define with a more unique name for the length instead, or better yet, replace len=10 with len=sizeof(dst)-1 or something. Larger problem: ret = strncpy(dst, not_null_less, len); This is ill-defined. You're copying 10 bytes from a 5 byte buffer. Don't do that. Also, passing a not-null-terminated string in as a special test case doesn't seem interesting... just pass in the longer null-terminated string, and specify a shorter length. Fewer test strings needed, easier to read code. Please run 'make check', and test using http://testbot.winehq.org, before submitting patches.

2 1

Re: [PATCH 1/1] msvcrt: Set ?: environment variable in _(w)chdir functions.
by Marvin Aug. 8, 2013

Aug. 8, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26639 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: msvcrt: strncpy doesn't compliant C standard (try 3)
by Marvin Aug. 7, 2013

Aug. 7, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26638 Your paranoid android. === W2KPROSP4 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WXPPROSP2 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WXPX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === W2K3R2SESP2 (32 bit string) === string.c:2585: Test failed: dst != 012345 === WVISTAX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === W2K8SE (32 bit string) === string.c:2585: Test failed: dst != 012345 === W7PROX64 (32 bit string) === string.c:2585: Test failed: dst != 012345 === TEST64_W7SP1 (32 bit string) === string.c:2585: Test failed: dst != 012345

1 0