August 2013 - Wine-Devel - list.winehq.org

Re: ntdll: Store all 'comClass' attributes
by Alexandre Julliard Aug. 27, 2013

Aug. 27, 2013

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > + while (min <= max) > + { > + int n, c; > + > + n = (min+max)/2; > + > + c = strncmpW(olemisc_values[n].name, str, len); strncmp isn't enough. -- Alexandre Julliard julliard(a)winehq.org

2 1

Does auto-apt work to get wine dependencies in source code?
by Susan Cragin Aug. 27, 2013

Aug. 27, 2013

Hello, Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work.

4 3

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (try 2).
by Bruno Jesus Aug. 27, 2013

Aug. 27, 2013

On Mon, Aug 5, 2013 at 1:24 AM, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > The attached patch is the next step in the series of fixes for > Silverlight/PlayReady under Wine. This particular patch does not > impact Netflix, but it does impact a number of other PlayReady > streaming services (and a variety of non-streaming sites as well). > Sorry it's taken so long to get back to this, life has been busy > lately. > > With this patch the SIO_ADDRESS_LIST_CHANGE call gets passed on to > NotifyAddrChange, which effectively fixes a problem where Silverlight > apps can loop forever calling SIO_ADDRESS_LIST_CHANGE (Bug #32328). > Part 2 actually implements the NotifyAddrChange call on Linux, though > this patch is sufficient on its own to resolve the bug since the > overlapped IO event no longer gets triggered. > > This version of the patch has bee updated to include tests that show > that the notification is not tied to the socket. For example, > changing an interface that the socket is not bound to still results in > an overlapped notification. It's worth noting that these tests > require interactive mode and a PC with two network cards, so for my > testing I used an actual (non-VM) Windows 7 box with a wired and a > wireless card. Was this patch already reviewed? Is there anything else take can be done to get it commited? I tested it in 2 different environments (win7 eth+wifi and winxp eth+eht) and the tests work as expected. Regards, Bruno

1 0

Re: Does auto-apt work to get wine dependencies in source code?
by Susan Cragin Aug. 26, 2013

Aug. 26, 2013

1 0

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.
by Alexandre Julliard Aug. 26, 2013

Aug. 26, 2013

Wolfgang Walter <wine(a)stwm.de> writes: > @@ -2749,19 +2752,46 @@ NTSTATUS WINAPI NtFlushBuffersFile( HANDLE hFile, IO_STATUS_BLOCK* IoStatusBlock > { > NTSTATUS ret; > HANDLE hEvent = NULL; > - > - SERVER_START_REQ( flush_file ) > - { > - req->handle = wine_server_obj_handle( hFile ); > - ret = wine_server_call( req ); > - hEvent = wine_server_ptr_handle( reply->event ); > + enum server_fd_type type; > + unsigned int options; > + int needs_close; > + int unix_handle; > + > + ret = server_get_unix_fd( hFile, FILE_WRITE_DATA, &unix_handle, > + &needs_close, &type, &options ); > + if (ret) return ret; You probably don't want to fail just because there's no unix fd. > + if (ret == STATUS_SUCCESS && IoStatusBlock) { > + IoStatusBlock->u.Status = ret; > } This is an unrelated change and should be a separate patch, with tests (also for failures cases), -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 2/7] wined3d: Use PBOs for dynamic volumes (try 2)
by Matteo Bruni Aug. 26, 2013

Aug. 26, 2013

2013/8/26 Stefan Dösinger <stefan(a)codeweavers.com>: > Try 2: > *) Require only GPU access for buffers > *) Reduce number of checkGLcall invocations > *) Remove a return from an ERR case > --- > dlls/wined3d/utils.c | 1 + > dlls/wined3d/volume.c | 168 ++++++++++++++++++++++++++++++++++++----- > dlls/wined3d/wined3d_private.h | 7 +- > 3 files changed, 157 insertions(+), 19 deletions(-) > > + case WINED3D_LOCATION_BUFFER: > + if (!volume->pbo || !(volume->flags & WINED3D_VFLAG_PBO)) > + ERR("Trying to load WINED3D_LOCATION_BUFFER without setting it up first.\n"); > + > + if (volume->locations & WINED3D_LOCATION_DISCARDED) > + { > + TRACE("Volume previously discarded, nothing to do.\n"); > + wined3d_volume_invalidate_location(volume, WINED3D_LOCATION_DISCARDED); > + } > + else if (volume->locations & WINED3D_LOCATION_TEXTURE_RGB) > + { > + struct wined3d_bo_address data = {volume->pbo, NULL}; > + volume_bind_and_dirtify(volume, context); > + wined3d_volume_download_data(volume, context, &data); > + } > + else > + { > + FIXME("Implement WINED3D_LOCATION_SYSMEM loading from %s.\n", > + wined3d_debug_location(volume->locations)); > + return; > + } > + wined3d_volume_validate_location(volume, WINED3D_LOCATION_BUFFER); > + break; > + Not really an actual review, but that FIXME looks wrong (copy-paste remnant probably).

2 1

questions to your commit "wineps.drv: Allow for vertical text printing!"
by Wolfgang Walter Aug. 26, 2013

Aug. 26, 2013

Hello Aric, I read commit 745e7c93c9042f62460f181daaa1f05645560b41 (wineps.drv: Allow for vertical text printing.) and I have some questions: 1) You added the parameter vertical to PSDRV_WriteSetFont() in ps.c but it remains unused. I think it isn't needed. 2) In PSDRV_WriteSetDownloadFont() in download.c you call PSDRV_WriteSetFont() with (lf.lfFaceName[0] == '@') for this new parameter vertical. I can't see why. 3) You added the parameter vertical to get_download_name() in download.c You use it to add "_vertical" to its name if vertical is true. I can't see why the font needs a different name. This will cause PSDRV_WriteSetDownloadFont() to download a font which is used vertically and horizontally twice. I can't see any reason why this could be necessary. I think that * PSDRV_WriteSetFont() should be changed back and of course the callers, too (in builtin.c and download.c) * get_download_name() should also be changed back (and its call in PSDRV_WriteSetDownloadFont()) Regards, -- Wolfgang Walter Studentenwerk München

2 1

Re: [patch fix]for 98152 and 98151,the encoding type was wrong.
by Akihiro Sagawa Aug. 26, 2013

Aug. 26, 2013

On Sun, 25 Aug 2013 23:13:53 +0900, matyapiro31 wrote: > The first one is > 0001-add-japanese-man-page-of-wine.patch > the second one is > 0001-last-change-of-my-translation-of-man-page.patch > Please cancel 98152 and 98151and try those two. These translations are outdated. The file seems to be based on wine 1.4 release. Makefile.in has a lot of formatting errors. You'd also refine it before resubmitting. Regards, Akihiro Sagawa

1 0

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.
by Alexandre Julliard Aug. 26, 2013

Aug. 26, 2013

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > MSDN for FlushFileBuffers says: > Flushes the buffers of a specified file and causes all buffered data to be > written to a file. > > Linux man page says: > tcdrain() waits until all output written to the object referred to by fd has > been transmitted. It's a blocking call, you can't do that on the server side. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [PATCH 1/2] advapi32/tests: Add tests for hkcr handle mask
by Nikolay Sivov Aug. 24, 2013

Aug. 24, 2013

On 8/24/2013 07:11, George Stephanos wrote: > +#define IS_HKCR(hk) ((UINT_PTR)hk > 0 && ((UINT_PTR)hk & 3) == 2) > + Why is that important to check? In other words what depends on particular value pattern?

1 0