January 2014 - Wine-Devel - list.winehq.org

Re: Command Stream Update
by Yuri Shishenko Jan. 9, 2014

Jan. 9, 2014

Civilization V has performance regression with this wine version. It shows less FPS than unpatched wine-1.7.10: 20 FPS on maximum camera distance while with unpatched wine it shows 40-50 FPS. My PC specs: openSUSE 13.1, linux 3.12.6 x86_64, nVidia GTX660 with 331.20 driver, Intel Core I5-3570k.

1 0

Re: [PATCH 4/5] d3dx9_36/tests: Use a window with a non-zero size.
by Henri Verbeet Jan. 9, 2014

Jan. 9, 2014

On 9 January 2014 13:43, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > WS_SYSMENU | WS_POPUP follows the existing code in D3DXCreateBoxTest, > which is the only test that created a useable device on my system. I think you might as well just use WS_OVERLAPPEDWINDOW like e.g. the d3d9 tests do, but I don't care that much.

1 0

Re: [PATCH 6/6] ddraw/tests: Add some color key tests for complex surfaces.
by Stefan Dösinger Jan. 9, 2014

Jan. 9, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-09 12:17, schrieb Henri Verbeet: > + hr = IDirectDrawSurface7_GetAttachedSurface(surface, &caps, > &tmp); + ok(SUCCEEDED(hr), "Failed to get attached surface, hr > %#x.\n", hr); + hr = IDirectDrawSurface7_GetColorKey(tmp, > DDCKEY_SRCBLT, &color_key); + ok(hr == DDERR_NOCOLORKEY, "Got > unexpected hr %#x, i %u.\n", hr, i); + + > color_key.dwColorSpaceLowValue = 0x0000ff00; + > color_key.dwColorSpaceHighValue = 0x0000ff00; + hr = > IDirectDrawSurface7_SetColorKey(surface, DDCKEY_SRCBLT, > &color_key); + ok(SUCCEEDED(hr), "Failed to set color key, hr > %#x.\n", hr); + memset(&color_key, 0, sizeof(color_key)); + > hr = IDirectDrawSurface7_GetColorKey(surface, DDCKEY_SRCBLT, > &color_key); + ok(SUCCEEDED(hr), "Failed to get color key, hr > %#x.\n", hr); + ok(color_key.dwColorSpaceLowValue == 0x0000ff00, > "Got unexpected value 0x%08x.\n", + > color_key.dwColorSpaceLowValue); + > ok(color_key.dwColorSpaceHighValue == 0x0000ff00, "Got unexpected > value 0x%08x.\n", + color_key.dwColorSpaceHighValue); + > + IDirectDrawSurface_Release(tmp); Did you mean to call SetColorKey and GetColorKey on tmp instead of surface here? For the sake of completion it might be interesting to test SetColorKey on cube textures. 5 of the faces are attached to a root surface but aren't mipmap sublevels. (I guess it'll still return DDERR_NOTONMIPMAPSUBLEVEL.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSzpDjAAoJEN0/YqbEcdMwyl0P/3OHO0kK93dh6XdY1RU9IvNv BASe8YHhv1a6rRxYNGDzGoX5bsnefWLcqUnsWsGGjlxdA13BxAB4NCenaMecu49v d3egCH547Bd94K/9wqqlDxl+aEe0Hh86Ig9t0LNBuruNh1hNKTG9OdohzJBuX1VD TcVYRv6S8wEwM2Gb24RL8wN359497vn58G3fAVxK7PiK/edqxlDTg+6oi6P0/L+x HLGFlSVL9bgtxpwAUVh3i9SRsnA6iS07qPmSHOXdoCz/OhoY29Lx7HLFRCOgUbJS XAo00HKWP+qB4myqt3Iir9QgtiFLFZiyBBn0HQQEWGeRsDpZTazH/EMZrbUPhP03 f9AiW/r7XX5fOoRG5HBv7i/eXdOw6XexVLEyXb57sEilNJfBF3ux2wDw/E34AiGT wUTkgY2VwjgaxNl022qsFYz6fboORwbQm0VyvWzxbKw7326pdt6Y3Q2WTvPEQ5Rk JvlVJ8McRzkrYU5hXjRW1D7/2rVmV8z+xGGi6IU1JoS3PBWIYMKjUDRlFg0n+JQG UzLnJcnxm/js8Ah4R8MWje1v4cq3TlKnc7WrMIwNtu3Wmvwjo34s4A84xdVPneY/ jIqgUGFBOeH/XnK+FAdU+ZFuUn4k/ttVNOuSrPe5HsZxc1uxGnec5OtuZB8FTjFH EH0rn+AxEiyaGPON+4w6 =GtY2 -----END PGP SIGNATURE-----

2 2

Re: [PATCH 5/6] ddraw: Return DDERR_NOTONMIPMAPSUBLEVEL for ddraw_surface7_SetColorKey() on mipmap sub levels.
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4096 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [PATCH 4/5] devenum: Make CLSID_VideoCompressorCategory a special category.
by Alexandre Julliard Jan. 9, 2014

Jan. 9, 2014

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/devenum/createdevenum.c | 1 + > 1 file changed, 1 insertion(+) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M dxdiagn.dll -p dxdiagn_test.exe.so provider && touch provider.ok provider.c:84: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:88: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:125: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:128: Tests skipped: IDxDiagProvider::Initialize failed make: *** [provider.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32/tests: Add broken for a WSALookupServiceBegin test in NT
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4089 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (174): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit sock) === sock.c:566: Test failed: oob_server (964): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 5/5] devenum: Added more strict CLSID_VideoCompressorCategory test.
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4077 Your paranoid android. === w2008s64 (64 bit devenum) === devenum.c:124: Test failed: mrle codec not found devenum.c:124: Test failed: mrle codec not found === w7pro64 (64 bit devenum) === devenum.c:124: Test failed: mrle codec not found devenum.c:124: Test failed: mrle codec not found

1 0

Re: [PATCH 2/5] ddraw/tests: Add some color key tests for complex surfaces.
by Marvin Jan. 9, 2014

Jan. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4071 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:1621: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:1621: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [PATCH] oleaut32: Mask out certain features on array copy
by Dmitry Timoshkov Jan. 8, 2014

Jan. 8, 2014

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +/* features listed here are not propagated to newly created array or data copy > + created with SafeArrayCopy()/SafeArrayCopyData() */ > +static const USHORT ignored_copy_features = > + FADF_AUTO | > + FADF_STATIC | > + FADF_EMBEDDED | > + FADF_FIXEDSIZE | > + FADF_CREATEVECTOR | > + FADF_DATADELETED; ... > - (*ppsaOut)->fFeatures = psa->fFeatures & ~FADF_CREATEVECTOR; > + (*ppsaOut)->fFeatures = psa->fFeatures & ~(FADF_CREATEVECTOR|ignored_copy_features); ignored_copy_features already includes FADF_CREATEVECTOR. > --- a/dlls/oleaut32/tests/safearray.c > +++ b/dlls/oleaut32/tests/safearray.c > @@ -57,6 +57,14 @@ static BOOL has_i8; > /* Has INT_PTR/UINT_PTR type? */ > static BOOL has_int_ptr; > > +static const USHORT ignored_copy_features[] = > + { > + FADF_AUTO, > + FADF_STATIC, > + FADF_EMBEDDED, > + FADF_FIXEDSIZE > + }; Tested and actually ignored flags do not match. Either the test is not complete or the ignored list includes too much. -- Dmitry.

2 1

Re: [PATCH 2/5] ddraw/tests: Add some color key tests for complex surfaces.
by Stefan Dösinger Jan. 8, 2014

Jan. 8, 2014

Am 08.01.2014 um 10:56 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > + for (i = 0; i < 7; ++i) > + { > + hr = IDirectDrawSurface_GetAttachedSurface(mipmap, &caps, &tmp); > + ok(SUCCEEDED(hr), "Failed to get attached surface, i %u, hr %#x.\n", i, hr); > + hr = IDirectDrawSurface_GetColorKey(tmp, DDCKEY_SRCBLT, &color_key); > + ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr %#x, i %u.\n", hr, i); > + IDirectDrawSurface_Release(mipmap); > + mipmap = tmp; > + } What is the 3D rendering and blitting behavior of the mipmap sublevels? Does an application have to set the color key on all surfaces to get proper color keying on a mipmapped texture, or do the sublevels use the color key from the root surface?

2 6