January 2014 - Wine-Devel - list.winehq.org

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Nikolay Sivov Jan. 7, 2014

Jan. 7, 2014

On 1/7/2014 16:08, Zhenbo Li wrote: > I'm working on Bug 33750, so I'll add test cases for > SHGetPathFromIDListA gradually. > --- > dlls/shell32/tests/pidl.c | 48 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 dlls/shell32/tests/pidl.c > Please use some existing file. > +void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + LPCSTR pszPath; > + > + pszPath = malloc(MAX_PATH); > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > + > + free((void *)pszPath); > +} > + You don't need to allocate it here, even if had to Heap* functions should be used.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Marvin Jan. 7, 2014

Jan. 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4048 Your paranoid android. === wxppro (32 bit pidl) === No test summary line found === wvista (32 bit pidl) === No test summary line found === w2008s64 (32 bit pidl) === No test summary line found === w7pro64 (32 bit pidl) === No test summary line found === w2008s64 (64 bit pidl) === No test summary line found === w7pro64 (64 bit pidl) === No test summary line found

1 0

Re: user32/tests: Use BOOL type where appropriate
by Marvin Jan. 7, 2014

Jan. 7, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4032 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000

1 0

Re: [2/2] ws2_32/tests: Show that the last WSACleanup must destroy sockets
by Marvin Jan. 6, 2014

Jan. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4029 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4220C0

1 0

Re: [1/2] ws2_32/tests: Add some FIONREAD tests
by Marvin Jan. 6, 2014

Jan. 6, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4028 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (4bc): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

[PATCH] Add support for GNU/Hurd
by Svante Signell Jan. 6, 2014

Jan. 6, 2014

Hi, Currently wine-1.6.1 FTBFS on Debian GNU/Hurd, see https://buildd.debian.org/status/fetch.php?pkg=wine&arch=hurd-i386&ver=1.6.… Attached is a patch enabling the build: - dlls/ntdll/directory.c: Define a character array on the heap of size 4096 instead of using PATH_MAX, which is not defined for GNU/Hurd. This approach was used in dlls/ntdll/file.c:server_get_unix_name() where an array of size 1024 was defined. In case this solution is not OK, a fixed size array on the stack could be used, or as a last resort adding #ifndef PATH_MAX; #define PATH_MAX 4096 to that file (not recommended, at least from a GNU/Hurd aspect). - libs/wine/ldt.c: Add LDT support for GNU/Hurd - dlls/ntdll/signal_i386.c: Add i386 signal handling support for GNU/Hurd Applications tested so far (slow to start) include cmd, hostname, clock, winemine, wineconsole, notepad, wordpad and explorer. This patch is sent upstream on recommendation by the Debian Wine maintainers, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733605 Thanks!

3 7

Re: strmbase: Store BasePinFuncTable inside Base*PinFuncTable structs.
by Aric Stewart Jan. 6, 2014

Jan. 6, 2014

On 1/3/14, 10:08 AM, Jacek Caban wrote: > --- > dlls/amstream/mediastreamfilter.c | 15 +++++++-------- > dlls/qcap/avico.c | 32 ++++++++++++++------------------ > dlls/qcap/avimux.c | 32 ++++++++++++++------------------ > dlls/qcap/vfwcapture.c | 15 +++++++-------- > dlls/quartz/filesource.c | 15 +++++++-------- > dlls/quartz/parser.c | 15 +++++++-------- > dlls/strmbase/pin.c | 24 ++++++++++++------------ > dlls/strmbase/renderer.c | 17 ++++++++--------- > dlls/strmbase/transform.c | 30 ++++++++++++++---------------- > include/wine/strmbase.h | 7 +++++-- > 10 files changed, 95 insertions(+), 107 deletions(-) > Also just so you are aware, all the strmbase stuff is based off actual microsoft strmbase stuff for directshow http://msdn.microsoft.com/en-us/library/windows/desktop/dd318897%28v=vs.85%… Not that this patch specifically breaks that, I have not dug that much, but just so that you are aware of the base for the implementation. -aric

2 1

Re: [1/7] gdi32: Relax vertical face requirements.
by Dmitry Timoshkov Jan. 6, 2014

Jan. 6, 2014

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -2148,6 +2148,9 @@ static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_ > #endif /* HAVE_CARBON_CARBON_H */ > > do { > + const DWORD DBCS_MASK = 0x3e0000; dlls/gdi32/font.c,GetFontLanguageInfo() defines DBCS_MASK as 0x3f0000, I'd guess that one of these places needs to be fixed. -- Dmitry.

2 1

Build fixes for wine-1.6.1 (FreeType2)
by David Naylor Jan. 6, 2014

Jan. 6, 2014

Dear Wine-developers, On behalf of Gerald Pfeifer and the FreeBSD/Wine team I would like to report that wine-1.6.1 does not build against recent versions of FreeType2. This has been fixed in master in commit 67f9b6e3c5d2397446d39ab454f691c1ee46d2c0 by Alexandre Julliard. We would like to request this commit be back-ported to the stable branch. Regards, David P.S. I'm not on the mailing list, please CC me in related correspondence, thanks.

3 2

Re: msvcp: Return if module is not loaded (Coverity)
by Piotr Caban Jan. 6, 2014

Jan. 6, 2014

On 01/04/14 19:24, André Hentschel wrote: > 1147949 > --- > dlls/msvcp90/msvcp_main.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/dlls/msvcp90/msvcp_main.c b/dlls/msvcp90/msvcp_main.c > index 489aacb..d946f3b 100644 > --- a/dlls/msvcp90/msvcp_main.c > +++ b/dlls/msvcp90/msvcp_main.c > @@ -67,7 +67,14 @@ static void init_cxx_funcs(void) > { > HMODULE hmod = GetModuleHandleA( MSVCRT_NAME(_MSVCP_VER) ); > > - if (!hmod) FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > + if (!hmod) > + { > + FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > + MSVCRT_operator_new = NULL; > + MSVCRT_operator_delete = NULL; > + MSVCRT_set_new_handler = NULL; > + return; > + } If we want to handle GetModuleHandle failure we should probably fail to load msvcpXX.dll (I'm not sure if it may ever happen unless we forget to import proper msvcrXX dll in makefile).

1 0